Refactoring (#1329)

* refactoring

* update

* update

* refactoring folder

* update

* update

* update

* package description

* update

* refactoring

src/01/00/03/z2ui5_cl_util.clas.abap

@@ -329,7 +329,7 @@ CLASS z2ui5_cl_util DEFINITION
 
     CLASS-METHODS filter_get_token_t_by_range_t
       IMPORTING
-        val           TYPE ty_t_range
+        val           TYPE ANY TABLE
       RETURNING
         VALUE(result) TYPE ty_t_token.
 
@@ -337,6 +337,12 @@ CLASS z2ui5_cl_util DEFINITION
       RETURNING
         VALUE(result) TYPE z2ui5_if_types=>ty_t_name_value.
 
+    CLASS-METHODS itab_corresponding
+      IMPORTING
+        val TYPE STANDARD TABLE
+      CHANGING
+        tab TYPE STANDARD TABLE.
+
     CLASS-METHODS itab_filter_by_val
       IMPORTING
         val TYPE clike
@@ -725,7 +731,16 @@ CLASS z2ui5_cl_util IMPLEMENTATION.
 
     DATA(lt_mapping) = filter_get_token_range_mapping( ).
 
-    LOOP AT val REFERENCE INTO DATA(lr_row).
+    DATA(lt_tab) = VALUE ty_t_range( ).
+
+      itab_corresponding(
+        EXPORTING
+          val = lt_tab
+        CHANGING
+          tab = lt_tab
+      ).
+
+    LOOP AT lt_tab REFERENCE INTO DATA(lr_row).
 
       DATA(lv_value) = lt_mapping[ n = lr_row->option ]-v.
       REPLACE `{LOW}`  IN lv_value WITH lr_row->low.
@@ -944,11 +959,14 @@ CLASS z2ui5_cl_util IMPLEMENTATION.
 
 
   METHOD rtti_get_type_name.
+    TRY.
 
-    DATA(lo_descr) = cl_abap_elemdescr=>describe_by_data( val ).
-    DATA(lo_ele) = CAST cl_abap_elemdescr( lo_descr ).
-    result  = lo_ele->get_relative_name( ).
+        DATA(lo_descr) = cl_abap_elemdescr=>describe_by_data( val ).
+        DATA(lo_ele) = CAST cl_abap_elemdescr( lo_descr ).
+        result  = lo_ele->get_relative_name( ).
 
+      CATCH cx_root.
+    ENDTRY.
   ENDMETHOD.
 
 
@@ -1055,7 +1073,7 @@ CLASS z2ui5_cl_util IMPLEMENTATION.
         TYPES fixvalues TYPE STANDARD TABLE OF fixvalue WITH EMPTY KEY.
         DATA lt_values TYPE fixvalues.
 
-        CALL METHOD ELEMDESCR->('GET_DDIC_FIXED_VALUES')
+        CALL METHOD elemdescr->('GET_DDIC_FIXED_VALUES')
           EXPORTING
             p_langu        = langu
           RECEIVING
@@ -1479,4 +1497,18 @@ CLASS z2ui5_cl_util IMPLEMENTATION.
 
   ENDMETHOD.
 
+  METHOD itab_corresponding.
+
+    FIELD-SYMBOLS <row_in> TYPE any.
+    FIELD-SYMBOLS <row_out> TYPE any.
+
+    LOOP AT val ASSIGNING <row_in>.
+
+      INSERT INITIAL LINE INTO tab ASSIGNING <row_out>.
+      <row_out> = CORRESPONDING #(  <row_in> ).
+
+    ENDLOOP.
+
+  ENDMETHOD.
+
 ENDCLASS.

src/01/01/package.devc.xml

@@ -3,7 +3,7 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <DEVC>
-    <CTEXT>abap2UI5 - core services</CTEXT>
+    <CTEXT>abap2UI5 - services</CTEXT>
    </DEVC>
   </asx:values>
  </asx:abap>

src/01/02/package.devc.xml

@@ -3,7 +3,7 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <DEVC>
-    <CTEXT>abap2UI5 - core</CTEXT>
+    <CTEXT>abap2UI5 - logic</CTEXT>
    </DEVC>
   </asx:values>
  </asx:abap>

src/01/03/z2ui5_cl_core_app_hello_w.clas.abap

@@ -1,4 +1,4 @@
-CLASS z2ui5_cl_app_hello_world DEFINITION
+CLASS z2ui5_cl_core_app_hello_w DEFINITION
   PUBLIC
   CREATE PUBLIC .
 
@@ -14,7 +14,7 @@ ENDCLASS.
 
 
 
-CLASS z2ui5_cl_app_hello_world IMPLEMENTATION.
+CLASS z2ui5_cl_core_app_hello_w IMPLEMENTATION.
 
 
   METHOD z2ui5_if_app~main.

src/01/03/z2ui5_cl_core_app_hello_w.clas.xml

@@ -3,9 +3,9 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <VSEOCLASS>
-    <CLSNAME>Z2UI5_CL_APP_HELLO_WORLD</CLSNAME>
+    <CLSNAME>Z2UI5_CL_CORE_APP_HELLO_W</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>ui - app hello world</DESCRIPT>
+    <DESCRIPT>abap2UI5 - app hello world</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/01/03/z2ui5_cl_core_app_startup.clas.abap

@@ -300,7 +300,7 @@ CLASS Z2UI5_CL_CORE_APP_STARTUP IMPLEMENTATION.
     ms_home-btn_event_id   = `BUTTON_CHECK`.
     ms_home-class_editable = abap_true.
     ms_home-btn_icon       = `sap-icon://validate`.
-    ms_home-classname      = z2ui5_cl_util=>rtti_get_classname_by_ref( NEW z2ui5_cl_app_hello_world( ) ).
+    ms_home-classname      = z2ui5_cl_util=>rtti_get_classname_by_ref( NEW z2ui5_cl_core_app_hello_w( ) ).
 
   ENDMETHOD.
 ENDCLASS.

src/01/04/package.devc.xml

@@ -3,7 +3,7 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <DEVC>
-    <CTEXT>abap2UI5 - cc startup</CTEXT>
+    <CTEXT>abap2UI5 - custom controls</CTEXT>
    </DEVC>
   </asx:values>
  </asx:abap>

src/02/01/z2ui5_cl_xml_view.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>Z2UI5_CL_XML_VIEW</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abap2UI5 - view renderer</DESCRIPT>
+    <DESCRIPT>abap2UI5 - view parser</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/02/01/z2ui5_cl_xml_view_cc.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>Z2UI5_CL_XML_VIEW_CC</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abap2UI5 - view renderer cc</DESCRIPT>
+    <DESCRIPT>abap2UI5 - view parser cc</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/02/02/z2ui5_cl_pop_get_range.clas.abap

@@ -19,7 +19,7 @@ CLASS z2ui5_cl_pop_get_range DEFINITION
 
     CLASS-METHODS factory
       IMPORTING
-        t_range         TYPE z2ui5_cl_util=>ty_t_range  OPTIONAL
+        t_range         TYPE any table OPTIONAL
       RETURNING
         VALUE(r_result) TYPE REF TO z2ui5_cl_pop_get_range.
 
@@ -51,7 +51,14 @@ CLASS Z2UI5_CL_POP_GET_RANGE IMPLEMENTATION.
   METHOD factory.
 
     r_result = NEW #( ).
-    r_result->ms_result-t_range = t_range.
+
+    z2ui5_cl_util=>itab_corresponding(
+      EXPORTING
+        val = t_range
+      CHANGING
+        tab =  r_result->ms_result-t_range
+    ).
+
     INSERT VALUE #( ) INTO TABLE r_result->ms_result-t_range.
 
   ENDMETHOD.

src/02/02/z2ui5_cl_pop_get_range.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>Z2UI5_CL_POP_GET_RANGE</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>ui - popup get range</DESCRIPT>
+    <DESCRIPT> ui - popup get range</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/02/03/package.devc.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DEVC" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DEVC>
+    <CTEXT>abap2UI5 - api</CTEXT>
+   </DEVC>
+  </asx:values>
+ </asx:abap>
+</abapGit>