From 447bdbfb55853d4346f7aed71e95319367850fba Mon Sep 17 00:00:00 2001 From: oblomov <102328295+oblomov-dev@users.noreply.github.com> Date: Thu, 16 Nov 2023 19:57:23 +0100 Subject: [PATCH] Bugfixes (#649) * bugfixes * Update README.md --- README.md | 2 +- src/01/z2ui5_cl_fw_app.clas.abap | 2 +- src/02/z2ui5_cl_ui5.clas.abap | 2 +- src/02/z2ui5_cl_ui5_html.clas.abap | 5 ++--- src/02/z2ui5_cl_ui5_m.clas.abap | 1 + src/03/z2ui5_cl_cc_geolocation.clas.xml | 2 +- src/03/z2ui5_cl_cc_info.clas.xml | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index d50c6951..59aeff7e 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,7 @@ CLASS z2ui5_cl_app_hello_world IMPLEMENTATION. client->message_toast_display( |{ quantity } Product ABC - send to the server| ). ENDCASE. - client->view_display( z2ui5_cl_xml_view=>factory( client + client->view_display( z2ui5_cl_xml_view=>factory( )->page( 'abap2UI5 - Hello World App' )->simple_form( )->content( ns = `form` )->title( 'Input here and send it to the server...' diff --git a/src/01/z2ui5_cl_fw_app.clas.abap b/src/01/z2ui5_cl_fw_app.clas.abap index 5eb1c3eb..f9b1d44a 100644 --- a/src/01/z2ui5_cl_fw_app.clas.abap +++ b/src/01/z2ui5_cl_fw_app.clas.abap @@ -159,7 +159,7 @@ CLASS Z2UI5_CL_FW_APP IMPLEMENTATION. IF mv_check_demo = abap_false. form->_ns_m( )->messagestrip( text = `Oops! You need to install abap2UI5 demos before continuing...` type = `Warning` - )->_go_new( )->_add( `link` )->_ns_m( )->link( text = `(HERE)` + )->_go_new( )->_add( n = `link` ns = `sap.m` )->_ns_m( )->link( text = `(HERE)` target = `_blank` href = `https://github.com/abap2UI5/abap2UI5-samples` ). ENDIF. diff --git a/src/02/z2ui5_cl_ui5.clas.abap b/src/02/z2ui5_cl_ui5.clas.abap index f38f1a2c..5f61a632 100644 --- a/src/02/z2ui5_cl_ui5.clas.abap +++ b/src/02/z2ui5_cl_ui5.clas.abap @@ -18,7 +18,7 @@ CLASS z2ui5_cl_ui5 DEFINITION METHODS _add IMPORTING n TYPE clike - ns TYPE clike OPTIONAL + ns TYPE clike t_p TYPE z2ui5_if_client=>ty_t_name_value OPTIONAL RETURNING VALUE(result) TYPE REF TO z2ui5_cl_ui5. diff --git a/src/02/z2ui5_cl_ui5_html.clas.abap b/src/02/z2ui5_cl_ui5_html.clas.abap index b828d921..9c0c53b8 100644 --- a/src/02/z2ui5_cl_ui5_html.clas.abap +++ b/src/02/z2ui5_cl_ui5_html.clas.abap @@ -20,10 +20,9 @@ ENDCLASS. CLASS z2ui5_cl_ui5_html IMPLEMENTATION. METHOD script. result = me. - _add( n = `script` - ns = `http://www.w3.org/1999/xhtml` + _add( n = `script` + ns = `http://www.w3.org/1999/xhtml` t_p = VALUE #( ( n = `src` v = src ) ) ). - ENDMETHOD. METHOD style. diff --git a/src/02/z2ui5_cl_ui5_m.clas.abap b/src/02/z2ui5_cl_ui5_m.clas.abap index 92d8df87..2c8ac788 100644 --- a/src/02/z2ui5_cl_ui5_m.clas.abap +++ b/src/02/z2ui5_cl_ui5_m.clas.abap @@ -340,6 +340,7 @@ CLASS z2ui5_cl_ui5_m IMPLEMENTATION. METHOD messagestrip. result = me. _add( n = `MessageStrip` + ns = `sap.m` t_p = VALUE #( ( n = `text` v = text ) ( n = `type` v = type ) ( n = `showIcon` v = z2ui5_cl_fw_utility=>boolean_abap_2_json( showicon ) ) diff --git a/src/03/z2ui5_cl_cc_geolocation.clas.xml b/src/03/z2ui5_cl_cc_geolocation.clas.xml index 57194e49..6f62c418 100644 --- a/src/03/z2ui5_cl_cc_geolocation.clas.xml +++ b/src/03/z2ui5_cl_cc_geolocation.clas.xml @@ -5,7 +5,7 @@ Z2UI5_CL_CC_GEOLOCATION E - browser - geolocation + cc - geolocation 1 X X diff --git a/src/03/z2ui5_cl_cc_info.clas.xml b/src/03/z2ui5_cl_cc_info.clas.xml index d62cfa8d..9b90794c 100644 --- a/src/03/z2ui5_cl_cc_info.clas.xml +++ b/src/03/z2ui5_cl_cc_info.clas.xml @@ -5,7 +5,7 @@ Z2UI5_CL_CC_INFO E - browser - info + cc - browser info 1 X X