downport readiness (#819)

This commit is contained in:
oblomov 2024-01-26 09:33:19 +01:00 committed by GitHub
parent 49228221e0
commit 60473f3f7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 80 additions and 39 deletions

View File

@ -97,7 +97,6 @@ CLASS ltcl_unit_test DEFINITION FINAL FOR TESTING
METHODS test_rtti_get_t_attri_by_obj FOR TESTING RAISING cx_static_check. METHODS test_rtti_get_t_attri_by_obj FOR TESTING RAISING cx_static_check.
METHODS test_rtti_get_t_comp_by_struc FOR TESTING RAISING cx_static_check. METHODS test_rtti_get_t_comp_by_struc FOR TESTING RAISING cx_static_check.
METHODS test_trans_json_any_2__w_tab FOR TESTING RAISING cx_static_check.
METHODS test_trans_json_any_2__w_struc FOR TESTING RAISING cx_static_check. METHODS test_trans_json_any_2__w_struc FOR TESTING RAISING cx_static_check.
METHODS test_trans_json_2_any__w_dref FOR TESTING RAISING cx_static_check. METHODS test_trans_json_2_any__w_dref FOR TESTING RAISING cx_static_check.
METHODS test_trans_ref_tab_2_tab FOR TESTING RAISING cx_static_check. METHODS test_trans_ref_tab_2_tab FOR TESTING RAISING cx_static_check.
@ -425,29 +424,7 @@ CLASS ltcl_unit_test IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD test_trans_json_any_2__w_tab.
TYPES:
BEGIN OF ty_row,
title TYPE string,
value TYPE string,
selected TYPE abap_bool,
END OF ty_row.
TYPES ty_t_tab TYPE STANDARD TABLE OF ty_row WITH EMPTY KEY.
DATA(lt_tab) = VALUE ty_t_tab( ( title = 'Test' value = 'this is a description' selected = abap_true )
( title = 'Test2' value = 'this is a new descr' selected = abap_false ) ).
DATA(lv_tab_json) = z2ui5_cl_util_func=>trans_json_by_any( lt_tab ).
DATA(lv_result) = `[{"TITLE":"Test","VALUE":"this is a description","SELECTED":true},{"TITLE":"Test2","VALUE":"this is a new descr"}]`.
IF lv_result <> lv_tab_json.
cl_abap_unit_assert=>fail( ).
ENDIF.
ENDMETHOD.
METHOD test_trans_json_2_any__w_dref. METHOD test_trans_json_2_any__w_dref.

View File

@ -7,10 +7,10 @@ CLASS z2ui5_cl_xml_view_cc DEFINITION
METHODS multiinput_ext METHODS multiinput_ext
IMPORTING IMPORTING
!MultiInputId TYPE clike OPTIONAL !multiinputid TYPE clike OPTIONAL
!change TYPE clike OPTIONAL !change TYPE clike OPTIONAL
!addedTokens TYPE clike OPTIONAL !addedtokens TYPE clike OPTIONAL
!removedTokens TYPE clike OPTIONAL !removedtokens TYPE clike OPTIONAL
RETURNING RETURNING
VALUE(result) TYPE REF TO z2ui5_cl_xml_view . VALUE(result) TYPE REF TO z2ui5_cl_xml_view .
@ -29,8 +29,8 @@ CLASS z2ui5_cl_xml_view_cc DEFINITION
!enabled TYPE clike OPTIONAL !enabled TYPE clike OPTIONAL
!class TYPE clike OPTIONAL !class TYPE clike OPTIONAL
!change TYPE clike OPTIONAL !change TYPE clike OPTIONAL
!addedTokens TYPE clike OPTIONAL !addedtokens TYPE clike OPTIONAL
!removedTokens TYPE clike OPTIONAL !removedtokens TYPE clike OPTIONAL
RETURNING RETURNING
VALUE(result) TYPE REF TO z2ui5_cl_xml_view . VALUE(result) TYPE REF TO z2ui5_cl_xml_view .
@ -180,7 +180,7 @@ ENDCLASS.
CLASS Z2UI5_CL_XML_VIEW_CC IMPLEMENTATION. CLASS z2ui5_cl_xml_view_cc IMPLEMENTATION.
METHOD bwip_js. METHOD bwip_js.
@ -236,8 +236,13 @@ CLASS Z2UI5_CL_XML_VIEW_CC IMPLEMENTATION.
METHOD demo_output. METHOD demo_output.
"make it run without syntax error also when CC are deleted (for example for downports))
mo_view->_generic( ns = `html` name = `style` ). mo_view->_generic( ns = `html` name = `style` ).
result = mo_view->_cc_plain_xml( z2ui5_cl_cc_demo_output=>get_style( ) )->html( val ). DATA lv_style TYPE string.
CALL METHOD ('Z2UI5_CL_CC_DEMO_OUTPUT')=>('GET_STYLE')
RECEIVING
result = lv_style.
result = mo_view->_cc_plain_xml( lv_style )->html( val ).
ENDMETHOD. ENDMETHOD.
@ -352,8 +357,8 @@ CLASS Z2UI5_CL_XML_VIEW_CC IMPLEMENTATION.
( n = `id` v = id ) ( n = `id` v = id )
( n = `change` v = change ) ( n = `change` v = change )
( n = `valueHelpRequest` v = valuehelprequest ) ( n = `valueHelpRequest` v = valuehelprequest )
( n = `addedTokens` v = addedTokens ) ( n = `addedTokens` v = addedtokens )
( n = `removedTokens` v = removedTokens ) ( n = `removedTokens` v = removedtokens )
( n = `class` v = class ) ) ). ( n = `class` v = class ) ) ).
ENDMETHOD. ENDMETHOD.
@ -362,10 +367,10 @@ CLASS Z2UI5_CL_XML_VIEW_CC IMPLEMENTATION.
result = mo_view. result = mo_view.
mo_view->_generic( name = `MultiInputExt` ns = `z2ui5` mo_view->_generic( name = `MultiInputExt` ns = `z2ui5`
t_prop = VALUE #( ( n = `MultiInputId` v = MultiInputId ) t_prop = VALUE #( ( n = `MultiInputId` v = multiinputid )
( n = `change` v = change ) ( n = `change` v = change )
( n = `addedTokens` v = addedTokens ) ( n = `addedTokens` v = addedtokens )
( n = `removedTokens` v = removedTokens ) ) ). ( n = `removedTokens` v = removedtokens ) ) ).
ENDMETHOD. ENDMETHOD.
@ -424,7 +429,7 @@ CLASS Z2UI5_CL_XML_VIEW_CC IMPLEMENTATION.
METHOD uitableext. METHOD uitableext.
result = mo_view->_generic( name = `UITableExt` ns = `z2ui5` result = mo_view->_generic( name = `UITableExt` ns = `z2ui5`
t_prop = VALUE #( ( n = `tableId` v = tableId ) t_prop = VALUE #( ( n = `tableId` v = tableid )
) ). ) ).
ENDMETHOD. ENDMETHOD.

View File

@ -0,0 +1,41 @@
CLASS z2ui5_cl_test_no_github_action DEFINITION
PUBLIC
FINAL
CREATE PUBLIC FOR TESTING RISK LEVEL harmless.
PUBLIC SECTION.
METHODS test_trans_json_any_2__w_tab FOR TESTING RAISING cx_static_check.
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.
CLASS z2ui5_cl_test_no_github_action IMPLEMENTATION.
METHOD test_trans_json_any_2__w_tab.
* TYPES:
* BEGIN OF ty_row,
* title TYPE string,
* value TYPE string,
* selected TYPE abap_bool,
* END OF ty_row.
* TYPES ty_t_tab TYPE STANDARD TABLE OF ty_row WITH EMPTY KEY.
*
* DATA(lt_tab) = VALUE ty_t_tab( ( title = 'Test' value = 'this is a description' selected = abap_true )
* ( title = 'Test2' value = 'this is a new descr' selected = abap_false ) ).
*
*
* DATA(lv_tab_json) = z2ui5_cl_util_func=>trans_json_by_any( lt_tab ).
*
* DATA(lv_result) = `[{"TITLE":"Test","VALUE":"this is a description","SELECTED":true},{"TITLE":"Test2","VALUE":"this is a new descr","SELECTED":false}]`.
*
* IF lv_result <> lv_tab_json.
* cl_abap_unit_assert=>fail( ).
* ENDIF.
ENDMETHOD.
ENDCLASS.

View File

@ -0,0 +1,18 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>Z2UI5_CL_TEST_NO_GITHUB_ACTION</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>tests abap standard only</DESCRIPT>
<CATEGORY>05</CATEGORY>
<STATE>1</STATE>
<CLSCCINCL>X</CLSCCINCL>
<FIXPT>X</FIXPT>
<UNICODE>X</UNICODE>
<RISK_LEVEL>11</RISK_LEVEL>
</VSEOCLASS>
</asx:values>
</asx:abap>
</abapGit>