SAP/abap2UI5
1
0
Fork 0
mirror of https://github.com/abap2UI5/abap2UI5.git synced 2025-04-29 16:36:11 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactoring (#119)

Browse Source 
* refactoring && to ||

* refactoring

* refactoring

* renaming

* refactoring
This commit is contained in:
oblomov 2023-03-22 18:26:56 +01:00
parent 9ff354c995
commit 8283f76a0c
2 changed files with 36 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/z2ui5_cl_http_handler.clas.abap
View File

@ -43,7 +43,7 @@ ENDCLASS.
CLASS Z2UI5_CL_HTTP_HANDLER IMPLEMENTATION. CLASS z2ui5_cl_http_handler IMPLEMENTATION.
METHOD main_roundtrip. METHOD main_roundtrip.
@ -52,7 +52,6 @@ CLASS Z2UI5_CL_HTTP_HANDLER IMPLEMENTATION.
DO. DO.
TRY. TRY.
DATA(li_client) = lo_runtime->app_before_event( ). DATA(li_client) = lo_runtime->app_before_event( ).
ROLLBACK WORK. ROLLBACK WORK.
CAST z2ui5_if_app( lo_runtime->ms_db-o_app )->controller( li_client ). CAST z2ui5_if_app( lo_runtime->ms_db-o_app )->controller( li_client ).
@ -63,7 +62,6 @@ CLASS Z2UI5_CL_HTTP_HANDLER IMPLEMENTATION.
CONTINUE. CONTINUE.
ENDTRY. ENDTRY.
IF lo_runtime->ms_next-s_nav_app_call_new IS NOT INITIAL. IF lo_runtime->ms_next-s_nav_app_call_new IS NOT INITIAL.
lo_runtime = lo_runtime->set_app_call_new( ). lo_runtime = lo_runtime->set_app_call_new( ).
CONTINUE. CONTINUE.
@ -74,14 +72,11 @@ CLASS Z2UI5_CL_HTTP_HANDLER IMPLEMENTATION.
CONTINUE. CONTINUE.
ENDIF. ENDIF.
TRY. TRY.
li_client = lo_runtime->app_before_rendering( ). li_client = lo_runtime->app_before_rendering( ).
ROLLBACK WORK. ROLLBACK WORK.
CAST z2ui5_if_app( lo_runtime->ms_db-o_app )->controller( li_client ). CAST z2ui5_if_app( lo_runtime->ms_db-o_app )->controller( li_client ).
ROLLBACK WORK. ROLLBACK WORK.
result = lo_runtime->request_end( ). result = lo_runtime->request_end( ).
CATCH cx_root INTO x. CATCH cx_root INTO x.

92
src/z2ui5_cl_http_handler.clas.locals_imp.abap
View File

@ -164,8 +164,10 @@ CLASS z2ui5_lcl_utility DEFINITION INHERITING FROM cx_no_check.
VALUE(result) TYPE string. VALUE(result) TYPE string.
CLASS-METHODS trans_ref_tab_2_tab CLASS-METHODS trans_ref_tab_2_tab
IMPORTING ir_tab_from TYPE REF TO data IMPORTING
CHANGING ct_to TYPE STANDARD TABLE. ir_tab_from TYPE REF TO data
CHANGING
ct_to TYPE STANDARD TABLE.
CLASS-METHODS get_trim_upper CLASS-METHODS get_trim_upper
IMPORTING IMPORTING
@ -809,9 +811,8 @@ CLASS z2ui5_lcl_utility_tree_json IMPLEMENTATION.
FIELD-SYMBOLS <attribute> TYPE any. FIELD-SYMBOLS <attribute> TYPE any.
DATA(lv_name) = c_prefix && replace( val = name sub = `-` with = `_` occ = 0 ). DATA(lv_name) = c_prefix && replace( val = name sub = `-` with = `_` occ = 0 ).
ASSIGN (lv_name) TO <attribute>. ASSIGN (lv_name) TO <attribute>.
IF sy-subrc <> 0. _=>raise( when = xsdbool( sy-subrc <> 0 ) ).
RETURN.
ENDIF.
lo_attri->mr_actual = <attribute>. lo_attri->mr_actual = <attribute>.
lo_attri->mo_parent = me. lo_attri->mo_parent = me.
@ -2316,7 +2317,7 @@ CLASS z2ui5_lcl_system_app IMPLEMENTATION.
result = NEW #( ). result = NEW #( ).
result->ms_error-x_error = error. result->ms_error-x_error = error.
result->ms_error-app = cast #( app ). result->ms_error-app = CAST #( app ).
ENDMETHOD. ENDMETHOD.
@ -2620,7 +2621,7 @@ CLASS z2ui5_lcl_system_runtime IMPLEMENTATION.
DATA(lo_system) = lo_ui5_model->add_attribute_object( `oSystem` ). DATA(lo_system) = lo_ui5_model->add_attribute_object( `oSystem` ).
lo_system->add_attribute( n = `ID` v = ms_db-id ). lo_system->add_attribute( n = `ID` v = ms_db-id ).
lo_system->add_attribute( n = `CHECK_DEBUG_ACTIVE` v = _=>get_abap_2_json( z2ui5_cl_http_handler=>cs_config-check_debug_mode ) apos_active = abap_false ). lo_system->add_attribute( n = `CHECK_DEBUG_ACTIVE` v = _=>get_abap_2_json( z2ui5_cl_http_handler=>cs_config-check_debug_mode ) apos_active = abap_false ).
IF ms_next-t_after IS NOT INITIAL. IF ms_next-t_after IS NOT INITIAL.
DATA(lo_list) = lo_ui5_model->add_attribute_list( `oAfter` ). DATA(lo_list) = lo_ui5_model->add_attribute_list( `oAfter` ).
@ -2670,56 +2671,33 @@ CLASS z2ui5_lcl_system_runtime IMPLEMENTATION.
result->ms_db-id_prev = id_prev. result->ms_db-id_prev = id_prev.
TRY. TRY.
DATA(lo_popup_model) = ss_client-o_body->get_attribute( `OPOPUP` ). DATA(lo_model) = ss_client-o_body->get_attribute( `OPOPUP` ).
LOOP AT result->ms_db-t_attri REFERENCE INTO DATA(lr_attri)
WHERE bind_type = z2ui5_if_view=>cs-bind_type-two_way.
FIELD-SYMBOLS <attribute> TYPE any.
DATA(lv_name) = c_prefix && to_upper( lr_attri->name ).
ASSIGN (lv_name) TO <attribute>.
_=>raise( when = xsdbool( sy-subrc <> 0 ) ).
CASE lr_attri->type_kind.
WHEN `g` OR `I` OR `C`.
DATA(lv_value) = lo_popup_model->get_attribute( lr_attri->name )->get_val( ).
<attribute> = lv_value.
WHEN `h`.
_=>trans_ref_tab_2_tab(
EXPORTING ir_tab_from = lo_popup_model->get_attribute( lr_attri->name )->mr_actual
CHANGING ct_to = <attribute> ).
ENDCASE.
ENDLOOP.
CATCH cx_root. CATCH cx_root.
lo_model = ss_client-o_body.
LOOP AT result->ms_db-t_attri REFERENCE INTO lr_attri
WHERE bind_type = z2ui5_if_view=>cs-bind_type-two_way.
lv_name = c_prefix && to_upper( lr_attri->name ).
ASSIGN (lv_name) TO <attribute>.
_=>raise( when = xsdbool( sy-subrc <> 0 ) ).
CASE lr_attri->type_kind.
WHEN `g` OR `I` OR `C`.
lv_value = ss_client-o_body->get_attribute( lr_attri->name )->get_val( ).
<attribute> = lv_value.
WHEN `h`.
_=>trans_ref_tab_2_tab(
EXPORTING
ir_tab_from = ss_client-o_body->get_attribute( lr_attri->name )->mr_actual
CHANGING
ct_to = <attribute> ).
ENDCASE.
ENDLOOP.
ENDTRY. ENDTRY.
LOOP AT result->ms_db-t_attri REFERENCE INTO DATA(lr_attri)
WHERE bind_type = z2ui5_if_view=>cs-bind_type-two_way.
FIELD-SYMBOLS <attribute> TYPE any.
DATA(lv_name) = c_prefix && to_upper( lr_attri->name ).
ASSIGN (lv_name) TO <attribute>.
_=>raise( when = xsdbool( sy-subrc <> 0 ) ).
CASE lr_attri->type_kind.
WHEN `g` OR `I` OR `C`.
DATA(lv_value) = lo_model->get_attribute( lr_attri->name )->get_val( ).
<attribute> = lv_value.
WHEN `h`.
_=>trans_ref_tab_2_tab(
EXPORTING ir_tab_from = lo_model->get_attribute( lr_attri->name )->mr_actual
CHANGING ct_to = <attribute> ).
ENDCASE.
ENDLOOP.
TRY. TRY.
result->ms_next-event = ss_client-o_body->get_attribute( `OEVENT` )->get_attribute( `EVENT` )->get_val( ). result->ms_next-event = ss_client-o_body->get_attribute( `OEVENT` )->get_attribute( `EVENT` )->get_val( ).
@ -3002,13 +2980,13 @@ CLASS z2ui5_lcl_if_client IMPLEMENTATION.
METHOD z2ui5_if_client~_bind. METHOD z2ui5_if_client~_bind.
result = `{` && mo_runtime->_create_binding( value = val type = z2ui5_if_view=>cs-bind_type-two_way ) && `}`. result = `{` && mo_runtime->_create_binding( value = val type = z2ui5_if_view=>cs-bind_type-two_way ) && `}`.
ENDMETHOD. ENDMETHOD.
METHOD z2ui5_if_client~_bind_one_way. METHOD z2ui5_if_client~_bind_one_way.
result = `{` && mo_runtime->_create_binding( value = val type = z2ui5_if_view=>cs-bind_type-one_way ) && `}`. result = `{` && mo_runtime->_create_binding( value = val type = z2ui5_if_view=>cs-bind_type-one_way ) && `}`.
ENDMETHOD. ENDMETHOD.
@ -3026,7 +3004,7 @@ CLASS z2ui5_lcl_if_client IMPLEMENTATION.
METHOD z2ui5_if_client~nav_app_leave. METHOD z2ui5_if_client~nav_app_leave.
_=>raise( when = xsdbool( id = `` ) v = `app not found, please check if calling app exists, pervious_app_id is empty` ). _=>raise( when = xsdbool( id = `` ) v = `app not found, please check if calling app exists, pervious app_id is empty` ).
mo_runtime->ms_next-nav_app_leave_to_id = id. mo_runtime->ms_next-nav_app_leave_to_id = id.
ENDMETHOD. ENDMETHOD.