* cleanup

* cleanup
This commit is contained in:
oblomov 2023-12-03 19:52:06 +01:00 committed by GitHub
parent 06f86836bb
commit df5b9e2226
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 48 additions and 103 deletions

View File

@ -392,12 +392,12 @@ CLASS Z2UI5_CL_FW_HANDLER IMPLEMENTATION.
ENDIF.
IF ix IS BOUND.
result->ms_next-o_app_call = z2ui5_cl_fw_app_error=>factory_error( ix ).
result->ms_next-o_app_call = z2ui5_cl_fw_app_error=>factory( ix ).
result = result->set_app_call( abap_true ).
RETURN.
ENDIF.
result->ms_db-app = z2ui5_cl_fw_app_startup=>factory_start( ).
result->ms_db-app = z2ui5_cl_fw_app_startup=>factory( ).
result->ms_db-app->id = result->ms_db-id.
ENDMETHOD.

View File

@ -1,47 +1,38 @@
class Z2UI5_CL_FW_APP_ERROR definition
public
final
create protected .
CLASS z2ui5_cl_fw_app_error DEFINITION
PUBLIC
FINAL
CREATE PROTECTED.
public section.
PUBLIC SECTION.
interfaces Z2UI5_IF_APP .
interfaces IF_SERIALIZABLE_OBJECT .
INTERFACES z2ui5_if_app.
DATA mx_error TYPE REF TO cx_root .
data CLIENT type ref to Z2UI5_IF_CLIENT .
data MV_CHECK_INITIALIZED type ABAP_BOOL .
data MV_CHECK_DEMO type ABAP_BOOL .
data MX_ERROR type ref to CX_ROOT .
CLASS-METHODS factory
IMPORTING
!error TYPE REF TO cx_root
RETURNING
VALUE(result) TYPE REF TO z2ui5_cl_fw_app_error.
class-methods FACTORY_ERROR
importing
!ERROR type ref to CX_ROOT
returning
value(RESULT) type ref to Z2UI5_CL_FW_APP_ERROR .
methods Z2UI5_ON_INIT .
methods Z2UI5_ON_EVENT .
methods VIEW_DISPLAY_ERROR .
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.
CLASS Z2UI5_CL_FW_APP_ERROR IMPLEMENTATION.
CLASS z2ui5_cl_fw_app_error IMPLEMENTATION.
METHOD factory_error.
METHOD factory.
result = NEW #( ).
result->mx_error = error.
ENDMETHOD.
METHOD z2ui5_if_app~main.
METHOD view_display_error.
DATA(lv_url) = shift_left( val = client->get( )-s_config-origin && client->get( )-s_config-pathname
sub = ` ` ).
DATA(lv_url) = shift_left( val = client->get( )-s_config-origin && client->get( )-s_config-pathname sub = ` ` ).
DATA(lv_url_app) = lv_url && client->get( )-s_config-search.
DATA(lv_text) = ``.
@ -69,48 +60,4 @@ CLASS Z2UI5_CL_FW_APP_ERROR IMPLEMENTATION.
ENDMETHOD.
METHOD z2ui5_if_app~main.
me->client = client.
IF mv_check_initialized = abap_false.
mv_check_initialized = abap_true.
z2ui5_on_init( ).
ENDIF.
z2ui5_on_event( ).
IF mx_error IS BOUND.
view_display_error( ).
ENDIF.
ENDMETHOD.
METHOD z2ui5_on_event.
CASE client->get( )-event.
WHEN `DEMOS`.
DATA li_app TYPE REF TO z2ui5_if_app.
TRY.
CREATE OBJECT li_app TYPE (`Z2UI5_CL_DEMO_APP_000`).
mv_check_demo = abap_true.
client->nav_app_call( li_app ).
CATCH cx_root.
mv_check_demo = abap_false.
ENDTRY.
ENDCASE.
ENDMETHOD.
METHOD z2ui5_on_init.
mv_check_demo = abap_true.
ENDMETHOD.
ENDCLASS.

View File

@ -1,30 +1,45 @@
class Z2UI5_CL_FW_APP_HELLO_WORLD definition
public
create public .
CLASS z2ui5_cl_fw_app_hello_world DEFINITION
PUBLIC
CREATE PUBLIC .
public section.
PUBLIC SECTION.
interfaces IF_SERIALIZABLE_OBJECT .
interfaces Z2UI5_IF_APP .
INTERFACES z2ui5_if_app.
DATA product TYPE string.
DATA quantity TYPE string.
DATA check_initialized TYPE abap_bool.
data PRODUCT type STRING .
data QUANTITY type STRING .
data CHECK_INITIALIZED type ABAP_BOOL .
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.
CLASS Z2UI5_CL_FW_APP_HELLO_WORLD IMPLEMENTATION.
CLASS z2ui5_cl_fw_app_hello_world IMPLEMENTATION.
METHOD z2ui5_if_app~main.
IF check_initialized = abap_false.
check_initialized = abap_true.
product = 'products'.
quantity = '500'.
client->view_display( z2ui5_cl_xml_view=>factory(
)->shell(
)->page( title = 'abap2UI5 - z2ui5_cl_app_hello_world'
)->simple_form( title = 'Hello World' editable = abap_true
)->content( ns = `form`
)->title( 'Make an input here and send it to the server...'
)->label( 'quantity'
)->input( client->_bind_edit( quantity )
)->label( 'product'
)->input( value = product enabled = abap_false
)->button( text = 'post' press = client->_event( 'BUTTON_POST' )
)->stringify( ) ).
ENDIF.
CASE client->get( )-event.
@ -32,18 +47,5 @@ CLASS Z2UI5_CL_FW_APP_HELLO_WORLD IMPLEMENTATION.
client->message_toast_display( |{ product } { quantity } - send to the server| ).
ENDCASE.
client->view_display( z2ui5_cl_xml_view=>factory(
)->shell(
)->page( title = 'abap2UI5 - z2ui5_cl_app_hello_world'
)->simple_form( title = 'Hello World' editable = abap_true
)->content( ns = `form`
)->title( 'Make an input here and send it to the server...'
)->label( 'quantity'
)->input( client->_bind_edit( quantity )
)->label( 'product'
)->input( value = product enabled = abap_false
)->button( text = 'post' press = client->_event( 'BUTTON_POST' )
)->stringify( ) ).
ENDMETHOD.
ENDCLASS.

View File

@ -21,7 +21,7 @@ CLASS z2ui5_cl_fw_app_startup DEFINITION
DATA mv_check_initialized TYPE abap_bool .
DATA mv_check_demo TYPE abap_bool .
CLASS-METHODS factory_start
CLASS-METHODS factory
RETURNING
VALUE(result) TYPE REF TO z2ui5_cl_fw_app_startup .
@ -37,7 +37,7 @@ ENDCLASS.
CLASS z2ui5_cl_fw_app_startup IMPLEMENTATION.
METHOD factory_start.
METHOD factory.
result = NEW #( ).
@ -47,9 +47,7 @@ CLASS z2ui5_cl_fw_app_startup IMPLEMENTATION.
DATA(lv_url) = z2ui5_cl_util_func=>app_get_url(
client = client
classname = ms_home-classname
).
classname = ms_home-classname ).
DATA(page) = z2ui5_cl_ui5=>_factory( )->_ns_m( )->shell(
)->page( shownavbutton = abap_false ).
@ -142,7 +140,6 @@ CLASS z2ui5_cl_fw_app_startup IMPLEMENTATION.
ENDIF.
z2ui5_on_event( ).
view_display_start( ).
ENDMETHOD.
@ -201,8 +198,7 @@ CLASS z2ui5_cl_fw_app_startup IMPLEMENTATION.
ms_home-class_editable = abap_true.
ms_home-btn_icon = `sap-icon://validate`.
ms_home-classname = `Z2UI5_CL_FW_APP_HELLO_WORLD`.
mv_check_demo = abap_true.
mv_check_demo = abap_true.
ENDMETHOD.
ENDCLASS.

View File

@ -12,7 +12,7 @@ CLASS ltcl_unit_test IMPLEMENTATION.
METHOD first_test.
DATA(lo_app) = Z2UI5_CL_FW_APP_STARTUP=>factory_start( ) ##NEEDED.
DATA(lo_app) = Z2UI5_CL_FW_APP_STARTUP=>factory( ) ##NEEDED.
ENDMETHOD.