From f543a1dc52704e653f4401f5ab7e7b0950f48ef6 Mon Sep 17 00:00:00 2001 From: oblomov <102328295+oblomov-dev@users.noreply.github.com> Date: Fri, 24 Mar 2023 17:30:21 +0100 Subject: [PATCH] bugfixes (#127) * Update README.md * fix table maintenance * bugfixes scroll container --- README.md | 2 +- src/00/z2ui5_cl_app_demo_06.clas.abap | 2 +- src/00/z2ui5_cl_app_demo_13.clas.abap | 14 ++++++++++---- src/00/z2ui5_cl_app_demo_16.clas.abap | 2 -- src/z2ui5_cl_http_handler.clas.locals_imp.abap | 6 ++---- 5 files changed, 14 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index aecc8049..accf2508 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ ENDMETHOD. ``` ### Setup -Check out the [wiki!](https://github.com/oblomov-dev/abap2ui5/wiki) It shows how to change the theme, the UI5 repository, the browser title etc. +Check out the [wiki!](https://github.com/oblomov-dev/abap2ui5/wiki) It shows how to change the theme, UI5 repository, browser title etc. ## FAQ * read these [instructions](https://github.com/oblomov-dev/ABAP2UI5/wiki/First-App) when you develop your first app
diff --git a/src/00/z2ui5_cl_app_demo_06.clas.abap b/src/00/z2ui5_cl_app_demo_06.clas.abap index 2f191cbb..3591ece1 100644 --- a/src/00/z2ui5_cl_app_demo_06.clas.abap +++ b/src/00/z2ui5_cl_app_demo_06.clas.abap @@ -68,7 +68,7 @@ CLASS Z2UI5_CL_APP_DEMO_06 IMPLEMENTATION. href = client->get( )-s_request-url_source_code )->get_parent( ). - DATA(tab) = page->scroll_container( '70%' + DATA(tab) = page->scroll_container( height = '70%' vertical = abap_true )->table( growing = abap_true growingthreshold = '20' diff --git a/src/00/z2ui5_cl_app_demo_13.clas.abap b/src/00/z2ui5_cl_app_demo_13.clas.abap index 904b59c3..2a8566d9 100644 --- a/src/00/z2ui5_cl_app_demo_13.clas.abap +++ b/src/00/z2ui5_cl_app_demo_13.clas.abap @@ -135,7 +135,7 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. client->popup_message_box( 'Table data saved to database successfully' ). WHEN 'EDIT_ROW_DELETE'. - " DELETE ms_edit-t_table INDEX ms_edit-delete_index + 1. + DELETE ms_edit-t_table WHERE selkz = abap_true. WHEN 'EDIT_CHANGE_MODE'. ms_edit-check_active = xsdbool( ms_edit-check_active = abap_false ). @@ -185,7 +185,7 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. press = client->_event( 'BTN_EXPORT' ) )->get_parent( )->get_parent( ). - DATA(grid) = page->grid( 'L12 M12 S12' )->content( 'l' ). + DATA(grid) = page->grid( 'L7 M7 S7' )->content( 'l' ). grid->simple_form( '1. Import Data' )->content( 'f' @@ -198,6 +198,8 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. )->segmented_button_item( key = 'csv' text = 'csv' )->segmented_button_item( key = 'xml' text = 'xml' ). + grid = page->grid( 'L12 M12 S12' )->content( 'l' ). + grid->scroll_container( '75%' )->code_editor( type = COND #( WHEN ms_import-segment_key = 'csv' THEN |plain_text| ELSE ms_import-segment_key ) @@ -247,13 +249,15 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. press = client->_event( 'BTN_EXPORT' ) )->get_parent( )->get_parent( ). - DATA(grid) = page->grid( 'L12 M12 S12' )->content( 'l' ). + DATA(grid) = page->grid( 'L7 M7 S7' )->content( 'l' ). grid->simple_form( '2. Edit Data' )->content( 'f' )->label( 'Table' )->input( 'SPFLI' ). + grid = page->grid( 'L12 M12 S12' )->content( 'l' ). + DATA(cont) = grid->simple_form( )->content( 'f' ). cont->overflow_toolbar( @@ -330,7 +334,7 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. enabled = abap_false )->get_parent( )->get_parent( ). - DATA(grid) = page->grid( 'L12 M12 S12' )->content( 'l' ). + DATA(grid) = page->grid( 'L7 M7 S7' )->content( 'l' ). grid->simple_form( '3. Export Data' )->content( 'f' @@ -343,6 +347,8 @@ CLASS z2ui5_cl_app_demo_13 IMPLEMENTATION. )->segmented_button_item( key = 'csv' text = 'csv' )->segmented_button_item( key = 'xml' text = 'xml' ). + grid = page->grid( 'L12 M12 S12' )->content( 'l' ). + grid->scroll_container( '75%' )->code_editor( type = COND #( WHEN ms_export-segment_key = 'csv' THEN |plain_text| ELSE ms_import-segment_key ) diff --git a/src/00/z2ui5_cl_app_demo_16.clas.abap b/src/00/z2ui5_cl_app_demo_16.clas.abap index 534fd983..1e1dde9e 100644 --- a/src/00/z2ui5_cl_app_demo_16.clas.abap +++ b/src/00/z2ui5_cl_app_demo_16.clas.abap @@ -8,8 +8,6 @@ CLASS z2ui5_cl_app_demo_16 DEFINITION PUBLIC. DATA mv_type TYPE string. DATA mv_path TYPE string. - DATA mv_editor TYPE string. - DATA mv_check_editable TYPE abap_bool. DATA mv_sel1 TYPE abap_bool. DATA mv_sel2 TYPE abap_bool. diff --git a/src/z2ui5_cl_http_handler.clas.locals_imp.abap b/src/z2ui5_cl_http_handler.clas.locals_imp.abap index 26da22d2..59a1b59b 100644 --- a/src/z2ui5_cl_http_handler.clas.locals_imp.abap +++ b/src/z2ui5_cl_http_handler.clas.locals_imp.abap @@ -2816,15 +2816,13 @@ CLASS z2ui5_lcl_if_client IMPLEMENTATION. METHOD z2ui5_if_client~popup_message_toast. - INSERT VALUE #( ( `MessageToast` ) ( `show` ) ( text ) ) - INTO TABLE mo_runtime->ms_next-t_after. + INSERT VALUE #( ( `MessageToast` ) ( `show` ) ( text ) ) INTO TABLE mo_runtime->ms_next-t_after. ENDMETHOD. METHOD z2ui5_if_client~popup_message_box. - INSERT VALUE #( ( `MessageBox` ) ( type ) ( text ) ) - INTO TABLE mo_runtime->ms_next-t_after. + INSERT VALUE #( ( `MessageBox` ) ( type ) ( text ) ) INTO TABLE mo_runtime->ms_next-t_after. ENDMETHOD.