From 08c794f3ca9d47d84073222c9fb39b2a9fbf3116 Mon Sep 17 00:00:00 2001 From: sandraros <34005250+sandraros@users.noreply.github.com> Date: Tue, 22 Apr 2025 12:52:43 +0200 Subject: [PATCH] Normalize variable names, isolate column/row logic (#1291) Refactoring of method ZCL_EXCEL_TABLE=>GET_REFERENCE changed by PR #1279 Co-authored-by: sandraros Co-authored-by: Abo Co-authored-by: Lars Hvam --- src/zcl_excel_table.clas.abap | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/zcl_excel_table.clas.abap b/src/zcl_excel_table.clas.abap index d6ecbea..34361ca 100644 --- a/src/zcl_excel_table.clas.abap +++ b/src/zcl_excel_table.clas.abap @@ -174,8 +174,8 @@ CLASS zcl_excel_table IMPLEMENTATION. METHOD get_reference. - DATA: lv_start_column TYPE zexcel_cell_column, - lv_end_column TYPE zexcel_cell_column, + DATA: lv_left_column_int TYPE zexcel_cell_column, + lv_right_column_int TYPE zexcel_cell_column, lv_table_lines TYPE i, lv_left_column TYPE zexcel_cell_column_alpha, lv_right_column TYPE zexcel_cell_column_alpha, @@ -187,12 +187,13 @@ CLASS zcl_excel_table IMPLEMENTATION. FIELD-SYMBOLS: TYPE STANDARD TABLE. *column - lv_start_column = zcl_excel_common=>convert_column2int( settings-top_left_column ). - lv_table_lines = 0. + lv_left_column_int = zcl_excel_common=>convert_column2int( settings-top_left_column ). + lv_right_column_int = lv_left_column_int - 1. LOOP AT fieldcat INTO ls_field_catalog WHERE dynpfld EQ abap_true. - ADD 1 TO lv_table_lines. + ADD 1 TO lv_right_column_int. ENDLOOP. - lv_end_column = lv_start_column + lv_table_lines - 1. + lv_left_column = zcl_excel_common=>convert_column2alpha( lv_left_column_int ). + lv_right_column = zcl_excel_common=>convert_column2alpha( lv_right_column_int ). *row ASSIGN table_data->* TO . @@ -206,11 +207,9 @@ CLASS zcl_excel_table IMPLEMENTATION. ADD 1 TO lv_bottom_row. ENDIF. - lv_top_row_string = zcl_excel_common=>number_to_excel_string( settings-top_left_row ). - lv_bottom_row_string = zcl_excel_common=>number_to_excel_string( lv_bottom_row ). + lv_top_row_string = |{ settings-top_left_row }|. + lv_bottom_row_string = |{ lv_bottom_row }|. - lv_left_column = zcl_excel_common=>convert_column2alpha( lv_start_column ). - lv_right_column = zcl_excel_common=>convert_column2alpha( lv_end_column ). CONCATENATE lv_left_column lv_top_row_string ':' lv_right_column lv_bottom_row_string INTO ov_reference.