From 0a907d27de32ee75077d644fe5ddf08fec909b87 Mon Sep 17 00:00:00 2001
From: Abo <andrea@borgia.bo.it>
Date: Sun, 21 Feb 2021 11:21:07 +0100
Subject: [PATCH] Remove doma ZEXCEL_BOOLE01 (#738)

* remove ZEXCEL_SHEET_PROTECTION_BOOL

this dtel uses doma ZEXCEL_BOOLE01

* remove ZEXCEL_CONDITIONAL_SHOW_VALUE

this dtel uses doma ZEXCEL_BOOLE01

* ZEXCEL_BOOLE01

it was used by:
dtel ZEXCEL_SHEET_PROTECTION_BOOL
dtel ZEXCEL_CONDITIONAL_SHOW_VALUE

* fixed spurious edit of .abapgit.xml
---
 src/zcl_excel_style_cond.clas.abap         |  7 ++--
 src/zexcel_conditional_iconset.tabl.xml    | 11 ++++---
 src/zexcel_conditional_show_value.dtel.xml | 23 --------------
 src/zexcel_sheet_protection_bool.dtel.xml  | 23 --------------
 src/zif_excel_sheet_protection.intf.abap   | 37 +++++++++++-----------
 5 files changed, 30 insertions(+), 71 deletions(-)
 delete mode 100644 src/zexcel_conditional_show_value.dtel.xml
 delete mode 100644 src/zexcel_sheet_protection_bool.dtel.xml

diff --git a/src/zcl_excel_style_cond.clas.abap b/src/zcl_excel_style_cond.clas.abap
index 01edada..bd4a663 100644
--- a/src/zcl_excel_style_cond.clas.abap
+++ b/src/zcl_excel_style_cond.clas.abap
@@ -8,6 +8,7 @@ public section.
 
 *"* public components of class ZCL_EXCEL_STYLE_COND
 *"* do not include other source files here!!!
+  types tv_conditional_show_value type c length 1.
   constants C_CFVO_TYPE_FORMULA type ZEXCEL_CONDITIONAL_TYPE value 'formula'. "#EC NOTEXT
   constants C_CFVO_TYPE_MAX type ZEXCEL_CONDITIONAL_TYPE value 'max'. "#EC NOTEXT
   constants C_CFVO_TYPE_MIN type ZEXCEL_CONDITIONAL_TYPE value 'min'. "#EC NOTEXT
@@ -52,8 +53,8 @@ public section.
   constants C_RULE_NONE type ZEXCEL_CONDITION_RULE value 'none'. "#EC NOTEXT
   constants C_RULE_TOP10 type ZEXCEL_CONDITION_RULE value 'top10'. "#EC NOTEXT
   constants C_RULE_ABOVE_AVERAGE type ZEXCEL_CONDITION_RULE value 'aboveAverage'. "#EC NOTEXT
-  constants C_SHOWVALUE_FALSE type ZEXCEL_CONDITIONAL_SHOW_VALUE value 0. "#EC NOTEXT
-  constants C_SHOWVALUE_TRUE type ZEXCEL_CONDITIONAL_SHOW_VALUE value 1. "#EC NOTEXT
+  constants C_SHOWVALUE_FALSE type TV_CONDITIONAL_SHOW_VALUE value 0. "#EC NOTEXT
+  constants C_SHOWVALUE_TRUE type TV_CONDITIONAL_SHOW_VALUE value 1. "#EC NOTEXT
   data MODE_CELLIS type ZEXCEL_CONDITIONAL_CELLIS .
   data MODE_COLORSCALE type ZEXCEL_CONDITIONAL_COLORSCALE .
   data MODE_DATABAR type ZEXCEL_CONDITIONAL_DATABAR .
@@ -101,7 +102,7 @@ public section.
       !IV_CFVO4_VALUE type ZEXCEL_CONDITIONAL_VALUE optional
       !IV_CFVO5_TYPE type ZEXCEL_CONDITIONAL_TYPE default C_CFVO_TYPE_PERCENT
       !IV_CFVO5_VALUE type ZEXCEL_CONDITIONAL_VALUE optional
-      !IV_SHOWVALUE type ZEXCEL_CONDITIONAL_SHOW_VALUE default ZCL_EXCEL_STYLE_COND=>C_SHOWVALUE_TRUE
+      !IV_SHOWVALUE type TV_CONDITIONAL_SHOW_VALUE default ZCL_EXCEL_STYLE_COND=>C_SHOWVALUE_TRUE
     returning
       value(EO_STYLE_COND) type ref to ZCL_EXCEL_STYLE_COND .
   methods GET_GUID
diff --git a/src/zexcel_conditional_iconset.tabl.xml b/src/zexcel_conditional_iconset.tabl.xml
index 3b69bae..7d27118 100644
--- a/src/zexcel_conditional_iconset.tabl.xml
+++ b/src/zexcel_conditional_iconset.tabl.xml
@@ -101,12 +101,15 @@
     <DD03P>
      <TABNAME>ZEXCEL_CONDITIONAL_ICONSET</TABNAME>
      <FIELDNAME>SHOWVALUE</FIELDNAME>
+     <DDLANGUAGE>E</DDLANGUAGE>
      <POSITION>0012</POSITION>
-     <ROLLNAME>ZEXCEL_CONDITIONAL_SHOW_VALUE</ROLLNAME>
      <ADMINFIELD>0</ADMINFIELD>
-     <VALEXI>X</VALEXI>
-     <SHLPORIGIN>F</SHLPORIGIN>
-     <COMPTYPE>E</COMPTYPE>
+     <INTTYPE>C</INTTYPE>
+     <INTLEN>000002</INTLEN>
+     <DATATYPE>CHAR</DATATYPE>
+     <LENG>000001</LENG>
+     <MASK>  CHAR</MASK>
+     <DDTEXT>Condition type</DDTEXT>
     </DD03P>
    </DD03P_TABLE>
   </asx:values>
diff --git a/src/zexcel_conditional_show_value.dtel.xml b/src/zexcel_conditional_show_value.dtel.xml
deleted file mode 100644
index 03158a4..0000000
--- a/src/zexcel_conditional_show_value.dtel.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<abapGit version="v1.0.0" serializer="LCL_OBJECT_DTEL" serializer_version="v1.0.0">
- <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-  <asx:values>
-   <DD04V>
-    <ROLLNAME>ZEXCEL_CONDITIONAL_SHOW_VALUE</ROLLNAME>
-    <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>ZEXCEL_BOOLE01</DOMNAME>
-    <HEADLEN>15</HEADLEN>
-    <SCRLEN1>05</SCRLEN1>
-    <SCRLEN2>15</SCRLEN2>
-    <SCRLEN3>15</SCRLEN3>
-    <DDTEXT>Condition type</DDTEXT>
-    <REPTEXT>Condition type</REPTEXT>
-    <SCRTEXT_S>Type</SCRTEXT_S>
-    <SCRTEXT_M>Condition type</SCRTEXT_M>
-    <SCRTEXT_L>Condition type</SCRTEXT_L>
-    <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
-   </DD04V>
-  </asx:values>
- </asx:abap>
-</abapGit>
diff --git a/src/zexcel_sheet_protection_bool.dtel.xml b/src/zexcel_sheet_protection_bool.dtel.xml
deleted file mode 100644
index daa2f57..0000000
--- a/src/zexcel_sheet_protection_bool.dtel.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<abapGit version="v1.0.0" serializer="LCL_OBJECT_DTEL" serializer_version="v1.0.0">
- <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-  <asx:values>
-   <DD04V>
-    <ROLLNAME>ZEXCEL_SHEET_PROTECTION_BOOL</ROLLNAME>
-    <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>ZEXCEL_BOOLE01</DOMNAME>
-    <HEADLEN>16</HEADLEN>
-    <SCRLEN1>10</SCRLEN1>
-    <SCRLEN2>16</SCRLEN2>
-    <SCRLEN3>20</SCRLEN3>
-    <DDTEXT>Sheet protection indicator</DDTEXT>
-    <REPTEXT>Sheet protection</REPTEXT>
-    <SCRTEXT_S>Protection</SCRTEXT_S>
-    <SCRTEXT_M>Sheet protection</SCRTEXT_M>
-    <SCRTEXT_L>Sheet protection</SCRTEXT_L>
-    <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
-   </DD04V>
-  </asx:values>
- </asx:abap>
-</abapGit>
diff --git a/src/zif_excel_sheet_protection.intf.abap b/src/zif_excel_sheet_protection.intf.abap
index 06820f2..12bd589 100644
--- a/src/zif_excel_sheet_protection.intf.abap
+++ b/src/zif_excel_sheet_protection.intf.abap
@@ -2,29 +2,30 @@ INTERFACE zif_excel_sheet_protection
   PUBLIC .
 
   TYPES tv_sheet_protection TYPE c LENGTH 1.
+  TYPES tv_sheet_protection_bool TYPE c LENGTH 1.
 
-  DATA auto_filter TYPE zexcel_sheet_protection_bool .
-  CONSTANTS c_active TYPE zexcel_sheet_protection_bool VALUE '1'. "#EC NOTEXT
-  CONSTANTS c_noactive TYPE zexcel_sheet_protection_bool VALUE '0'. "#EC NOTEXT
+  DATA auto_filter TYPE tv_sheet_protection_bool .
+  CONSTANTS c_active TYPE tv_sheet_protection_bool VALUE '1'. "#EC NOTEXT
+  CONSTANTS c_noactive TYPE tv_sheet_protection_bool VALUE '0'. "#EC NOTEXT
   CONSTANTS c_protected TYPE tv_sheet_protection VALUE 'X'. "#EC NOTEXT
   CONSTANTS c_unprotected TYPE tv_sheet_protection VALUE ''. "#EC NOTEXT
-  DATA delete_columns TYPE zexcel_sheet_protection_bool .
-  DATA delete_rows TYPE zexcel_sheet_protection_bool .
-  DATA format_cells TYPE zexcel_sheet_protection_bool .
-  DATA format_columns TYPE zexcel_sheet_protection_bool .
-  DATA format_rows TYPE zexcel_sheet_protection_bool .
-  DATA insert_columns TYPE zexcel_sheet_protection_bool .
-  DATA insert_hyperlinks TYPE zexcel_sheet_protection_bool .
-  DATA insert_rows TYPE zexcel_sheet_protection_bool .
-  DATA objects TYPE zexcel_sheet_protection_bool .
+  DATA delete_columns TYPE tv_sheet_protection_bool .
+  DATA delete_rows TYPE tv_sheet_protection_bool .
+  DATA format_cells TYPE tv_sheet_protection_bool .
+  DATA format_columns TYPE tv_sheet_protection_bool .
+  DATA format_rows TYPE tv_sheet_protection_bool .
+  DATA insert_columns TYPE tv_sheet_protection_bool .
+  DATA insert_hyperlinks TYPE tv_sheet_protection_bool .
+  DATA insert_rows TYPE tv_sheet_protection_bool .
+  DATA objects TYPE tv_sheet_protection_bool .
   DATA password TYPE zexcel_aes_password .
-  DATA pivot_tables TYPE zexcel_sheet_protection_bool .
+  DATA pivot_tables TYPE tv_sheet_protection_bool .
   DATA protected TYPE tv_sheet_protection .
-  DATA scenarios TYPE zexcel_sheet_protection_bool .
-  DATA select_locked_cells TYPE zexcel_sheet_protection_bool .
-  DATA select_unlocked_cells TYPE zexcel_sheet_protection_bool .
-  DATA sheet TYPE zexcel_sheet_protection_bool .
-  DATA sort TYPE zexcel_sheet_protection_bool .
+  DATA scenarios TYPE tv_sheet_protection_bool .
+  DATA select_locked_cells TYPE tv_sheet_protection_bool .
+  DATA select_unlocked_cells TYPE tv_sheet_protection_bool .
+  DATA sheet TYPE tv_sheet_protection_bool .
+  DATA sort TYPE tv_sheet_protection_bool .
 
   METHODS initialize .
 ENDINTERFACE.