SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 19:26:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove more comments and old coding

Browse Source
This commit is contained in:
Domi Bigl 2024-08-22 16:32:19 +00:00
parent 353b3ea7cc
commit 0ca9f78896
4 changed files with 14 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/not_cloud/zcl_excel_converter.clas.abap
View File

@ -524,10 +524,7 @@ CLASS zcl_excel_converter IMPLEMENTATION.
METHOD create_color_style. METHOD create_color_style.
DATA: ls_styles TYPE ts_styles. DATA: ls_styles TYPE ts_styles.
DATA: lo_style TYPE REF TO zcl_excel_style. DATA: lo_style TYPE REF TO zcl_excel_style.
* Begin of ATC fix-issue-1014-part1
* READ TABLE wt_styles INTO ls_styles WITH KEY guid = i_style.
READ TABLE wt_styles INTO ls_styles WITH KEY guid COMPONENTS guid = i_style. READ TABLE wt_styles INTO ls_styles WITH KEY guid COMPONENTS guid = i_style.
* End of ATC fix-issue-1014-part1
IF sy-subrc = 0. IF sy-subrc = 0.
lo_style = wo_excel->add_new_style( ). lo_style = wo_excel->add_new_style( ).
lo_style->font->bold = ls_styles-style->font->bold. lo_style->font->bold = ls_styles-style->font->bold.
@ -1372,15 +1369,10 @@ CLASS zcl_excel_converter IMPLEMENTATION.
IF l_line <= 1. IF l_line <= 1.
CLEAR l_hidden. CLEAR l_hidden.
ELSE. ELSE.
* Begin of ATC fix-issue-1014-part1 LOOP AT wt_sort_values INTO ls_sort_values USING KEY collapsed WHERE is_collapsed = abap_false.
* LOOP AT wt_sort_values INTO ls_sort_values WHERE is_collapsed = abap_false.
LOOP AT wt_sort_values INTO ls_sort_values USING KEY sort_level. "WHERE is_collapsed = abap_false.
* End of ATC fix-issue-1014-part1
IF ls_sort_values-is_collapsed = abap_false. "ATC fix-issue-1014-part1
IF l_hidden < ls_sort_values-sort_level. IF l_hidden < ls_sort_values-sort_level.
l_hidden = ls_sort_values-sort_level. l_hidden = ls_sort_values-sort_level.
ENDIF. ENDIF.
ENDIF.
ENDLOOP. ENDLOOP.
ENDIF. ENDIF.
ADD 1 TO l_hidden. " As this is the first level we show. ADD 1 TO l_hidden. " As this is the first level we show.
@ -1425,13 +1417,8 @@ CLASS zcl_excel_converter IMPLEMENTATION.
<fs_sortval> = <fs_fldval>. <fs_sortval> = <fs_fldval>.
<fs_sortv>-new = abap_false. <fs_sortv>-new = abap_false.
l_line = <fs_sortv>-sort_level. l_line = <fs_sortv>-sort_level.
* Begin of ATC fix-issue-1014-part1 LOOP AT wt_sort_values ASSIGNING <fs_sortv> WHERE sort_level >= l_line. "#EC CI_HASHSEQ
* LOOP AT wt_sort_values ASSIGNING <fs_sortv> WHERE sort_level >= l_line.
LOOP AT wt_sort_values ASSIGNING <fs_sortv> USING KEY sort_level .
* End of ATC fix-issue-1014-part1
IF <fs_sortv>-sort_level >= l_line. "ATC fix-issue-1014-part1
<fs_sortv>-row_int = l_row_int. <fs_sortv>-row_int = l_row_int.
ENDIF. "ATC fix-issue-1014-part1
ENDLOOP. ENDLOOP.
ENDIF. ENDIF.
ENDIF. ENDIF.

16
src/not_cloud/zcl_excel_converter.clas.locals_def.abap
View File

@ -18,13 +18,8 @@ TYPES: BEGIN OF ts_sort_values,
sort_level TYPE int4, sort_level TYPE int4,
is_collapsed TYPE flag, is_collapsed TYPE flag,
END OF ts_sort_values, END OF ts_sort_values,
* Begin of ATC fix-issue-1014-part1 tt_sort_values TYPE HASHED TABLE OF ts_sort_values WITH UNIQUE KEY primary_key COMPONENTS fieldname
* tt_sort_values TYPE HASHED TABLE OF ts_sort_values WITH UNIQUE KEY fieldname . WITH NON-UNIQUE SORTED KEY collapsed COMPONENTS is_collapsed .
tt_sort_values TYPE HASHED TABLE OF ts_sort_values
WITH UNIQUE KEY primary_key COMPONENTS fieldname
WITH NON-UNIQUE SORTED KEY sort_level COMPONENTS sort_level is_collapsed .
* End of ATC fix-issue-1014-part1
TYPES: BEGIN OF ts_subtotal_rows, TYPES: BEGIN OF ts_subtotal_rows,
row_int TYPE zexcel_cell_row, row_int TYPE zexcel_cell_row,
row_int_start TYPE zexcel_cell_row, row_int_start TYPE zexcel_cell_row,
@ -41,13 +36,8 @@ TYPES: BEGIN OF ts_styles,
style TYPE REF TO zcl_excel_style, style TYPE REF TO zcl_excel_style,
guid TYPE zexcel_cell_style, guid TYPE zexcel_cell_style,
END OF ts_styles, END OF ts_styles,
* Begin of ATC fix-issue-1014-part1 tt_styles TYPE HASHED TABLE OF ts_styles WITH UNIQUE KEY primary_key COMPONENTS type alignment inttype decimals
* tt_styles TYPE HASHED TABLE OF ts_styles WITH UNIQUE KEY type alignment inttype decimals.
tt_styles TYPE HASHED TABLE OF ts_styles WITH UNIQUE KEY primary_key
COMPONENTS type alignment inttype decimals
WITH NON-UNIQUE SORTED KEY guid COMPONENTS guid . WITH NON-UNIQUE SORTED KEY guid COMPONENTS guid .
.
* End of ATC fix-issue-1014-part1
TYPES: BEGIN OF ts_color_styles, TYPES: BEGIN OF ts_color_styles,
guid_old TYPE zexcel_cell_style, guid_old TYPE zexcel_cell_style,

6
src/zcl_excel_fill_template.clas.abap
View File

@ -192,7 +192,7 @@ CLASS zcl_excel_fill_template IMPLEMENTATION.
* update merged cells before range * update merged cells before range
LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from >= lv_start_row AND row_to <= lv_stop_row. LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from >= lv_start_row AND row_to <= lv_stop_row. "#EC CI_SORTSEQ
ls_merged_cell-row_from = ls_merged_cell-row_from + cv_diff. ls_merged_cell-row_from = ls_merged_cell-row_from + cv_diff.
ls_merged_cell-row_to = ls_merged_cell-row_to + cv_diff. ls_merged_cell-row_to = ls_merged_cell-row_to + cv_diff.
@ -216,7 +216,7 @@ CLASS zcl_excel_fill_template IMPLEMENTATION.
APPEND ls_cell TO lt_tmp_cells_template. APPEND ls_cell TO lt_tmp_cells_template.
ENDLOOP. ENDLOOP.
LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from >= <ls_range>-start AND row_to <= <ls_range>-stop. LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from >= <ls_range>-start AND row_to <= <ls_range>-stop. "#EC CI_SORTSEQ
APPEND ls_merged_cell TO lt_tmp_merged_cells_template. APPEND ls_merged_cell TO lt_tmp_merged_cells_template.
ENDLOOP. ENDLOOP.
@ -271,7 +271,7 @@ CLASS zcl_excel_fill_template IMPLEMENTATION.
ct_cells = lt_cells_result. ct_cells = lt_cells_result.
LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from > <ls_range>-stop. LOOP AT ct_merged_cells INTO ls_merged_cell WHERE row_from > <ls_range>-stop. "#EC CI_SORTSEQ
ls_merged_cell-row_from = ls_merged_cell-row_from + cv_diff. ls_merged_cell-row_from = ls_merged_cell-row_from + cv_diff.
ls_merged_cell-row_to = ls_merged_cell-row_to + cv_diff. ls_merged_cell-row_to = ls_merged_cell-row_to + cv_diff.

4
src/zcl_excel_worksheet.clas.abap
View File

@ -2441,7 +2441,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
LOOP AT me->mt_merged_cells TRANSPORTING NO FIELDS LOOP AT me->mt_merged_cells TRANSPORTING NO FIELDS
WHERE row_from <= ip_cell_row AND row_to >= ip_cell_row WHERE row_from <= ip_cell_row AND row_to >= ip_cell_row
AND col_from <= lv_column AND col_to >= lv_column. AND col_from <= lv_column AND col_to >= lv_column. "#EC CI_SORTSEQ
DELETE me->mt_merged_cells. DELETE me->mt_merged_cells.
EXIT. EXIT.
ENDLOOP. ENDLOOP.
@ -4328,7 +4328,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
LOOP AT me->mt_merged_cells TRANSPORTING NO FIELDS WHERE NOT ( row_from > ls_merge-row_to LOOP AT me->mt_merged_cells TRANSPORTING NO FIELDS WHERE NOT ( row_from > ls_merge-row_to
OR row_to < ls_merge-row_from OR row_to < ls_merge-row_from
OR col_from > ls_merge-col_to OR col_from > ls_merge-col_to
OR col_to < ls_merge-col_from ). OR col_to < ls_merge-col_from ). "#EC CI_SORTSEQ
lv_errormessage = 'Overlapping merges'(404). lv_errormessage = 'Overlapping merges'(404).
zcx_excel=>raise_text( lv_errormessage ). zcx_excel=>raise_text( lv_errormessage ).