SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 02:30:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

ZCL_EXCEL_COMMON: less DDIC references (#828)

Browse Source 
* ZCL_EXCEL_COMMON: less DDIC references

* Update zexcel_s_org_rel.tabl.xml

* fix

* remove more DDIC references from testclasses
This commit is contained in:
Lars Hvam 2021-10-07 06:33:48 +02:00 committed by GitHub
parent ca69b38a79
commit 16430d17dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/zcl_excel_common.clas.abap
View File

@ -933,8 +933,8 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
* This is private an no one using it so far except me, so no need to hurry
DATA: descr TYPE REF TO cl_abap_structdescr,
wa_component LIKE LINE OF descr->components,
attribute_name TYPE fieldname,
flag_class TYPE flag.
attribute_name LIKE wa_component-name,
flag_class TYPE abap_bool.
FIELD-SYMBOLS: <field> TYPE any,
<fieldx> TYPE any,
@ -987,8 +987,8 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
* This is private an no one using it so far except me, so no need to hurry
DATA: descr TYPE REF TO cl_abap_structdescr,
wa_component LIKE LINE OF descr->components,
attribute_name TYPE fieldname,
flag_class TYPE flag,
attribute_name LIKE wa_component-name,
flag_class TYPE abap_bool,
o_border TYPE REF TO zcl_excel_style_border.
FIELD-SYMBOLS: <field> TYPE any,

44
src/zcl_excel_common.clas.testclasses.abap
View File

@ -14,8 +14,8 @@ CLASS lcl_excel_common_test DEFINITION FOR TESTING
* ================
DATA:
lx_excel TYPE REF TO zcx_excel,
ls_symsg_act TYPE symsg, " actual messageinformation of exception
ls_symsg_exp TYPE symsg, " expected messageinformation of exception
ls_symsg_act LIKE sy, " actual messageinformation of exception
ls_symsg_exp LIKE sy, " expected messageinformation of exception
f_cut TYPE REF TO zcl_excel_common. "class under test
METHODS: setup.
@ -893,7 +893,7 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
METHOD describe_structure.
DATA: ls_test TYPE scarr.
DATA: ls_test TYPE zexcel_pane.
DATA: lo_structdescr TYPE REF TO cl_abap_structdescr.
DATA: lt_structure TYPE ddfields.
FIELD-SYMBOLS: <line> LIKE LINE OF lt_structure.
@ -904,15 +904,15 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
READ TABLE lt_structure ASSIGNING <line> INDEX 1.
cl_abap_unit_assert=>assert_equals(
act = <line>-fieldname
exp = 'MANDT'
exp = 'YSPLIT'
msg = 'Describe structure failed'
level = if_aunit_constants=>critical ).
" Test with local defined structure having DDIC and non DDIC elements
TYPES:
BEGIN OF t_test,
carrid TYPE s_carr_id,
carrname TYPE s_carrname,
carrid TYPE string,
carrname TYPE string,
carrdesc TYPE string,
END OF t_test.
DATA: ls_ttest TYPE t_test.
@ -1041,7 +1041,7 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
DATA: lv_resulting_formula TYPE string,
lv_message TYPE string,
lv_counter TYPE num8.
lv_counter TYPE n LENGTH 8.
ADD 1 TO lv_counter.
CLEAR lv_resulting_formula.
@ -1083,105 +1083,105 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
iv_shift_rows = 0
iv_expected = 'C17' ).
" Check shift right and down
" Check shift right and down
macro_shift_formula(
iv_reference_formula = 'C17'
iv_shift_cols = 2
iv_shift_rows = 3
iv_expected = 'E20' ).
" Check shift left and up
" Check shift left and up
macro_shift_formula(
iv_reference_formula = 'C17'
iv_shift_cols = -2
iv_shift_rows = -3
iv_expected = 'A14' ).
" Fixed columns/rows
" Fixed columns/rows
macro_shift_formula(
iv_reference_formula = '$C$17'
iv_shift_cols = 1
iv_shift_rows = 1
iv_expected = '$C$17' ).
" Operators and Ranges, mixed fixed rows or columns
" Operators and Ranges, mixed fixed rows or columns
macro_shift_formula(
iv_reference_formula = 'SUM($C17:C$23)+C30'
iv_shift_cols = 1
iv_shift_rows = 11
iv_expected = 'SUM($C28:D$23)+D41' ).
" Operators and Rangename
" Operators and Rangename
macro_shift_formula(
iv_reference_formula = 'RNGNAME1+C7'
iv_shift_cols = -1
iv_shift_rows = -4
iv_expected = 'RNGNAME1+B3' ).
" String literals and string concatenation
" String literals and string concatenation
macro_shift_formula(
iv_reference_formula = '"Date:"&TEXT(B2)'
iv_shift_cols = 1
iv_shift_rows = 1
iv_expected = '"Date:"&TEXT(C3)' ).
" External sheet reference
" External sheet reference
macro_shift_formula(
iv_reference_formula = '[TEST6.XLSX]SHEET1!A1'
iv_shift_cols = 1
iv_shift_rows = 11
iv_expected = '[TEST6.XLSX]SHEET1!B12' ).
" superflous blanks, multi-argument functions, literals in function, unknown functions
" superflous blanks, multi-argument functions, literals in function, unknown functions
macro_shift_formula(
iv_reference_formula = `X(B13, "KK" ) `
iv_shift_cols = 1
iv_shift_rows = 1
iv_expected = `X(C14,"KK")` ).
" same as above - but with string input instead of Char-input
" same as above - but with string input instead of Char-input
macro_shift_formula(
iv_reference_formula = `SIN(SIN(SIN(SIN(E22))))`
iv_shift_cols = 0
iv_shift_rows = 1
iv_expected = 'SIN(SIN(SIN(SIN(E23))))' ).
" Functions w/o arguments, No cellreferences
" Functions w/o arguments, No cellreferences
macro_shift_formula(
iv_reference_formula = 'HEUTE()'
iv_shift_cols = 2
iv_shift_rows = 5
iv_expected = 'HEUTE()' ).
" No cellreferences
" No cellreferences
macro_shift_formula(
iv_reference_formula = '"B2"'
iv_shift_cols = 2
iv_shift_rows = 5
iv_expected = '"B2"' ).
" Empty
" Empty
macro_shift_formula(
iv_reference_formula = ''
iv_shift_cols = 2
iv_shift_rows = 5
iv_expected = '' ).
" Referencing error , column only , underflow
" Referencing error , column only , underflow
macro_shift_formula(
iv_reference_formula = 'A1+$A1+A$1+$A$1+B2'
iv_shift_cols = -1
iv_shift_rows = 0
iv_expected = '#REF!+$A1+#REF!+$A$1+A2' ).
" Referencing error , row only , underflow
" Referencing error , row only , underflow
macro_shift_formula(
iv_reference_formula = 'A1+$A1+A$1+$A$1+B2'
iv_shift_cols = 0
iv_shift_rows = -1
iv_expected = '#REF!+#REF!+A$1+$A$1+B1' ).
" Referencing error , row and column , underflow
" Referencing error , row and column , underflow
macro_shift_formula(
iv_reference_formula = 'A1+$A1+A$1+$A$1+B2'
iv_shift_cols = -1