SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 11:16:14 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

ZCL_EXCEL_COMMON: less DDIC references (#828)

Browse Source 
* ZCL_EXCEL_COMMON: less DDIC references

* Update zexcel_s_org_rel.tabl.xml

* fix

* remove more DDIC references from testclasses
This commit is contained in:
Lars Hvam 2021-10-07 06:33:48 +02:00 committed by GitHub
parent ca69b38a79
commit 16430d17dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/zcl_excel_common.clas.abap
View File

@ -933,8 +933,8 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
* This is private an no one using it so far except me, so no need to hurry * This is private an no one using it so far except me, so no need to hurry
DATA: descr TYPE REF TO cl_abap_structdescr, DATA: descr TYPE REF TO cl_abap_structdescr,
wa_component LIKE LINE OF descr->components, wa_component LIKE LINE OF descr->components,
attribute_name TYPE fieldname, attribute_name LIKE wa_component-name,
flag_class TYPE flag. flag_class TYPE abap_bool.
FIELD-SYMBOLS: <field> TYPE any, FIELD-SYMBOLS: <field> TYPE any,
<fieldx> TYPE any, <fieldx> TYPE any,
@ -987,8 +987,8 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
* This is private an no one using it so far except me, so no need to hurry * This is private an no one using it so far except me, so no need to hurry
DATA: descr TYPE REF TO cl_abap_structdescr, DATA: descr TYPE REF TO cl_abap_structdescr,
wa_component LIKE LINE OF descr->components, wa_component LIKE LINE OF descr->components,
attribute_name TYPE fieldname, attribute_name LIKE wa_component-name,
flag_class TYPE flag, flag_class TYPE abap_bool,
o_border TYPE REF TO zcl_excel_style_border. o_border TYPE REF TO zcl_excel_style_border.
FIELD-SYMBOLS: <field> TYPE any, FIELD-SYMBOLS: <field> TYPE any,

14
src/zcl_excel_common.clas.testclasses.abap
View File

@ -14,8 +14,8 @@ CLASS lcl_excel_common_test DEFINITION FOR TESTING
* ================ * ================
DATA: DATA:
lx_excel TYPE REF TO zcx_excel, lx_excel TYPE REF TO zcx_excel,
ls_symsg_act TYPE symsg, " actual messageinformation of exception ls_symsg_act LIKE sy, " actual messageinformation of exception
ls_symsg_exp TYPE symsg, " expected messageinformation of exception ls_symsg_exp LIKE sy, " expected messageinformation of exception
f_cut TYPE REF TO zcl_excel_common. "class under test f_cut TYPE REF TO zcl_excel_common. "class under test
METHODS: setup. METHODS: setup.
@ -893,7 +893,7 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
METHOD describe_structure. METHOD describe_structure.
DATA: ls_test TYPE scarr. DATA: ls_test TYPE zexcel_pane.
DATA: lo_structdescr TYPE REF TO cl_abap_structdescr. DATA: lo_structdescr TYPE REF TO cl_abap_structdescr.
DATA: lt_structure TYPE ddfields. DATA: lt_structure TYPE ddfields.
FIELD-SYMBOLS: <line> LIKE LINE OF lt_structure. FIELD-SYMBOLS: <line> LIKE LINE OF lt_structure.
@ -904,15 +904,15 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
READ TABLE lt_structure ASSIGNING <line> INDEX 1. READ TABLE lt_structure ASSIGNING <line> INDEX 1.
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = <line>-fieldname act = <line>-fieldname
exp = 'MANDT' exp = 'YSPLIT'
msg = 'Describe structure failed' msg = 'Describe structure failed'
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
" Test with local defined structure having DDIC and non DDIC elements " Test with local defined structure having DDIC and non DDIC elements
TYPES: TYPES:
BEGIN OF t_test, BEGIN OF t_test,
carrid TYPE s_carr_id, carrid TYPE string,
carrname TYPE s_carrname, carrname TYPE string,
carrdesc TYPE string, carrdesc TYPE string,
END OF t_test. END OF t_test.
DATA: ls_ttest TYPE t_test. DATA: ls_ttest TYPE t_test.
@ -1041,7 +1041,7 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
DATA: lv_resulting_formula TYPE string, DATA: lv_resulting_formula TYPE string,
lv_message TYPE string, lv_message TYPE string,
lv_counter TYPE num8. lv_counter TYPE n LENGTH 8.
ADD 1 TO lv_counter. ADD 1 TO lv_counter.
CLEAR lv_resulting_formula. CLEAR lv_resulting_formula.