From 8428eb04d2e20bf702f83ba10e2e493ff4241249 Mon Sep 17 00:00:00 2001 From: Domi Bigl Date: Sat, 8 Feb 2025 19:47:27 +0100 Subject: [PATCH 1/2] usea APLHA for cols in reference string (#1279) fixes #1215 --- src/zcl_excel_table.clas.abap | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/zcl_excel_table.clas.abap b/src/zcl_excel_table.clas.abap index 6887e3f..d6ecbea 100644 --- a/src/zcl_excel_table.clas.abap +++ b/src/zcl_excel_table.clas.abap @@ -174,8 +174,10 @@ CLASS zcl_excel_table IMPLEMENTATION. METHOD get_reference. - DATA: lv_column TYPE zexcel_cell_column, + DATA: lv_start_column TYPE zexcel_cell_column, + lv_end_column TYPE zexcel_cell_column, lv_table_lines TYPE i, + lv_left_column TYPE zexcel_cell_column_alpha, lv_right_column TYPE zexcel_cell_column_alpha, ls_field_catalog TYPE zexcel_s_fieldcatalog, lv_bottom_row TYPE zexcel_cell_row, @@ -185,13 +187,12 @@ CLASS zcl_excel_table IMPLEMENTATION. FIELD-SYMBOLS: TYPE STANDARD TABLE. *column - lv_column = zcl_excel_common=>convert_column2int( settings-top_left_column ). + lv_start_column = zcl_excel_common=>convert_column2int( settings-top_left_column ). lv_table_lines = 0. LOOP AT fieldcat INTO ls_field_catalog WHERE dynpfld EQ abap_true. ADD 1 TO lv_table_lines. ENDLOOP. - lv_column = lv_column + lv_table_lines - 1. - lv_right_column = zcl_excel_common=>convert_column2alpha( lv_column ). + lv_end_column = lv_start_column + lv_table_lines - 1. *row ASSIGN table_data->* TO . @@ -208,7 +209,9 @@ CLASS zcl_excel_table IMPLEMENTATION. lv_top_row_string = zcl_excel_common=>number_to_excel_string( settings-top_left_row ). lv_bottom_row_string = zcl_excel_common=>number_to_excel_string( lv_bottom_row ). - CONCATENATE settings-top_left_column lv_top_row_string + lv_left_column = zcl_excel_common=>convert_column2alpha( lv_start_column ). + lv_right_column = zcl_excel_common=>convert_column2alpha( lv_end_column ). + CONCATENATE lv_left_column lv_top_row_string ':' lv_right_column lv_bottom_row_string INTO ov_reference. From a1af09f064ea0aec3aae058efd121354ac8dae48 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Sun, 9 Feb 2025 16:29:59 +0100 Subject: [PATCH 2/2] Create SECURITY.md: Reporting Security Issues (#1289) Co-authored-by: Domi Bigl --- SECURITY.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 SECURITY.md diff --git a/SECURITY.md b/SECURITY.md new file mode 100644 index 0000000..63bce7d --- /dev/null +++ b/SECURITY.md @@ -0,0 +1,3 @@ +# Reporting Security Issues + +To report a security issue, please use the GitHub Security Advisory ["Report a Vulnerability"](https://github.com/abap2xlsx/abap2xlsx/security/advisories/new) tab.