SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 19:16:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid recent syntax - keep compatible with old SAP

Browse Source 
Data declarations made explicit
This commit is contained in:
Kjetil Kilhavn 2023-08-10 07:32:39 +00:00
parent 7e5f6da63d
commit 375334a0ed
2 changed files with 34 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/zcl_excel_common.clas.testclasses.abap
View File

@ -141,11 +141,19 @@ CLASS ltc_xlsx_date_time DEFINITION FINAL FOR TESTING
PRIVATE SECTION. PRIVATE SECTION.
CONSTANTS dt_20230803_140711 TYPE string VALUE `45141.588321759256`. "Excel raw value for date & time 2023-08-03 14:07:11 CONSTANTS dt_20230803_140711 TYPE string VALUE `45141.588321759256`. "Excel raw value for date & time 2023-08-03 14:07:11
DATA cut TYPE REF TO zcl_excel_common.
METHODS:
setup,
teardown.
METHODS: METHODS:
from_xlsx_to_date FOR TESTING RAISING cx_static_check, from_xlsx_to_date FOR TESTING RAISING cx_static_check,
from_xlsx_to_time FOR TESTING RAISING cx_static_check, from_xlsx_to_time FOR TESTING RAISING cx_static_check,
from_xlsx_to_timestamp FOR TESTING RAISING cx_static_check. from_xlsx_to_timestamp FOR TESTING RAISING cx_static_check.
ENDCLASS.
DATA excel_error TYPE REF TO zcx_excel.
ENDCLASS.
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
* CLASS lcl_Excel_Common_Test IMPLEMENTATION * CLASS lcl_Excel_Common_Test IMPLEMENTATION
@ -1708,16 +1716,24 @@ ENDCLASS.
CLASS ltc_xlsx_date_time IMPLEMENTATION. CLASS ltc_xlsx_date_time IMPLEMENTATION.
METHOD setup.
cut = NEW #( ).
ENDMETHOD.
METHOD teardown.
CLEAR cut.
ENDMETHOD.
METHOD from_xlsx_to_date. METHOD from_xlsx_to_date.
TRY. TRY.
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = zcl_excel_common=>excel_string_to_date( dt_20230803_140711 ) act = cut->excel_string_to_date( dt_20230803_140711 )
exp = '20230803' exp = '20230803'
msg = 'Wrong date from conversion' msg = 'Wrong date from conversion'
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
CATCH zcx_excel INTO DATA(excel_error). CATCH zcx_excel INTO excel_error.
cl_abap_unit_assert=>fail( cl_abap_unit_assert=>fail(
msg = 'unexpected exception' && excel_error->get_text( ) msg = 'Unexpected exception: ' && excel_error->get_text( )
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -1725,13 +1741,13 @@ CLASS ltc_xlsx_date_time IMPLEMENTATION.
METHOD from_xlsx_to_time. METHOD from_xlsx_to_time.
TRY. TRY.
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = zcl_excel_common=>excel_string_to_time( dt_20230803_140711 ) act = cut->excel_string_to_time( dt_20230803_140711 )
exp = '140711' exp = '140711'
msg = 'Wrong time from conversion' msg = 'Wrong time from conversion'
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
CATCH zcx_excel INTO DATA(excel_error). CATCH zcx_excel INTO excel_error.
cl_abap_unit_assert=>fail( cl_abap_unit_assert=>fail(
msg = 'unexpected exception' && excel_error->get_text( ) msg = 'Unexpected exception: ' && excel_error->get_text( )
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -1739,13 +1755,13 @@ CLASS ltc_xlsx_date_time IMPLEMENTATION.
METHOD from_xlsx_to_timestamp. METHOD from_xlsx_to_timestamp.
TRY. TRY.
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = zcl_excel_common=>excel_string_to_timestamp( dt_20230803_140711 ) act = cut->excel_string_to_timestamp( dt_20230803_140711 )
exp = '20230803140711' exp = '20230803140711'
msg = 'Wrong time stamp from conversion' msg = 'Wrong time stamp from conversion'
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
CATCH zcx_excel INTO DATA(excel_error). CATCH zcx_excel INTO excel_error.
cl_abap_unit_assert=>fail( cl_abap_unit_assert=>fail(
msg = 'unexpected exception' && excel_error->get_text( ) msg = 'Unexpected exception: ' && excel_error->get_text( )
level = if_aunit_constants=>critical ). level = if_aunit_constants=>critical ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.

12
src/zcl_excel_worksheet.clas.testclasses.abap
View File

@ -318,6 +318,8 @@ CLASS ltc_is_date_format DEFINITION FINAL FOR TESTING
teardown. teardown.
METHODS: METHODS:
date_format_iso FOR TESTING RAISING cx_static_check. date_format_iso FOR TESTING RAISING cx_static_check.
DATA excel_error TYPE REF TO zcx_excel.
ENDCLASS. ENDCLASS.
@ -334,6 +336,8 @@ CLASS ltc_is_time_format DEFINITION FINAL FOR TESTING
teardown. teardown.
METHODS: METHODS:
time_format_iso FOR TESTING RAISING cx_static_check. time_format_iso FOR TESTING RAISING cx_static_check.
DATA excel_error TYPE REF TO zcx_excel.
ENDCLASS. ENDCLASS.
@ -1708,9 +1712,9 @@ CLASS ltc_is_date_format IMPLEMENTATION.
TRY. TRY.
xlsx = NEW #( ). xlsx = NEW #( ).
cut = NEW #( xlsx ). cut = NEW #( xlsx ).
CATCH zcx_excel INTO DATA(excel_error). CATCH zcx_excel INTO excel_error.
cl_abap_unit_assert=>fail( cl_abap_unit_assert=>fail(
msg = 'Could not create instance' msg = 'Could not create instance: ' && excel_error->get_text( )
quit = if_aunit_constants=>class ). quit = if_aunit_constants=>class ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -1736,9 +1740,9 @@ CLASS ltc_is_time_format IMPLEMENTATION.
TRY. TRY.
xlsx = NEW #( ). xlsx = NEW #( ).
cut = NEW #( xlsx ). cut = NEW #( xlsx ).
CATCH zcx_excel INTO DATA(excel_error). CATCH zcx_excel INTO excel_error.
cl_abap_unit_assert=>fail( cl_abap_unit_assert=>fail(
msg = 'Could not create instance' msg = 'Could not create instance: ' && excel_error->get_text( )
quit = if_aunit_constants=>class ). quit = if_aunit_constants=>class ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.