From 8230c41f09d21bcce1e024b006699e87a2dfdb69 Mon Sep 17 00:00:00 2001 From: Bernd <135710507+darnoc312@users.noreply.github.com> Date: Thu, 31 Oct 2024 13:55:57 +0100 Subject: [PATCH 1/3] Update zcl_excel_writer_2007.clas.locals_imp.abap --- src/zcl_excel_writer_2007.clas.locals_imp.abap | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/zcl_excel_writer_2007.clas.locals_imp.abap b/src/zcl_excel_writer_2007.clas.locals_imp.abap index b8afbff..a32fe27 100644 --- a/src/zcl_excel_writer_2007.clas.locals_imp.abap +++ b/src/zcl_excel_writer_2007.clas.locals_imp.abap @@ -460,19 +460,19 @@ CLASS lcl_create_xl_sheet IMPLEMENTATION. METHOD add_sheetformatpr. DATA: lo_element TYPE REF TO if_ixml_element, lo_column_default TYPE REF TO zcl_excel_column, - lo_row_default TYPE REF TO zcl_excel_row,lv_value TYPE string, + lo_row_default TYPE REF TO zcl_excel_row, + lv_value TYPE string, + lo_columns TYPE REF TO zcl_excel_columns, lo_column_iterator TYPE REF TO zcl_excel_collection_iterator, lo_column TYPE REF TO zcl_excel_column, - lo_row_iterator TYPE REF TO zcl_excel_collection_iterator, outline_level_col TYPE i VALUE 0. - lo_column_iterator = o_worksheet->get_columns_iterator( ). - lo_row_iterator = o_worksheet->get_rows_iterator( ). + lo_columns = o_worksheet->get_columns( ). " Calculate col - IF NOT lo_column_iterator IS BOUND. + IF lo_columns->is_empty() = abap_false. o_worksheet->calculate_column_widths( ). - lo_column_iterator = o_worksheet->get_columns_iterator( ). ENDIF. + lo_column_iterator = lo_columns->get_iterator( ). " sheetFormatPr node lo_element = o_document->create_simple_element( name = lc_xml_node_sheetformatpr From 0ccb26f312d359cb999937e460148f776e2bae33 Mon Sep 17 00:00:00 2001 From: Bernd <135710507+darnoc312@users.noreply.github.com> Date: Thu, 31 Oct 2024 14:06:51 +0100 Subject: [PATCH 2/3] Update zcl_excel_writer_2007.clas.locals_imp.abap --- src/zcl_excel_writer_2007.clas.locals_imp.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zcl_excel_writer_2007.clas.locals_imp.abap b/src/zcl_excel_writer_2007.clas.locals_imp.abap index a32fe27..9201f6c 100644 --- a/src/zcl_excel_writer_2007.clas.locals_imp.abap +++ b/src/zcl_excel_writer_2007.clas.locals_imp.abap @@ -469,7 +469,7 @@ CLASS lcl_create_xl_sheet IMPLEMENTATION. lo_columns = o_worksheet->get_columns( ). " Calculate col - IF lo_columns->is_empty() = abap_false. + IF lo_columns->is_empty( ) = abap_false. o_worksheet->calculate_column_widths( ). ENDIF. lo_column_iterator = lo_columns->get_iterator( ). From e41cfae2795b63f0759456509fe450d3bf147e28 Mon Sep 17 00:00:00 2001 From: Bernd <135710507+darnoc312@users.noreply.github.com> Date: Sun, 3 Nov 2024 14:54:41 +0100 Subject: [PATCH 3/3] Update zcl_excel_writer_2007.clas.locals_imp.abap This seems to be more usual --- src/zcl_excel_writer_2007.clas.locals_imp.abap | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/zcl_excel_writer_2007.clas.locals_imp.abap b/src/zcl_excel_writer_2007.clas.locals_imp.abap index 9201f6c..f913c7b 100644 --- a/src/zcl_excel_writer_2007.clas.locals_imp.abap +++ b/src/zcl_excel_writer_2007.clas.locals_imp.abap @@ -462,17 +462,15 @@ CLASS lcl_create_xl_sheet IMPLEMENTATION. lo_column_default TYPE REF TO zcl_excel_column, lo_row_default TYPE REF TO zcl_excel_row, lv_value TYPE string, - lo_columns TYPE REF TO zcl_excel_columns, lo_column_iterator TYPE REF TO zcl_excel_collection_iterator, lo_column TYPE REF TO zcl_excel_column, outline_level_col TYPE i VALUE 0. - lo_columns = o_worksheet->get_columns( ). + lo_column_iterator = o_worksheet->get_columns_iterator( ). " Calculate col - IF lo_columns->is_empty( ) = abap_false. + IF lo_column_iterator->has_next( ) = abap_true. o_worksheet->calculate_column_widths( ). ENDIF. - lo_column_iterator = lo_columns->get_iterator( ). " sheetFormatPr node lo_element = o_document->create_simple_element( name = lc_xml_node_sheetformatpr