Replace pass by value with reference

#1013
This commit is contained in:
Prashant Kumar 2022-06-15 12:49:29 +00:00
parent 781edaf1d6
commit 6ba17cfa6c
4 changed files with 50 additions and 48 deletions

View File

@ -24,10 +24,10 @@ CLASS zcl_excel_theme DEFINITION
VALUE(rv_xstring) TYPE xstring . VALUE(rv_xstring) TYPE xstring .
METHODS set_color METHODS set_color
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_srgb) TYPE zcl_excel_theme_color_scheme=>t_srgb OPTIONAL iv_srgb TYPE zcl_excel_theme_color_scheme=>t_srgb OPTIONAL
VALUE(iv_syscolorname) TYPE string OPTIONAL iv_syscolorname TYPE string OPTIONAL
VALUE(iv_syscolorlast) TYPE zcl_excel_theme_color_scheme=>t_srgb OPTIONAL . iv_syscolorlast TYPE zcl_excel_theme_color_scheme=>t_srgb OPTIONAL .
METHODS set_color_scheme_name METHODS set_color_scheme_name
IMPORTING IMPORTING
iv_name TYPE string . iv_name TYPE string .
@ -38,31 +38,31 @@ CLASS zcl_excel_theme DEFINITION
iv_typeface TYPE string . iv_typeface TYPE string .
METHODS set_latin_font METHODS set_latin_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS set_ea_font METHODS set_ea_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS set_cs_font METHODS set_cs_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS set_font_scheme_name METHODS set_font_scheme_name
IMPORTING IMPORTING
VALUE(iv_name) TYPE string . iv_name TYPE string .
METHODS set_theme_name METHODS set_theme_name
IMPORTING IMPORTING
VALUE(iv_name) TYPE string . iv_name TYPE string .
PROTECTED SECTION. PROTECTED SECTION.
DATA elements TYPE REF TO zcl_excel_theme_elements . DATA elements TYPE REF TO zcl_excel_theme_elements .

View File

@ -54,7 +54,7 @@ CLASS zcl_excel_theme_color_scheme DEFINITION
METHODS constructor . METHODS constructor .
METHODS set_name METHODS set_name
IMPORTING IMPORTING
VALUE(iv_name) TYPE string . iv_name TYPE string .
PROTECTED SECTION. PROTECTED SECTION.
DATA name TYPE string . DATA name TYPE string .

View File

@ -58,41 +58,41 @@ CLASS zcl_excel_theme_font_scheme DEFINITION
!io_document TYPE REF TO if_ixml_document . !io_document TYPE REF TO if_ixml_document .
METHODS modify_font METHODS modify_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_script) TYPE string iv_script TYPE string
VALUE(iv_typeface) TYPE string . iv_typeface TYPE string .
METHODS modify_latin_font METHODS modify_latin_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS modify_ea_font METHODS modify_ea_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS modify_cs_font METHODS modify_cs_font
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
METHODS constructor . METHODS constructor .
PROTECTED SECTION. PROTECTED SECTION.
METHODS modify_lec_fonts METHODS modify_lec_fonts
IMPORTING IMPORTING
VALUE(iv_type) TYPE string iv_type TYPE string
VALUE(iv_font_type) TYPE string iv_font_type TYPE string
VALUE(iv_typeface) TYPE string iv_typeface TYPE string
VALUE(iv_panose) TYPE string OPTIONAL iv_panose TYPE string OPTIONAL
VALUE(iv_pitchfamily) TYPE string OPTIONAL iv_pitchfamily TYPE string OPTIONAL
VALUE(iv_charset) TYPE string OPTIONAL . iv_charset TYPE string OPTIONAL .
PRIVATE SECTION. PRIVATE SECTION.
DATA font_scheme TYPE t_scheme . DATA font_scheme TYPE t_scheme .

View File

@ -73,8 +73,10 @@ CLASS zcl_excel_worksheet DEFINITION
col_from TYPE i, col_from TYPE i,
col_to TYPE i, col_to TYPE i,
END OF mty_merge . END OF mty_merge .
TYPES: TYPES:
mty_ts_merge TYPE SORTED TABLE OF mty_merge WITH UNIQUE KEY table_line . mty_ts_merge TYPE SORTED TABLE OF mty_merge WITH UNIQUE KEY table_line .
* mty_ts_merge TYPE TABLE OF mty_merge WITH UNIQUE SORTED KEY sort_key COMPONENTS row_from row_to.
TYPES: TYPES:
ty_area TYPE c LENGTH 1 . ty_area TYPE c LENGTH 1 .
@ -814,7 +816,7 @@ ENDCLASS.
CLASS zcl_excel_worksheet IMPLEMENTATION. CLASS ZCL_EXCEL_WORKSHEET IMPLEMENTATION.
METHOD add_comment. METHOD add_comment.