update linter config, remove some unused variables (#685)

* update linter config

* teched9 demo, cleanup unused variables

* 28 and 29, cleanup unused variables

* remove few more

abaplint.json

@@ -13,6 +13,11 @@
     "globalMacros": []
   },
   "rules": {
+    "downport": false,
+    "forbidden_void_type": false,
+    "line_break_multiple_parameters": false,
+    "prefer_inline": false,
+    "reduce_string_templates": true,
     "forbidden_identifier": false,
     "try_without_catch": true,
     "unknown_types": false,
@@ -79,6 +84,7 @@
       "ttyp": "^ZEXCEL",
       "dtel": "^ZEXCEL",
       "doma": "^Z",
+      "shlp": "^Z",
       "msag": "^Z",
       "tran": "^Z",
       "enqu": "^EZ",

src/zcl_excel_writer_2007.clas.abap

@@ -242,7 +242,6 @@ METHOD create.
         lv_xl_sheet_rels          TYPE string,
         lv_xl_drawing_for_comment TYPE string,   " (+) Issue #180
         lv_xl_comment             TYPE string,   " (+) Issue #180
-        lv_xl_comment_rels        TYPE string,   " (+) Issue #180
         lv_xl_drawing             TYPE string,
         lv_xl_drawing_rels        TYPE string,
         lv_index_str              TYPE string,
@@ -3294,7 +3293,6 @@ METHOD create_xl_drawing_for_hdft_im.
       ld_3 TYPE string,
       ld_4 TYPE string,
       ld_5 TYPE string,
-      ld_6 TYPE string,
       ld_7 TYPE string,
 
       ls_odd_header  TYPE zexcel_s_worksheet_head_foot,
@@ -7757,13 +7755,10 @@ METHOD set_vml_string.
       ld_3 TYPE string,
       ld_4 TYPE string,
       ld_5 TYPE string,
-      ld_6 TYPE string,
       ld_7 TYPE string,
 
-      lv_value       TYPE string,
       lv_relation_id TYPE i,
       lo_iterator    TYPE REF TO cl_object_collection_iterator,
-      lo_drawing     TYPE REF TO zcl_excel_drawing,
       lo_worksheet   TYPE REF TO zcl_excel_worksheet,
       ls_odd_header  TYPE zexcel_s_worksheet_head_foot,
       ls_odd_footer  TYPE zexcel_s_worksheet_head_foot,

src/zcl_excel_writer_huge_file.clas.abap

@@ -135,7 +135,6 @@ METHOD create_xl_sheet.
     lty_bool TYPE c LENGTH 5.
 
   CONSTANTS:
-    lc_false              TYPE lty_bool   VALUE 'false',    "#EC NEEDED
     lc_true               TYPE lty_bool   VALUE 'true',
     lc_zero               TYPE c LENGTH 1 VALUE '0',
     lc_one                TYPE c LENGTH 1 VALUE '1',

src/zdemo_excel28.prog.abap

@@ -11,16 +11,13 @@ REPORT zdemo_excel28.
 DATA: lo_excel                TYPE REF TO zcl_excel,
       lo_excel_writer         TYPE REF TO zif_excel_writer,
       lo_worksheet            TYPE REF TO zcl_excel_worksheet,
-      lo_hyperlink            TYPE REF TO zcl_excel_hyperlink,
       lo_column               TYPE REF TO zcl_excel_column.
 
 DATA: lv_file                 TYPE xstring,
       lv_bytecount            TYPE i,
       lt_file_tab             TYPE solix_tab.
 
-DATA: lv_file_name      TYPE string,
+DATA: lv_full_path      TYPE string,
-      lv_file_path      TYPE string,
-      lv_full_path      TYPE string,
       lv_workdir        TYPE string,
       lv_file_separator TYPE c.
 

src/zdemo_excel29.prog.abap

@@ -18,8 +18,7 @@ DATA: lv_file                 TYPE xstring,
 
 DATA: lv_full_path      TYPE string,
       lv_filename       TYPE string,
-      lv_workdir        TYPE string,
+      lv_workdir        TYPE string.
-      lv_file_separator TYPE c.
 
 PARAMETERS: p_path TYPE zexcel_export_dir OBLIGATORY.
 

src/zdemo_teched9.prog.abap

@@ -35,16 +35,13 @@ DATA: lo_style_title           TYPE REF TO zcl_excel_style,
 DATA: lo_send_request TYPE REF TO cl_bcs,
       lo_document     TYPE REF TO cl_document_bcs,
       lo_sender       TYPE REF TO cl_sapuser_bcs,
-      lo_recipient    TYPE REF TO cl_sapuser_bcs,
+      lo_recipient    TYPE REF TO cl_sapuser_bcs.
-      lo_recipient_i  TYPE REF TO CL_CAM_ADDRESS_BCS.
 
 DATA: lv_file                 TYPE xstring,
       lv_bytecount            TYPE i,
       lv_bytecount_c          TYPE sood-objlen,
       lt_file_tab             TYPE solix_tab.
 
-CONSTANTS: lv_default_file_name TYPE string VALUE 'TechEd01.xlsx'.
-
 *******************************
 *    abap2xlsx create XLSX    *
 *******************************
@@ -205,7 +202,6 @@ CONSTANTS: lv_default_file_name TYPE string VALUE 'TechEd01.xlsx'.
 
   lo_sender       = cl_sapuser_bcs=>create( sy-uname ).
   lo_recipient    = cl_sapuser_bcs=>create( sy-uname ).
-*  lo_recipient_i  = cl_cam_address_bcs=>create_internet_address( 'ivan.femia@techedge.it' ).
 
   lo_send_request = cl_bcs=>create_persistent( ).
   lo_send_request->set_document( lo_document ).