From 89c6ba0677699d44e90fab172b2fd4cef67541de Mon Sep 17 00:00:00 2001
From: larshp <larshp@hotmail.com>
Date: Sun, 23 Jul 2023 10:55:04 +0000
Subject: [PATCH] split unit test delete_merge

into one unit test per test
---
 src/zcl_excel_worksheet.clas.testclasses.abap | 69 ++++++++++++++++---
 1 file changed, 58 insertions(+), 11 deletions(-)

diff --git a/src/zcl_excel_worksheet.clas.testclasses.abap b/src/zcl_excel_worksheet.clas.testclasses.abap
index 65d9be1..1715183 100644
--- a/src/zcl_excel_worksheet.clas.testclasses.abap
+++ b/src/zcl_excel_worksheet.clas.testclasses.abap
@@ -30,7 +30,12 @@ CLASS lcl_excel_worksheet_test DEFINITION FOR TESTING
     METHODS: setup.
     METHODS: teardown.
     METHODS: set_merge FOR TESTING RAISING cx_static_check.
-    METHODS: delete_merge FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge1 FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge2 FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge3 FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge4 FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge5 FOR TESTING RAISING cx_static_check.
+    METHODS delete_merge6 FOR TESTING RAISING cx_static_check.
     METHODS: get_dimension_range FOR TESTING RAISING cx_static_check.
 ENDCLASS.       "lcl_Excel_Worksheet_Test
 
@@ -465,12 +470,11 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
 
   ENDMETHOD.
 
-  METHOD delete_merge.
+  METHOD delete_merge1.
 * ====================
     DATA lt_merge TYPE string_table.
     DATA lv_merge TYPE string.
     DATA lv_size TYPE i.
-    DATA lv_index TYPE i.
 
 *  Test 1. Simple test delete all merges
 
@@ -491,6 +495,13 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
       msg   = 'Expect merge table with 1 line fully cleared'
       level = if_aunit_constants=>critical
     ).
+  ENDMETHOD.
+
+  METHOD delete_merge2.
+* ====================
+    DATA lt_merge TYPE string_table.
+    DATA lv_merge TYPE string.
+    DATA lv_size TYPE i.
 
 *  Test 2. Simple test delete all merges
 
@@ -513,7 +524,14 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
       msg   = 'Expect merge table with few lines fully cleared'
       level = if_aunit_constants=>critical
     ).
+  ENDMETHOD.
 
+  METHOD delete_merge3.
+* ====================
+    DATA lt_merge TYPE string_table.
+    DATA lv_merge TYPE string.
+    DATA lv_size TYPE i.
+    DATA lv_index TYPE i.
 *  Test 3. Delete concrete merge with success
 
     DO 4 TIMES.
@@ -529,10 +547,14 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
       ).
 
       CASE lv_index.
-        WHEN 1. f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 2 ).
-        WHEN 2. f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 3 ).
-        WHEN 3. f_cut->delete_merge( ip_cell_column = 3 ip_cell_row = 2 ).
-        WHEN 4. f_cut->delete_merge( ip_cell_column = 3 ip_cell_row = 3 ).
+        WHEN 1.
+          f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 2 ).
+        WHEN 2.
+          f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 3 ).
+        WHEN 3.
+          f_cut->delete_merge( ip_cell_column = 3 ip_cell_row = 2 ).
+        WHEN 4.
+          f_cut->delete_merge( ip_cell_column = 3 ip_cell_row = 3 ).
       ENDCASE.
 
       lt_merge = f_cut->get_merge( ).
@@ -545,7 +567,14 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
         level = if_aunit_constants=>critical
       ).
     ENDDO.
+  ENDMETHOD.
 
+  METHOD delete_merge4.
+* ====================
+    DATA lt_merge TYPE string_table.
+    DATA lv_merge TYPE string.
+    DATA lv_size TYPE i.
+    DATA lv_index TYPE i.
 *  Test 4. Delete concrete merge with fail
 
     DO 4 TIMES.
@@ -561,10 +590,14 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
       ).
 
       CASE lv_index.
-        WHEN 1. f_cut->delete_merge( ip_cell_column = 1 ip_cell_row = 2 ).
-        WHEN 2. f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 1 ).
-        WHEN 3. f_cut->delete_merge( ip_cell_column = 4 ip_cell_row = 2 ).
-        WHEN 4. f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 4 ).
+        WHEN 1.
+          f_cut->delete_merge( ip_cell_column = 1 ip_cell_row = 2 ).
+        WHEN 2.
+          f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 1 ).
+        WHEN 3.
+          f_cut->delete_merge( ip_cell_column = 4 ip_cell_row = 2 ).
+        WHEN 4.
+          f_cut->delete_merge( ip_cell_column = 2 ip_cell_row = 4 ).
       ENDCASE.
 
       lt_merge = f_cut->get_merge( ).
@@ -577,6 +610,13 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
         level = if_aunit_constants=>critical
       ).
     ENDDO.
+  ENDMETHOD.
+
+  METHOD delete_merge5.
+* ====================
+    DATA lt_merge TYPE string_table.
+    DATA lv_merge TYPE string.
+    DATA lv_size TYPE i.
 
 *  Test 5. Delete concrete merge #1
 
@@ -614,6 +654,13 @@ CLASS lcl_excel_worksheet_test IMPLEMENTATION.
       msg   = 'Expect delete B2:C3 merge'
       level = if_aunit_constants=>critical
     ).
+  ENDMETHOD.
+
+  METHOD delete_merge6.
+* ====================
+    DATA lt_merge TYPE string_table.
+    DATA lv_merge TYPE string.
+    DATA lv_size TYPE i.
 
 *  Test 6. Delete concrete merge #2