SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 11:06:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

calculate_column_widths: low performance on styles

Browse Source 
Fix #1018
This commit is contained in:
sandraros 2022-05-02 20:18:03 +00:00
parent d2a1301329
commit 9725e62bde
2 changed files with 69 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/zcl_excel.clas.abap
View File

@ -94,6 +94,14 @@ CLASS zcl_excel DEFINITION
!ip_cstylex_complete TYPE zexcel_s_cstylex_complete
RETURNING
VALUE(ep_guid) TYPE zexcel_cell_style .
METHODS get_style_from_guid2
IMPORTING
!ip_guid TYPE zexcel_cell_style
EXPORTING
!eo_style TYPE REF TO zcl_excel_style
!es_stylemapping TYPE zexcel_s_stylemapping
RAISING
zcx_excel.
METHODS get_styles_iterator
RETURNING
VALUE(eo_iterator) TYPE REF TO zcl_excel_collection_iterator .
@ -497,6 +505,20 @@ CLASS zcl_excel IMPLEMENTATION.
ENDMETHOD.
METHOD get_style_from_guid2.
READ TABLE me->t_stylemapping2 INTO es_stylemapping WITH TABLE KEY guid = ip_guid.
IF sy-subrc <> 0.
zcx_excel=>raise_text( 'GUID not found' ).
ENDIF.
IF es_stylemapping-dynamic_style_guid IS NOT INITIAL.
eo_style = get_style_from_guid( ip_guid ).
ENDIF.
ENDMETHOD.
METHOD get_style_index_in_styles.
DATA: index TYPE i.
DATA: lo_iterator TYPE REF TO zcl_excel_collection_iterator,

57
src/zcl_excel_worksheet.clas.abap
View File

@ -1241,6 +1241,20 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
ld_date_char TYPE c LENGTH 50,
ld_font_height TYPE tdfontsize VALUE zcl_excel_font=>lc_default_font_height,
ld_font_name TYPE zexcel_style_font_name VALUE zcl_excel_font=>lc_default_font_name.
DATA: lo_style TYPE REF TO zcl_excel_style,
BEGIN OF ls_stylex,
font_size TYPE flag,
font_name TYPE flag,
font_bold TYPE flag,
font_italic TYPE flag,
END OF ls_stylex,
BEGIN OF ls_style,
format_code TYPE zexcel_number_format,
font_size TYPE zexcel_style_font_size,
font_name TYPE zexcel_style_font_name,
font_bold TYPE flag,
font_italic TYPE flag,
END OF ls_style.
" Determine cell content and cell style
me->get_cell( EXPORTING ip_column = ip_column
@ -1280,11 +1294,34 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
IF ld_style_guid IS NOT INITIAL.
TRY.
" Read style attributes
ls_stylemapping = me->excel->get_style_to_guid( ld_style_guid ).
excel->get_style_from_guid2( EXPORTING ip_guid = ld_style_guid IMPORTING es_stylemapping = ls_stylemapping eo_style = lo_style ).
CLEAR: ls_style, ls_stylex.
IF lo_style IS NOT BOUND.
ls_style-format_code = ls_stylemapping-complete_style-number_format-format_code.
ls_stylex-font_size = ls_stylemapping-complete_stylex-font-size.
ls_stylex-font_name = ls_stylemapping-complete_stylex-font-name.
ls_stylex-font_bold = ls_stylemapping-complete_stylex-font-bold.
ls_stylex-font_italic = ls_stylemapping-complete_stylex-font-italic.
ls_style-font_size = ls_stylemapping-complete_style-font-size.
ls_style-font_name = ls_stylemapping-complete_style-font-name.
ls_style-font_bold = ls_stylemapping-complete_style-font-bold.
ls_style-font_italic = ls_stylemapping-complete_style-font-italic.
ELSE.
ls_style-format_code = lo_style->number_format->format_code.
ls_stylex-font_size = abap_true.
ls_stylex-font_name = abap_true.
ls_stylex-font_bold = abap_true.
ls_stylex-font_italic = abap_true.
ls_style-font_size = lo_style->font->size.
ls_style-font_name = lo_style->font->name.
ls_style-font_bold = lo_style->font->bold.
ls_style-font_italic = lo_style->font->italic.
ENDIF.
" If the current cell contains the default date format,
" convert the cell value to a date and calculate its length
IF ls_stylemapping-complete_style-number_format-format_code =
IF ls_style-format_code =
zcl_excel_style_number_format=>c_format_date_std.
" Convert excel date to ABAP date
@ -1301,22 +1338,22 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
" Read the font size and convert it to the font height
" used by SAPscript (multiplication by 10)
IF ls_stylemapping-complete_stylex-font-size = abap_true.
ld_font_height = ls_stylemapping-complete_style-font-size * 10.
IF ls_stylex-font_size = abap_true.
ld_font_height = ls_style-font_size * 10.
ENDIF.
" If set, remember the font name
IF ls_stylemapping-complete_stylex-font-name = abap_true.
ld_font_name = ls_stylemapping-complete_style-font-name.
IF ls_stylex-font_name = abap_true.
ld_font_name = ls_style-font_name.
ENDIF.
" If set, remember whether font is bold and italic.
IF ls_stylemapping-complete_stylex-font-bold = abap_true.
ld_flag_bold = ls_stylemapping-complete_style-font-bold.
IF ls_stylex-font_bold = abap_true.
ld_flag_bold = ls_style-font_bold.
ENDIF.
IF ls_stylemapping-complete_stylex-font-italic = abap_true.
ld_flag_italic = ls_stylemapping-complete_style-font-italic.
IF ls_stylex-font_italic = abap_true.
ld_flag_italic = ls_style-font_italic.
ENDIF.
CATCH zcx_excel. "#EC NO_HANDLER