SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 11:06:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

zcl_excel_common: refactor unit tests (#833)

Browse Source 
* split date_to_excel_string into one test per metho

* split excel_string_to_time

* refactor time_to_excel_string
This commit is contained in:
Lars Hvam 2021-10-11 20:14:41 +02:00 committed by GitHub
parent 66a45b840a
commit 98a251a859
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 172 additions and 219 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

243
src/zcl_excel_common.clas.testclasses.abap
View File

@ -21,11 +21,23 @@ CLASS lcl_excel_common_test DEFINITION FOR TESTING
METHODS: setup. METHODS: setup.
METHODS: convert_column2alpha FOR TESTING. METHODS: convert_column2alpha FOR TESTING.
METHODS: convert_column2int FOR TESTING. METHODS: convert_column2int FOR TESTING.
METHODS: date_to_excel_string FOR TESTING. METHODS date_to_excel_string1 FOR TESTING RAISING cx_static_check.
METHODS date_to_excel_string2 FOR TESTING RAISING cx_static_check.
METHODS date_to_excel_string3 FOR TESTING RAISING cx_static_check.
METHODS date_to_excel_string4 FOR TESTING RAISING cx_static_check.
METHODS date_to_excel_string5 FOR TESTING RAISING cx_static_check.
METHODS date_to_excel_string6 FOR TESTING RAISING cx_static_check.
METHODS: encrypt_password FOR TESTING. METHODS: encrypt_password FOR TESTING.
METHODS: excel_string_to_date FOR TESTING. METHODS: excel_string_to_date FOR TESTING.
METHODS: excel_string_to_time FOR TESTING. METHODS excel_string_to_time1 FOR TESTING RAISING cx_static_check.
METHODS: time_to_excel_string FOR TESTING. METHODS excel_string_to_time2 FOR TESTING RAISING cx_static_check.
METHODS excel_string_to_time3 FOR TESTING RAISING cx_static_check.
METHODS excel_string_to_time4 FOR TESTING RAISING cx_static_check.
METHODS excel_string_to_time5 FOR TESTING RAISING cx_static_check.
METHODS time_to_excel_string1 FOR TESTING RAISING cx_static_check.
METHODS time_to_excel_string2 FOR TESTING RAISING cx_static_check.
METHODS time_to_excel_string3 FOR TESTING RAISING cx_static_check.
METHODS time_to_excel_string4 FOR TESTING RAISING cx_static_check.
METHODS: split_file FOR TESTING. METHODS: split_file FOR TESTING.
METHODS: convert_range2column_a_row FOR TESTING RAISING cx_static_check. METHODS: convert_range2column_a_row FOR TESTING RAISING cx_static_check.
METHODS: describe_structure FOR TESTING. METHODS: describe_structure FOR TESTING.
@ -217,78 +229,65 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
ENDMETHOD. "convert_Column2int ENDMETHOD. "convert_Column2int
METHOD date_to_excel_string. METHOD date_to_excel_string1.
* ============================
DATA ep_value TYPE zexcel_cell_value. DATA ep_value TYPE zexcel_cell_value.
* Test 1. Basic conversion * Test 1. Basic conversion
TRY.
ep_value = zcl_excel_common=>date_to_excel_string( '19000101' ). ep_value = zcl_excel_common=>date_to_excel_string( '19000101' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = 1 exp = 1
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD date_to_excel_string2.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
* Check around the "Excel Leap Year" 1900 * Check around the "Excel Leap Year" 1900
TRY.
ep_value = zcl_excel_common=>date_to_excel_string( '19000228' ). ep_value = zcl_excel_common=>date_to_excel_string( '19000228' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = 59 exp = 59
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD date_to_excel_string3.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
TRY.
ep_value = zcl_excel_common=>date_to_excel_string( '19000301' ). ep_value = zcl_excel_common=>date_to_excel_string( '19000301' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = 61 exp = 61
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD.
METHOD date_to_excel_string4.
DATA ep_value TYPE zexcel_cell_value.
* Test 2. Basic conversion * Test 2. Basic conversion
TRY.
ep_value = zcl_excel_common=>date_to_excel_string( '99991212' ). ep_value = zcl_excel_common=>date_to_excel_string( '99991212' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = 2958446 exp = 2958446
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD date_to_excel_string5.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
* Test 3. Initial date * Test 3. Initial date
TRY.
DATA: lv_date TYPE d. DATA: lv_date TYPE d.
ep_value = zcl_excel_common=>date_to_excel_string( lv_date ). ep_value = zcl_excel_common=>date_to_excel_string( lv_date ).
@ -296,17 +295,14 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
act = ep_value act = ep_value
exp = '' exp = ''
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD date_to_excel_string6.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
* Test 2. Basic conversion * Test 2. Basic conversion
TRY.
DATA exp_value TYPE zexcel_cell_value VALUE 0. DATA exp_value TYPE zexcel_cell_value VALUE 0.
ep_value = zcl_excel_common=>date_to_excel_string( '18991231' ). ep_value = zcl_excel_common=>date_to_excel_string( '18991231' ).
@ -314,18 +310,9 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
act = ep_value act = ep_value
exp = exp_value exp = exp_value
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>assert_equals(
act = lx_excel->error
exp = 'Index out of bounds'
msg = 'Dates prior of 1900 are not available in excel'
level = if_aunit_constants=>critical
).
ENDTRY.
ENDMETHOD. "date_To_Excel_String ENDMETHOD.
METHOD encrypt_password. METHOD encrypt_password.
@ -505,78 +492,64 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
ENDMETHOD. "excel_String_To_Date ENDMETHOD. "excel_String_To_Date
METHOD excel_string_to_time. METHOD excel_string_to_time1.
* ============================
DATA ep_value TYPE t. DATA ep_value TYPE t.
* Test 1. Simple test * Test 1. Simple test
TRY.
ep_value = zcl_excel_common=>excel_string_to_time( '0' ). ep_value = zcl_excel_common=>excel_string_to_time( '0' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '000000' exp = '000000'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>tolerable level = if_aunit_constants=>tolerable ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD.
METHOD excel_string_to_time2.
DATA ep_value TYPE t.
* Test 2. Simple test * Test 2. Simple test
TRY.
ep_value = zcl_excel_common=>excel_string_to_time( '1' ). ep_value = zcl_excel_common=>excel_string_to_time( '1' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '000000' exp = '000000'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD.
METHOD excel_string_to_time3.
DATA ep_value TYPE t.
* Test 3. Simple test * Test 3. Simple test
TRY.
ep_value = zcl_excel_common=>excel_string_to_time( '0.99999' ). ep_value = zcl_excel_common=>excel_string_to_time( '0.99999' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '235959' exp = '235959'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD.
METHOD excel_string_to_time4.
DATA ep_value TYPE t.
* Test 4. Also string greater than 1 should be managed * Test 4. Also string greater than 1 should be managed
TRY.
ep_value = zcl_excel_common=>excel_string_to_time( '4.1' ). ep_value = zcl_excel_common=>excel_string_to_time( '4.1' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '022400' exp = '022400'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD.
METHOD excel_string_to_time5.
DATA ep_value TYPE t.
* Test 4. string is not a number * Test 4. string is not a number
TRY. TRY.
ep_value = zcl_excel_common=>excel_string_to_time( 'NaN' ). ep_value = zcl_excel_common=>excel_string_to_time( 'NaN' ).
@ -585,92 +558,72 @@ CLASS lcl_excel_common_test IMPLEMENTATION.
act = ep_value act = ep_value
exp = '000000' exp = '000000'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = lx_excel->error act = lx_excel->error
exp = 'Unable to interpret time' exp = 'Unable to interpret time'
msg = 'Time should be a valid string' msg = 'Time should be a valid string'
level = if_aunit_constants=>fatal level = if_aunit_constants=>fatal ).
).
ENDTRY. ENDTRY.
ENDMETHOD. "excel_String_To_Time ENDMETHOD.
METHOD time_to_excel_string1.
METHOD time_to_excel_string.
* ============================
DATA ep_value TYPE zexcel_cell_value. DATA ep_value TYPE zexcel_cell_value.
* Test 1. Basic conversion * Test 1. Basic conversion
TRY.
ep_value = zcl_excel_common=>time_to_excel_string( '000001' ). ep_value = zcl_excel_common=>time_to_excel_string( '000001' ).
" A test directly in Excel returns the value 0.0000115740740740741000 " A test directly in Excel returns the value 0.0000115740740740741000
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '0.0000115740740741' exp = '0.0000115740740741'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD time_to_excel_string2.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
* Test 2. Basic conversion * Test 2. Basic conversion
TRY.
ep_value = zcl_excel_common=>time_to_excel_string( '235959' ). ep_value = zcl_excel_common=>time_to_excel_string( '235959' ).
" A test directly in Excel returns the value 0.9999884259259260000000 " A test directly in Excel returns the value 0.9999884259259260000000
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '0.9999884259259260' exp = '0.9999884259259260'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD time_to_excel_string3.
level = if_aunit_constants=>critical " Error Severity DATA ep_value TYPE zexcel_cell_value.
).
ENDTRY.
* Test 3. Initial date * Test 3. Initial date
TRY.
ep_value = zcl_excel_common=>time_to_excel_string( '000000' ). ep_value = zcl_excel_common=>time_to_excel_string( '000000' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '0' exp = '0'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel. ENDMETHOD.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception' METHOD time_to_excel_string4.
level = if_aunit_constants=>critical " Error Severity
). DATA ep_value TYPE zexcel_cell_value.
ENDTRY.
* Test 2. Basic conversion * Test 2. Basic conversion
TRY.
ep_value = zcl_excel_common=>time_to_excel_string( '022400' ). ep_value = zcl_excel_common=>time_to_excel_string( '022400' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = ep_value act = ep_value
exp = '0.1000000000000000' exp = '0.1000000000000000'
msg = 'Wrong date conversion' msg = 'Wrong date conversion'
level = if_aunit_constants=>critical level = if_aunit_constants=>critical ).
).
CATCH zcx_excel INTO lx_excel.
cl_abap_unit_assert=>fail(
msg = 'unexpected exception'
level = if_aunit_constants=>critical " Error Severity
).
ENDTRY.
ENDMETHOD. "time_To_Excel_String ENDMETHOD.
METHOD split_file. METHOD split_file.
* ============================ * ============================