SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 16:36:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

change EXIT to RETURN, where applicable (#814)

Browse Source
This commit is contained in:
Lars Hvam 2021-09-26 18:43:53 +02:00 committed by GitHub
parent d66e0d5cc7
commit ac5c95ace7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
abaplint.json
View File

@ -163,7 +163,10 @@
"parser_error": true, "parser_error": true,
"space_before_colon": false, "space_before_colon": false,
"colon_missing_space": false, "colon_missing_space": false,
"exit_or_check": false, "exit_or_check": {
"allowCheck": true,
"allowExit": false
},
"line_only_punc": false, "line_only_punc": false,
"obsolete_statement": false, "obsolete_statement": false,
"start_at_tab": false, "start_at_tab": false,

2
src/demos/zdemo_excel_outputopt_incl.prog.abap
View File

@ -156,7 +156,7 @@ CLASS lcl_output IMPLEMENTATION.
IF sy-subrc <> 0. IF sy-subrc <> 0.
MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4. WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
EXIT. RETURN.
ENDIF. ENDIF.
READ TABLE lt_dynpfields INTO ls_dynpfields INDEX 1. READ TABLE lt_dynpfields INTO ls_dynpfields INDEX 1.

2
src/not_cloud/zcl_excel_ole.clas.abap
View File

@ -948,7 +948,7 @@ CLASS zcl_excel_ole IMPLEMENTATION.
no_flush = no_flush no_flush = no_flush
IMPORTING IMPORTING
error = lo_error_w. error = lo_error_w.
EXIT. RETURN.
ENDIF. ENDIF.
CREATE OBJECT l_error CREATE OBJECT l_error

2
src/zcl_excel_column.clas.abap
View File

@ -192,7 +192,7 @@ CLASS zcl_excel_column IMPLEMENTATION.
me->style_guid = stylemapping-guid. me->style_guid = stylemapping-guid.
CATCH zcx_excel . CATCH zcx_excel .
EXIT. " leave as is in case of error RETURN. " leave as is in case of error
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.

8
src/zcl_excel_common.clas.abap
View File

@ -400,7 +400,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
lv_errormessage = 'Index out of bounds'(004). lv_errormessage = 'Index out of bounds'(004).
zcx_excel=>raise_text( lv_errormessage ). zcx_excel=>raise_text( lv_errormessage ).
ENDIF. ENDIF.
EXIT. RETURN.
ENDIF. ENDIF.
CATCH cx_sy_conversion_no_number. "#EC NO_HANDLER CATCH cx_sy_conversion_no_number. "#EC NO_HANDLER
" Try the character-approach if approach via number has failed " Try the character-approach if approach via number has failed
@ -539,7 +539,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
e_sheet. e_sheet.
IF i_range IS INITIAL. " a) input empty --> nothing to do IF i_range IS INITIAL. " a) input empty --> nothing to do
EXIT. RETURN.
ELSEIF i_range(1) = `'`. " b) sheetname existing - starts with ' ELSEIF i_range(1) = `'`. " b) sheetname existing - starts with '
FIND REGEX '\![^\!]*$' IN i_range MATCH OFFSET lv_position. " Find last ! FIND REGEX '\![^\!]*$' IN i_range MATCH OFFSET lv_position. " Find last !
@ -1091,7 +1091,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
IF iv_shift_cols = 0 IF iv_shift_cols = 0
AND iv_shift_rows = 0. AND iv_shift_rows = 0.
ev_resulting_formula = iv_reference_formula. ev_resulting_formula = iv_reference_formula.
EXIT. " done RETURN. " done
ENDIF. ENDIF.
@ -1442,7 +1442,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
DESCRIBE TABLE lt_hlp LINES lf_anz. DESCRIBE TABLE lt_hlp LINES lf_anz.
IF lf_anz <= 1. IF lf_anz <= 1.
ep_file = ip_file. ep_file = ip_file.
EXIT. RETURN.
ENDIF. ENDIF.
READ TABLE lt_hlp INTO ls_hlp INDEX lf_anz. READ TABLE lt_hlp INTO ls_hlp INDEX lf_anz.

4
src/zcl_excel_table.clas.abap
View File

@ -141,7 +141,7 @@ CLASS zcl_excel_table IMPLEMENTATION.
IF settings-bottom_right_row IS NOT INITIAL. IF settings-bottom_right_row IS NOT INITIAL.
* ev_row = zcl_excel_common=>convert_column2int( settings-bottom_right_row ). " del issue #246 * ev_row = zcl_excel_common=>convert_column2int( settings-bottom_right_row ). " del issue #246
ev_row = settings-bottom_right_row . " ins issue #246 ev_row = settings-bottom_right_row . " ins issue #246
EXIT. RETURN.
ENDIF. ENDIF.
ASSIGN table_data->* TO <fs_table>. ASSIGN table_data->* TO <fs_table>.
@ -221,7 +221,7 @@ CLASS zcl_excel_table IMPLEMENTATION.
IF settings-bottom_right_column IS NOT INITIAL. IF settings-bottom_right_column IS NOT INITIAL.
ev_column = zcl_excel_common=>convert_column2int( settings-bottom_right_column ). ev_column = zcl_excel_common=>convert_column2int( settings-bottom_right_column ).
EXIT. RETURN.
ENDIF. ENDIF.
ev_column = zcl_excel_common=>convert_column2int( settings-top_left_column ). ev_column = zcl_excel_common=>convert_column2int( settings-top_left_column ).

4
src/zcl_excel_worksheet.clas.abap
View File

@ -3171,7 +3171,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
zcx_excel=>raise_text( 'Please supply a positive number as column-width' ). zcx_excel=>raise_text( 'Please supply a positive number as column-width' ).
ENDIF. ENDIF.
lo_column->set_width( width ). lo_column->set_width( width ).
EXIT. RETURN.
CATCH cx_sy_conversion_no_number. CATCH cx_sy_conversion_no_number.
* Strange stuff passed --> raise error * Strange stuff passed --> raise error
zcx_excel=>raise_text( 'Unable to interpret supplied input as number' ). zcx_excel=>raise_text( 'Unable to interpret supplied input as number' ).
@ -3316,7 +3316,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
zcx_excel=>raise_text( 'Please supply a positive number as row-height' ). zcx_excel=>raise_text( 'Please supply a positive number as row-height' ).
ENDIF. ENDIF.
lo_row->set_row_height( height ). lo_row->set_row_height( height ).
EXIT. RETURN.
CATCH cx_sy_conversion_no_number. CATCH cx_sy_conversion_no_number.
* Strange stuff passed --> raise error * Strange stuff passed --> raise error
zcx_excel=>raise_text( 'Unable to interpret supplied input as number' ). zcx_excel=>raise_text( 'Unable to interpret supplied input as number' ).