From 496b51e53168e01da07e80e6d317cba9ddc415c0 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Mon, 3 Jan 2022 21:33:18 +0100 Subject: [PATCH 1/3] change SYTABIX to I (#947) * change SYTABIX to I * another --- src/demos/zdemo_excel38.prog.abap | 2 +- src/zcl_excel.clas.abap | 2 +- src/zcl_excel_reader_2007.clas.abap | 2 +- src/zcl_excel_writer_2007.clas.abap | 4 ++-- src/zcl_excel_writer_csv.clas.abap | 4 ++-- src/zcl_excel_writer_huge_file.clas.abap | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/demos/zdemo_excel38.prog.abap b/src/demos/zdemo_excel38.prog.abap index c7c62dd..2a59f9d 100644 --- a/src/demos/zdemo_excel38.prog.abap +++ b/src/demos/zdemo_excel38.prog.abap @@ -14,7 +14,7 @@ TYPES: BEGIN OF gty_icon, gtyt_icon TYPE STANDARD TABLE OF gty_icon WITH NON-UNIQUE DEFAULT KEY. DATA: lt_icon TYPE gtyt_icon, - lv_row TYPE sytabix, + lv_row TYPE i, ls_wwwdatatab TYPE wwwdatatab, lt_mimedata TYPE STANDARD TABLE OF w3mime WITH NON-UNIQUE DEFAULT KEY, lv_xstring TYPE xstring. diff --git a/src/zcl_excel.clas.abap b/src/zcl_excel.clas.abap index 4b140fa..2af87ae 100644 --- a/src/zcl_excel.clas.abap +++ b/src/zcl_excel.clas.abap @@ -98,7 +98,7 @@ CLASS zcl_excel DEFINITION IMPORTING !ip_guid TYPE zexcel_cell_style RETURNING - VALUE(ep_index) TYPE sytabix + VALUE(ep_index) TYPE i RAISING zcx_excel . METHODS get_style_to_guid diff --git a/src/zcl_excel_reader_2007.clas.abap b/src/zcl_excel_reader_2007.clas.abap index e9f3ba5..0906a43 100644 --- a/src/zcl_excel_reader_2007.clas.abap +++ b/src/zcl_excel_reader_2007.clas.abap @@ -1782,7 +1782,7 @@ CLASS zcl_excel_reader_2007 IMPLEMENTATION. lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_range TYPE REF TO zcl_excel_range, lv_worksheet_title TYPE zexcel_sheet_title, - lv_tabix TYPE sytabix, " #235 - repeat rows/cols. Needed to link defined name to correct worksheet + lv_tabix TYPE i, " #235 - repeat rows/cols. Needed to link defined name to correct worksheet ls_range TYPE t_range, lv_range_value TYPE zexcel_range_value, diff --git a/src/zcl_excel_writer_2007.clas.abap b/src/zcl_excel_writer_2007.clas.abap index d1feb67..24af91e 100644 --- a/src/zcl_excel_writer_2007.clas.abap +++ b/src/zcl_excel_writer_2007.clas.abap @@ -3547,7 +3547,7 @@ CLASS zcl_excel_writer_2007 IMPLEMENTATION. ls_shared_string TYPE zexcel_s_shared_string, lv_count_str TYPE string, lv_uniquecount_str TYPE string, - lv_sytabix TYPE sytabix, + lv_sytabix TYPE i, lv_count TYPE i, lv_uniquecount TYPE i. @@ -6415,7 +6415,7 @@ CLASS zcl_excel_writer_2007 IMPLEMENTATION. TYPES: BEGIN OF ts_built_in_format, num_format TYPE zexcel_number_format, - id TYPE sytabix, + id TYPE i, END OF ts_built_in_format. DATA: lt_built_in_num_formats TYPE HASHED TABLE OF ts_built_in_format WITH UNIQUE KEY num_format, diff --git a/src/zcl_excel_writer_csv.clas.abap b/src/zcl_excel_writer_csv.clas.abap index 2be17af..4c28c72 100644 --- a/src/zcl_excel_writer_csv.clas.abap +++ b/src/zcl_excel_writer_csv.clas.abap @@ -81,8 +81,8 @@ CLASS zcl_excel_writer_csv IMPLEMENTATION. lo_worksheet TYPE REF TO zcl_excel_worksheet. DATA: lt_cell_data TYPE zexcel_t_cell_data_unsorted, - lv_row TYPE sytabix, - lv_col TYPE sytabix, + lv_row TYPE i, + lv_col TYPE i, lv_string TYPE string, lc_value TYPE string, lv_attrname TYPE seocmpname. diff --git a/src/zcl_excel_writer_huge_file.clas.abap b/src/zcl_excel_writer_huge_file.clas.abap index 25894e6..e5941f7 100644 --- a/src/zcl_excel_writer_huge_file.clas.abap +++ b/src/zcl_excel_writer_huge_file.clas.abap @@ -62,7 +62,7 @@ CLASS zcl_excel_writer_huge_file IMPLEMENTATION. ls_root TYPE ts_root, lt_cell_data TYPE zexcel_t_cell_data_unsorted, ls_shared_string TYPE zexcel_s_shared_string, - lv_sytabix TYPE sytabix. + lv_sytabix TYPE i. FIELD-SYMBOLS: TYPE zexcel_s_cell_data. From 8d072439da457f92e060c80e50e59617cbcad052 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Mon, 3 Jan 2022 21:42:10 +0100 Subject: [PATCH 2/3] remove TYPE-POOLS statements (#948) * remove TYPE-POOLS statements * fix whitespace Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com> --- src/demos/zdemo_calendar.prog.abap | 3 +-- src/demos/zdemo_excel11.prog.abap | 2 -- src/demos/zdemo_excel15.prog.abap | 2 -- src/demos/zdemo_excel19.prog.abap | 2 -- src/demos/zdemo_excel23.prog.abap | 2 -- src/demos/zdemo_excel24.prog.abap | 2 -- src/demos/zdemo_excel3.prog.abap | 2 -- src/demos/zdemo_excel33.prog.abap | 2 -- src/demos/zdemo_excel37.prog.abap | 2 -- src/demos/zdemo_excel42.prog.abap | 1 - src/not_cloud/zcl_excel_ole.clas.locals_def.abap | 3 +-- src/zcl_excel_autofilter.clas.abap | 1 - src/zcl_excel_autofilters.clas.abap | 1 - src/zcl_excel_column.clas.abap | 1 - src/zcl_excel_comment.clas.abap | 1 - src/zcl_excel_common.clas.abap | 1 - src/zcl_excel_converter.clas.abap | 1 - src/zcl_excel_converter_alv.clas.abap | 2 -- src/zcl_excel_data_validation.clas.abap | 1 - src/zcl_excel_data_validations.clas.abap | 1 - src/zcl_excel_drawing.clas.abap | 1 - src/zcl_excel_hyperlink.clas.abap | 1 - src/zcl_excel_legacy_palette.clas.abap | 1 - src/zcl_excel_reader_2007.clas.abap | 1 - src/zcl_excel_row.clas.abap | 1 - src/zcl_excel_security.clas.abap | 1 - src/zcl_excel_sheet_setup.clas.abap | 1 - src/zcl_excel_style_alignment.clas.abap | 1 - src/zcl_excel_style_fill.clas.abap | 1 - src/zcl_excel_style_font.clas.abap | 1 - src/zcl_excel_table.clas.abap | 1 - src/zcl_excel_worksheet.clas.abap | 3 --- 32 files changed, 2 insertions(+), 45 deletions(-) diff --git a/src/demos/zdemo_calendar.prog.abap b/src/demos/zdemo_calendar.prog.abap index 90450af..53df60e 100644 --- a/src/demos/zdemo_calendar.prog.abap +++ b/src/demos/zdemo_calendar.prog.abap @@ -23,7 +23,6 @@ REPORT zdemo_calendar. -TYPE-POOLS: abap. CONSTANTS: gc_save_file_name TYPE string VALUE 'Calendar.xlsx'. INCLUDE zdemo_excel_outputopt_incl. INCLUDE zdemo_calendar_classes. @@ -34,7 +33,7 @@ PARAMETERS: p_from TYPE dfrom, p_to TYPE dto. SELECTION-SCREEN BEGIN OF BLOCK orientation WITH FRAME TITLE orient. - PARAMETERS: p_portr TYPE flag RADIOBUTTON GROUP orie, +PARAMETERS: p_portr TYPE flag RADIOBUTTON GROUP orie, p_lands TYPE flag RADIOBUTTON GROUP orie DEFAULT 'X'. SELECTION-SCREEN END OF BLOCK orientation. diff --git a/src/demos/zdemo_excel11.prog.abap b/src/demos/zdemo_excel11.prog.abap index 11459fb..52215d3 100644 --- a/src/demos/zdemo_excel11.prog.abap +++ b/src/demos/zdemo_excel11.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel11. -TYPE-POOLS: abap. - DATA: central_search TYPE bapibus1006_central_search, addressdata_search TYPE bapibus1006_addr_search, others_search TYPE bapibus1006_other_data. diff --git a/src/demos/zdemo_excel15.prog.abap b/src/demos/zdemo_excel15.prog.abap index 0c16995..f5c0709 100644 --- a/src/demos/zdemo_excel15.prog.abap +++ b/src/demos/zdemo_excel15.prog.abap @@ -10,8 +10,6 @@ REPORT zdemo_excel15. -TYPE-POOLS: abap. - TYPES: BEGIN OF t_demo_excel15, input TYPE string, diff --git a/src/demos/zdemo_excel19.prog.abap b/src/demos/zdemo_excel19.prog.abap index 34bd240..523c6ed 100644 --- a/src/demos/zdemo_excel19.prog.abap +++ b/src/demos/zdemo_excel19.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel19. -TYPE-POOLS: abap. - DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet. diff --git a/src/demos/zdemo_excel23.prog.abap b/src/demos/zdemo_excel23.prog.abap index 5a09ff4..9716d62 100644 --- a/src/demos/zdemo_excel23.prog.abap +++ b/src/demos/zdemo_excel23.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel23. -TYPE-POOLS: abap. - DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_hyperlink TYPE REF TO zcl_excel_hyperlink. diff --git a/src/demos/zdemo_excel24.prog.abap b/src/demos/zdemo_excel24.prog.abap index 44f81db..c82e2a0 100644 --- a/src/demos/zdemo_excel24.prog.abap +++ b/src/demos/zdemo_excel24.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel24. -TYPE-POOLS: abap. - DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_column TYPE REF TO zcl_excel_column, diff --git a/src/demos/zdemo_excel3.prog.abap b/src/demos/zdemo_excel3.prog.abap index 29ba65c..0cf5560 100644 --- a/src/demos/zdemo_excel3.prog.abap +++ b/src/demos/zdemo_excel3.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel3. -TYPE-POOLS: abap. - DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_column TYPE REF TO zcl_excel_column. diff --git a/src/demos/zdemo_excel33.prog.abap b/src/demos/zdemo_excel33.prog.abap index fe85bdc..29a8970 100644 --- a/src/demos/zdemo_excel33.prog.abap +++ b/src/demos/zdemo_excel33.prog.abap @@ -8,8 +8,6 @@ REPORT zdemo_excel33. -TYPE-POOLS: abap. - DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_converter TYPE REF TO zcl_excel_converter, diff --git a/src/demos/zdemo_excel37.prog.abap b/src/demos/zdemo_excel37.prog.abap index 172c0ee..b9eaf81 100644 --- a/src/demos/zdemo_excel37.prog.abap +++ b/src/demos/zdemo_excel37.prog.abap @@ -1,7 +1,5 @@ REPORT zdemo_excel37. -TYPE-POOLS: vrm. - DATA: excel TYPE REF TO zcl_excel, reader TYPE REF TO zif_excel_reader, go_error TYPE REF TO cx_root, diff --git a/src/demos/zdemo_excel42.prog.abap b/src/demos/zdemo_excel42.prog.abap index 7482a6c..ebfaada 100644 --- a/src/demos/zdemo_excel42.prog.abap +++ b/src/demos/zdemo_excel42.prog.abap @@ -7,7 +7,6 @@ *&---------------------------------------------------------------------* REPORT zdemo_excel42. -TYPE-POOLS: vrm. DATA: lo_excel TYPE REF TO zcl_excel, lo_worksheet TYPE REF TO zcl_excel_worksheet, diff --git a/src/not_cloud/zcl_excel_ole.clas.locals_def.abap b/src/not_cloud/zcl_excel_ole.clas.locals_def.abap index 9e50658..8a58c35 100644 --- a/src/not_cloud/zcl_excel_ole.clas.locals_def.abap +++ b/src/not_cloud/zcl_excel_ole.clas.locals_def.abap @@ -1,8 +1,7 @@ *"* use this source file for any type of declarations (class *"* definitions, interfaces or type declarations) you need for *"* components in the private section -TYPE-POOLS: sydes. -TYPE-POOLS: slis. + *--------------------------------------------------------------------* * CLASS c_oi_proxy_error *--------------------------------------------------------------------* diff --git a/src/zcl_excel_autofilter.clas.abap b/src/zcl_excel_autofilter.clas.abap index b382fbb..a0ed31f 100644 --- a/src/zcl_excel_autofilter.clas.abap +++ b/src/zcl_excel_autofilter.clas.abap @@ -49,7 +49,6 @@ CLASS zcl_excel_autofilter DEFINITION METHODS get_values RETURNING VALUE(rt_filter) TYPE zexcel_t_autofilter_values . - TYPE-POOLS abap . METHODS is_row_hidden IMPORTING !iv_row TYPE zexcel_cell_row diff --git a/src/zcl_excel_autofilters.clas.abap b/src/zcl_excel_autofilters.clas.abap index fcd523f..8127dd1 100644 --- a/src/zcl_excel_autofilters.clas.abap +++ b/src/zcl_excel_autofilters.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_autofilters DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_AUTOFILTERS *"* do not include other source files here!!! - TYPE-POOLS abap . CONSTANTS c_autofilter TYPE string VALUE '_xlnm._FilterDatabase'. "#EC NOTEXT diff --git a/src/zcl_excel_column.clas.abap b/src/zcl_excel_column.clas.abap index ebf80eb..1f18d49 100644 --- a/src/zcl_excel_column.clas.abap +++ b/src/zcl_excel_column.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_column DEFINITION *"* public components of class ZCL_EXCEL_COLUMN *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . METHODS constructor IMPORTING diff --git a/src/zcl_excel_comment.clas.abap b/src/zcl_excel_comment.clas.abap index d698bec..d25310e 100644 --- a/src/zcl_excel_comment.clas.abap +++ b/src/zcl_excel_comment.clas.abap @@ -4,7 +4,6 @@ CLASS zcl_excel_comment DEFINITION CREATE PUBLIC . PUBLIC SECTION. - TYPE-POOLS abap . METHODS constructor . METHODS get_name diff --git a/src/zcl_excel_common.clas.abap b/src/zcl_excel_common.clas.abap index c5d3e37..67bb55d 100644 --- a/src/zcl_excel_common.clas.abap +++ b/src/zcl_excel_common.clas.abap @@ -133,7 +133,6 @@ CLASS zcl_excel_common DEFINITION !ip_value TYPE t RETURNING VALUE(ep_value) TYPE zexcel_cell_value . - TYPE-POOLS abap . TYPES: t_char10 TYPE c LENGTH 10. TYPES: t_char255 TYPE c LENGTH 255. CLASS-METHODS split_file diff --git a/src/zcl_excel_converter.clas.abap b/src/zcl_excel_converter.clas.abap index a462297..3d986aa 100644 --- a/src/zcl_excel_converter.clas.abap +++ b/src/zcl_excel_converter.clas.abap @@ -5,7 +5,6 @@ CLASS zcl_excel_converter DEFINITION *"* public components of class ZCL_EXCEL_CONVERTER *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . CLASS-METHODS class_constructor . METHODS ask_option diff --git a/src/zcl_excel_converter_alv.clas.abap b/src/zcl_excel_converter_alv.clas.abap index 48ed4cf..39e9365 100644 --- a/src/zcl_excel_converter_alv.clas.abap +++ b/src/zcl_excel_converter_alv.clas.abap @@ -6,8 +6,6 @@ CLASS zcl_excel_converter_alv DEFINITION *"* public components of class ZCL_EXCEL_CONVERTER_ALV *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . - TYPE-POOLS kkblo . INTERFACES zif_excel_converter ALL METHODS ABSTRACT . diff --git a/src/zcl_excel_data_validation.clas.abap b/src/zcl_excel_data_validation.clas.abap index 1d0a171..d826a54 100644 --- a/src/zcl_excel_data_validation.clas.abap +++ b/src/zcl_excel_data_validation.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_data_validation DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_DATA_VALIDATION *"* do not include other source files here!!! - TYPE-POOLS abap . DATA errorstyle TYPE zexcel_data_val_error_style . DATA operator TYPE zexcel_data_val_operator . diff --git a/src/zcl_excel_data_validations.clas.abap b/src/zcl_excel_data_validations.clas.abap index d3e99ea..2afd865 100644 --- a/src/zcl_excel_data_validations.clas.abap +++ b/src/zcl_excel_data_validations.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_data_validations DEFINITION *"* public components of class ZCL_EXCEL_DATA_VALIDATIONS *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . METHODS add IMPORTING diff --git a/src/zcl_excel_drawing.clas.abap b/src/zcl_excel_drawing.clas.abap index 1c579e4..bdf21e4 100644 --- a/src/zcl_excel_drawing.clas.abap +++ b/src/zcl_excel_drawing.clas.abap @@ -12,7 +12,6 @@ CLASS zcl_excel_drawing DEFINITION *"* do not include other source files here!!! *"* protected components of class ZCL_EXCEL_DRAWING *"* do not include other source files here!!! - TYPE-POOLS abap . CONSTANTS c_graph_pie TYPE zexcel_graph_type VALUE 1. "#EC NOTEXT CONSTANTS c_graph_line TYPE zexcel_graph_type VALUE 2. "#EC NOTEXT diff --git a/src/zcl_excel_hyperlink.clas.abap b/src/zcl_excel_hyperlink.clas.abap index d4f3f8b..0346557 100644 --- a/src/zcl_excel_hyperlink.clas.abap +++ b/src/zcl_excel_hyperlink.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_hyperlink DEFINITION *"* public components of class ZCL_EXCEL_HYPERLINK *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . CLASS-METHODS create_external_link IMPORTING diff --git a/src/zcl_excel_legacy_palette.clas.abap b/src/zcl_excel_legacy_palette.clas.abap index 4931604..c9afcde 100644 --- a/src/zcl_excel_legacy_palette.clas.abap +++ b/src/zcl_excel_legacy_palette.clas.abap @@ -5,7 +5,6 @@ CLASS zcl_excel_legacy_palette DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_LEGACY_PALETTE *"* do not include other source files here!!! - TYPE-POOLS abap . METHODS constructor . METHODS is_modified diff --git a/src/zcl_excel_reader_2007.clas.abap b/src/zcl_excel_reader_2007.clas.abap index 0906a43..9af4962 100644 --- a/src/zcl_excel_reader_2007.clas.abap +++ b/src/zcl_excel_reader_2007.clas.abap @@ -5,7 +5,6 @@ CLASS zcl_excel_reader_2007 DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_READER_2007 *"* do not include other source files here!!! - TYPE-POOLS ixml . INTERFACES zif_excel_reader . diff --git a/src/zcl_excel_row.clas.abap b/src/zcl_excel_row.clas.abap index af655b6..6f7606f 100644 --- a/src/zcl_excel_row.clas.abap +++ b/src/zcl_excel_row.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_row DEFINITION *"* public components of class ZCL_EXCEL_ROW *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . METHODS constructor IMPORTING diff --git a/src/zcl_excel_security.clas.abap b/src/zcl_excel_security.clas.abap index 1d6997d..4823d2a 100644 --- a/src/zcl_excel_security.clas.abap +++ b/src/zcl_excel_security.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_security DEFINITION *"* public components of class ZCL_EXCEL_SECURITY *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . DATA lockrevision TYPE flag . DATA lockstructure TYPE flag . diff --git a/src/zcl_excel_sheet_setup.clas.abap b/src/zcl_excel_sheet_setup.clas.abap index 1cf7014..86fedd6 100644 --- a/src/zcl_excel_sheet_setup.clas.abap +++ b/src/zcl_excel_sheet_setup.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_sheet_setup DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_SHEET_SETUP *"* do not include other source files here!!! - TYPE-POOLS abap . DATA black_and_white TYPE flag . DATA cell_comments TYPE stringval . diff --git a/src/zcl_excel_style_alignment.clas.abap b/src/zcl_excel_style_alignment.clas.abap index 94e39ed..b0a3624 100644 --- a/src/zcl_excel_style_alignment.clas.abap +++ b/src/zcl_excel_style_alignment.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_style_alignment DEFINITION *"* public components of class ZCL_EXCEL_STYLE_ALIGNMENT *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . CONSTANTS c_horizontal_general TYPE zexcel_alignment VALUE 'general'. "#EC NOTEXT CONSTANTS c_horizontal_left TYPE zexcel_alignment VALUE 'left'. "#EC NOTEXT diff --git a/src/zcl_excel_style_fill.clas.abap b/src/zcl_excel_style_fill.clas.abap index 39c9edc..f20b06d 100644 --- a/src/zcl_excel_style_fill.clas.abap +++ b/src/zcl_excel_style_fill.clas.abap @@ -4,7 +4,6 @@ CLASS zcl_excel_style_fill DEFINITION CREATE PUBLIC . PUBLIC SECTION. - TYPE-POOLS abap . *"* public components of class ZCL_EXCEL_STYLE_FILL *"* do not include other source files here!!! diff --git a/src/zcl_excel_style_font.clas.abap b/src/zcl_excel_style_font.clas.abap index a094389..f5e8827 100644 --- a/src/zcl_excel_style_font.clas.abap +++ b/src/zcl_excel_style_font.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_style_font DEFINITION PUBLIC SECTION. *"* public components of class ZCL_EXCEL_STYLE_FONT *"* do not include other source files here!!! - TYPE-POOLS abap . DATA bold TYPE flag . DATA color TYPE zexcel_s_style_color . diff --git a/src/zcl_excel_table.clas.abap b/src/zcl_excel_table.clas.abap index bfadc9a..6887e3f 100644 --- a/src/zcl_excel_table.clas.abap +++ b/src/zcl_excel_table.clas.abap @@ -6,7 +6,6 @@ CLASS zcl_excel_table DEFINITION *"* public components of class ZCL_EXCEL_TABLE *"* do not include other source files here!!! PUBLIC SECTION. - TYPE-POOLS abap . CONSTANTS builtinstyle_dark1 TYPE zexcel_table_style VALUE 'TableStyleDark1'. "#EC NOTEXT CONSTANTS builtinstyle_dark2 TYPE zexcel_table_style VALUE 'TableStyleDark2'. "#EC NOTEXT diff --git a/src/zcl_excel_worksheet.clas.abap b/src/zcl_excel_worksheet.clas.abap index 58a48fa..d6907ff 100644 --- a/src/zcl_excel_worksheet.clas.abap +++ b/src/zcl_excel_worksheet.clas.abap @@ -9,9 +9,6 @@ CLASS zcl_excel_worksheet DEFINITION *"* do not include other source files here!!! *"* protected components of class ZCL_EXCEL_WORKSHEET *"* do not include other source files here!!! - TYPE-POOLS abap . - TYPE-POOLS slis . - TYPE-POOLS soi . INTERFACES zif_excel_sheet_printsettings . INTERFACES zif_excel_sheet_properties . From 9d0c970682ff71b132d4395c01cc343acc4fc1a5 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Mon, 3 Jan 2022 21:50:43 +0100 Subject: [PATCH 3/3] change FLOAT to F (#949) * change FLOAT to F * fix whitespace Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com> --- src/zcl_excel_column.clas.abap | 4 ++-- src/zcl_excel_font.clas.abap | 4 ++-- src/zcl_excel_reader_2007.clas.abap | 6 +++--- src/zcl_excel_row.clas.abap | 4 ++-- src/zcl_excel_sheet_setup.clas.abap | 12 ++++++------ src/zcl_excel_worksheet.clas.abap | 10 +++++----- src/zcl_excel_writer_huge_file.clas.abap | 10 +++++----- 7 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/zcl_excel_column.clas.abap b/src/zcl_excel_column.clas.abap index 1f18d49..a1d2fb6 100644 --- a/src/zcl_excel_column.clas.abap +++ b/src/zcl_excel_column.clas.abap @@ -31,7 +31,7 @@ CLASS zcl_excel_column DEFINITION VALUE(r_visible) TYPE abap_bool . METHODS get_width RETURNING - VALUE(r_width) TYPE float . + VALUE(r_width) TYPE f . METHODS get_xf_index RETURNING VALUE(r_xf_index) TYPE int4 . @@ -90,7 +90,7 @@ CLASS zcl_excel_column DEFINITION PRIVATE SECTION. DATA column_index TYPE int4 . - DATA width TYPE float . + DATA width TYPE f . DATA auto_size TYPE abap_bool . DATA visible TYPE abap_bool . DATA outline_level TYPE int4 . diff --git a/src/zcl_excel_font.clas.abap b/src/zcl_excel_font.clas.abap index c7f0e2e..b670008 100644 --- a/src/zcl_excel_font.clas.abap +++ b/src/zcl_excel_font.clas.abap @@ -39,7 +39,7 @@ CLASS zcl_excel_font DEFINITION !iv_flag_italic TYPE abap_bool !iv_cell_value TYPE zexcel_cell_value RETURNING - VALUE(rv_width) TYPE float . + VALUE(rv_width) TYPE f . PROTECTED SECTION. PRIVATE SECTION. ENDCLASS. @@ -51,7 +51,7 @@ CLASS zcl_excel_font IMPLEMENTATION. METHOD calculate_text_width. - CONSTANTS lc_excel_cell_padding TYPE float VALUE '0.75'. + CONSTANTS lc_excel_cell_padding TYPE f VALUE '0.75'. DATA: ld_current_character TYPE c LENGTH 1, lt_itcfc TYPE STANDARD TABLE OF itcfc, diff --git a/src/zcl_excel_reader_2007.clas.abap b/src/zcl_excel_reader_2007.clas.abap index 9af4962..0d1169a 100644 --- a/src/zcl_excel_reader_2007.clas.abap +++ b/src/zcl_excel_reader_2007.clas.abap @@ -2184,7 +2184,7 @@ CLASS zcl_excel_reader_2007 IMPLEMENTATION. TYPES: BEGIN OF lty_column, min TYPE string, max TYPE string, - width TYPE float, + width TYPE f, customwidth TYPE string, style TYPE string, bestfit TYPE string, @@ -2209,7 +2209,7 @@ CLASS zcl_excel_reader_2007 IMPLEMENTATION. TYPES: BEGIN OF lty_row, r TYPE string, customheight TYPE string, - ht TYPE float, + ht TYPE f, spans TYPE string, thickbot TYPE string, customformat TYPE string, @@ -2313,7 +2313,7 @@ CLASS zcl_excel_reader_2007 IMPLEMENTATION. lo_ixml_sheetformatpr_elem TYPE REF TO if_ixml_element, ls_sheetformatpr TYPE lty_sheetformatpr, - lv_height TYPE float, + lv_height TYPE f, lo_ixml_headerfooter_elem TYPE REF TO if_ixml_element, ls_headerfooter TYPE lty_headerfooter, diff --git a/src/zcl_excel_row.clas.abap b/src/zcl_excel_row.clas.abap index 6f7606f..77161f5 100644 --- a/src/zcl_excel_row.clas.abap +++ b/src/zcl_excel_row.clas.abap @@ -22,7 +22,7 @@ CLASS zcl_excel_row DEFINITION VALUE(r_outline_level) TYPE int4 . METHODS get_row_height RETURNING - VALUE(r_row_height) TYPE float . + VALUE(r_row_height) TYPE f . METHODS get_custom_height RETURNING VALUE(r_custom_height) TYPE abap_bool . @@ -68,7 +68,7 @@ CLASS zcl_excel_row DEFINITION PRIVATE SECTION. DATA row_index TYPE int4 . - DATA row_height TYPE float . + DATA row_height TYPE f . DATA visible TYPE abap_bool . DATA outline_level TYPE int4 VALUE 0. "#EC NOTEXT . . . . . . . . . " . DATA collapsed TYPE abap_bool . diff --git a/src/zcl_excel_sheet_setup.clas.abap b/src/zcl_excel_sheet_setup.clas.abap index 86fedd6..73fa944 100644 --- a/src/zcl_excel_sheet_setup.clas.abap +++ b/src/zcl_excel_sheet_setup.clas.abap @@ -124,12 +124,12 @@ CLASS zcl_excel_sheet_setup DEFINITION METHODS constructor . METHODS set_page_margins IMPORTING - !ip_bottom TYPE float OPTIONAL - !ip_footer TYPE float OPTIONAL - !ip_header TYPE float OPTIONAL - !ip_left TYPE float OPTIONAL - !ip_right TYPE float OPTIONAL - !ip_top TYPE float OPTIONAL + !ip_bottom TYPE f OPTIONAL + !ip_footer TYPE f OPTIONAL + !ip_header TYPE f OPTIONAL + !ip_left TYPE f OPTIONAL + !ip_right TYPE f OPTIONAL + !ip_top TYPE f OPTIONAL !ip_unit TYPE csequence DEFAULT 'in' . METHODS set_header_footer IMPORTING diff --git a/src/zcl_excel_worksheet.clas.abap b/src/zcl_excel_worksheet.clas.abap index d6907ff..0760cc5 100644 --- a/src/zcl_excel_worksheet.clas.abap +++ b/src/zcl_excel_worksheet.clas.abap @@ -686,7 +686,7 @@ CLASS zcl_excel_worksheet DEFINITION !ip_column TYPE simple !ip_row TYPE zexcel_cell_row RETURNING - VALUE(ep_width) TYPE float + VALUE(ep_width) TYPE f RAISING zcx_excel . CLASS-METHODS check_cell_column_formula @@ -1345,7 +1345,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION. TYPES: BEGIN OF t_auto_size, col_index TYPE int4, - width TYPE float, + width TYPE f, END OF t_auto_size. TYPES: tt_auto_size TYPE TABLE OF t_auto_size. @@ -1356,7 +1356,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION. DATA: auto_sizes TYPE tt_auto_size. DATA: count TYPE int4. DATA: highest_row TYPE int4. - DATA: width TYPE float. + DATA: width TYPE f. FIELD-SYMBOLS: LIKE LINE OF auto_sizes. @@ -3550,7 +3550,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION. METHOD set_column_width. DATA: lo_column TYPE REF TO zcl_excel_column. - DATA: width TYPE float. + DATA: width TYPE f. lo_column = me->get_column( ip_column ). @@ -3701,7 +3701,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION. METHOD set_row_height. DATA: lo_row TYPE REF TO zcl_excel_row. - DATA: height TYPE float. + DATA: height TYPE f. lo_row = me->get_row( ip_row ). diff --git a/src/zcl_excel_writer_huge_file.clas.abap b/src/zcl_excel_writer_huge_file.clas.abap index e5941f7..8395fa7 100644 --- a/src/zcl_excel_writer_huge_file.clas.abap +++ b/src/zcl_excel_writer_huge_file.clas.abap @@ -139,13 +139,13 @@ CLASS zcl_excel_writer_huge_file IMPLEMENTATION. lc_true TYPE lty_bool VALUE 'true', lc_zero TYPE c LENGTH 1 VALUE '0', lc_one TYPE c LENGTH 1 VALUE '1', - lc_default_col_width TYPE float VALUE '9.10'. + lc_default_col_width TYPE f VALUE '9.10'. TYPES: BEGIN OF lty_column, min TYPE i, max TYPE i, - width TYPE float, + width TYPE f, hidden TYPE lty_bool, customwidth TYPE lty_bool, bestfit TYPE lty_bool, @@ -160,7 +160,7 @@ CLASS zcl_excel_writer_huge_file IMPLEMENTATION. spans TYPE c LENGTH 11, "12345:12345" hidden TYPE lty_bool, customheight TYPE lty_bool, - height TYPE float, + height TYPE f, collapsed TYPE lty_bool, outlinelevel TYPE i, customformat TYPE lty_bool, @@ -220,8 +220,8 @@ CLASS zcl_excel_writer_huge_file IMPLEMENTATION. topleftcell TYPE c LENGTH 10, activecell TYPE c LENGTH 10, customheight TYPE lty_bool, - defaultrowheight TYPE float, - defaultcolwidth TYPE float, + defaultrowheight TYPE f, + defaultcolwidth TYPE f, outlinelevelrow TYPE i, outlinelevelcol TYPE i, cols TYPE STANDARD TABLE OF lty_column,