From c2419f389604ea9a627b30c531400a41c5831c45 Mon Sep 17 00:00:00 2001 From: Ivan Date: Tue, 18 Mar 2014 10:34:13 -0500 Subject: [PATCH] Code Inspector improvements Change coding issues raised by code inspector. Still some remain to fix. --- ZA2X/CLAS/ZCL_EXCEL_COMMON.slnk | 1180 ++---------------- ZA2X/CLAS/ZCL_EXCEL_CONVERTER.slnk | 97 +- ZA2X/CLAS/ZCL_EXCEL_CONVERTER_ALV.slnk | 26 +- ZA2X/CLAS/ZCL_EXCEL_CONVERTER_RESULT_WD.slnk | 38 +- ZA2X/CLAS/ZCL_EXCEL_DRAWING.slnk | 42 +- ZA2X/CLAS/ZCL_EXCEL_GRAPH.slnk | 627 +++------- ZA2X/CLAS/ZCL_EXCEL_RANGE.slnk | 60 +- ZA2X/CLAS/ZCL_EXCEL_READER_2007.slnk | 30 +- ZA2X/CLAS/ZCL_EXCEL_SECURITY.slnk | 52 +- ZA2X/CLAS/ZCL_EXCEL_STYLE_BORDERS.slnk | 69 +- ZA2X/CLAS/ZCL_EXCEL_STYLE_COLOR.slnk | 128 +- ZA2X/CLAS/ZCL_EXCEL_TABLE.slnk | 13 +- ZA2X/CLAS/ZCL_EXCEL_WORKSHEET.slnk | 12 +- ZA2X/INTF/ZIF_EXCEL_SHEET_PROPERTIES.slnk | 10 +- ZA2X/PROG/ZDEMO_EXCEL11.slnk | 18 +- 15 files changed, 441 insertions(+), 1961 deletions(-) diff --git a/ZA2X/CLAS/ZCL_EXCEL_COMMON.slnk b/ZA2X/CLAS/ZCL_EXCEL_COMMON.slnk index fe3e007..f291237 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_COMMON.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_COMMON.slnk @@ -8,1043 +8,11 @@ *"* implementation or private method's signature *"* use this source file for any macro definitions you need *"* in the implementation part of the class - CLASS lcl_excel_common_test DEFINITION DEFERRED. -CLASS zcl_excel_common DEFINITION LOCAL FRIENDS lcl_excel_common_test. - -*----------------------------------------------------------------------* -* CLASS lcl_Excel_Common_Test DEFINITION -*----------------------------------------------------------------------* -* -*----------------------------------------------------------------------* -CLASS lcl_excel_common_test DEFINITION FOR TESTING "#AU Risk_Level Harmless - . "#AU Duration Short -*?<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0"> -*?<asx:values> -*?<TESTCLASS_OPTIONS> -*?<TEST_CLASS>lcl_Excel_Common_Test -*?</TEST_CLASS> -*?<TEST_MEMBER>f_Cut -*?</TEST_MEMBER> -*?<OBJECT_UNDER_TEST>ZCL_EXCEL_COMMON -*?</OBJECT_UNDER_TEST> -*?<OBJECT_IS_LOCAL/> -*?<GENERATE_FIXTURE>X -*?</GENERATE_FIXTURE> -*?<GENERATE_CLASS_FIXTURE>X -*?</GENERATE_CLASS_FIXTURE> -*?<GENERATE_INVOCATION>X -*?</GENERATE_INVOCATION> -*?<GENERATE_ASSERT_EQUAL>X -*?</GENERATE_ASSERT_EQUAL> -*?</TESTCLASS_OPTIONS> -*?</asx:values> -*?</asx:abap> - PRIVATE SECTION. -* ================ - DATA: - lx_excel TYPE REF TO zcx_excel, - ls_symsg_act TYPE symsg, " actual messageinformation of exception - ls_symsg_exp TYPE symsg, " expected messageinformation of exception - f_cut TYPE REF TO zcl_excel_common. "class under test - - CLASS-METHODS: class_setup. - CLASS-METHODS: class_teardown. - METHODS: setup. - METHODS: teardown. -* METHODS: char2hex FOR TESTING. - METHODS: convert_column2alpha FOR TESTING. - METHODS: convert_column2int FOR TESTING. - METHODS: date_to_excel_string FOR TESTING. - METHODS: encrypt_password FOR TESTING. - METHODS: excel_string_to_date FOR TESTING. - METHODS: excel_string_to_time FOR TESTING. -* METHODS: number_to_excel_string FOR TESTING. - METHODS: time_to_excel_string FOR TESTING. - METHODS: split_file FOR TESTING. - METHODS: convert_range2column_a_row FOR TESTING. - METHODS: describe_structure FOR TESTING. - METHODS: calculate_cell_distance FOR TESTING. - METHODS: shift_formula FOR TESTING. -ENDCLASS. "lcl_Excel_Common_Test - - -*----------------------------------------------------------------------* -* CLASS lcl_Excel_Common_Test IMPLEMENTATION -*----------------------------------------------------------------------* -* -*----------------------------------------------------------------------* -CLASS lcl_excel_common_test IMPLEMENTATION. -* =========================================== - - METHOD class_setup. -* =================== - - - ENDMETHOD. "class_Setup - - - METHOD class_teardown. -* ====================== - - - ENDMETHOD. "class_Teardown - - - METHOD setup. -* ============= - - CREATE OBJECT f_cut. - ENDMETHOD. "setup - - - METHOD teardown. -* ================ - - - ENDMETHOD. "teardown - - - METHOD convert_column2alpha. -* ============================ - DATA ep_column TYPE zexcel_cell_column_alpha. - -* Test 1. Simple test - TRY. - ep_column = zcl_excel_common=>convert_column2alpha( 1 ). - - zcl_excel_common=>assert_equals( - act = ep_column - exp = 'A' - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Max column for OXML #16,384 = XFD - TRY. - ep_column = zcl_excel_common=>convert_column2alpha( 16384 ). - - zcl_excel_common=>assert_equals( - act = ep_column - exp = 'XFD' - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Index 0 is out of bounds - TRY. - ep_column = zcl_excel_common=>convert_column2alpha( 0 ). - - zcl_excel_common=>assert_equals( - act = ep_column - exp = 'A' - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( - act = lx_excel->error - exp = 'Index out of bounds' - msg = 'Colum index 0 is out of bounds, min column index is 1' - level = if_aunit_constants=>fatal - ). - ENDTRY. - -* Test 4. Exception should be thrown index out of bounds - TRY. - ep_column = zcl_excel_common=>convert_column2alpha( 16385 ). - - zcl_excel_common=>assert_differs( - act = ep_column - exp = 'XFE' - msg = 'Colum index 16385 is out of bounds, max column index is 16384' - level = if_aunit_constants=>fatal - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( - act = lx_excel->error - exp = 'Index out of bounds' - msg = 'Wrong exception is thrown' - level = if_aunit_constants=>tolerable - ). - ENDTRY. - ENDMETHOD. "convert_Column2alpha - - - METHOD convert_column2int. -* ========================== - DATA ep_column TYPE zexcel_cell_column. - -* Test 1. Basic test - TRY. - ep_column = zcl_excel_common=>convert_column2int( 'A' ). - - zcl_excel_common=>assert_equals( - act = ep_column - exp = 1 - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Max column - TRY. - ep_column = zcl_excel_common=>convert_column2int( 'XFD' ). - - zcl_excel_common=>assert_equals( - act = ep_column - exp = 16384 - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Out of bounds - TRY. - ep_column = zcl_excel_common=>convert_column2int( '' ). - - zcl_excel_common=>assert_differs( act = ep_column - exp = '0' - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical ). - CATCH zcx_excel INTO lx_excel. - CLEAR: ls_symsg_act, - ls_symsg_exp. - ls_symsg_exp-msgid = 'ZABAP2XLSX'. - ls_symsg_exp-msgno = '800'. - ls_symsg_act-msgid = lx_excel->syst_at_raise-msgid. - ls_symsg_act-msgno = lx_excel->syst_at_raise-msgno. - zcl_excel_common=>assert_equals( act = ls_symsg_act - exp = ls_symsg_exp - msg = 'Colum name should be a valid string' - level = if_aunit_constants=>fatal ). - ENDTRY. - -* Test 4. Out of bounds - TRY. - ep_column = zcl_excel_common=>convert_column2int( 'XFE' ). - - zcl_excel_common=>assert_differs( act = ep_column - exp = 16385 - msg = 'Wrong column conversion' - level = if_aunit_constants=>critical ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( act = lx_excel->error - exp = 'Index out of bounds' - msg = 'Colum XFE is out of range' - level = if_aunit_constants=>fatal ). - ENDTRY. - ENDMETHOD. "convert_Column2int - - - METHOD date_to_excel_string. -* ============================ - DATA ep_value TYPE zexcel_cell_value. - -* Test 1. Basic conversion - TRY. - ep_value = zcl_excel_common=>date_to_excel_string( '19000101' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = 1 - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. -* Check around the "Excel Leap Year" 1900 - TRY. - ep_value = zcl_excel_common=>date_to_excel_string( '19000228' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = 59 - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - TRY. - ep_value = zcl_excel_common=>date_to_excel_string( '19000301' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = 61 - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - - -* Test 2. Basic conversion - TRY. - ep_value = zcl_excel_common=>date_to_excel_string( '99991212' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = 2958446 - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Initial date - TRY. - DATA: lv_date TYPE d. - ep_value = zcl_excel_common=>date_to_excel_string( lv_date ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Basic conversion - TRY. - DATA exp_value TYPE zexcel_cell_value VALUE 0. - ep_value = zcl_excel_common=>date_to_excel_string( '18991231' ). - - zcl_excel_common=>assert_differs( - act = ep_value - exp = exp_value - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( - act = lx_excel->error - exp = 'Index out of bounds' - msg = 'Dates prior of 1900 are not available in excel' - level = if_aunit_constants=>critical - ). - ENDTRY. - - ENDMETHOD. "date_To_Excel_String - - - METHOD encrypt_password. -* ======================== - DATA lv_encrypted_pwd TYPE zexcel_aes_password. - - TRY. - lv_encrypted_pwd = zcl_excel_common=>encrypt_password( 'test' ). - - zcl_excel_common=>assert_equals( - act = lv_encrypted_pwd - exp = 'CBEB' - msg = 'Wrong password encryption' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - ENDMETHOD. "encrypt_Password - - - METHOD excel_string_to_date. -* ============================ - DATA ep_value TYPE d. - - -* Test 1. Simple test -> ABAP Manage also date prior of 1900 - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '0' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '18991231' - msg = 'Wrong date conversion' - level = if_aunit_constants=>tolerable - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. -* Check around the "Excel Leap Year" 1900 - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '59' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '19000228' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '61' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '19000301' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Simple test - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '1' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '19000101' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Index 0 is out of bounds - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '2958446' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '99991212' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 4. Exception should be thrown index out of bounds - TRY. - ep_value = zcl_excel_common=>excel_string_to_date( '2958447' ). - - zcl_excel_common=>assert_differs( - act = ep_value - exp = '99991212' - msg = 'Wrong date conversion' - level = if_aunit_constants=>fatal - ). - - zcl_excel_common=>assert_differs( - act = ep_value - exp = '00000000' - msg = 'Wrong date conversion' - level = if_aunit_constants=>fatal - ). - - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( - act = lx_excel->error - exp = 'Index out of bounds' - msg = 'Wrong exception is thrown' - level = if_aunit_constants=>tolerable - ). - ENDTRY. - ENDMETHOD. "excel_String_To_Date - - - METHOD excel_string_to_time. -* ============================ - DATA ep_value TYPE t. - -* Test 1. Simple test - TRY. - ep_value = zcl_excel_common=>excel_string_to_time( '0' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '000000' - msg = 'Wrong date conversion' - level = if_aunit_constants=>tolerable - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Simple test - TRY. - ep_value = zcl_excel_common=>excel_string_to_time( '1' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '000000' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Simple test - TRY. - ep_value = zcl_excel_common=>excel_string_to_time( '0.99999' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '235959' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 4. Also string greater than 1 should be managed - TRY. - ep_value = zcl_excel_common=>excel_string_to_time( '4.1' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '022400' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 4. string is not a number - TRY. - ep_value = zcl_excel_common=>excel_string_to_time( 'NaN' ). - - zcl_excel_common=>assert_differs( - act = ep_value - exp = '000000' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>assert_equals( - act = lx_excel->error - exp = 'Unable to interpret time' - msg = 'Time should be a valid string' - level = if_aunit_constants=>fatal - ). - ENDTRY. - ENDMETHOD. "excel_String_To_Time - - - METHOD time_to_excel_string. -* ============================ - DATA ep_value TYPE zexcel_cell_value. - -* Test 1. Basic conversion - TRY. - ep_value = zcl_excel_common=>time_to_excel_string( '000001' ). - " A test directly in Excel returns the value 0.0000115740740740741000 - zcl_excel_common=>assert_equals( - act = ep_value - exp = '0.0000115740740741' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Basic conversion - TRY. - ep_value = zcl_excel_common=>time_to_excel_string( '235959' ). - " A test directly in Excel returns the value 0.9999884259259260000000 - zcl_excel_common=>assert_equals( - act = ep_value - exp = '0.9999884259259260' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 3. Initial date - TRY. - ep_value = zcl_excel_common=>time_to_excel_string( '000000' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '0' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - -* Test 2. Basic conversion - TRY. - ep_value = zcl_excel_common=>time_to_excel_string( '022400' ). - - zcl_excel_common=>assert_equals( - act = ep_value - exp = '0.1000000000000000' - msg = 'Wrong date conversion' - level = if_aunit_constants=>critical - ). - CATCH zcx_excel INTO lx_excel. - zcl_excel_common=>fail( - msg = 'unexpected exception' - level = if_aunit_constants=>critical " Error Severity - ). - ENDTRY. - - ENDMETHOD. "time_To_Excel_String - - METHOD split_file. -* ============================ - - DATA: ep_file TYPE text255, - ep_extension TYPE char10, - ep_dotextension TYPE char10. - - -* Test 1. Basic conversion - zcl_excel_common=>split_file( EXPORTING ip_file = 'filename.xml' - IMPORTING ep_file = ep_file - ep_extension = ep_extension - ep_dotextension = ep_dotextension ). - - zcl_excel_common=>assert_equals( - act = ep_file - exp = 'filename' - msg = 'Split filename failed' - level = if_aunit_constants=>critical ). - - zcl_excel_common=>assert_equals( - act = ep_extension - exp = 'xml' - msg = 'Split extension failed' - level = if_aunit_constants=>critical ). - - zcl_excel_common=>assert_equals( - act = ep_dotextension - exp = '.xml' - msg = 'Split extension failed' - level = if_aunit_constants=>critical ). - -* Test 2. no extension - zcl_excel_common=>split_file( EXPORTING ip_file = 'filename' - IMPORTING ep_file = ep_file - ep_extension = ep_extension - ep_dotextension = ep_dotextension ). - - zcl_excel_common=>assert_equals( - act = ep_file - exp = 'filename' - msg = 'Split filename failed' - level = if_aunit_constants=>critical ). - - zcl_excel_common=>assert_equals( - act = ep_extension - exp = '' - msg = 'Split extension failed' - level = if_aunit_constants=>critical ). - - zcl_excel_common=>assert_equals( - act = ep_dotextension - exp = '' - msg = 'Split extension failed' - level = if_aunit_constants=>critical ). - - ENDMETHOD. "split_file - - METHOD convert_range2column_a_row. - DATA: lv_range TYPE string. - DATA: lv_column_start TYPE zexcel_cell_column_alpha, - lv_column_end TYPE zexcel_cell_column_alpha, - lv_row_start TYPE zexcel_cell_row, - lv_row_end TYPE zexcel_cell_row, - lv_sheet TYPE string. - -* a) input empty --> nothing to do - zcl_excel_common=>convert_range2column_a_row( - EXPORTING - i_range = lv_range - IMPORTING - e_column_start = lv_column_start " Cell Column Start - e_column_end = lv_column_end " Cell Column End - e_row_start = lv_row_start " Cell Row - e_row_end = lv_row_end " Cell Row - e_sheet = lv_sheet " Title - ). - - zcl_excel_common=>assert_equals( - act = lv_column_start - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_column_end - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_start - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_end - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_sheet - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). -* b) sheetname existing - starts with ' example 'Sheet 1'!$B$6:$D$13 - lv_range = `'Sheet 1'!$B$6:$D$13`. - zcl_excel_common=>convert_range2column_a_row( - EXPORTING - i_range = lv_range - IMPORTING - e_column_start = lv_column_start " Cell Column Start - e_column_end = lv_column_end " Cell Column End - e_row_start = lv_row_start " Cell Row - e_row_end = lv_row_end " Cell Row - e_sheet = lv_sheet " Title - ). - - zcl_excel_common=>assert_equals( - act = lv_column_start - exp = 'B' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_column_end - exp = 'D' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_start - exp = '6' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_end - exp = '13' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_sheet - exp = 'Sheet 1' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). -* c) sheetname existing - does not start with ' example Sheet1!$B$6:$D$13 - lv_range = `Sheet1!B6:$D$13`. - zcl_excel_common=>convert_range2column_a_row( - EXPORTING - i_range = lv_range - IMPORTING - e_column_start = lv_column_start " Cell Column Start - e_column_end = lv_column_end " Cell Column End - e_row_start = lv_row_start " Cell Row - e_row_end = lv_row_end " Cell Row - e_sheet = lv_sheet " Title - ). - - zcl_excel_common=>assert_equals( - act = lv_column_start - exp = 'B' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_column_end - exp = 'D' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_start - exp = '6' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_end - exp = '13' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_sheet - exp = 'Sheet1' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). -* d) no sheetname - just area example $B$6:$D$13 - lv_range = `$B$6:D13`. - zcl_excel_common=>convert_range2column_a_row( - EXPORTING - i_range = lv_range - IMPORTING - e_column_start = lv_column_start " Cell Column Start - e_column_end = lv_column_end " Cell Column End - e_row_start = lv_row_start " Cell Row - e_row_end = lv_row_end " Cell Row - e_sheet = lv_sheet " Title - ). - - zcl_excel_common=>assert_equals( - act = lv_column_start - exp = 'B' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_column_end - exp = 'D' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_start - exp = '6' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_row_end - exp = '13' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - zcl_excel_common=>assert_equals( - act = lv_sheet - exp = '' - msg = 'Conversion of range failed' - level = if_aunit_constants=>critical ). - ENDMETHOD. "convert_range2column_a_row - - - METHOD describe_structure. - DATA: ls_test TYPE scarr. - DATA: lo_structdescr TYPE REF TO cl_abap_structdescr. - DATA: lt_structure TYPE ddfields. - FIELD-SYMBOLS: <line> LIKE LINE OF lt_structure. - - " Test with DDIC Type - lo_structdescr ?= cl_abap_structdescr=>describe_by_data( p_data = ls_test ). - lt_structure = zcl_excel_common=>describe_structure( io_struct = lo_structdescr ). - READ TABLE lt_structure ASSIGNING <line> INDEX 1. - zcl_excel_common=>assert_equals( - act = <line>-fieldname - exp = 'MANDT' - msg = 'Describe structure failed' - level = if_aunit_constants=>critical ). - - " Test with local defined structure having DDIC and non DDIC elements - TYPES: - BEGIN OF t_test, - carrid TYPE s_carr_id, - carrname TYPE s_carrname, - carrdesc TYPE string, - END OF t_test. - DATA: ls_ttest TYPE t_test. - - lo_structdescr ?= cl_abap_structdescr=>describe_by_data( p_data = ls_ttest ). - lt_structure = zcl_excel_common=>describe_structure( io_struct = lo_structdescr ). - READ TABLE lt_structure ASSIGNING <line> INDEX 1. - zcl_excel_common=>assert_equals( - act = <line>-fieldname - exp = 'CARRID' - msg = 'Describe structure failed' - level = if_aunit_constants=>critical ). - - ENDMETHOD. "describe_structure - - - METHOD calculate_cell_distance. - DATA: lv_offset_rows TYPE i, - lv_offset_cols TYPE i, - lv_message TYPE string. - - DEFINE macro_calculate_cell_distance. - zcl_excel_common=>calculate_cell_distance( exporting iv_reference_cell = &1 - iv_current_cell = &2 - importing ev_row_difference = lv_offset_rows - ev_col_difference = lv_offset_cols ). -* Check delta columns - concatenate 'Error calculating column difference in test:' - &1 - '->' - &2 - into lv_message separated by space. - zcl_excel_common=>assert_equals( act = lv_offset_cols - exp = &3 - msg = lv_message - quit = 0 " continue tests - level = if_aunit_constants=>critical ). -* Check delta rows - concatenate 'Error calculating row difference in test:' - &1 - '->' - &2 - into lv_message separated by space. - zcl_excel_common=>assert_equals( act = lv_offset_rows - exp = &4 - msg = lv_message - quit = 0 " continue tests - level = if_aunit_constants=>critical ). - END-OF-DEFINITION. - - - macro_calculate_cell_distance: - 'C12' 'C12' 0 0 , " Same cell - 'C12' 'C13' 0 1 , " Shift down 1 place - 'C12' 'C25' 0 13 , " Shift down some places - 'C12' 'C11' 0 -1 , " Shift up 1 place - 'C12' 'C1' 0 -11 , " Shift up some place - 'C12' 'D12' 1 0 , " Shift right 1 place - 'C12' 'AA12' 24 0 , " Shift right some places - 'C12' 'B12' -1 0 , " Shift left 1 place - 'AA12' 'C12' -24 0 , " Shift left some place - 'AA121' 'C12' -24 -109 . " The full package. - - ENDMETHOD. "CALCULATE_CELL_DISTANCE - - METHOD shift_formula. - DATA: lv_resulting_formula TYPE string, - lv_message TYPE string, - lv_counter TYPE num8. - - DEFINE macro_shift_formula. - add 1 to lv_counter. - clear lv_resulting_formula. - try. - lv_resulting_formula = zcl_excel_common=>shift_formula( iv_reference_formula = &1 - iv_shift_cols = &2 - iv_shift_rows = &3 ). - concatenate 'Wrong result in test' - lv_counter - 'shifting formula ' - &1 - into lv_message separated by space. - zcl_excel_common=>assert_equals( act = lv_resulting_formula - exp = &4 - msg = lv_message - quit = 0 " continue tests - level = if_aunit_constants=>critical ). - catch zcx_excel. - concatenate 'Unexpected exception occurred in test' - lv_counter - 'shifting formula ' - &1 - into lv_message separated by space. - zcl_excel_common=>assert_equals( act = lv_resulting_formula - exp = &4 - msg = lv_message - quit = 0 " continue tests - level = if_aunit_constants=>critical ). - endtry. - END-OF-DEFINITION. - -* Test shifts that should result in a valid output - macro_shift_formula: - 'C17' 0 0 'C17', " Very basic check - 'C17' 2 3 'E20', " Check shift right and down - 'C17' -2 -3 'A14', " Check shift left and up - '$C$17' 1 1 '$C$17', " Fixed columns/rows - 'SUM($C17:C$23)+C30' 1 11 'SUM($C28:D$23)+D41', " Operators and Ranges, mixed fixed rows or columns - 'RNGNAME1+C7' -1 -4 'RNGNAME1+B3', " Operators and Rangename - '"Date:"&TEXT(B2)' 1 1 '"Date:"&TEXT(C3)', " String literals and string concatenation - '[TEST6.XLSX]SHEET1!A1' 1 11 '[TEST6.XLSX]SHEET1!B12', " External sheet reference - `X(B13, "KK" ) ` 1 1 `X(C14,"KK")`, " superflous blanks, multi-argument functions, literals in function, unknown functions -* 'SIN((((((B2))))))' 1 1 'SIN((((((C3))))))', " Deep nesting -* 'SIN(SIN(SIN(SIN(E22))))' 0 1 'SIN(SIN(SIN(SIN(E23))))', " Different type of deep nesting - `SIN(SIN(SIN(SIN(E22))))` 0 1 'SIN(SIN(SIN(SIN(E23))))', " same as above - but with string input instead of Char-input - 'HEUTE()' 2 5 'HEUTE()', " Functions w/o arguments, No cellreferences - '"B2"' 2 5 '"B2"', " No cellreferences - '' 2 5 '', " Empty - 'A1+$A1+A$1+$A$1+B2' -1 0 '#REF!+$A1+#REF!+$A$1+A2', " Referencing error , column only , underflow - 'A1+$A1+A$1+$A$1+B2' 0 -1 '#REF!+#REF!+A$1+$A$1+B1', " Referencing error , row only , underflow - 'A1+$A1+A$1+$A$1+B2' -1 -1 '#REF!+#REF!+#REF!+$A$1+A1'. " Referencing error , row and column , underflow - ENDMETHOD. "SHIFT_FORMULA - - - - - -ENDCLASS. "lcl_Excel_Common_Test + *"* use this source file for your ABAP unit test classes - + @@ -1066,7 +34,7 @@ ENDCLASS. "lcl_Excel_Common_Test - + @@ -1114,9 +82,9 @@ ENDCLASS. "lcl_Excel_Common_Test * We do nothing for now not supported ENDIF. ENDIF. -endmethod. + endmethod. - + @@ -1125,7 +93,7 @@ endmethod. - METHOD assert_equals. + method ASSERT_EQUALS. DATA: ls_seoclass TYPE seoclass. " Let see >=7.02 @@ -1167,15 +135,15 @@ endmethod. * We do nothing for now not supported ENDIF. ENDIF. -ENDMETHOD. + endmethod. - + - METHOD calculate_cell_distance. + method CALCULATE_CELL_DISTANCE. DATA: lv_reference_row TYPE i, lv_reference_col_alpha TYPE zexcel_cell_column_alpha, @@ -1214,7 +182,7 @@ ENDMETHOD. ev_row_difference = lv_current_row - lv_reference_row. ev_col_difference = lv_current_col - lv_reference_col. -ENDMETHOD. + endmethod. @@ -1231,13 +199,13 @@ ENDMETHOD. CALL METHOD o_conv->write( data = i_char ). r_hex+1 = o_conv->get_buffer( ). " x'65' must be x'0065' -endmethod. + endmethod. - + - METHOD convert_column2alpha. + method CONVERT_COLUMN2ALPHA. DATA: lv_uccpi TYPE i, lv_text TYPE sychar02, @@ -1272,17 +240,17 @@ endmethod. ENDWHILE. -ENDMETHOD. + endmethod. - + - METHOD convert_column2int. + method CONVERT_COLUMN2INT. *--------------------------------------------------------------------* * issue #230 - Pimp my Code -* - Stefan Schmöcker, (done) 2012-12-29 +* - Stefan Schmöcker, (done) 2012-12-29 * - ... * changes: renaming variables to naming conventions * removing unused variables @@ -1291,7 +259,7 @@ ENDMETHOD. * adding comments to explain what we are trying to achieve *--------------------------------------------------------------------* * issue#246 - error converting lower case column names -* - Stefan Schmöcker, 2012-12-29 +* - Stefan Schmöcker, 2012-12-29 * changes: translating the correct variable to upper dase * adding missing exception if input is a number * that is out of bounds @@ -1431,9 +399,9 @@ ENDMETHOD. ENDIF. -ENDMETHOD. + endmethod. - + @@ -1441,7 +409,7 @@ ENDMETHOD. *--------------------------------------------------------------------* "issue #256 - replacing char processing with regex *--------------------------------------------------------------------* -* Stefan Schmöcker, 2013-08-11 +* Stefan Schmöcker, 2013-08-11 * Allow input to be CLIKE instead of STRING *--------------------------------------------------------------------* @@ -1454,9 +422,9 @@ ENDMETHOD. pane_cell_row_a. e_row = pane_cell_row_a. -endmethod. + endmethod. - + @@ -1467,7 +435,7 @@ endmethod. method CONVERT_RANGE2COLUMN_A_ROW. *--------------------------------------------------------------------* * issue #230 - Pimp my Code -* - Stefan Schmöcker, (done) 2012-12-07 +* - Stefan Schmöcker, (done) 2012-12-07 * - ... * changes: renaming variables to naming conventions * aligning code @@ -1477,12 +445,12 @@ endmethod. *--------------------------------------------------------------------* * issue#241 - error when sheetname contains "!" * - sheetname should be returned unescaped -* - Stefan Schmöcker, 2012-12-07 +* - Stefan Schmöcker, 2012-12-07 * changes: changed coding to support sheetnames with "!" * unescaping sheetname *--------------------------------------------------------------------* * issue#155 - lessening restrictions of input parameters -* - Stefan Schmöcker, 2012-12-07 +* - Stefan Schmöcker, 2012-12-07 * changes: i_range changed to clike * e_sheet changed to clike *--------------------------------------------------------------------* @@ -1547,9 +515,9 @@ endmethod. e_row = e_row_end ). e_sheet = unescape_string( lv_sheet ). " Return in unescaped form -endmethod. + endmethod. - + method DATE_TO_EXCEL_STRING. @@ -1565,7 +533,7 @@ endmethod. lv_date_diff = ip_value - c_excel_baseline_date + 1. ENDIF. ep_value = zcl_excel_common=>number_to_excel_string( ip_value = lv_date_diff ). -endmethod. + endmethod. @@ -1616,19 +584,15 @@ endmethod. ENDIF. ENDLOOP. ENDIF. -endmethod. + endmethod. - - method DESCRIBE_TABLE. -endmethod. - - + - METHOD determine_resulting_formula. + method DETERMINE_RESULTING_FORMULA. DATA: lv_row_difference TYPE i, lv_col_difference TYPE i. @@ -1650,9 +614,9 @@ endmethod. iv_shift_rows = lv_row_difference iv_shift_cols = lv_col_difference ). -ENDMETHOD. "determine_resulting_formula + endmethod. - + method ENCRYPT_PASSWORD. @@ -1692,27 +656,27 @@ ENDMETHOD. "determine_resulting_formula WRITE lv_pwd_hash TO r_encrypted_pwd. -endmethod. + endmethod. - + method ESCAPE_STRING. *--------------------------------------------------------------------* * issue #230 - Pimp my Code -* - Stefan Schmöcker, (done) 2012-12-08 +* - Stefan Schmöcker, (done) 2012-12-08 * - ... * changes: aligning code * adding comments to explain what we are trying to achieve *--------------------------------------------------------------------* * issue#242 - Support escaping for white-spaces * - Escaping also necessary when ' encountered in input -* - Stefan Schmöcker, 2012-12-08 +* - Stefan Schmöcker, 2012-12-08 * changes: switched check if escaping is necessary to regular expression * and moved the "REPLACE" *--------------------------------------------------------------------* * issue#155 - lessening restrictions of input parameters -* - Stefan Schmöcker, 2012-12-08 +* - Stefan Schmöcker, 2012-12-08 * changes: ip_value changed to clike *--------------------------------------------------------------------* DATA: lv_value TYPE string. @@ -1743,9 +707,9 @@ endmethod. ep_escaped_value = lv_value. -endmethod. + endmethod. - + @@ -1766,9 +730,9 @@ endmethod. EXPORTING error = 'Index out of bounds'. ENDTRY. -endmethod. + endmethod. - + @@ -1789,9 +753,9 @@ endmethod. EXPORTING error = 'Unable to interpret time'. ENDTRY. -endmethod. + endmethod. - + @@ -1829,9 +793,9 @@ endmethod. ENDIF. ENDIF. -endmethod. + endmethod. - + method GET_FIELDCATALOG. @@ -1890,9 +854,9 @@ endmethod. ENDLOOP. -endmethod. + endmethod. - + method NUMBER_TO_EXCEL_STRING. @@ -1909,9 +873,9 @@ endmethod. ELSEIF ip_value EQ 0. ep_value = '0'. ENDIF. -endmethod. + endmethod. - + @@ -1968,9 +932,9 @@ endmethod. ENDCASE. ENDLOOP. -endmethod. + endmethod. - + @@ -2032,15 +996,15 @@ endmethod. ENDCASE. ENDLOOP. -endmethod. + endmethod. - + - METHOD shift_formula. + method SHIFT_FORMULA. CONSTANTS: lcv_operators TYPE string VALUE '+-/*^%=<>&, !', lcv_letters TYPE string VALUE 'ABCDEFGHIJKLMNOPQRSTUVWXYZ$', @@ -2077,10 +1041,10 @@ endmethod. * are copied as well. Cell-references in the formula are being adjusted * by the distance of the new cell to the original one *--------------------------------------------------------------------* -* §1 Parse reference formula character by character -* §2 Identify Cell-references -* §3 Shift cell-reference -* §4 Build resulting formula +* §1 Parse reference formula character by character +* §2 Identify Cell-references +* §3 Shift cell-reference +* §4 Build resulting formula *--------------------------------------------------------------------* *--------------------------------------------------------------------* @@ -2097,7 +1061,7 @@ endmethod. lv_numchars = 1. *--------------------------------------------------------------------* -* §1 Parse reference formula character by character +* §1 Parse reference formula character by character *--------------------------------------------------------------------* DO lv_flen TIMES. @@ -2373,7 +1337,7 @@ endmethod. MOVE lv_cur_form TO ev_resulting_formula. ENDIF. -ENDMETHOD. + endmethod. @@ -2393,7 +1357,7 @@ ENDMETHOD. ENDDO. SET BIT 16 OF r_pwd_hash TO 0. -endmethod. + endmethod. @@ -2420,9 +1384,9 @@ endmethod. SET BIT 1 OF r_pwd_hash TO 0. ENDDO. -endmethod. + endmethod. - + @@ -2468,7 +1432,7 @@ endmethod. ep_file = ip_file(lf_len). ENDIF. -endmethod. + endmethod. @@ -2487,7 +1451,7 @@ endmethod. WHEN OTHERS. "cl_abap_typedescr=>kind_ref or cl_abap_typedescr=>kind_class or cl_abap_typedescr=>kind_intf. * We skip it. for now. ENDCASE. -endmethod. + endmethod. @@ -2507,9 +1471,9 @@ endmethod. CHANGING xt_components = rt_components ) . ENDLOOP. -endmethod. + endmethod. - + method TIME_TO_EXCEL_STRING. @@ -2521,9 +1485,9 @@ endmethod. lv_seconds_in_day = ip_value - lc_time_baseline. lv_day_fraction = lv_seconds_in_day / lc_seconds_in_day. ep_value = zcl_excel_common=>number_to_excel_string( ip_value = lv_day_fraction ). -endmethod. + endmethod. - + @@ -2581,6 +1545,6 @@ endmethod. REPLACE ALL OCCURRENCES OF `''` IN ev_unescaped_string WITH `'`. -endmethod. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER.slnk b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER.slnk index 8f95e16..d6dc26d 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER.slnk @@ -1,5 +1,5 @@ - + + + + + + + + + @@ -126,7 +135,7 @@ TYPES: BEGIN OF ts_color_styles, - METHOD ask_option. + method ASK_OPTION. DATA: ls_sval TYPE sval, lt_sval TYPE STANDARD TABLE OF sval, l_returncode TYPE string, @@ -213,7 +222,7 @@ TYPES: BEGIN OF ts_color_styles, rs_option = ws_option. ENDIF. ENDIF. -ENDMETHOD. + endmethod. @@ -230,7 +239,7 @@ ENDMETHOD. i_col_int = w_col_int ) . ENDIF. -endmethod. + endmethod. @@ -296,10 +305,10 @@ endmethod. endif. endloop. -endmethod. + endmethod. - METHOD class_constructor. + method CLASS_CONSTRUCTOR. DATA: ls_objects TYPE ts_alv_types. DATA: ls_option TYPE zexcel_s_converter_option, l_uname TYPE sy-uname. @@ -338,7 +347,7 @@ endmethod. init_option( ) . ENDIF. -ENDMETHOD. + endmethod. method CLEAN_FIELDCATALOG. @@ -375,7 +384,7 @@ ENDMETHOD. i_decimals = <fs_sfcat>-decimals ). ENDLOOP. -endmethod. + endmethod. @@ -388,7 +397,7 @@ endmethod. - METHOD convert. + method CONVERT. IF is_option IS SUPPLIED. ws_option = is_option. @@ -441,7 +450,7 @@ endmethod. create_worksheet( i_table = i_table i_style_table = i_style_table ) . -ENDMETHOD. + endmethod. @@ -466,7 +475,7 @@ ENDMETHOD. ro_style = lo_style. ENDIF. -endmethod. + endmethod. @@ -484,7 +493,7 @@ endmethod. l_func_num = get_function_number( i_totals_function = i_totals_function ). concatenate 'SUBTOTAL(' l_func_num ',' i_column l_row_alpha_start ':' i_column l_row_alpha_end ')' into r_formula. -endmethod. + endmethod. @@ -499,7 +508,7 @@ endmethod. l_row_e_alpha = i_row_int. concatenate i_totals_function '(' i_column l_row_alpha ':' i_column l_row_e_alpha ')' into r_formula. -endmethod. + endmethod. @@ -556,7 +565,7 @@ endmethod. ENDDO. ENDIF. -endmethod. + endmethod. @@ -573,7 +582,7 @@ endmethod. lo_style->alignment->horizontal = i_alignment. endif. ro_style = lo_style . -endmethod. + endmethod. @@ -604,7 +613,7 @@ endmethod. ro_style = lo_style . ENDIF. -endmethod. + endmethod. @@ -630,7 +639,7 @@ endmethod. endif. ro_style = lo_style. -endmethod. + endmethod. @@ -657,7 +666,7 @@ endmethod. ro_style = lo_style . -endmethod. + endmethod. @@ -700,7 +709,7 @@ endmethod. ro_style = lo_style . -endmethod. + endmethod. method CREATE_TABLE. @@ -768,7 +777,7 @@ endmethod. ENDIF. ENDIF. -endmethod. + endmethod. @@ -793,7 +802,7 @@ endmethod. CLEAR l_func. ENDCASE. - WRITE i_value TO l_string. + MOVE i_value TO l_string. CONCATENATE l_string l_func INTO r_text SEPARATED BY space. @@ -841,7 +850,7 @@ ENDMETHOD. ENDIF. ENDIF. -endmethod. + endmethod. @@ -891,7 +900,7 @@ endmethod. GET REFERENCE OF it_table INTO wo_table. ENDIF. -endmethod. + endmethod. @@ -953,7 +962,7 @@ endmethod. r_style = i_style. ENDIF. -endmethod. + endmethod. @@ -993,7 +1002,7 @@ endmethod. endif. endif. -endmethod. + endmethod. @@ -1026,15 +1035,15 @@ endmethod. when others. clear r_function_number. endcase. -endmethod. + endmethod. - METHOD get_option. + method GET_OPTION. rs_option = ws_option. -ENDMETHOD. + endmethod. @@ -1086,25 +1095,25 @@ ENDMETHOD. INSERT ls_styles INTO TABLE wt_styles. ENDIF. ENDIF. -endmethod. + endmethod. - METHOD init_option. + method INIT_OPTION. ws_option-filter = abap_true. ws_option-hidenc = abap_true. ws_option-subtot = abap_true. -ENDMETHOD. + endmethod. - METHOD loop_normal. + method LOOP_NORMAL. DATA: lo_data TYPE REF TO data, - l_row_header TYPE zexcel_cell_row VALUE '2', + l_row_header TYPE zexcel_cell_row VALUE 2, l_col_header TYPE zexcel_cell_column_alpha VALUE 'B', l_row_int_start TYPE zexcel_cell_row, l_row_int_end TYPE zexcel_cell_row, @@ -1217,7 +1226,7 @@ ENDMETHOD. ip_style = <fs_sfcat>-style_total ). ENDIF. ENDLOOP. -ENDMETHOD. + endmethod. @@ -1227,7 +1236,7 @@ ENDMETHOD. method LOOP_SUBTOTAL. DATA: lo_data TYPE REF TO data, - l_row_header TYPE zexcel_cell_row VALUE '2', + l_row_header TYPE zexcel_cell_row VALUE 2, l_col_header TYPE zexcel_cell_column_alpha VALUE 'B', l_row_int_start TYPE zexcel_cell_row, l_row_int_end TYPE zexcel_cell_row, @@ -1566,7 +1575,7 @@ ENDMETHOD. ENDIF. ENDLOOP. -endmethod. + endmethod. method OPEN_FILE. @@ -1620,7 +1629,7 @@ endmethod. endif. -endmethod. + endmethod. method SET_AUTOFILTER_AREA. @@ -1646,7 +1655,7 @@ endmethod. wo_autofilter->set_filter_area( is_area = ls_area ) . ENDIF. -endmethod. + endmethod. @@ -1673,10 +1682,10 @@ endmethod. r_format = '#,##0'. ENDCASE. -endmethod. + endmethod. - METHOD set_fieldcatalog. + method SET_FIELDCATALOG. DATA: lr_data TYPE REF TO data, lo_structdescr TYPE REF TO cl_abap_structdescr, @@ -1703,11 +1712,11 @@ endmethod. clean_fieldcatalog( ). -ENDMETHOD. + endmethod. - METHOD set_option. + method SET_OPTION. IF ws_indx-begdt IS INITIAL. ws_indx-begdt = sy-datum. @@ -1723,7 +1732,7 @@ ENDMETHOD. ws_option = is_option. ENDIF. -ENDMETHOD. + endmethod. @@ -1751,6 +1760,6 @@ ENDMETHOD. filetype = 'BIN' changing data_tab = lt_file ). endif. -endmethod. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_ALV.slnk b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_ALV.slnk index a230d03..48edf15 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_ALV.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_ALV.slnk @@ -1,6 +1,6 @@ - - + + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -31,7 +31,7 @@ TYPES: BEGIN OF ts_col_converter, - METHOD apply_sort. + method APPLY_SORT. DATA: lt_otab TYPE abap_sortorder_tab, ls_otab TYPE abap_sortorder. @@ -62,7 +62,7 @@ TYPES: BEGIN OF ts_col_converter, SORT <fs_table> BY (lt_otab). ENDIF. -ENDMETHOD. + endmethod. method CLASS_CONSTRUCTOR. @@ -271,12 +271,12 @@ ENDMETHOD. ls_color-fillcolor = 'FFFFFFFF'. " 255 255 255 White INSERT ls_color INTO TABLE wt_colors. -endmethod. + endmethod. - METHOD get_color. + method GET_COLOR. DATA: ls_con_col TYPE zexcel_s_converter_col, ls_color TYPE ts_col_converter, l_line TYPE i, @@ -340,7 +340,7 @@ endmethod. ENDIF. ENDLOOP. ENDIF. -ENDMETHOD. + endmethod. @@ -360,10 +360,10 @@ ENDMETHOD. FIELD-SYMBOLS: <fs_tab> TYPE STANDARD TABLE, <fs_ltab> TYPE STANDARD TABLE, - <fs_stab> TYPE ANY, - <fs> TYPE ANY, - <fs1> TYPE ANY, - <fs_srange> TYPE ANY, + <fs_stab> TYPE any, + <fs> TYPE any, + <fs1> TYPE any, + <fs_srange> TYPE any, <fs_trange> TYPE STANDARD TABLE. IF ws_option-filter = abap_false. @@ -446,7 +446,7 @@ ENDMETHOD. - METHOD update_catalog. + method UPDATE_CATALOG. DATA: ls_fieldcatalog TYPE zexcel_s_converter_fcat, ls_ref TYPE salv_s_ddic_reference, ls_fcat TYPE lvc_s_fcat, @@ -562,6 +562,6 @@ ENDMETHOD. <fs_scat>-sort_level = cs_layout-max_subtotal_level. ENDLOOP. -ENDMETHOD. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_RESULT_WD.slnk b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_RESULT_WD.slnk index d3cc338..8a377e6 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_RESULT_WD.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_CONVERTER_RESULT_WD.slnk @@ -1,5 +1,5 @@ - + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -8,12 +8,12 @@ *"* implementation or private method's signature *"* use this source file for any macro definitions you need *"* in the implementation part of the class - + - + - - + + METHOD ZIF_EXCEL_CONVERTER~CAN_CONVERT_OBJECT. @@ -81,9 +81,9 @@ ENDMETHOD. ENDIF. ENDMETHOD. - - - METHOD create_wt_fcat. + + + method CREATE_WT_FCAT. DATA: lr_data TYPE REF TO data, lo_structdescr TYPE REF TO cl_abap_structdescr, lt_dfies TYPE ddfields, @@ -115,10 +115,10 @@ ENDMETHOD. INSERT ls_fcat INTO TABLE wt_fcat. endloop. -ENDMETHOD. + endmethod. - - METHOD create_wt_filt. + + method CREATE_WT_FILT. * No neeed for superclass. * Only for WD DATA: lt_otab TYPE abap_sortorder_tab, @@ -146,10 +146,10 @@ ENDMETHOD. ENDLOOP. ENDLOOP. -ENDMETHOD. + endmethod. - - METHOD create_wt_sort. + + method CREATE_WT_SORT. DATA: lo_sort TYPE REF TO cl_salv_wd_sort_rule, l_sort_order TYPE salv_wd_constant, ls_sort TYPE lvc_s_sort. @@ -182,11 +182,11 @@ ENDMETHOD. ENDIF. ENDLOOP. -ENDMETHOD. + endmethod. - METHOD get_columns_info. + method GET_COLUMNS_INFO. DATA: l_numc2 TYPE salv_wd_constant. @@ -205,11 +205,11 @@ ENDMETHOD. ENDIF. ENDIF. -ENDMETHOD. + endmethod. - METHOD get_fields_info. + method GET_FIELDS_INFO. DATA: lo_aggr TYPE REF TO cl_salv_wd_aggr_rule, l_aggrtype TYPE salv_wd_constant. @@ -235,6 +235,6 @@ ENDMETHOD. ENDIF. ENDIF. -ENDMETHOD. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_DRAWING.slnk b/ZA2X/CLAS/ZCL_EXCEL_DRAWING.slnk index 6ba5d31..6ba6b3d 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_DRAWING.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_DRAWING.slnk @@ -14,15 +14,15 @@ - - - + + + - - - + + + @@ -112,15 +112,18 @@ - method GET_MEDIA. + METHOD get_media. + + DATA: lv_language TYPE sylangu. + DATA: lt_bin_mime TYPE sdokcntbins. + DATA: lt_mime TYPE tsfmime, + lv_filesize TYPE i, + lv_filesizec(10). + CASE media_source. WHEN c_media_source_xstring. r_media = media. WHEN c_media_source_www. - DATA: lt_mime TYPE tsfmime, - lv_filesize TYPE i, - lv_filesizec(10). - CALL FUNCTION 'WWWDATA_IMPORT' EXPORTING key = media_key_www @@ -149,14 +152,14 @@ failed = 1 OTHERS = 2. WHEN c_media_source_mime. - DATA: lt_bin_mime TYPE sdokcntbins. + lv_language = sy-langu. cl_wb_mime_repository=>load_mime( EXPORTING io = me->io IMPORTING filesize = lv_filesize bin_data = lt_bin_mime CHANGING - language = sy-langu ). + language = lv_language ). CALL FUNCTION 'SCMS_BINARY_TO_XSTRING' EXPORTING @@ -169,7 +172,7 @@ failed = 1 OTHERS = 2. ENDCASE. - endmethod. +ENDMETHOD. @@ -946,26 +949,27 @@ - method SET_MEDIA_MIME. + METHOD set_media_mime. + + DATA: lv_language TYPE sylangu. io = ip_io. media_source = c_media_source_mime. size-width = ip_width. size-height = ip_height. + lv_language = sy-langu. cl_wb_mime_repository=>load_mime( EXPORTING io = ip_io IMPORTING filename = media_name "mimetype = media_type CHANGING - language = sy-langu ). + language = lv_language ). SPLIT media_name AT '.' INTO media_name media_type. - - - endmethod. +ENDMETHOD. diff --git a/ZA2X/CLAS/ZCL_EXCEL_GRAPH.slnk b/ZA2X/CLAS/ZCL_EXCEL_GRAPH.slnk index 60b2b17..d35cf21 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_GRAPH.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_GRAPH.slnk @@ -1,5 +1,5 @@ - + - class ZCL_EXCEL_GRAPH definition - public - create public . - -public section. -*"* public components of class ZCL_EXCEL_GRAPH -*"* do not include other source files here!!! - - types: - BEGIN OF s_style, - c14style type i, - cstyle type i, - end of s_style . - types: - BEGIN OF s_series, - idx TYPE i, - order TYPE i, - invertifnegative TYPE string, - symbol TYPE string, - smooth TYPE string, - lbl TYPE string, - ref TYPE string, - sername TYPE string, - END OF s_series . - types: - t_series TYPE STANDARD TABLE OF s_series . - types: - BEGIN OF s_pagemargins, - b TYPE string, - l TYPE string, - r TYPE string, - t TYPE string, - header TYPE string, - footer TYPE string, - END OF s_pagemargins . - - data NS_1904VAL type STRING value '0'. "#EC NOTEXT . - data NS_LANGVAL type STRING value 'it-IT'. "#EC NOTEXT . - data NS_ROUNDEDCORNERSVAL type STRING value '0'. "#EC NOTEXT . - data PAGEMARGINS type S_PAGEMARGINS . - data NS_AUTOTITLEDELETEDVAL type STRING value '0'. "#EC NOTEXT . - data NS_PLOTVISONLYVAL type STRING value '1'. "#EC NOTEXT . - data NS_DISPBLANKSASVAL type STRING value 'gap'. "#EC NOTEXT . - data NS_SHOWDLBLSOVERMAXVAL type STRING value '0'. "#EC NOTEXT . - data SERIES type T_SERIES . - data NS_C14STYLEVAL type STRING value '102'. "#EC NOTEXT . - data PRINT_LABEL type C value 'X'. "#EC NOTEXT . - data NS_STYLEVAL type STRING value '2'. "#EC NOTEXT . - constants: - BEGIN OF c_style_default, - c14style type i value '102', - cstyle type i value '2', - END OF c_style_default . - constants: - BEGIN OF c_style_1, - c14style type i value '101', - cstyle type i value '1', - END OF c_style_1 . - constants: - BEGIN OF c_style_3, - c14style type i value '103', - cstyle type i value '3', - END OF c_style_3 . - constants: - BEGIN OF c_style_4, - c14style type i value '104', - cstyle type i value '4', - END OF c_style_4 . - constants: - BEGIN OF c_style_5, - c14style type i value '105', - cstyle type i value '5', - END OF c_style_5 . - constants: - BEGIN OF c_style_6, - c14style type i value '106', - cstyle type i value '6', - END OF c_style_6 . - constants: - BEGIN OF c_style_7, - c14style type i value '107', - cstyle type i value '7', - END OF c_style_7 . - constants: - BEGIN OF c_style_8, - c14style type i value '108', - cstyle type i value '8', - END OF c_style_8 . - constants: - BEGIN OF c_style_9, - c14style type i value '109', - cstyle type i value '9', - END OF c_style_9 . - constants: - BEGIN OF c_style_10, - c14style type i value '110', - cstyle type i value '10', - END OF c_style_10 . - constants: - BEGIN OF c_style_11, - c14style type i value '111', - cstyle type i value '11', - END OF c_style_11 . - constants: - BEGIN OF c_style_12, - c14style type i value '112', - cstyle type i value '12', - END OF c_style_12 . - constants: - BEGIN OF c_style_13, - c14style type i value '113', - cstyle type i value '13', - END OF c_style_13 . - constants: - BEGIN OF c_style_14, - c14style type i value '114', - cstyle type i value '14', - END OF c_style_14 . - constants: - BEGIN OF c_style_15, - c14style type i value '115', - cstyle type i value '15', - END OF c_style_15 . - constants: - BEGIN OF c_style_16, - c14style type i value '116', - cstyle type i value '16', - END OF c_style_16 . - constants: - BEGIN OF c_style_17, - c14style type i value '117', - cstyle type i value '17', - END OF c_style_17 . - constants: - BEGIN OF c_style_18, - c14style type i value '118', - cstyle type i value '18', - END OF c_style_18 . - constants: - BEGIN OF c_style_19, - c14style type i value '119', - cstyle type i value '19', - END OF c_style_19 . - constants: - BEGIN OF c_style_20, - c14style type i value '120', - cstyle type i value '20', - END OF c_style_20 . - constants: - BEGIN OF c_style_21, - c14style type i value '121', - cstyle type i value '21', - END OF c_style_21 . - constants: - BEGIN OF c_style_22, - c14style type i value '122', - cstyle type i value '22', - END OF c_style_22 . - constants: - BEGIN OF c_style_23, - c14style type i value '123', - cstyle type i value '23', - END OF c_style_23 . - constants: - BEGIN OF c_style_24, - c14style type i value '124', - cstyle type i value '24', - END OF c_style_24 . - constants: - BEGIN OF c_style_25, - c14style type i value '125', - cstyle type i value '25', - END OF c_style_25 . - constants: - BEGIN OF c_style_26, - c14style type i value '126', - cstyle type i value '26', - END OF c_style_26 . - constants: - BEGIN OF c_style_27, - c14style type i value '127', - cstyle type i value '27', - END OF c_style_27 . - constants: - BEGIN OF c_style_28, - c14style type i value '128', - cstyle type i value '28', - END OF c_style_28 . - constants: - BEGIN OF c_style_29, - c14style type i value '129', - cstyle type i value '29', - END OF c_style_29 . - constants: - BEGIN OF c_style_30, - c14style type i value '130', - cstyle type i value '30', - END OF c_style_30 . - constants: - BEGIN OF c_style_31, - c14style type i value '131', - cstyle type i value '31', - END OF c_style_31 . - constants: - BEGIN OF c_style_32, - c14style type i value '132', - cstyle type i value '32', - END OF c_style_32 . - constants: - BEGIN OF c_style_33, - c14style type i value '133', - cstyle type i value '33', - END OF c_style_33 . - constants: - BEGIN OF c_style_34, - c14style type i value '134', - cstyle type i value '34', - END OF c_style_34 . - constants: - BEGIN OF c_style_35, - c14style type i value '135', - cstyle type i value '35', - END OF c_style_35 . - constants: - BEGIN OF c_style_36, - c14style type i value '136', - cstyle type i value '36', - END OF c_style_36 . - constants: - BEGIN OF c_style_37, - c14style type i value '137', - cstyle type i value '37', - END OF c_style_37 . - constants: - BEGIN OF c_style_38, - c14style type i value '138', - cstyle type i value '38', - END OF c_style_38 . - constants: - BEGIN OF c_style_39, - c14style type i value '139', - cstyle type i value '39', - END OF c_style_39 . - constants: - BEGIN OF c_style_40, - c14style type i value '140', - cstyle type i value '40', - END OF c_style_40 . - constants: - BEGIN OF c_style_41, - c14style type i value '141', - cstyle type i value '41', - END OF c_style_41 . - constants: - BEGIN OF c_style_42, - c14style type i value '142', - cstyle type i value '42', - END OF c_style_42 . - constants: - BEGIN OF c_style_43, - c14style type i value '143', - cstyle type i value '43', - END OF c_style_43 . - constants: - BEGIN OF c_style_44, - c14style type i value '144', - cstyle type i value '44', - END OF c_style_44 . - constants: - BEGIN OF c_style_45, - c14style type i value '145', - cstyle type i value '45', - END OF c_style_45 . - constants: - BEGIN OF c_style_46, - c14style type i value '146', - cstyle type i value '46', - END OF c_style_46 . - constants: - BEGIN OF c_style_47, - c14style type i value '147', - cstyle type i value '47', - END OF c_style_47 . - constants: - BEGIN OF c_style_48, - c14style type i value '148', - cstyle type i value '48', - END OF c_style_48 . - constants C_SHOW_TRUE type C value '1'. "#EC NOTEXT - constants C_SHOW_FALSE type C value '0'. "#EC NOTEXT - constants C_PRINT_LBL_TRUE type C value '1'. "#EC NOTEXT - constants C_PRINT_LBL_FALSE type C value '0'. "#EC NOTEXT - - methods CONSTRUCTOR . - methods CREATE_SERIE - importing - !IP_IDX type I optional - !IP_ORDER type I - !IP_INVERTIFNEGATIVE type STRING optional - !IP_SYMBOL type STRING optional - !IP_SMOOTH type C optional - !IP_LBL_FROM_COL type ZEXCEL_CELL_COLUMN_ALPHA optional - !IP_LBL_FROM_ROW type ZEXCEL_CELL_ROW optional - !IP_LBL_TO_COL type ZEXCEL_CELL_COLUMN_ALPHA optional - !IP_LBL_TO_ROW type ZEXCEL_CELL_ROW optional - !IP_LBL type STRING optional - !IP_REF_FROM_COL type ZEXCEL_CELL_COLUMN_ALPHA optional - !IP_REF_FROM_ROW type ZEXCEL_CELL_ROW optional - !IP_REF_TO_COL type ZEXCEL_CELL_COLUMN_ALPHA optional - !IP_REF_TO_ROW type ZEXCEL_CELL_ROW optional - !IP_REF type STRING optional - !IP_SERNAME type STRING - !IP_SHEET type ZEXCEL_SHEET_TITLE optional . - methods SET_STYLE - importing - !IP_STYLE type S_STYLE . - methods SET_PRINT_LBL - importing - !IP_VALUE type C . - protected section. -*"* protected components of class ZCL_EXCEL_GRAPH -*"* do not include other source files here!!! - private section. -*"* private components of class ZCL_EXCEL_GRAPH -*"* do not include other source files here!!! *"* use this source file for the definition and implementation of *"* local helper classes, interface definitions and type *"* declarations @@ -364,244 +39,244 @@ public section. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -625,7 +300,7 @@ public section. me->pagemargins-t = '0.75'. me->pagemargins-header = '0.3'. me->pagemargins-footer = '0.3'. -endmethod. + endmethod. @@ -645,7 +320,7 @@ endmethod. - METHOD create_serie. + method CREATE_SERIE. DATA ls_serie TYPE s_series. DATA: lv_start_row_c TYPE char7, @@ -688,21 +363,21 @@ endmethod. ls_serie-sername = ip_sername. APPEND ls_serie TO me->series. SORT me->series BY order ASCENDING. -ENDMETHOD. + endmethod. method SET_PRINT_LBL. me->print_label = ip_value. -endmethod. + endmethod. - METHOD set_style. + method SET_STYLE. me->ns_c14styleval = ip_style-c14style. CONDENSE me->ns_c14styleval NO-GAPS. me->ns_styleval = ip_style-cstyle. CONDENSE me->ns_styleval NO-GAPS. -ENDMETHOD. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_RANGE.slnk b/ZA2X/CLAS/ZCL_EXCEL_RANGE.slnk index 3eee92c..4b9a9bb 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_RANGE.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_RANGE.slnk @@ -1,43 +1,5 @@ - - class ZCL_EXCEL_RANGE definition - public - final - create public . - -*"* public components of class ZCL_EXCEL_RANGE -*"* do not include other source files here!!! -public section. - - constants GCV_PRINT_TITLE_NAME type STRING value '_xlnm.Print_Titles'. "#EC NOTEXT - data NAME type ZEXCEL_RANGE_NAME . - data GUID type ZEXCEL_RANGE_GUID . - - methods CONSTRUCTOR . - methods GET_GUID - returning - value(EP_GUID) type ZEXCEL_RANGE_GUID . - methods SET_VALUE - importing - !IP_SHEET_NAME type ZEXCEL_SHEET_TITLE - !IP_START_ROW type ZEXCEL_CELL_ROW - !IP_START_COLUMN type ZEXCEL_CELL_COLUMN_ALPHA - !IP_STOP_ROW type ZEXCEL_CELL_ROW - !IP_STOP_COLUMN type ZEXCEL_CELL_COLUMN_ALPHA . - methods GET_VALUE - returning - value(EP_VALUE) type ZEXCEL_RANGE_VALUE . - methods SET_RANGE_VALUE - importing - !IP_VALUE type ZEXCEL_RANGE_VALUE . - *"* protected components of class ZABAP_EXCEL_WORKSHEET -*"* do not include other source files here!!! -protected section. - *"* private components of class ZCL_EXCEL_RANGE -*"* do not include other source files here!!! -private section. - - data VALUE type ZEXCEL_RANGE_VALUE . + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -50,33 +12,29 @@ private section. - - method CONSTRUCTOR. -endmethod. - - + method GET_GUID. ep_guid = me->guid. -endmethod. + endmethod. - + method GET_VALUE. ep_value = me->value. -endmethod. + endmethod. - + method SET_RANGE_VALUE. me->value = ip_value. -endmethod. + endmethod. - + @@ -96,6 +54,6 @@ endmethod. me->value = zcl_excel_common=>escape_string( ip_value = lv_value ). CONCATENATE me->value '!$' ip_start_column '$' lv_start_row_c ':$' ip_stop_column '$' lv_stop_row_c INTO me->value. -endmethod. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_READER_2007.slnk b/ZA2X/CLAS/ZCL_EXCEL_READER_2007.slnk index 83b5c69..b7bff91 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_READER_2007.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_READER_2007.slnk @@ -11,7 +11,7 @@ "/> - - - - - - - - - - - - - - - *"* local class implementation for public class diff --git a/ZA2X/CLAS/ZCL_EXCEL_SECURITY.slnk b/ZA2X/CLAS/ZCL_EXCEL_SECURITY.slnk index b02e187..26f71bf 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_SECURITY.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_SECURITY.slnk @@ -1,31 +1,5 @@ - - - class ZCL_EXCEL_SECURITY definition - public - final - create public . - -*"* public components of class ZCL_EXCEL_SECURITY -*"* do not include other source files here!!! -public section. - type-pools ABAP . - - data LOCKREVISION type FLAG . - data LOCKSTRUCTURE type FLAG . - data LOCKWINDOWS type FLAG . - data REVISIONSPASSWORD type ZEXCEL_REVISIONSPASSWORD . - data WORKBOOKPASSWORD type ZEXCEL_WORKBOOKPASSWORD . - - methods CONSTRUCTOR . - methods IS_SECURITY_ENABLED - returning - value(EP_SECURITY_ENABLED) type FLAG . - *"* protected components of class ZABAP_EXCEL_SECURITY -*"* do not include other source files here!!! -protected section. - *"* private components of class ZABAP_EXCEL_SECURITY -*"* do not include other source files here!!! -private section. + + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -36,21 +10,17 @@ private section. *"* in the implementation part of the class ABAP - - - - - - - method CONSTRUCTOR. -endmethod. - - - - method IS_SECURITY_ENABLED. + + + + + + + + METHOD is_security_enabled. IF lockrevision EQ abap_true OR lockstructure EQ abap_true OR lockwindows EQ abap_true. ep_security_enabled = abap_true. ENDIF. -endmethod. +ENDMETHOD. diff --git a/ZA2X/CLAS/ZCL_EXCEL_STYLE_BORDERS.slnk b/ZA2X/CLAS/ZCL_EXCEL_STYLE_BORDERS.slnk index d383dc6..bc6e557 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_STYLE_BORDERS.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_STYLE_BORDERS.slnk @@ -1,36 +1,5 @@ - - - class ZCL_EXCEL_STYLE_BORDERS definition - public - final - create public . - -*"* public components of class ZCL_EXCEL_STYLE_BORDERS -*"* do not include other source files here!!! -public section. - - data ALLBORDERS type ref to ZCL_EXCEL_STYLE_BORDER . - constants C_DIAGONAL_BOTH type ZEXCEL_DIAGONAL value 3. "#EC NOTEXT - constants C_DIAGONAL_DOWN type ZEXCEL_DIAGONAL value 2. "#EC NOTEXT - constants C_DIAGONAL_NONE type ZEXCEL_DIAGONAL value 0. "#EC NOTEXT - constants C_DIAGONAL_UP type ZEXCEL_DIAGONAL value 1. "#EC NOTEXT - data DIAGONAL type ref to ZCL_EXCEL_STYLE_BORDER . - data DIAGONAL_MODE type ZEXCEL_DIAGONAL . - data DOWN type ref to ZCL_EXCEL_STYLE_BORDER . - data LEFT type ref to ZCL_EXCEL_STYLE_BORDER . - data RIGHT type ref to ZCL_EXCEL_STYLE_BORDER . - data TOP type ref to ZCL_EXCEL_STYLE_BORDER . - - methods CONSTRUCTOR . - methods GET_STRUCTURE - returning - value(ES_FILL) type ZEXCEL_S_STYLE_BORDER . - *"* protected components of class ZABAP_EXCEL_STYLE_FONT -*"* do not include other source files here!!! -protected section. - *"* private components of class ZCL_EXCEL_STYLE_BORDERS -*"* do not include other source files here!!! -private section. + + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -39,24 +8,20 @@ private section. *"* implementation or private method's signature *"* use this source file for any macro definitions you need *"* in the implementation part of the class - - - - - - - - - - - - - method CONSTRUCTOR. -endmethod. - - - - METHOD get_structure. + + + + + + + + + + + + + + method GET_STRUCTURE. *initialize colors to 'not set' es_fill-left_color-indexed = zcl_excel_style_color=>c_indexed_not_set. es_fill-left_color-theme = zcl_excel_style_color=>c_theme_not_set. @@ -118,6 +83,6 @@ endmethod. ENDCASE. ENDIF. -ENDMETHOD. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_STYLE_COLOR.slnk b/ZA2X/CLAS/ZCL_EXCEL_STYLE_COLOR.slnk index e594806..341e829 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_STYLE_COLOR.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_STYLE_COLOR.slnk @@ -1,57 +1,5 @@ - - - class ZCL_EXCEL_STYLE_COLOR definition - public - final - create public . - -public section. -*"* public components of class ZCL_EXCEL_STYLE_COLOR -*"* do not include other source files here!!! - - constants C_BLACK type ZEXCEL_STYLE_COLOR_ARGB value 'FF000000'. "#EC NOTEXT - constants C_BLUE type ZEXCEL_STYLE_COLOR_ARGB value 'FF0000FF'. "#EC NOTEXT - constants C_DARKBLUE type ZEXCEL_STYLE_COLOR_ARGB value 'FF000080'. "#EC NOTEXT - constants C_DARKGREEN type ZEXCEL_STYLE_COLOR_ARGB value 'FF008000'. "#EC NOTEXT - constants C_DARKRED type ZEXCEL_STYLE_COLOR_ARGB value 'FF800000'. "#EC NOTEXT - constants C_DARKYELLOW type ZEXCEL_STYLE_COLOR_ARGB value 'FF808000'. "#EC NOTEXT - constants C_GRAY type ZEXCEL_STYLE_COLOR_ARGB value 'FFCCCCCC'. "#EC NOTEXT - constants C_GREEN type ZEXCEL_STYLE_COLOR_ARGB value 'FF00FF00'. "#EC NOTEXT - constants C_RED type ZEXCEL_STYLE_COLOR_ARGB value 'FFFF0000'. "#EC NOTEXT - constants C_WHITE type ZEXCEL_STYLE_COLOR_ARGB value 'FFFFFFFF'. "#EC NOTEXT - constants C_YELLOW type ZEXCEL_STYLE_COLOR_ARGB value 'FFFFFF00'. "#EC NOTEXT - constants C_THEME_DARK1 type ZEXCEL_STYLE_COLOR_THEME value '0'. "#EC NOTEXT - constants C_THEME_LIGHT1 type ZEXCEL_STYLE_COLOR_THEME value '1'. "#EC NOTEXT - constants C_THEME_DARK2 type ZEXCEL_STYLE_COLOR_THEME value '2'. "#EC NOTEXT - constants C_THEME_LIGHT2 type ZEXCEL_STYLE_COLOR_THEME value '3'. "#EC NOTEXT - constants C_THEME_ACCENT1 type ZEXCEL_STYLE_COLOR_THEME value '4'. "#EC NOTEXT - constants C_THEME_ACCENT2 type ZEXCEL_STYLE_COLOR_THEME value '5'. "#EC NOTEXT - constants C_THEME_ACCENT3 type ZEXCEL_STYLE_COLOR_THEME value '6'. "#EC NOTEXT - constants C_THEME_ACCENT4 type ZEXCEL_STYLE_COLOR_THEME value '7'. "#EC NOTEXT - constants C_THEME_ACCENT5 type ZEXCEL_STYLE_COLOR_THEME value '8'. "#EC NOTEXT - constants C_THEME_ACCENT6 type ZEXCEL_STYLE_COLOR_THEME value '9'. "#EC NOTEXT - constants C_THEME_HYPERLINK type ZEXCEL_STYLE_COLOR_THEME value '10'. "#EC NOTEXT - constants C_THEME_HYPERLINK_FOLLOWED type ZEXCEL_STYLE_COLOR_THEME value '11'. "#EC NOTEXT - constants C_THEME_NOT_SET type ZEXCEL_STYLE_COLOR_THEME value -1. "#EC NOTEXT - constants C_INDEXED_NOT_SET type ZEXCEL_STYLE_COLOR_INDEXED value -1. "#EC NOTEXT - constants C_INDEXED_SYS_FOREGROUND type ZEXCEL_STYLE_COLOR_INDEXED value 64. "#EC NOTEXT - - methods CONSTRUCTOR . - class-methods CREATE_NEW_ARGB - importing - !IP_RED type ZEXCEL_STYLE_COLOR_COMPONENT - !IP_GREEN type ZEXCEL_STYLE_COLOR_COMPONENT - !IP_BLU type ZEXCEL_STYLE_COLOR_COMPONENT - returning - value(EP_COLOR_ARGB) type ZEXCEL_STYLE_COLOR_ARGB . - *"* protected components of class ZCL_EXCEL_STYLE_COLOR -*"* do not include other source files here!!! -protected section. - private section. -*"* private components of class ZCL_EXCEL_STYLE_COLOR -*"* do not include other source files here!!! - - constants C_ALPHA type CHAR2 value 'FF'. "#EC NOTEXT + + *"* local class implementation for public class *"* use this source file for the implementation part of *"* local helper classes @@ -60,49 +8,43 @@ protected section. *"* implementation or private method's signature *"* use this source file for any macro definitions you need *"* in the implementation part of the class - - - - - - - - - - - - - - - - - - - - - - - - - - - - - method CONSTRUCTOR. - - -endmethod. - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + method CREATE_NEW_ARGB. CONCATENATE zcl_excel_style_color=>c_alpha ip_red ip_green ip_blu INTO ep_color_argb. -endmethod. + endmethod. diff --git a/ZA2X/CLAS/ZCL_EXCEL_TABLE.slnk b/ZA2X/CLAS/ZCL_EXCEL_TABLE.slnk index f18ed07..e91e87a 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_TABLE.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_TABLE.slnk @@ -38,12 +38,7 @@ - - method CONSTRUCTOR. - - endmethod. - - + method GET_BOTTOM_ROW_INTEGER. DATA: lv_table_lines TYPE i. @@ -74,7 +69,7 @@ ov_id = id. endmethod. - + method GET_NAME. @@ -86,7 +81,7 @@ ov_name = me->name. endmethod. - + method GET_REFERENCE. @@ -130,7 +125,7 @@ endmethod. - + method GET_RIGHT_COLUMN_INTEGER. diff --git a/ZA2X/CLAS/ZCL_EXCEL_WORKSHEET.slnk b/ZA2X/CLAS/ZCL_EXCEL_WORKSHEET.slnk index 104915d..7cd92d8 100644 --- a/ZA2X/CLAS/ZCL_EXCEL_WORKSHEET.slnk +++ b/ZA2X/CLAS/ZCL_EXCEL_WORKSHEET.slnk @@ -1,15 +1,15 @@ - - - - @@ -2634,7 +2634,7 @@ ENDCLASS. "lcl_gui_alv_grid DEFINITION CONSTANTS: lc_top_left_column TYPE zexcel_cell_column_alpha VALUE 'B', - lc_top_left_row TYPE zexcel_cell_row VALUE '3'. + lc_top_left_row TYPE zexcel_cell_row VALUE 3. DATA: lv_row_int TYPE zexcel_cell_row, @@ -4797,7 +4797,7 @@ ENDMETHOD. ls_newline TYPE REF TO data, ls_header TYPE x030l, lt_dfies TYPE ddfields, - lv_row_header TYPE zexcel_cell_row VALUE '2', + lv_row_header TYPE zexcel_cell_row VALUE 2, lv_col_header TYPE zexcel_cell_column_alpha VALUE 'B', lv_row_int TYPE zexcel_cell_row, lv_column_int TYPE zexcel_cell_column, diff --git a/ZA2X/INTF/ZIF_EXCEL_SHEET_PROPERTIES.slnk b/ZA2X/INTF/ZIF_EXCEL_SHEET_PROPERTIES.slnk index c5a48f5..071fe19 100644 --- a/ZA2X/INTF/ZIF_EXCEL_SHEET_PROPERTIES.slnk +++ b/ZA2X/INTF/ZIF_EXCEL_SHEET_PROPERTIES.slnk @@ -1,11 +1,11 @@ - - - + + + - - + + diff --git a/ZA2X/PROG/ZDEMO_EXCEL11.slnk b/ZA2X/PROG/ZDEMO_EXCEL11.slnk index 8a77441..3d8f7d4 100644 --- a/ZA2X/PROG/ZDEMO_EXCEL11.slnk +++ b/ZA2X/PROG/ZDEMO_EXCEL11.slnk @@ -1,12 +1,14 @@ - - + + - + + + - + @@ -52,7 +54,7 @@ INCLUDE zdemo_excel_outputopt_incl. PARAMETERS: md TYPE flag RADIOBUTTON GROUP act. -SELECTION-SCREEN BEGIN OF BLOCK a WITH FRAME TITLE a. +SELECTION-SCREEN BEGIN OF BLOCK a WITH FRAME TITLE text-00a. PARAMETERS: partnerc TYPE bu_type DEFAULT 2, " Organizations postlcod TYPE ad_pstcd1 DEFAULT '8334*', country TYPE land1 DEFAULT 'DE', @@ -61,15 +63,11 @@ SELECTION-SCREEN END OF BLOCK a. PARAMETERS: rel TYPE flag RADIOBUTTON GROUP act DEFAULT 'X'. -SELECTION-SCREEN BEGIN OF BLOCK b WITH FRAME TITLE b. +SELECTION-SCREEN BEGIN OF BLOCK b WITH FRAME TITLE text-00b. PARAMETERS: reltyp TYPE bu_reltyp DEFAULT 'BUR011', partner TYPE bu_partner DEFAULT '191'. SELECTION-SCREEN END OF BLOCK b. -INITIALIZATION. - a = 'Select by master data'. - b = 'Select by relationship'. - START-OF-SELECTION. IF md = abap_true. " Read all Companies by Master Data