From 9f94ee3af3f3a85fcb3b03dc96a5c0768f2cf4ab Mon Sep 17 00:00:00 2001 From: larshp Date: Sun, 29 Jul 2018 11:14:48 +0000 Subject: [PATCH 1/3] remove TRY without CATCH --- src/zcl_excel_converter_salv_table.clas.abap | 4 +--- src/zdemo_excel43.prog.abap | 22 +++++++++----------- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/src/zcl_excel_converter_salv_table.clas.abap b/src/zcl_excel_converter_salv_table.clas.abap index 5b03179..beae4c9 100644 --- a/src/zcl_excel_converter_salv_table.clas.abap +++ b/src/zcl_excel_converter_salv_table.clas.abap @@ -223,9 +223,7 @@ ENDMETHOD. METHOD zif_excel_converter~create_fieldcatalog. DATA: lo_salv TYPE REF TO cl_salv_table. - TRY. - zif_excel_converter~can_convert_object( io_object = io_object ). - ENDTRY. + zif_excel_converter~can_convert_object( io_object = io_object ). ws_option = is_option. diff --git a/src/zdemo_excel43.prog.abap b/src/zdemo_excel43.prog.abap index b608374..cdc5467 100644 --- a/src/zdemo_excel43.prog.abap +++ b/src/zdemo_excel43.prog.abap @@ -12,17 +12,17 @@ REPORT zdemo_excel43. "Locally created Structure, which should be equal to the excels structure " TYPES: BEGIN OF lty_excel_s, - dummy TYPE dummy. + dummy TYPE dummy. TYPES: END OF lty_excel_s. DATA lt_tab TYPE TABLE OF lty_excel_s. DATA: lt_filetable TYPE filetable, ls_filetable TYPE file_table. DATA lv_subrc TYPE i. -DATA: lo_excel TYPE REF TO zcl_excel, - lo_reader TYPE REF TO zif_excel_reader, - lo_worksheet TYPE REF TO zcl_excel_worksheet, - lo_salv TYPE REF TO cl_salv_table. +DATA: lo_excel TYPE REF TO zcl_excel, + lo_reader TYPE REF TO zif_excel_reader, + lo_worksheet TYPE REF TO zcl_excel_worksheet, + lo_salv TYPE REF TO cl_salv_table. " "Ask User to choose a path @@ -42,13 +42,11 @@ IF sy-subrc <> 0. WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4. ELSE. CREATE OBJECT lo_reader TYPE zcl_excel_reader_2007. - TRY. - LOOP AT lt_filetable INTO ls_filetable. - lo_excel = lo_reader->load_file( ls_filetable-filename ). - lo_worksheet = lo_excel->get_worksheet_by_index( iv_index = 1 ). - lo_worksheet->get_table( IMPORTING et_table = lt_tab ). - ENDLOOP. - ENDTRY. + LOOP AT lt_filetable INTO ls_filetable. + lo_excel = lo_reader->load_file( ls_filetable-filename ). + lo_worksheet = lo_excel->get_worksheet_by_index( iv_index = 1 ). + lo_worksheet->get_table( IMPORTING et_table = lt_tab ). + ENDLOOP. ENDIF. " "Do the presentation stuff From d1532a347bf7360872032f69f3dacd3ba7d7dcfc Mon Sep 17 00:00:00 2001 From: larshp Date: Sun, 29 Jul 2018 11:16:53 +0000 Subject: [PATCH 2/3] remove double space --- src/zcl_excel_theme_font_scheme.clas.abap | 2 +- src/zdemo_calendar.prog.abap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zcl_excel_theme_font_scheme.clas.abap b/src/zcl_excel_theme_font_scheme.clas.abap index 0c84f05..7e4b302 100644 --- a/src/zcl_excel_theme_font_scheme.clas.abap +++ b/src/zcl_excel_theme_font_scheme.clas.abap @@ -250,7 +250,7 @@ method load. data: lo_minor_iterator type ref to if_ixml_node_iterator. data: lo_minor_element type ref to if_ixml_element. data: ls_font type t_font. - check io_font_scheme is not initial. + check io_font_scheme is not initial. clear font_scheme. font_scheme-name = io_font_scheme->get_attribute( name = c_name ). lo_scheme_children = io_font_scheme->get_children( ). diff --git a/src/zdemo_calendar.prog.abap b/src/zdemo_calendar.prog.abap index 25b92e9..29e3ac5 100644 --- a/src/zdemo_calendar.prog.abap +++ b/src/zdemo_calendar.prog.abap @@ -201,7 +201,7 @@ START-OF-SELECTION. " Get active sheet lo_worksheet = lo_excel->get_active_worksheet( ). ELSE. - lo_worksheet = lo_excel->add_new_worksheet( ). + lo_worksheet = lo_excel->add_new_worksheet( ). ENDIF. lo_worksheet->zif_excel_sheet_properties~selected = zif_excel_sheet_properties=>c_selected. From a5985ea2ead3c498aaa6190547dc8b182c74893b Mon Sep 17 00:00:00 2001 From: larshp Date: Sun, 29 Jul 2018 11:20:21 +0000 Subject: [PATCH 3/3] remove some unreferenced variables --- src/zangry_birds.prog.abap | 3 +-- src/zcl_excel_worksheet.clas.abap | 4 +--- src/zdemo_calendar.prog.abap | 5 ----- src/zdemo_excel11.prog.abap | 4 ---- 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/zangry_birds.prog.abap b/src/zangry_birds.prog.abap index 788d37c..de22d8b 100644 --- a/src/zangry_birds.prog.abap +++ b/src/zangry_birds.prog.abap @@ -35,8 +35,7 @@ DATA: lv_style_color0_guid TYPE zexcel_cell_style, lv_style_color6_guid TYPE zexcel_cell_style, lv_style_color7_guid TYPE zexcel_cell_style, lv_style_credit_guid TYPE zexcel_cell_style, - lv_style_link_guid TYPE zexcel_cell_style, - lv_style TYPE zexcel_cell_style. + lv_style_link_guid TYPE zexcel_cell_style. DATA: lv_col_str TYPE zexcel_cell_column_alpha, lv_row TYPE i, diff --git a/src/zcl_excel_worksheet.clas.abap b/src/zcl_excel_worksheet.clas.abap index 0eba77e..542ad56 100644 --- a/src/zcl_excel_worksheet.clas.abap +++ b/src/zcl_excel_worksheet.clas.abap @@ -3838,9 +3838,7 @@ CLASS ZCL_EXCEL_WORKSHEET IMPLEMENTATION. method GET_COLUMN. - data: LO_COLUMN_ITERATOR type ref to CL_OBJECT_COLLECTION_ITERATOR, - LO_COLUMN type ref to ZCL_EXCEL_COLUMN, - LV_COLUMN type ZEXCEL_CELL_COLUMN. + data: LV_COLUMN type ZEXCEL_CELL_COLUMN. LV_COLUMN = ZCL_EXCEL_COMMON=>CONVERT_COLUMN2INT( IP_COLUMN ). diff --git a/src/zdemo_calendar.prog.abap b/src/zdemo_calendar.prog.abap index 29e3ac5..7ae1a33 100644 --- a/src/zdemo_calendar.prog.abap +++ b/src/zdemo_calendar.prog.abap @@ -46,7 +46,6 @@ INITIALIZATION. START-OF-SELECTION. DATA: lo_excel TYPE REF TO zcl_excel, - lo_excel_writer TYPE REF TO zif_excel_writer, lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_column TYPE REF TO zcl_excel_column, lo_row TYPE REF TO zcl_excel_row, @@ -61,10 +60,6 @@ START-OF-SELECTION. DATA: lo_style_center TYPE REF TO zcl_excel_style, lv_style_center_guid TYPE zexcel_cell_style. - DATA: lv_file TYPE xstring, - lv_bytecount TYPE i, - lt_file_tab TYPE solix_tab. - DATA: lv_full_path TYPE string, image_descr_path TYPE string, lv_file_separator TYPE c. diff --git a/src/zdemo_excel11.prog.abap b/src/zdemo_excel11.prog.abap index c05ae30..220dcb8 100644 --- a/src/zdemo_excel11.prog.abap +++ b/src/zdemo_excel11.prog.abap @@ -199,10 +199,6 @@ START-OF-SELECTION. DATA: row TYPE zexcel_cell_row. - DATA: lv_file TYPE xstring, - lv_bytecount TYPE i, - lt_file_tab TYPE solix_tab. - DATA: lt_field_catalog TYPE zexcel_t_fieldcatalog, ls_table_settings TYPE zexcel_s_table_settings.