From c6e5ad6ee63429c4ee16ba796738c7ee46c9a3d0 Mon Sep 17 00:00:00 2001
From: Abo <andrea@borgia.bo.it>
Date: Sat, 16 Jul 2022 19:38:46 +0200
Subject: [PATCH] adopt default style when setting format for date / time
 (#1025)

* first draft

must check cloning vs uuid assignment, it works but I'm not convinced this is correct

* remove unused class attribute

* fixed unrelated typo

* fixed linter complaints and revised changes

* Delete zexcel_t_sheet_style.ttyp.xml

* Delete zexcel_s_sheet_style.tabl.xml

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
---
 src/zcl_excel_worksheet.clas.abap |  6 ++++--
 src/zcl_excel_worksheet.clas.xml  | 12 ------------
 src/zexcel_s_sheet_style.tabl.xml | 22 ----------------------
 src/zexcel_t_sheet_style.ttyp.xml | 18 ------------------
 4 files changed, 4 insertions(+), 54 deletions(-)
 delete mode 100644 src/zexcel_s_sheet_style.tabl.xml
 delete mode 100644 src/zexcel_t_sheet_style.ttyp.xml

diff --git a/src/zcl_excel_worksheet.clas.abap b/src/zcl_excel_worksheet.clas.abap
index db1837e..4a871a4 100644
--- a/src/zcl_excel_worksheet.clas.abap
+++ b/src/zcl_excel_worksheet.clas.abap
@@ -92,7 +92,6 @@ CLASS zcl_excel_worksheet DEFINITION
     DATA sheet_setup TYPE REF TO zcl_excel_sheet_setup .
     DATA show_gridlines TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT.
     DATA show_rowcolheaders TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT.
-    DATA styles TYPE zexcel_t_sheet_style .
     DATA tabcolor TYPE zexcel_s_tabcolor READ-ONLY .
     DATA column_formulas TYPE mty_th_column_formula READ-ONLY .
     CLASS-DATA:
@@ -3144,7 +3143,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
       rv_guid = ip_style_or_guid.
 
     ELSE.
-      RAISE EXCEPTION TYPE zcx_excel EXPORTING error = 'IP_GUID type must be either REF TO zcl_excel_tyle or zexcel_cell_style'.
+      RAISE EXCEPTION TYPE zcx_excel EXPORTING error = 'IP_GUID type must be either REF TO zcl_excel_style or zexcel_cell_style'.
     ENDIF.
 
   ENDMETHOD.
@@ -3698,6 +3697,9 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
 *                      If not, use default
     DATA: lo_format_code_datetime TYPE zexcel_number_format.
     DATA: stylemapping    TYPE zexcel_s_stylemapping.
+    IF <fs_sheet_content>-cell_style IS INITIAL.
+      <fs_sheet_content>-cell_style = me->excel->get_default_style( ).
+    ENDIF.
     CASE lv_value_type.
       WHEN cl_abap_typedescr=>typekind_date.
         TRY.
diff --git a/src/zcl_excel_worksheet.clas.xml b/src/zcl_excel_worksheet.clas.xml
index f53acab..7b905e8 100644
--- a/src/zcl_excel_worksheet.clas.xml
+++ b/src/zcl_excel_worksheet.clas.xml
@@ -1101,18 +1101,6 @@
      <LANGU>I</LANGU>
      <DESCRIPT>Show Gridlines</DESCRIPT>
     </SEOCOMPOTX>
-    <SEOCOMPOTX>
-     <CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
-     <CMPNAME>STYLES</CMPNAME>
-     <LANGU>E</LANGU>
-     <DESCRIPT>Sheet style table type</DESCRIPT>
-    </SEOCOMPOTX>
-    <SEOCOMPOTX>
-     <CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
-     <CMPNAME>STYLES</CMPNAME>
-     <LANGU>I</LANGU>
-     <DESCRIPT>Sheet style table type</DESCRIPT>
-    </SEOCOMPOTX>
     <SEOCOMPOTX>
      <CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
      <CMPNAME>STYLES_COND</CMPNAME>
diff --git a/src/zexcel_s_sheet_style.tabl.xml b/src/zexcel_s_sheet_style.tabl.xml
deleted file mode 100644
index 9d2dd49..0000000
--- a/src/zexcel_s_sheet_style.tabl.xml
+++ /dev/null
@@ -1,22 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<abapGit version="v1.0.0" serializer="LCL_OBJECT_TABL" serializer_version="v1.0.0">
- <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-  <asx:values>
-   <DD02V>
-    <TABNAME>ZEXCEL_S_SHEET_STYLE</TABNAME>
-    <DDLANGUAGE>E</DDLANGUAGE>
-    <TABCLASS>INTTAB</TABCLASS>
-    <DDTEXT>Sheet style structure</DDTEXT>
-    <EXCLASS>1</EXCLASS>
-   </DD02V>
-   <DD03P_TABLE>
-    <DD03P>
-     <FIELDNAME>GUID</FIELDNAME>
-     <ROLLNAME>ZEXCEL_CELL_STYLE</ROLLNAME>
-     <ADMINFIELD>0</ADMINFIELD>
-     <COMPTYPE>E</COMPTYPE>
-    </DD03P>
-   </DD03P_TABLE>
-  </asx:values>
- </asx:abap>
-</abapGit>
diff --git a/src/zexcel_t_sheet_style.ttyp.xml b/src/zexcel_t_sheet_style.ttyp.xml
deleted file mode 100644
index 68734a7..0000000
--- a/src/zexcel_t_sheet_style.ttyp.xml
+++ /dev/null
@@ -1,18 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<abapGit version="v1.0.0" serializer="LCL_OBJECT_TTYP" serializer_version="v1.0.0">
- <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-  <asx:values>
-   <DD40V>
-    <TYPENAME>ZEXCEL_T_SHEET_STYLE</TYPENAME>
-    <DDLANGUAGE>E</DDLANGUAGE>
-    <ROWTYPE>ZEXCEL_S_SHEET_STYLE</ROWTYPE>
-    <ROWKIND>S</ROWKIND>
-    <DATATYPE>STRU</DATATYPE>
-    <ACCESSMODE>T</ACCESSMODE>
-    <KEYDEF>D</KEYDEF>
-    <KEYKIND>N</KEYKIND>
-    <DDTEXT>Sheet style table type</DDTEXT>
-   </DD40V>
-  </asx:values>
- </asx:abap>
-</abapGit>