adopt default style when setting format for date / time (#1025)

* first draft

must check cloning vs uuid assignment, it works but I'm not convinced this is correct

* remove unused class attribute

* fixed unrelated typo

* fixed linter complaints and revised changes

* Delete zexcel_t_sheet_style.ttyp.xml

* Delete zexcel_s_sheet_style.tabl.xml

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
This commit is contained in:
Abo 2022-07-16 19:38:46 +02:00 committed by GitHub
parent 4ab5bbe961
commit c6e5ad6ee6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 54 deletions

View File

@ -92,7 +92,6 @@ CLASS zcl_excel_worksheet DEFINITION
DATA sheet_setup TYPE REF TO zcl_excel_sheet_setup . DATA sheet_setup TYPE REF TO zcl_excel_sheet_setup .
DATA show_gridlines TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT. DATA show_gridlines TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT.
DATA show_rowcolheaders TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT. DATA show_rowcolheaders TYPE zexcel_show_gridlines READ-ONLY VALUE abap_true ##NO_TEXT.
DATA styles TYPE zexcel_t_sheet_style .
DATA tabcolor TYPE zexcel_s_tabcolor READ-ONLY . DATA tabcolor TYPE zexcel_s_tabcolor READ-ONLY .
DATA column_formulas TYPE mty_th_column_formula READ-ONLY . DATA column_formulas TYPE mty_th_column_formula READ-ONLY .
CLASS-DATA: CLASS-DATA:
@ -3144,7 +3143,7 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
rv_guid = ip_style_or_guid. rv_guid = ip_style_or_guid.
ELSE. ELSE.
RAISE EXCEPTION TYPE zcx_excel EXPORTING error = 'IP_GUID type must be either REF TO zcl_excel_tyle or zexcel_cell_style'. RAISE EXCEPTION TYPE zcx_excel EXPORTING error = 'IP_GUID type must be either REF TO zcl_excel_style or zexcel_cell_style'.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
@ -3698,6 +3697,9 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
* If not, use default * If not, use default
DATA: lo_format_code_datetime TYPE zexcel_number_format. DATA: lo_format_code_datetime TYPE zexcel_number_format.
DATA: stylemapping TYPE zexcel_s_stylemapping. DATA: stylemapping TYPE zexcel_s_stylemapping.
IF <fs_sheet_content>-cell_style IS INITIAL.
<fs_sheet_content>-cell_style = me->excel->get_default_style( ).
ENDIF.
CASE lv_value_type. CASE lv_value_type.
WHEN cl_abap_typedescr=>typekind_date. WHEN cl_abap_typedescr=>typekind_date.
TRY. TRY.

View File

@ -1101,18 +1101,6 @@
<LANGU>I</LANGU> <LANGU>I</LANGU>
<DESCRIPT>Show Gridlines</DESCRIPT> <DESCRIPT>Show Gridlines</DESCRIPT>
</SEOCOMPOTX> </SEOCOMPOTX>
<SEOCOMPOTX>
<CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
<CMPNAME>STYLES</CMPNAME>
<LANGU>E</LANGU>
<DESCRIPT>Sheet style table type</DESCRIPT>
</SEOCOMPOTX>
<SEOCOMPOTX>
<CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
<CMPNAME>STYLES</CMPNAME>
<LANGU>I</LANGU>
<DESCRIPT>Sheet style table type</DESCRIPT>
</SEOCOMPOTX>
<SEOCOMPOTX> <SEOCOMPOTX>
<CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME> <CLSNAME>ZCL_EXCEL_WORKSHEET</CLSNAME>
<CMPNAME>STYLES_COND</CMPNAME> <CMPNAME>STYLES_COND</CMPNAME>

View File

@ -1,22 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_TABL" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<DD02V>
<TABNAME>ZEXCEL_S_SHEET_STYLE</TABNAME>
<DDLANGUAGE>E</DDLANGUAGE>
<TABCLASS>INTTAB</TABCLASS>
<DDTEXT>Sheet style structure</DDTEXT>
<EXCLASS>1</EXCLASS>
</DD02V>
<DD03P_TABLE>
<DD03P>
<FIELDNAME>GUID</FIELDNAME>
<ROLLNAME>ZEXCEL_CELL_STYLE</ROLLNAME>
<ADMINFIELD>0</ADMINFIELD>
<COMPTYPE>E</COMPTYPE>
</DD03P>
</DD03P_TABLE>
</asx:values>
</asx:abap>
</abapGit>

View File

@ -1,18 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_TTYP" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<DD40V>
<TYPENAME>ZEXCEL_T_SHEET_STYLE</TYPENAME>
<DDLANGUAGE>E</DDLANGUAGE>
<ROWTYPE>ZEXCEL_S_SHEET_STYLE</ROWTYPE>
<ROWKIND>S</ROWKIND>
<DATATYPE>STRU</DATATYPE>
<ACCESSMODE>T</ACCESSMODE>
<KEYDEF>D</KEYDEF>
<KEYKIND>N</KEYKIND>
<DDTEXT>Sheet style table type</DDTEXT>
</DD40V>
</asx:values>
</asx:abap>
</abapGit>