Merge pull request #529 from bilencekic/bilencekic-patch-1

Performance improvement for GET_ROW method

src/zcl_excel_rows.clas.abap

@@ -3,45 +3,51 @@
 *----------------------------------------------------------------------*
 *
 *----------------------------------------------------------------------*
-class ZCL_EXCEL_ROWS definition
+CLASS ZCL_EXCEL_ROWS DEFINITION
-  public
+  PUBLIC
-  final
+  FINAL
-  create public .
+  CREATE PUBLIC .
+
 
 *"* public components of class ZCL_EXCEL_ROWS
 *"* do not include other source files here!!!
 *"* protected components of class ZABAP_EXCEL_WORKSHEETS
 *"* do not include other source files here!!!
-public section.
+  PUBLIC SECTION.
+    TYPES:
+      BEGIN OF T_ROWS, " performance improvement #527
+        ROW_INDEX TYPE INT4,
+        ROW       TYPE REF TO ZCL_EXCEL_ROW,
+      END OF T_ROWS.
 
-  methods ADD
+    DATA:
-    importing
+          DT_ROWS TYPE HASHED TABLE OF T_ROWS WITH UNIQUE KEY ROW_INDEX READ-ONLY.
-      !IO_ROW type ref to ZCL_EXCEL_ROW .
+
-  methods CLEAR .
+    METHODS ADD
-  methods CONSTRUCTOR .
+      IMPORTING
-  methods GET
+        !IO_ROW TYPE REF TO ZCL_EXCEL_ROW .
-    importing
+    METHODS CLEAR .
-      !IP_INDEX type I
+    METHODS CONSTRUCTOR .
-    returning
+    METHODS GET
-      value(EO_ROW) type ref to ZCL_EXCEL_ROW .
+      IMPORTING
-  methods GET_ITERATOR
+        !IP_INDEX     TYPE I
-    returning
+      RETURNING
-      value(EO_ITERATOR) type ref to CL_OBJECT_COLLECTION_ITERATOR .
+        VALUE(EO_ROW) TYPE REF TO ZCL_EXCEL_ROW .
-  methods IS_EMPTY
+    METHODS IS_EMPTY
-    returning
+      RETURNING
-      value(IS_EMPTY) type FLAG .
+        VALUE(IS_EMPTY) TYPE FLAG .
-  methods REMOVE
+    METHODS REMOVE
-    importing
+      IMPORTING
-      !IO_ROW type ref to ZCL_EXCEL_ROW .
+        !IO_ROW TYPE REF TO ZCL_EXCEL_ROW .
-  methods SIZE
+    METHODS SIZE
-    returning
+      RETURNING
-      value(EP_SIZE) type I .
+        VALUE(EP_SIZE) TYPE I .
   PROTECTED SECTION.
 *"* private components of class ZABAP_EXCEL_RANGES
 *"* do not include other source files here!!!
   PRIVATE SECTION.
 
-    DATA rows TYPE REF TO cl_object_collection .
+    DATA ROWS TYPE REF TO CL_OBJECT_COLLECTION .
 ENDCLASS.
 
 
@@ -49,44 +55,89 @@ ENDCLASS.
 CLASS ZCL_EXCEL_ROWS IMPLEMENTATION.
 
 
-  METHOD add.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    rows->add( io_row ).
+* | Instance Public Method ZCL_EXCEL_ROWS->ADD
+* +-------------------------------------------------------------------------------------------------+
+* | [--->] IO_ROW                         TYPE REF TO ZCL_EXCEL_ROW
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD ADD.
+
+    DATA:
+          LS_ROW TYPE T_ROWS.
+    LS_ROW-ROW_INDEX = IO_ROW->GET_ROW_INDEX( ).
+    LS_ROW-ROW = IO_ROW.
+    INSERT LS_ROW INTO TABLE DT_ROWS.
+
   ENDMETHOD.                    "ADD
 
 
-  METHOD clear.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    rows->clear( ).
+* | Instance Public Method ZCL_EXCEL_ROWS->CLEAR
+* +-------------------------------------------------------------------------------------------------+
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD CLEAR.
+    CLEAR DT_ROWS[].
+
   ENDMETHOD.                    "CLEAR
 
 
-  METHOD constructor.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
+* | Instance Public Method ZCL_EXCEL_ROWS->CONSTRUCTOR
+* +-------------------------------------------------------------------------------------------------+
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD CONSTRUCTOR.
 
-    CREATE OBJECT rows.
+    CREATE OBJECT ROWS.
 
   ENDMETHOD.                    "CONSTRUCTOR
 
 
-  METHOD get.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    eo_row ?= rows->if_object_collection~get( ip_index ).
+* | Instance Public Method ZCL_EXCEL_ROWS->GET
+* +-------------------------------------------------------------------------------------------------+
+* | [--->] IP_INDEX                       TYPE        I
+* | [<-()] EO_ROW                         TYPE REF TO ZCL_EXCEL_ROW
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD GET.
+    READ TABLE DT_ROWS ASSIGNING FIELD-SYMBOL(<LS_ROW>) WITH TABLE KEY ROW_INDEX = IP_INDEX.
+    IF SY-SUBRC = 0.
+      EO_ROW ?= <LS_ROW>-ROW.
+    ENDIF.
   ENDMETHOD.                    "GET
 
 
-  METHOD get_iterator.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    eo_iterator ?= rows->if_object_collection~get_iterator( ).
+* | Instance Public Method ZCL_EXCEL_ROWS->IS_EMPTY
-  ENDMETHOD.                    "GET_ITERATOR
+* +-------------------------------------------------------------------------------------------------+
+* | [<-()] IS_EMPTY                       TYPE        FLAG
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD IS_EMPTY.
+    DATA(LV_LINES) = LINES( DT_ROWS ).
 
-
+    IF LV_LINES = 0.
-  METHOD is_empty.
+      IS_EMPTY = abap_true.
-    is_empty = rows->if_object_collection~is_empty( ).
+    ELSE.
+      IS_EMPTY = abap_false.
+    ENDIF.
   ENDMETHOD.                    "IS_EMPTY
 
 
-  METHOD remove.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    rows->remove( io_row ).
+* | Instance Public Method ZCL_EXCEL_ROWS->REMOVE
+* +-------------------------------------------------------------------------------------------------+
+* | [--->] IO_ROW                         TYPE REF TO ZCL_EXCEL_ROW
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD REMOVE.
+    DELETE DT_ROWS WHERE ROW_INDEX = IO_ROW->GET_ROW_INDEX( ).
   ENDMETHOD.                    "REMOVE
 
 
-  METHOD size.
+* <SIGNATURE>---------------------------------------------------------------------------------------+
-    ep_size = rows->if_object_collection~size( ).
+* | Instance Public Method ZCL_EXCEL_ROWS->SIZE
+* +-------------------------------------------------------------------------------------------------+
+* | [<-()] EP_SIZE                        TYPE        I
+* +--------------------------------------------------------------------------------------</SIGNATURE>
+  METHOD SIZE.
+    EP_SIZE = LINES( DT_ROWS )..
   ENDMETHOD.                    "SIZE
 ENDCLASS.

src/zcl_excel_worksheet.clas.abap

@@ -4098,20 +4098,14 @@ method GET_RANGES_ITERATOR.
 
 METHOD get_row.
 
-  DATA: lo_row_iterator TYPE REF TO cl_object_collection_iterator,
+* performance improvement for issue #527
-        lo_row          TYPE REF TO zcl_excel_row.
+  READ TABLE ROWS->DT_ROWS ASSIGNING FIELD-SYMBOL(<LS_ROW>) WITH TABLE KEY ROW_INDEX = IP_ROW.
-
+  IF SY-SUBRC = 0.
-  lo_row_iterator = me->get_rows_iterator( ).
+    EO_ROW = <LS_ROW>-ROW.
-  WHILE lo_row_iterator->has_next( ) = abap_true.
-    lo_row ?= lo_row_iterator->get_next( ).
-    IF lo_row->get_row_index( ) = ip_row.
-      eo_row = lo_row.
-      EXIT.
   ENDIF.
-  ENDWHILE.
 
-  IF eo_row IS NOT BOUND.
+  IF EO_ROW IS NOT BOUND.
-    eo_row = me->add_new_row( ip_row ).
+    EO_ROW = ME->ADD_NEW_ROW( IP_ROW ).
   ENDIF.
 
 ENDMETHOD.