SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 13:46:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove no-more-appropriate comments from set_title (#1237)

Browse Source 
These comments are old and useless
This commit is contained in:
sandraros 2024-06-09 20:40:45 +02:00 committed by GitHub
parent e389d2dff5
commit d25eb31d78
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/zcl_excel_worksheet.clas.abap
View File

@ -4505,24 +4505,6 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
METHOD set_title. METHOD set_title.
*--------------------------------------------------------------------*
* ToDos:
* 2do §1 The current coding for replacing a named ranges name
* after renaming a sheet should be checked if it is
* really working if sheetname should be escaped
*--------------------------------------------------------------------*
*--------------------------------------------------------------------*
* issue #230 - Pimp my Code
* - Stefan Schmoecker, (wip ) 2012-12-08
* - ...
* changes: aligning code
* message made to support multilinguality
*--------------------------------------------------------------------*
* issue#243 - ' is not allowed as first character in sheet title
* - Stefan Schmoecker, 2012-12-02
* changes: added additional check for ' as first character
*--------------------------------------------------------------------*
DATA: lo_worksheets_iterator TYPE REF TO zcl_excel_collection_iterator, DATA: lo_worksheets_iterator TYPE REF TO zcl_excel_collection_iterator,
lo_worksheet TYPE REF TO zcl_excel_worksheet, lo_worksheet TYPE REF TO zcl_excel_worksheet,
lv_rangesheetname_old TYPE string, lv_rangesheetname_old TYPE string,
@ -4575,10 +4557,6 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
*--------------------------------------------------------------------* *--------------------------------------------------------------------*
* After changing this worksheet's title we have to adjust * After changing this worksheet's title we have to adjust
* all ranges that are referring to this worksheet. * all ranges that are referring to this worksheet.
*--------------------------------------------------------------------*
* 2do §1 - Check if the following quickfix is solid
* I fear it isn't - but this implementation is better then
* nothing at all since it handles a supposed majority of cases
*--------------------------------------------------------------------* *--------------------------------------------------------------------*
lv_rangesheetname_new = zcl_excel_common=>escape_string( me->title ) && '!'. lv_rangesheetname_new = zcl_excel_common=>escape_string( me->title ) && '!'.