SAP/abap2xlsx
1
0
Fork 0
mirror of https://github.com/abap2xlsx/abap2xlsx.git synced 2025-05-05 13:46:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Normalize variable names, isolate column/row logic

Browse Source 
Refactoring of method ZCL_EXCEL_TABLE=>GET_REFERENCE changed by PR #1279
This commit is contained in:
sandraros 2025-02-08 18:50:39 +00:00
parent 8428eb04d2
commit dbeac84637
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/zcl_excel_table.clas.abap
View File

@ -174,8 +174,8 @@ CLASS zcl_excel_table IMPLEMENTATION.
METHOD get_reference. METHOD get_reference.
DATA: lv_start_column TYPE zexcel_cell_column, DATA: lv_left_column_int TYPE zexcel_cell_column,
lv_end_column TYPE zexcel_cell_column, lv_right_column_int TYPE zexcel_cell_column,
lv_table_lines TYPE i, lv_table_lines TYPE i,
lv_left_column TYPE zexcel_cell_column_alpha, lv_left_column TYPE zexcel_cell_column_alpha,
lv_right_column TYPE zexcel_cell_column_alpha, lv_right_column TYPE zexcel_cell_column_alpha,
@ -187,12 +187,13 @@ CLASS zcl_excel_table IMPLEMENTATION.
FIELD-SYMBOLS: <fs_table> TYPE STANDARD TABLE. FIELD-SYMBOLS: <fs_table> TYPE STANDARD TABLE.
*column *column
lv_start_column = zcl_excel_common=>convert_column2int( settings-top_left_column ). lv_left_column_int = zcl_excel_common=>convert_column2int( settings-top_left_column ).
lv_table_lines = 0. lv_right_column_int = lv_left_column_int - 1.
LOOP AT fieldcat INTO ls_field_catalog WHERE dynpfld EQ abap_true. LOOP AT fieldcat INTO ls_field_catalog WHERE dynpfld EQ abap_true.
ADD 1 TO lv_table_lines. ADD 1 TO lv_right_column_int.
ENDLOOP. ENDLOOP.
lv_end_column = lv_start_column + lv_table_lines - 1. lv_left_column = zcl_excel_common=>convert_column2alpha( lv_left_column_int ).
lv_right_column = zcl_excel_common=>convert_column2alpha( lv_right_column_int ).
*row *row
ASSIGN table_data->* TO <fs_table>. ASSIGN table_data->* TO <fs_table>.
@ -206,11 +207,9 @@ CLASS zcl_excel_table IMPLEMENTATION.
ADD 1 TO lv_bottom_row. ADD 1 TO lv_bottom_row.
ENDIF. ENDIF.
lv_top_row_string = zcl_excel_common=>number_to_excel_string( settings-top_left_row ). lv_top_row_string = |{ settings-top_left_row }|.
lv_bottom_row_string = zcl_excel_common=>number_to_excel_string( lv_bottom_row ). lv_bottom_row_string = |{ lv_bottom_row }|.
lv_left_column = zcl_excel_common=>convert_column2alpha( lv_start_column ).
lv_right_column = zcl_excel_common=>convert_column2alpha( lv_end_column ).
CONCATENATE lv_left_column lv_top_row_string CONCATENATE lv_left_column lv_top_row_string
':' ':'
lv_right_column lv_bottom_row_string INTO ov_reference. lv_right_column lv_bottom_row_string INTO ov_reference.