DDIC reference fixes (#884)

* DATS -> D, and propagate exceptions to caller

* replace sydatum and syuzeit

* ZEXCEL_CONDITIONAL_ABOVE_AVG, change to builtin ty

* fix ZEXCEL_DOCSECURITY

* fix NUMC3

* fix numc3

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

src/zcl_excel_converter.clas.abap

@@ -100,7 +100,7 @@ CLASS zcl_excel_converter DEFINITION
     DATA wt_colors TYPE zexcel_t_converter_col .
     DATA wt_filter TYPE zexcel_t_converter_fil .
     CLASS-DATA wt_objects TYPE tt_alv_types .
-    CLASS-DATA w_fcount TYPE numc3 .
+    CLASS-DATA w_fcount TYPE n LENGTH 3 .
     DATA wt_sort_values TYPE tt_sort_values .
     DATA wt_subtotal_rows TYPE tt_subtotal_rows .
     DATA wt_styles TYPE tt_styles .
@@ -249,7 +249,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_excel_converter IMPLEMENTATION.
+CLASS ZCL_EXCEL_CONVERTER IMPLEMENTATION.
 
 
   METHOD ask_option.

src/zcl_excel_writer_2007.clas.abap

@@ -597,7 +597,7 @@ CLASS zcl_excel_writer_2007 IMPLEMENTATION.
           lo_table           TYPE REF TO zcl_excel_table.
 
     DATA: lv_worksheets_num        TYPE i,
-          lv_worksheets_numc       TYPE numc3,
+          lv_worksheets_numc       TYPE n LENGTH 3,
           lv_xml_node_worksheet_pn TYPE string,
           lv_value                 TYPE string,
           lv_comment_index         TYPE i VALUE 1,  " (+) GGAR
@@ -1075,8 +1075,8 @@ CLASS zcl_excel_writer_2007 IMPLEMENTATION.
           lo_element      TYPE REF TO if_ixml_element.
 
     DATA: lv_value TYPE string,
-          lv_date  TYPE sydatum,
+          lv_date  TYPE d,
-          lv_time  TYPE syuzeit.
+          lv_time  TYPE t.
 
 **********************************************************************
 * STEP 1: Create [Content_Types].xml into the root of the ZIP

src/zcl_excel_writer_csv.clas.abap

@@ -32,23 +32,28 @@ CLASS zcl_excel_writer_csv DEFINITION
   PRIVATE SECTION.
 
     DATA excel TYPE REF TO zcl_excel .
-    CLASS-DATA delimiter TYPE c VALUE ';'. "#EC NOTEXT .  .  .  .  .  .  .  .  . " .
+    CLASS-DATA delimiter TYPE c VALUE ';' ##NO_TEXT.
-    CLASS-DATA enclosure TYPE c VALUE '"'. "#EC NOTEXT .  .  .  .  .  .  .  .  . " .
+    CLASS-DATA enclosure TYPE c VALUE '"' ##NO_TEXT.
-    CLASS-DATA eol TYPE c LENGTH 2 VALUE cl_abap_char_utilities=>cr_lf. "#EC NOTEXT .  .  .  .  .  .  .  .  . " .
+    CLASS-DATA:
+      eol TYPE c LENGTH 2 VALUE cl_abap_char_utilities=>cr_lf ##NO_TEXT.
     CLASS-DATA worksheet_name TYPE zexcel_worksheets_name .
     CLASS-DATA worksheet_index TYPE zexcel_active_worksheet .
 
     METHODS create
       RETURNING
-        VALUE(ep_excel) TYPE xstring .
+        VALUE(ep_excel) TYPE xstring
+      RAISING
+        zcx_excel.
     METHODS create_csv
       RETURNING
-        VALUE(ep_content) TYPE xstring .
+        VALUE(ep_content) TYPE xstring
+      RAISING
+        zcx_excel .
 ENDCLASS.
 
 
 
-CLASS zcl_excel_writer_csv IMPLEMENTATION.
+CLASS ZCL_EXCEL_WRITER_CSV IMPLEMENTATION.
 
 
   METHOD create.
@@ -68,7 +73,7 @@ CLASS zcl_excel_writer_csv IMPLEMENTATION.
            END OF lty_format.
     DATA: lt_format TYPE STANDARD TABLE OF lty_format,
           ls_format LIKE LINE OF lt_format,
-          lv_date   TYPE dats,
+          lv_date   TYPE d,
           lv_tmp    TYPE string,
           lv_time   TYPE c LENGTH 8.
 

src/zexcel_conditional_above_avg.tabl.xml

@@ -12,7 +12,7 @@
    <DD03P_TABLE>
     <DD03P>
      <FIELDNAME>ABOVE_AVERAGE</FIELDNAME>
-     <ROLLNAME>FLAG</ROLLNAME>
+     <ROLLNAME>XSDBOOLEAN</ROLLNAME>
      <ADMINFIELD>0</ADMINFIELD>
      <VALEXI>X</VALEXI>
      <SHLPORIGIN>F</SHLPORIGIN>
@@ -20,7 +20,7 @@
     </DD03P>
     <DD03P>
      <FIELDNAME>EQUAL_AVERAGE</FIELDNAME>
-     <ROLLNAME>FLAG</ROLLNAME>
+     <ROLLNAME>XSDBOOLEAN</ROLLNAME>
      <ADMINFIELD>0</ADMINFIELD>
      <VALEXI>X</VALEXI>
      <SHLPORIGIN>F</SHLPORIGIN>
@@ -28,9 +28,12 @@
     </DD03P>
     <DD03P>
      <FIELDNAME>STANDARD_DEVIATION</FIELDNAME>
-     <ROLLNAME>NUM1</ROLLNAME>
      <ADMINFIELD>0</ADMINFIELD>
-     <COMPTYPE>E</COMPTYPE>
+     <INTTYPE>N</INTTYPE>
+     <INTLEN>000002</INTLEN>
+     <DATATYPE>NUMC</DATATYPE>
+     <LENG>000001</LENG>
+     <MASK>  NUMC</MASK>
     </DD03P>
     <DD03P>
      <FIELDNAME>CELL_STYLE</FIELDNAME>

src/zexcel_docsecurity.dtel.xml

@@ -5,7 +5,6 @@
    <DD04V>
     <ROLLNAME>ZEXCEL_DOCSECURITY</ROLLNAME>
     <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>NUMC1</DOMNAME>
     <HEADLEN>55</HEADLEN>
     <SCRLEN1>10</SCRLEN1>
     <SCRLEN2>15</SCRLEN2>
@@ -16,7 +15,9 @@
     <SCRTEXT_M>DocSecurity</SCRTEXT_M>
     <SCRTEXT_L>DocSecurity</SCRTEXT_L>
     <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
+    <DATATYPE>NUMC</DATATYPE>
+    <LENG>000001</LENG>
+    <OUTPUTLEN>000001</OUTPUTLEN>
    </DD04V>
   </asx:values>
  </asx:abap>

src/zif_excel_writer.intf.abap

@@ -6,5 +6,7 @@ INTERFACE zif_excel_writer
     IMPORTING
       !io_excel      TYPE REF TO zcl_excel
     RETURNING
-      VALUE(ep_file) TYPE xstring .
+      VALUE(ep_file) TYPE xstring
+    RAISING
+      zcx_excel.
 ENDINTERFACE.