From e9386fd022690a64f35674764acbf1e87edf98b3 Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Wed, 6 Oct 2021 08:08:11 +0200
Subject: [PATCH] refactor some ddic uses to builtin (#824)

reference = #692
---
 src/zcl_excel_common.clas.abap        | 14 ++++++++------
 src/zexcel_aes_password.dtel.xml      |  5 +++--
 src/zexcel_cell_column_alpha.dtel.xml |  5 +++--
 src/zexcel_cell_value.dtel.xml        |  3 +--
 4 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/zcl_excel_common.clas.abap b/src/zcl_excel_common.clas.abap
index 615c6ae..d92053a 100644
--- a/src/zcl_excel_common.clas.abap
+++ b/src/zcl_excel_common.clas.abap
@@ -128,11 +128,12 @@ CLASS zcl_excel_common DEFINITION
         VALUE(ep_value) TYPE zexcel_cell_value .
     TYPE-POOLS abap .
     TYPES: t_char10 TYPE c LENGTH 10.
+    TYPES: t_char255 TYPE c LENGTH 255.
     CLASS-METHODS split_file
       IMPORTING
-        !ip_file         TYPE text255
+        !ip_file         TYPE t_char255
       EXPORTING
-        !ep_file         TYPE text255
+        !ep_file         TYPE t_char255
         !ep_extension    TYPE t_char10
         !ep_dotextension TYPE t_char10 .
     CLASS-METHODS calculate_cell_distance
@@ -181,7 +182,7 @@ CLASS zcl_excel_common DEFINITION
     CLASS-DATA c_excel_col_module TYPE int2 VALUE 64. "#EC NOTEXT .  .  .  .  .  .  .  .  .  .  .  .  .  .  . " .
     CLASS-DATA sv_prev_in1  TYPE zexcel_cell_column.
     CLASS-DATA sv_prev_out1 TYPE zexcel_cell_column_alpha.
-    CLASS-DATA sv_prev_in2  TYPE char10.
+    CLASS-DATA sv_prev_in2  TYPE c LENGTH 10.
     CLASS-DATA sv_prev_out2 TYPE zexcel_cell_column.
     CLASS-METHODS structure_case
       IMPORTING
@@ -193,9 +194,10 @@ CLASS zcl_excel_common DEFINITION
         !is_component        TYPE abap_componentdescr
       RETURNING
         VALUE(rt_components) TYPE abap_component_tab .
+    TYPES ty_char1 TYPE c LENGTH 1.
     CLASS-METHODS char2hex
       IMPORTING
-        !i_char      TYPE char1
+        !i_char      TYPE ty_char1
       RETURNING
         VALUE(r_hex) TYPE zexcel_pwd_hash .
     CLASS-METHODS shl01
@@ -280,7 +282,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
   METHOD convert_column2alpha.
 
     DATA: lv_uccpi  TYPE i,
-          lv_text   TYPE sychar02,
+          lv_text   TYPE c LENGTH 2,
           lv_module TYPE int4,
           lv_column TYPE zexcel_cell_column.
 
@@ -351,7 +353,7 @@ CLASS ZCL_EXCEL_COMMON IMPLEMENTATION.
 *--------------------------------------------------------------------*
 
     DATA: lv_column       TYPE zexcel_cell_column_alpha,
-          lv_column_c     TYPE char10,
+          lv_column_c     TYPE c LENGTH 10,
           lv_column_s     TYPE string,
           lv_errormessage TYPE string,                          " Can't pass '...'(abc) to exception-class
           lv_modulo       TYPE i.
diff --git a/src/zexcel_aes_password.dtel.xml b/src/zexcel_aes_password.dtel.xml
index bb70db7..64baf5f 100644
--- a/src/zexcel_aes_password.dtel.xml
+++ b/src/zexcel_aes_password.dtel.xml
@@ -5,7 +5,6 @@
    <DD04V>
     <ROLLNAME>ZEXCEL_AES_PASSWORD</ROLLNAME>
     <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>CHAR50</DOMNAME>
     <HEADLEN>20</HEADLEN>
     <SCRLEN1>10</SCRLEN1>
     <SCRLEN2>15</SCRLEN2>
@@ -16,7 +15,9 @@
     <SCRTEXT_M>AES Password</SCRTEXT_M>
     <SCRTEXT_L>AES Password</SCRTEXT_L>
     <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
+    <DATATYPE>CHAR</DATATYPE>
+    <LENG>000050</LENG>
+    <OUTPUTLEN>000050</OUTPUTLEN>
    </DD04V>
   </asx:values>
  </asx:abap>
diff --git a/src/zexcel_cell_column_alpha.dtel.xml b/src/zexcel_cell_column_alpha.dtel.xml
index 09c97d0..224644e 100644
--- a/src/zexcel_cell_column_alpha.dtel.xml
+++ b/src/zexcel_cell_column_alpha.dtel.xml
@@ -5,7 +5,6 @@
    <DD04V>
     <ROLLNAME>ZEXCEL_CELL_COLUMN_ALPHA</ROLLNAME>
     <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>CHAR3</DOMNAME>
     <HEADLEN>11</HEADLEN>
     <SCRLEN1>06</SCRLEN1>
     <SCRLEN2>11</SCRLEN2>
@@ -16,7 +15,9 @@
     <SCRTEXT_M>Cell Column</SCRTEXT_M>
     <SCRTEXT_L>Cell Column</SCRTEXT_L>
     <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
+    <DATATYPE>CHAR</DATATYPE>
+    <LENG>000003</LENG>
+    <OUTPUTLEN>000003</OUTPUTLEN>
    </DD04V>
   </asx:values>
  </asx:abap>
diff --git a/src/zexcel_cell_value.dtel.xml b/src/zexcel_cell_value.dtel.xml
index a61385c..f5e7db4 100644
--- a/src/zexcel_cell_value.dtel.xml
+++ b/src/zexcel_cell_value.dtel.xml
@@ -5,7 +5,6 @@
    <DD04V>
     <ROLLNAME>ZEXCEL_CELL_VALUE</ROLLNAME>
     <DDLANGUAGE>E</DDLANGUAGE>
-    <DOMNAME>STRING</DOMNAME>
     <HEADLEN>10</HEADLEN>
     <SCRLEN1>10</SCRLEN1>
     <SCRLEN2>15</SCRLEN2>
@@ -16,7 +15,7 @@
     <SCRTEXT_M>Cell Value</SCRTEXT_M>
     <SCRTEXT_L>Cell Value</SCRTEXT_L>
     <DTELMASTER>E</DTELMASTER>
-    <REFKIND>D</REFKIND>
+    <DATATYPE>STRG</DATATYPE>
    </DD04V>
   </asx:values>
  </asx:abap>