From fb4c62d598c97220f237b3beeb97fab2b50d954f Mon Sep 17 00:00:00 2001 From: Abo Date: Sun, 17 Oct 2021 20:08:39 +0200 Subject: [PATCH] remove usage of CHAR5 ( WIP #692 ) (#856) * remove usage of CHAR5 * remove type from class local types * move type declaration Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com> Co-authored-by: Domi Bigl --- src/zcl_excel_graph_bars.clas.abap | 5 +++-- src/zcl_excel_graph_line.clas.abap | 5 +++-- src/zcl_excel_writer_2007.clas.abap | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/zcl_excel_graph_bars.clas.abap b/src/zcl_excel_graph_bars.clas.abap index eaa5883..0c47247 100644 --- a/src/zcl_excel_graph_bars.clas.abap +++ b/src/zcl_excel_graph_bars.clas.abap @@ -9,9 +9,10 @@ CLASS zcl_excel_graph_bars DEFINITION TYPES: *"* public components of class ZCL_EXCEL_GRAPH_BARS *"* do not include other source files here!!! + tv_type TYPE c LENGTH 5, BEGIN OF s_ax, axid TYPE string, - type TYPE char5, + type TYPE tv_type, orientation TYPE string, delete TYPE string, axpos TYPE string, @@ -56,7 +57,7 @@ CLASS zcl_excel_graph_bars DEFINITION METHODS create_ax IMPORTING !ip_axid TYPE string OPTIONAL - !ip_type TYPE char5 + !ip_type TYPE tv_type !ip_orientation TYPE string OPTIONAL !ip_delete TYPE string OPTIONAL !ip_axpos TYPE string OPTIONAL diff --git a/src/zcl_excel_graph_line.clas.abap b/src/zcl_excel_graph_line.clas.abap index fed2987..3a9930e 100644 --- a/src/zcl_excel_graph_line.clas.abap +++ b/src/zcl_excel_graph_line.clas.abap @@ -9,9 +9,10 @@ CLASS zcl_excel_graph_line DEFINITION TYPES: *"* public components of class ZCL_EXCEL_GRAPH_LINE *"* do not include other source files here!!! + tv_type TYPE c LENGTH 5, BEGIN OF s_ax, axid TYPE string, - type TYPE char5, + type TYPE tv_type, orientation TYPE string, delete TYPE string, axpos TYPE string, @@ -54,7 +55,7 @@ CLASS zcl_excel_graph_line DEFINITION METHODS create_ax IMPORTING !ip_axid TYPE string OPTIONAL - !ip_type TYPE char5 + !ip_type TYPE tv_type !ip_orientation TYPE string OPTIONAL !ip_delete TYPE string OPTIONAL !ip_axpos TYPE string OPTIONAL diff --git a/src/zcl_excel_writer_2007.clas.abap b/src/zcl_excel_writer_2007.clas.abap index 70ef5c0..ba8fb15 100644 --- a/src/zcl_excel_writer_2007.clas.abap +++ b/src/zcl_excel_writer_2007.clas.abap @@ -235,12 +235,13 @@ CLASS zcl_excel_writer_2007 DEFINITION CONSTANTS c_off TYPE string VALUE '0'. "#EC NOTEXT CONSTANTS c_on TYPE string VALUE '1'. "#EC NOTEXT CONSTANTS c_xl_printersettings TYPE string VALUE 'xl/printerSettings/printerSettings#.bin'. "#EC NOTEXT + TYPES: tv_charbool TYPE c LENGTH 5. METHODS flag2bool IMPORTING !ip_flag TYPE flag RETURNING - VALUE(ep_boolean) TYPE char5 . + VALUE(ep_boolean) TYPE tv_charbool . ENDCLASS.