From fc211853d238f3d87a6275a9751a498102592566 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Fri, 5 Nov 2021 13:28:15 +0100 Subject: [PATCH] fix syntax error (#873) * enable syntax check * fix syntax error * additional checks * upd --- abaplint.json | 30 ++++++------------------ src/zcl_excel_writer_huge_file.clas.abap | 2 +- 2 files changed, 8 insertions(+), 24 deletions(-) diff --git a/abaplint.json b/abaplint.json index 288651e..2ba0307 100644 --- a/abaplint.json +++ b/abaplint.json @@ -47,7 +47,7 @@ "omit_receiving": true, "prefer_is_not": false, "prefer_xsdbool": true, - "sy_modification": false, + "sy_modification": true, "unused_methods": false, "use_bool_expression": false, "begin_single_include": true, @@ -67,7 +67,7 @@ "reduce_string_templates": true, "forbidden_identifier": false, "try_without_catch": true, - "unknown_types": false, + "unknown_types": true, "prefix_is_current_class": false, "unused_variables": false, "abapdoc": false, @@ -85,10 +85,10 @@ "chain_mainly_declarations": false, "check_abstract": true, "check_comments": false, - "check_ddic": false, + "check_ddic": true, "check_include": true, "check_no_handler_pragma": true, - "check_syntax": false, + "check_syntax": true, "check_text_elements": false, "check_transformation_exists": true, "commented_code": false, @@ -102,7 +102,7 @@ "global_class": true, "identical_form_names": true, "if_in_if": false, - "implement_methods": false, + "implement_methods": true, "in_statement_indentation": false, "indentation": false, "keep_single_parameter_on_one_line": false, @@ -115,27 +115,11 @@ "newline_between_methods": false, "no_public_attributes": false, "object_naming": { - "patternKind": "required", - "ignoreNames": [], - "ignorePatterns": [], "clas": "^ZC(L|X)\\_EXCEL", "intf": "^ZIF\\_EXCEL", - "prog": "^Z", - "fugr": "^Z", "tabl": "^ZEXCEL", "ttyp": "^ZEXCEL", - "dtel": "^ZEXCEL", - "doma": "^Z", - "shlp": "^Z", - "msag": "^Z", - "tran": "^Z", - "enqu": "^EZ", - "auth": "^Z", - "pinf": "^Z", - "idoc": "^Z", - "xslt": "^Z", - "ssfo": "^Z", - "ssst": "^Z" + "dtel": "^ZEXCEL" }, "prefer_returning_to_exporting": false, "preferred_compare_operator": false, @@ -148,7 +132,7 @@ "space_before_dot": false, "sql_escape_host_variables": false, "superclass_final": false, - "tabl_enhancement_category": false, + "tabl_enhancement_category": true, "type_form_parameters": true, "types_naming": false, "unreachable_code": true, diff --git a/src/zcl_excel_writer_huge_file.clas.abap b/src/zcl_excel_writer_huge_file.clas.abap index 0ad113d..c271f92 100644 --- a/src/zcl_excel_writer_huge_file.clas.abap +++ b/src/zcl_excel_writer_huge_file.clas.abap @@ -805,7 +805,7 @@ CLASS zcl_excel_writer_huge_file IMPLEMENTATION. -type = -data_type. IF -type = 's'. -value = me->get_shared_string_index( ip_cell_value = -cell_value - ir_rtf = -rtf_tab ). + it_rtf = -rtf_tab ). ELSE. -value = -cell_value. ENDIF.