* indicate preserve attribute in Excel writer
fix#673
* Update src/zcl_excel_writer_2007.clas.abap
Not sure to understand why it's needed, but no problem to do that
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Do not change sy fields anymore (abaplint)
Fix#704
* forgotten case in zcl_excel_writer_2007
#704
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
In github repository, ZDEMO_CALENDAR_CLASSES seems to not contain a newline character at the end. When pulling it, abapGit creates ABAP source code with newline character at the end -> abapGit indicates a difference. PR to push the newline character at the end.
Co-authored-by: sandra <sandra.rossi@gmail.com>
Fix#715. Replaced with CL_ABAP_UNIT_ASSERT. Class ZCL_EXCEL_AUNIT deleted.
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* first draft of the contributing guidelines
* added link to coding guidelines
* clarified use of github for bugreports vs SCN for usage questions
Co-authored-by: Lars Hvam <larshp@hotmail.com>
I could find only one use of the OS_BOOLEAN DTEL in all of abap2xlsx, precisely in zdemo_excel_outputopt_incl where it is used for the return value of a standard class method, cl_send_request->send.
"send" calls "release" which calls "submit" which finally sets e_sent_to_all to X unless one recipient has issues, in which case it is cleared: for this reason, replacing "IS INITIAL" with "= abap_false" is incorrect and the test should be inverted.
Fix of bug #756
Vietnamese/Emoji should now be rendered in systems before ABAP 7.52
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
* First solution, but wrong
Excel saves table1.xml with _x000d__x000a_ but abap2xlsx doing the same thing makes Excel say it's wrong!? To be analyzed...
* non-final solution
* Fix newline now accepted in table header
Fix of #474, \r\n can now be used in field catalog of table header in bind_table to display text on several lines. ZDEMO_EXCEL22 demonstrates it in first column "Flight Number" on 2 lines.
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
These lines are added to method SET_CELL of ZCL_EXCEL_WORKSHEET:
IF lv_value CS '_x'.
" Issue #761 value "_x0041_" rendered as "A".
" "_x...._", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
" that Excel uses to store special characters, it's interpreted like Unicode character U+....
" for instance "_x0041_" is U+0041 which is "A".
" To not interpret such text, the first underscore is replaced with "_x005f_".
" The value "_x0041_" is to be stored internally "_x005f_x0041_" so that it's rendered like "_x0041_".
" Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
REPLACE ALL OCCURRENCES OF REGEX '_(x[0-9a-fA-F]{4}_)' IN lv_value WITH '_x005f_$1' RESPECTING CASE.
ENDIF.
Co-authored-by: sandraros <sandra.rossi@gmail.com>
* Fix output of "non-XML" characters 672 and 688
Fix#672 ("vietnamese") and #688 ("emoji").
It works for a recent system but unfortunately I can't test it on a old system to make sure that the new method `is_support_non_xml_characters` returns false.
* Remove useless code and rename variables
* Demo "Hello World" in 10 major languages + Emoji
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
