Commit Graph

56 Commits

Author SHA1 Message Date
Bernd
1037898d0c
Update zcl_excel_reader_2007.clas.abap 2024-06-14 15:46:28 +02:00
Bernd
33247032a8
Update zcl_excel_reader_2007.clas.abap 2024-06-14 15:31:43 +02:00
Bernd
be2b57a4fa
Update zcl_excel_reader_2007.clas.abap 2024-06-11 12:03:36 +02:00
Bernd
0c68ff0c79
Update zcl_excel_reader_2007.clas.abap 2024-06-11 11:54:08 +02:00
Bernd
564d60e0f5
Update zcl_excel_reader_2007.clas.abap (#1234) 2024-06-09 10:39:59 +02:00
sandraros
fd2dc14ac2
Support of empty cell address by LOAD (workbook) (#1225)
Fix #1081

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Andrea Borgia <andrea@borgia.bo.it>
2024-05-12 11:57:33 +02:00
Domi Bigl
3cb8f883f1
fix hidden compare values (#1208)
set hidden compare values to constants lc_xml_attr_true and lc_xml_attr_true_int ( 'true' and '1' )
2024-04-27 12:14:29 +02:00
sandraros
cc8fb819ad
Fix freeze and topLeftCell in reader/writer (#1178)
Fix freeze and topLeftCell in reader/writer

Fix #1175
Adds new methods set_pane_top_left_cell and set_sheetview_top_left_cell to zcl_excel_worksheet
2024-01-31 16:23:15 +01:00
sandraros
5f784c8ed6
Fix zoom information in reader and writer (#1177)
Fix #1176
2024-01-19 21:37:06 +01:00
HuprichTo
92809a41e3
Fix unescape string value when not escpaped (#1160)
* BUGFIX: Skip Input without escaped Character

Some special Values, e.g. "TEST_X" were handled like it was an escaped Character, thats because it was not checked if the second conition, an "_" behind it was there

* Adjust Package Description to its Original

* Remove commented Code

Was there for testing, not needed anymore

* Downport to 7.02

Adjust Method Call to apply 7.02 Syntax

* Fix abaplint Issues

* Fix abaplint Issues (again)

---------

Fix #1122 

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2024-01-11 17:35:46 +01:00
sandraros
76a39a7819
Make the reader get the Tables (#1159)
Fix #1158
Fix #1168
2023-12-25 16:36:58 +01:00
Arno
ccda3a0aa8
read all header/footer (odd/even) elements (#1144)
Previously only the "oddFooter" was read and stored. Read the missing elements as well.
2023-10-29 19:09:30 +01:00
sandraros
869dc52e40
Escape/unescape control characters in writer/reader (#1099)
* Escape/unescape control characters

Fix #1098

---------

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2023-04-21 17:51:25 +02:00
pksingh78
b669bdf893
Replace Pass by value with reference (#1027)
#1012
2022-05-19 11:47:35 +02:00
sandraros
e97169a0c3
Reader: custom paper height and width (#984)
Fix #396

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-23 23:00:24 +01:00
Abo
bffb01c7b9
comments support in reader, initial version (#976)
* comments support in reader, initial version

* fixes formatting for unmodified section

* remove spurious cast

hopefully fixes linter complaint

* handle raw text comments

* removed raw text handling (unused)
2022-01-23 16:41:47 +01:00
sandraros
c3204b5c7b
Reader called twice loses formatting (#965)
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 19:39:47 +01:00
sandraros
6a32480e5d
Read XLSX from third-party providers (namespaces) (#935)
* theme namespace

* XLSM and rename namespace default to main

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 17:05:38 +01:00
sandraros
c5eb18acdc
prevent row height zero (#950)
Fix #944

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 10:32:24 +01:00
Lars Hvam
9d0c970682
change FLOAT to F (#949)
* change FLOAT to F

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:50:43 +01:00
Lars Hvam
8d072439da
remove TYPE-POOLS statements (#948)
* remove TYPE-POOLS statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:42:10 +01:00
Lars Hvam
496b51e531
change SYTABIX to I (#947)
* change SYTABIX to I

* another
2022-01-03 21:33:18 +01:00
sandraros
3a4270c11e
Delete code instead of commenting it (#946)
* Detect commented code

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* first batch of modifications

* Last batch of modifications

* Last batch of modifications (again)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-03 08:54:52 +01:00
Lars Hvam
98d67652a9
refactor to use new collection classes (#937)
* refactor to use new collection classes

closes #880

* Update src/zcl_excel.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_comments.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_data_validations.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_drawings.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheets.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_csv.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_huge_file.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_xlsm.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_columns.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_fill_template.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_ranges.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_reader_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_rows.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles_cond.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-01 12:46:10 +01:00
Lars Hvam
dea6cfd9f0
refactor all MOVE statements (#926)
* refactor all MOVE statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 18:11:40 +01:00
sandraros
6532e0e0b5
+ worksheet columns right-to-left (#911)
fix #890

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 09:14:17 +01:00
sandraros
d7011f715c
Fix #893
* first part

* second and last part

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-11-28 20:25:35 +01:00
Mike Pokraka
dbd260da2c
Add exeption handling (#889)
* Add exeption handling

* Lint fixes

* Revert back keywords -> upper case

(test classes of zcl_excel_worksheet)

* revert pretty print->diff shows only excp handl

proposing to create a different pull request with only pretty print

* proposing tiny fixes

1) a few alignment fixes
2) ls_message renamed to lv_message
3) message ... type 'E' -> message ... type 'I' display like 'E' to avoid short dumps

Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-24 19:40:45 +01:00
Domi Bigl
6d12c57f27
fix print titles range read and write #801 (#862)
* fix print titles range read and write

* remove empty line in method definition
2021-10-30 19:54:46 +02:00
sandraros
5da41aaab2
Fix #486 Multiple Styles in One Cell ("rich text format") (#852)
* Final modifications - All good

* Lint 7.02 + reader huge was forgotten

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <sandraros@gmail.com>
2021-10-24 16:07:58 +02:00
sandraros
ec3f73c0e2
Fix #836 new feature "Ignored Errors" (#839)
* Fix SHIFT_FORMULA (issues #727 and #728) (#830) (#838)

Fix SHIFT_FORMULA (issues #727 and #728)

Co-authored-by: Abo <andrea@borgia.bo.it>

Co-authored-by: Abo <andrea@borgia.bo.it>

* Fix #836 new feature "Ignored Errors"

Fix #836

* Lint xsdbool -> boolc
* lint expression as argument -> variable as argumen
* lint remove constructor expression

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix previous merge mistake

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandraros@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-16 13:22:38 +02:00
sandraros
de39aa842a
Modif done but tests not done (#851)
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 15:42:33 +02:00
sandraros
1076b86547
Fix #547 autofilter messed up if several sheets (#821)
Fix #547

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-04 16:50:50 +02:00
sandraros
b9a248dcb4
Fix issue #819 read/write autofilter values (#820)
* Fix issue #819 read/write autofilter values

Fix issue #819

* Code cleanup

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-04 16:47:32 +02:00
sandraros
69d4883773
Do not change sy fields anymore (abaplint) (#797)
Fix #704

Co-authored-by: sandra <sandra.rossi@gmail.com>
2021-09-19 09:49:46 +02:00
Mike Pokraka
2710dd9717
Pretty print (#781)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-28 00:33:22 +02:00
sandraros
e029864bbb
Wrongly changed file size #722 (#741)
* Fix #722 worksheet dimension (last empty rows)

* Fix #722 reduce DIFF quantity (indentations)

Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-07-03 19:07:18 +02:00
sandraros
7b48cd0d90
fix #687 for reading range of hyperlinks (#750)
fix-#687-for-reading-range-of-hyperlinks

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-05-21 21:15:49 +02:00
Lars Hvam
5eae938b01
replace boolean with abap_bool (#694) 2020-09-19 08:11:03 +02:00
Domi Bigl
37ad2fd68a
improve handling of multiple CF rules and ranges (#682) 2020-07-21 22:22:20 +02:00
JuvickAul
1c7e527a3b
Reading corrupted xlsx file (#663)
A cell contained text in the original template. It was lated deleted. But apparently a link to SharedStrings from the cell was not removed. An exception occurred after downloading and opening the file via ZCL_EXCELL_READER_2007 class. All operations until ZCL_EXCEL_READER_2007 were done using other tools.
2020-04-28 17:28:58 +02:00
Lars Hvam
49d78bfe35
remove tabs, remove seq empty lines (#660)
LGTM
2020-04-19 16:15:07 +02:00
Dennis Schaaf
718b15091e
ATC check cleared (#657)
* ATC check cleared

removed SELECT * from USR01
removed empty SELECT...ENDSELECT on URS01

* Removed Inerface method implementation

ZIF_EXCEL_READER~CAN_READ_FILE was implemented but this method is not defined anymore in the Interface.
ATC check failed with incorrect syntax.
Solution: Method implementation deleted.
2020-04-17 11:06:58 +02:00
Dennis Schaaf
84aa650b8e Bugfix range conversion (#628)
When reading xlsx and autofilters are being applied a dump occured when autofilter range was defined like "Sheet1!#REF1"
Such ranges are now ignored so that the xlsx can be read.
2019-09-24 22:35:12 +02:00
Gregor Wolf
d3fd799e5b Remove beak-point + pretty print 2019-02-19 10:08:05 +00:00
Gregor Wolf
8699a5ce48 Implementation for #396
As suggested by @Jitsuryoku
2019-01-29 15:41:43 +01:00
Ivan
3c578c447e
Merge pull request #566 from AtomKrieg/master
modern style exception raise
2018-10-19 15:18:51 -05:00
AtomKrieg
a150c56e0d modern style exception raise 2018-10-19 07:24:31 +03:00
Ivan
1c143fad77
Adding some comment #551
Comments
2018-09-16 17:33:38 -05:00
Ivan
39c906c88d
Close issue #551
Including fix for issue #551
2018-09-16 17:32:06 -05:00