Commit Graph

192 Commits

Author SHA1 Message Date
psio3123
701e8a197e
Enable ValidationStyle (#671)
Enable Validation Style (Error/Warning/...) for Value Lists

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 12:16:28 +02:00
Domi Bigl
37ad2fd68a
improve handling of multiple CF rules and ranges (#682) 2020-07-21 22:22:20 +02:00
srps
5a33253f0e
Bug fix - add INT4 support (#679)
* Bug fix - add INT4 support

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-20 20:58:41 +02:00
Domi Bigl
3b7f7f7b04
get INT8 typekind dynamic (#676) 2020-07-02 06:39:20 +02:00
JuvickAul
1c7e527a3b
Reading corrupted xlsx file (#663)
A cell contained text in the original template. It was lated deleted. But apparently a link to SharedStrings from the cell was not removed. An exception occurred after downloading and opening the file via ZCL_EXCELL_READER_2007 class. All operations until ZCL_EXCEL_READER_2007 were done using other tools.
2020-04-28 17:28:58 +02:00
Lars Hvam
0de59b65c7
upper case interfaces (#662)
* upper case interfaces

* add some naming conventions
2020-04-26 21:07:54 +02:00
Lars Hvam
49d78bfe35
remove tabs, remove seq empty lines (#660)
LGTM
2020-04-19 16:15:07 +02:00
Dennis Schaaf
718b15091e
ATC check cleared (#657)
* ATC check cleared

removed SELECT * from USR01
removed empty SELECT...ENDSELECT on URS01

* Removed Inerface method implementation

ZIF_EXCEL_READER~CAN_READ_FILE was implemented but this method is not defined anymore in the Interface.
ATC check failed with incorrect syntax.
Solution: Method implementation deleted.
2020-04-17 11:06:58 +02:00
bhavesh4321
c48484d6dc
Update zcl_excel_writer_2007.clas.abap (#654)
* Update zcl_excel_writer_2007.clas.abap

* dummy change

* revert

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-24 08:20:08 +01:00
Stefan Rutzmoser
1d76e44a83
Fix: Support ranges without stop row/column (#649)
Co-authored-by: Stefan Rutzmoser <Stefan.Rutzmoser@msg.group>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-17 08:03:31 +01:00
Lars Hvam
8ea5ab07ea update abaplint config to latest (#645)
* update abaplint config to latest

* remove whitespace
2020-01-23 09:00:14 +01:00
Manuel Laggner
df80e6fd74 remove illegal files from the XML (#644)
according to the SAP note 1750204 we can use the method IF_IXML_OSTREAM->SKIP_NON_XML_CHARACTERS to strip out illegal characters for XML rendering.
Since this method needs a kernel version with builtin support, I've made the call dynamically in a try/catch block to support systems with a lower kernel too.

This patch fixes the issues from #298 (at least for us)
2020-01-22 14:40:44 +01:00
Lars Hvam
b9a787afd6 fix REPORT names (#642) 2020-01-04 11:50:47 +01:00
Gregor Wolf
0446c85866
Update link and translation for calendar (#640) 2020-01-01 18:22:33 +01:00
striezl
36ea883d33 Fix #637 (#638)
LGTM. Thanks.
2019-10-30 07:20:30 +01:00
IBN
5053bf93a2 Issue #626 (#636) 2019-10-05 14:13:42 +02:00
Enno
2f7b9482d9 added description column for demo show report (#635)
* added description column for demo show report

* added description column for demo show report 2

2nd try
2019-10-01 16:49:07 +02:00
Gregor Wolf
7712316e9d
Fill second sheed with data to avoid print issues (#630) 2019-09-29 19:52:35 +02:00
mfallen
d104e020f3 Error headerfooter (#603)
Error (again?) when using more than 1 sheet
2019-09-29 19:07:29 +02:00
AtomKrieg
8938dba50f remove boilerplate: create/render ixml_document (#605)
also clear "dead code"
2019-09-29 17:40:48 +02:00
Gregor Wolf
3bee79156d
No line if empty by kwaishang (#629)
* Update zcl_excel_worksheet.clas.abap

Allow int8 type columns

* Option to create empty file 

Allow to create empty excel file even if input table is empty

* Update zcl_excel_worksheet.clas.abap

Add the option to create the file or not if the input table is empty

*  Test report zdemo_excel43 

When using CSV mainly, if the input table is empty, the csv file contained a line with empty fields and separators.
This fooled some automation process thinking there's data to process in the file.
When optional input parameter "iv_no_line_if_empty" of method "zcl_excel_worksheet->bind_table"  is checked, there's no more empty line in this case.

* User demo report 44 instead of 43

Mistake in test program name

* Fix internal renaming of test report 44

* Correct filename and test both cases

* Include test 44
2019-09-29 17:03:03 +02:00
striezl
e02733290f Fix as discussed in issue #623 (#624)
Convert exponential number from excel to ABAP datatype P (packed number)
2019-09-24 22:37:49 +02:00
Dennis Schaaf
84aa650b8e Bugfix range conversion (#628)
When reading xlsx and autofilters are being applied a dump occured when autofilter range was defined like "Sheet1!#REF1"
Such ranges are now ignored so that the xlsx can be read.
2019-09-24 22:35:12 +02:00
striezl
1da0be9fb9 Fix Issue #610 (Error if last column of last row is empty) (#620)
* #610 Error handling in ZCL_EXCEL_WORKSHEET->GET_TA

* #610 Error handling in ZCL_EXCEL_WORKSHEET->GET_TA

* Revert "#610 Error handling in ZCL_EXCEL_WORKSHEET->GET_TA"

This reverts commit 794320fc1b.

* #610 Error handling in ZCL_EXCEL_WORKSHEET->GET_TA

* rebase abaplint.json
2019-09-05 01:05:47 -07:00
Gregor Wolf
f5a6453e3a Adjust to current abapGit format 2019-09-04 21:28:31 -07:00
mfallen
8006c97ceb Pretty Print of zcl_excel_worksheet 2019-02-25 10:25:15 +01:00
mfallen
edb50701b1 Redefinition Header Footer Image
Get errors when using header/footer in more than one sheet
2019-02-21 15:45:27 +01:00
Berreke
66b581391c
Pretty print of zcl_excel_writer_xlsm 2019-02-20 15:17:15 +01:00
Berreke
4f7a64656e
ZCL_EXCEL_WRITER_XLSM add required parameter
create_xl_sheet_rels has a required parameter iv_comment_index. This was not populated in this version. When transporting the transport goes in error because he can't activate this class. adding lv_comment_index like it is in zcl_excel_writer_2007 corrects this problem.
2019-02-20 14:40:44 +01:00
Gregor Wolf
225fa0b29a Add ztest_excel_image_header to demos 2019-02-19 10:09:08 +00:00
Gregor Wolf
d3fd799e5b Remove beak-point + pretty print 2019-02-19 10:08:05 +00:00
Gregor Wolf
09b6b5f162
Merge pull request #595 from mfallen/headerfooter
Header Footer Image
2019-02-19 10:55:44 +01:00
mfallen
d1c74a18e4 Update XSTRING conversion 2019-02-19 07:47:30 +01:00
mfallen
0a17f7f14a IMAGE_HEADER_FOOTER 2019-02-19 07:37:22 +01:00
mfallen
f6b2a0218d Update of Test program 2019-02-19 07:01:14 +01:00
Gregor Wolf
3481ca8b76 Add ZDEMO_EXCEL_COMMENTS to demo 2019-02-18 16:10:37 +00:00
mfallen
d907d03e28 Header Footer Image
including a test program
2019-02-18 07:23:15 +01:00
AtomKrieg
2cb048d5bb new abapgit
fixed some diffs
2019-02-17 21:18:37 +03:00
AtomKrieg
a5194c647b fix comments on second sheet
https://github.com/sapmentors/abap2xlsx/issues/587
2019-02-17 11:35:01 +03:00
AtomKrieg
83d4cc5dd5 Resolved merge conflict by keeping clfinal flag 2019-02-16 10:32:31 +03:00
Gregor Wolf
ec08afe506 700 support#562 2019-02-11 18:36:56 +01:00
Gregor Wolf
42a85aaa18 700 support #562 2019-02-11 17:33:24 +00:00
Gregor Wolf
e45d2c9274 700 support #562 2019-02-11 17:11:56 +00:00
Gregor Wolf
6bf5141b00 Pretty print in GET_TABLE 2019-02-11 17:03:14 +00:00
Gregor Wolf
8a7918eb11 Add example for #565
Example how to use zcl_excel_common%3D>excel_string_to_date
2019-02-11 16:41:01 +00:00
Lars Hvam
f7792bf272
package: remove permissions 2019-02-06 08:48:59 +01:00
Jitsuryoku
3ff18207f7
Add unit of measurement to margin attribute description
Added "in inches" to MARGIN_XXXXXX fields, as an inch is the specified unit of measurement for margins in OpenXML standard (so it cannot be different).
2019-01-31 10:16:58 +02:00
Gregor Wolf
8699a5ce48 Implementation for #396
As suggested by @Jitsuryoku
2019-01-29 15:41:43 +01:00
Gregor Wolf
aaad50440d Support for comments (Issue #180) (#583)
* Read UTF-8 input file correctly

* Classes for cell coments

As contributed by guillaumegarcia13

* Support for comments (Issue #180)

As contributed by guillaumegarcia13
2019-01-23 08:23:09 -06:00
Lars Hvam
6b84761443
update to latest abapGit format (#582)
* update to latest abapGit format

* fix syntax error
2019-01-11 09:46:50 +01:00
Gregor Wolf
095f3d135b Read UTF-8 input file correctly (#576) 2019-01-09 08:29:41 -06:00
MCH123
4ca4991167 Issue #572 - Protect sheet with filter caused Excel error (#577)
Issue #572 - Protect sheet with filter caused Excel error 

Autofilter + sheet protection causes excel error.

Sheet protection must be set BEFORE autofilter in XML.
2019-01-09 08:25:50 -06:00
AtomKrieg
39c1ad1b08 extract unit test methods from zcl_excel_common (#568)
It is necessary to isolate the functionality for unit tests to another class according to the SRP principle.
2018-12-29 04:41:49 -08:00
bohrh
b57484b1fd style at a merged cell #364 (#574)
I implemented the suggested changes and are using it in a customer project. It's working lick a charm
Added demo of new set_area method
2018-12-14 10:59:14 -06:00
Ivan
71f4cee997
Merge pull request #571 from larshp/master
whitespace fixes
2018-12-07 17:11:54 -06:00
CodePerfectionist
a50a26c764
Support for more than 255 conditional formatting rules
Changed conditional formatting priority datafield from int1 to int4
2018-12-05 12:32:01 +01:00
larshp
59f270b682 replace tabs with spaces 2018-11-24 11:12:35 +00:00
larshp
49f7113883 remove double spaces 2018-11-24 11:09:02 +00:00
larshp
faa434ec3e add spaces 2018-11-21 17:50:54 +01:00
AtomKrieg
996dcc39d6 extract unit test methods from zcl_excel_common
It is necessary to isolate the functionality for unit tests to another class according to the SRP principle.
2018-10-29 15:55:48 +03:00
Ivan
3c578c447e
Merge pull request #566 from AtomKrieg/master
modern style exception raise
2018-10-19 15:18:51 -05:00
AtomKrieg
a150c56e0d modern style exception raise 2018-10-19 07:24:31 +03:00
Ivan
1c5db94374
Merge pull request #563 from AtomKrieg/master
Update zcl_excel_writer_2007.clas.abap
2018-09-25 12:38:27 -05:00
AtomKrieg
d150160aea
Update zcl_excel_writer_2007.clas.abap 2018-09-25 18:52:01 +03:00
Ivan
1c143fad77
Adding some comment #551
Comments
2018-09-16 17:33:38 -05:00
Ivan
39c906c88d
Close issue #551
Including fix for issue #551
2018-09-16 17:32:06 -05:00
AtomKrieg
8653c21b89
Update zcl_excel.clas.abap 2018-09-16 12:13:16 +03:00
AtomKrieg
3e51f77be3
Update zcl_excel.clas.abap 2018-09-16 12:11:27 +03:00
AtomKrieg
a1867fd71e
Update zcl_excel.clas.abap 2018-09-16 11:52:49 +03:00
AtomKrieg
284d7db7c1
Update zcl_excel_worksheet.clas.abap 2018-09-16 11:39:01 +03:00
AtomKrieg
03247f23c7
Update zcl_excel_table.clas.abap 2018-09-16 11:36:52 +03:00
AtomKrieg
2f5c41832c
Update zcl_excel_table.clas.abap 2018-09-16 11:36:01 +03:00
AtomKrieg
bf3766a170
Update zcl_excel_style_cond.clas.abap 2018-09-16 11:34:13 +03:00
AtomKrieg
558578fa5e
Update zcl_excel_reader_xlsm.clas.abap 2018-09-16 11:29:40 +03:00
AtomKrieg
4354a8accf
Update zcl_excel_reader_huge_file.clas.abap 2018-09-16 11:28:57 +03:00
AtomKrieg
0945411b94
Update zcl_excel_reader_2007.clas.abap 2018-09-16 11:21:41 +03:00
AtomKrieg
323d91929f
Update zcl_excel_legacy_palette.clas.abap 2018-09-16 11:20:12 +03:00
AtomKrieg
70d8c148ae
Update zcl_excel_drawing.clas.abap 2018-09-16 11:18:21 +03:00
AtomKrieg
539d21bbe2
Update zcl_excel_autofilter.clas.abap 2018-09-16 11:17:01 +03:00
AtomKrieg
1b7cd1a2c1
Update zcl_excel.clas.abap 2018-09-16 11:00:38 +03:00
AtomKrieg
f767b80bfa
Update zcl_excel_worksheet.clas.testclasses.abap 2018-08-20 00:08:42 +03:00
AtomKrieg
bbbf511dd6
Update zcl_excel_worksheet.clas.abap 2018-08-20 00:07:56 +03:00
larshp
a5985ea2ea remove some unreferenced variables 2018-07-29 11:20:21 +00:00
larshp
d1532a347b remove double space 2018-07-29 11:16:53 +00:00
larshp
9f94ee3af3 remove TRY without CATCH 2018-07-29 11:14:48 +00:00
pacojka
7481a0bde3 modify not working on hashtables 2018-07-16 10:30:30 +02:00
pacojka
2217873519 Added hashtables for columns and rows objects 2018-07-14 22:28:35 +02:00
larshp
bdd2bfeb8d Fix syntax warnings in ZDEMO_EXCEL* 2018-06-03 12:19:01 +00:00
larshp
1f896dd025 ZDEMO_CALENDAR_CLASSES fix syntax warnings 2018-06-03 12:16:18 +00:00
Gregor Wolf
4ecb09f839
NetWeaver 7.51 doesn't contain CHAR02 2018-04-22 21:09:29 +02:00
IvanFemia
7bb0ae6e69 Update from latest abapGit 2018-04-13 02:35:19 +00:00
Ivan
f7787a90b5
Revert "Performance improvement for GET_ROW method" 2018-03-27 11:57:41 -05:00
Ivan
bc44a6c7c9
Update zcl_excel_rows.clas.abap 2018-03-21 16:15:51 -05:00
Ivan
4917b88a77
Update zcl_excel_rows.clas.abap 2018-03-20 22:10:45 -05:00
Bilen
2f8b93f2a5
performance improvement for GET_ROW
Iterator logic removed and hash table logic inserted to the GET_ROW method.
2018-03-20 20:53:53 +08:00
Bilen
cb1364b65f
Update zcl_excel_rows.clas.abap 2018-03-20 20:50:10 +08:00
Bilen
66e4ef4793
Performance update for iterator
Iterator is slowing down for read operations, row class reference is now stored in hash table rather than iterator.
2018-03-20 09:32:36 +08:00
Ivan
33e215d075
Merge pull request #518 from christianguenter2/fix_dump
add with missing flag
2018-02-23 17:20:22 -06:00
Christian Günter
4d2aaf049c add 'with unit tests' 2018-01-30 11:13:09 +01:00
Cril2000
0744e0c6c9
Update zcl_excel_writer_csv.clas.abap
Fixed EOL width to handle correctly CRLF
2018-01-30 10:57:01 +01:00