Commit Graph

110 Commits

Author SHA1 Message Date
Abo
37f0427fb3
Merge 29d18c3241 into 08c794f3ca 2025-05-02 22:35:09 +00:00
pksingh78
9fde3924bb
Fix issue 1013 part1 (#1039)
* Replace pass by value with reference

#1013

* Possible sequential read on sorted/hashed table

#1014

* Update src/not_cloud/zcl_excel_converter.clas.locals_def.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* remove comments and old coding

* fix UT errors

* remove more comments and old coding

* Improvements / Fix aesthetic regression on XML

---------

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2025-03-08 19:23:02 +01:00
pksingh78
ca6fda29ed
Replace pass by value with reference (#1037)
* Replace pass by value with reference

#1013

---------

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2025-02-22 16:59:14 +01:00
Lars Hvam
776ff5aa26
normalize_style_parameter: remove check for absolute names (#1167)
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2024-09-13 12:41:08 +02:00
Domi Bigl
b3201166fc
consider time format for cell with calculation (#1263)
fixes #521
2024-08-22 11:46:55 +02:00
sandraros
b5f5d11e1c
Fix default cell format to not use UTCLONG (#1262)
Fix #1261

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-08-18 14:52:53 +02:00
Lars Hvam
4e1931af15
font class cleanup (#1125) 2024-08-07 09:05:50 +02:00
sandraros
0f19081a04
Code to handle the UTCLONG type added in ABAP 7.54 (#1253)
Fix #1252
2024-08-06 14:12:23 +02:00
sandraros
d25eb31d78
Remove no-more-appropriate comments from set_title (#1237)
These comments are old and useless
2024-06-09 20:40:45 +02:00
Bernd
e389d2dff5
Worksheet's method set_title doesn't handle escaped titles and sheetlocal ranges (#1236)
Fix #1235
2024-06-09 20:34:29 +02:00
RixarSAP
c2096d1f9b
Added field WIDTH in field catalog of method BIND_TABLE (#1224)
Fix #1227
2024-05-11 17:34:06 +02:00
Kjetil Kilhavn
f9685c981d
Convert fields with date & time value correctly to just date or just time (#1197)
* Convert fields with date 

Ignore decimals when converting to date and ignore integer when converting to time
Fix #1132

* New ip_exact parameter of excel_string_to_date

- I'm not comfortable about changing the logic in `excel_string_to_date`, in case other people have implemented a "-1 day" fix after the call, so I added a parameter `ip_exact` to keep an ascending compatibility.
- I reused the old structure of unit tests to simplify the diff
- fix #1205 (I added this time issue that you fixed, the original issue mentioned only the date issue)

---------

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-04-20 09:53:31 +02:00
sandraros
a69258e829
set_table to support table components not DDIC (#1204)
Fix #1166
2024-04-13 15:54:22 +02:00
sandraros
cc8fb819ad
Fix freeze and topLeftCell in reader/writer (#1178)
Fix freeze and topLeftCell in reader/writer

Fix #1175
Adds new methods set_pane_top_left_cell and set_sheetview_top_left_cell to zcl_excel_worksheet
2024-01-31 16:23:15 +01:00
larsip
c1a20e870b
Convert currency amount to external format (#1147)
Fix #1145

* Convert currency amount to external format
Fetching currency reference field from ALV and use the value from this field convert the value to external format

* Missing field catalog update

* Little changes proposed

* Code best positioned, delete unused declaration
Latest changes proposed by darnoc312
2023-11-04 17:09:11 +01:00
Daniel Wegner
cf8bb2c501
add iv_end_row to convert_to_table (#1148)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2023-10-29 18:29:51 +01:00
Abo
b4deed2a97
Merge branch 'abap2xlsx:main' into fix-bind_no_filter 2023-01-14 22:40:25 +01:00
Domi Bigl
684c8f71e0
get INT8 typekind dynamic (#1065) 2022-11-20 20:44:47 +01:00
Abo
e314594a2c
Merge branch 'main' into fix-bind_no_filter 2022-08-29 18:11:21 +02:00
Derby
90981b21c5
add METHOD convert_to_table. (#999)
* added METHOD convert_to_table.

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2022-08-29 18:04:16 +02:00
Abo
dfa8c13474
Merge branch 'main' into fix-bind_no_filter 2022-08-12 18:19:34 +02:00
Domi Bigl
bca6db91c3
enable 255 cell header with table binding (#1051)
* add column_name to fcat and link cell to table

add column_name char 255 to table fieldcat - this is used as table name and cell value
link cell to table and fieldcat

* update fieldcat by cell value change

* fix linter errors

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix linter errors

* fix linter errors

* undo PP

* undo PP

* undo PP

* fix colname for totals functions

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-08-07 15:56:26 +02:00
Abo
a24bb9ebb7
Merge branch 'main' into fix-bind_no_filter 2022-07-18 14:22:06 +02:00
Abo
c6e5ad6ee6
adopt default style when setting format for date / time (#1025)
* first draft

must check cloning vs uuid assignment, it works but I'm not convinced this is correct

* remove unused class attribute

* fixed unrelated typo

* fixed linter complaints and revised changes

* Delete zexcel_t_sheet_style.ttyp.xml

* Delete zexcel_s_sheet_style.tabl.xml

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2022-07-16 19:38:46 +02:00
Abo
639066865c
Merge branch 'main' into fix-bind_no_filter 2022-07-15 23:36:30 +02:00
sandraros
11b47ec222
endless loop in bind_table (#1044)
Fix #1043

* endless loop in bind_table
* Handle more than 100 identical texts
* correct typos in comments

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-07-13 20:28:07 +02:00
Andrea Borgia
7085eac57b WIP #807 - enable filter detection
setting "filter" option in method BIND_ALV enables filter detection later;
this happens in GET_FILTER (ZCL_EXCEL_CONVERTER_ALV) which takes the filter, applies it and returns table "et_filter" with the row numbers of the filtered items.
2022-04-16 17:29:08 +00:00
sandraros
211cf550e6
SET_CELL_FORMULA sets formula in wrong cell (#961)
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-19 16:29:33 +01:00
sandraros
f2dd72e76e
SET_CELL use output length for conversion exits (#982)
* SET_CELL use output length for conversion exits

* bind_table: field catalog + demo

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-19 15:59:22 +01:00
sandraros
2973d66594
Refactor headings logic in BIND_TABLE (#960)
* Refactor headings logic in BIND_TABLE

to help proposing a change for #764

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-07 16:37:06 +01:00
sandraros
5bb343a3e4
Fix set_cell overflow big value type int8 (#979)
Fix #977

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-29 18:08:54 +01:00
sandraros
79d0df4dc3
BIND_TABLE incorrect table overlap check (#964)
* draft, not finished

* Final commit

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 19:19:14 +01:00
sandraros
c3481d5d90
GET_TABLE skip bottom empty rows (#959)
Fix #787

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 18:32:56 +01:00
sandraros
7fa137bc94
ip_style TYPE any + add_new_style( io_clone_of = ) (#929)
* ip_style TYPE any + add_new_style( io_clone_of = )

* zdemo_excel2 instead of zdemo_excel1

* Update zcl_excel_worksheet.clas.abap

* Unit tests added + fix demo 2

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-09 13:07:22 +01:00
Lars Hvam
5e1ca6255f
change REFRESH to CLEAR (#954)
* change REFRESH to CLEAR

and remve REFRESH if the variable is always empty

* more refresh

* enable REFRESH obsolete rule

* another

* last two

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-07 09:25:03 +01:00
sandraros
c5eb18acdc
prevent row height zero (#950)
Fix #944

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 10:32:24 +01:00
sandraros
6fcbc5c8a8
ip_columnrow in SET_CELL and other methods (#930)
* get_cell, set_cell, set_area, set_merge

* Test classes + Fixes

* demo simple set_cell in zdemo_excel1

* rename the "normalize" methods + cleanup

* Demonstration programs and few fixes

* added "raising cx_static_check"

* zdemo_excel40 call methods with only IP_RANGE

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 09:44:09 +01:00
Lars Hvam
9d0c970682
change FLOAT to F (#949)
* change FLOAT to F

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:50:43 +01:00
Lars Hvam
8d072439da
remove TYPE-POOLS statements (#948)
* remove TYPE-POOLS statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:42:10 +01:00
sandraros
3a4270c11e
Delete code instead of commenting it (#946)
* Detect commented code

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* first batch of modifications

* Last batch of modifications

* Last batch of modifications (again)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-03 08:54:52 +01:00
Lars Hvam
98d67652a9
refactor to use new collection classes (#937)
* refactor to use new collection classes

closes #880

* Update src/zcl_excel.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_comments.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_data_validations.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_drawings.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheets.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_csv.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_huge_file.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_xlsm.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_columns.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_fill_template.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_ranges.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_reader_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_rows.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles_cond.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-01 12:46:10 +01:00
Lars Hvam
dea6cfd9f0
refactor all MOVE statements (#926)
* refactor all MOVE statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 18:11:40 +01:00
Pascal Möller
49938b0c60
Fix: after BIND_TABLE no columns in object (#731)
* Fix: after BIND_TABLE no columns in object

* fix 4 methods get_{rows|columns}[_iterator]

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-12-24 16:21:42 +01:00
sandraros
3df52da4c2
+ change_area_style (same as change_cell_style, but for area) (#922)
* + change_area_style

New method change_area_style as combination of change_cell_style and set_area_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-24 12:46:31 +01:00
sandraros
0f51d6d884
refactor method change_cell_style in zcl_excel_worksheet (#904)
* refactor worksheet change_cell_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-14 22:57:06 +01:00
sandraros
6532e0e0b5
+ worksheet columns right-to-left (#911)
fix #890

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 09:14:17 +01:00
sandraros
d7011f715c
Fix #893
* first part

* second and last part

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-11-28 20:25:35 +01:00
Mike Pokraka
dbd260da2c
Add exeption handling (#889)
* Add exeption handling

* Lint fixes

* Revert back keywords -> upper case

(test classes of zcl_excel_worksheet)

* revert pretty print->diff shows only excp handl

proposing to create a different pull request with only pretty print

* proposing tiny fixes

1) a few alignment fixes
2) ls_message renamed to lv_message
3) message ... type 'E' -> message ... type 'I' display like 'E' to avoid short dumps

Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-24 19:40:45 +01:00
sandraros
8f65718db4
SET_AREA/SET_AREA_FORMULA: set value or formula for whole area instead top/left only (#869)
* Fix #867

* Behavior to depend on ip_merge / ip_area parameters

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-14 18:36:15 +01:00
Lars Hvam
fd83cbc112
extract font width logic to new class (#882)
* extract font width logic to new class

* rename importing parameters

* fixes

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.testclasses.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* fix syntax

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-11 10:19:41 +01:00