Commit Graph

864 Commits

Author SHA1 Message Date
sandraros
9684b02af2 Fix all syntax check warnings
Fix #874
2022-01-08 11:14:04 +00:00
Lars Hvam
5e1ca6255f
change REFRESH to CLEAR (#954)
* change REFRESH to CLEAR

and remve REFRESH if the variable is always empty

* more refresh

* enable REFRESH obsolete rule

* another

* last two

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-07 09:25:03 +01:00
sandraros
c5eb18acdc
prevent row height zero (#950)
Fix #944

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 10:32:24 +01:00
sandraros
6fcbc5c8a8
ip_columnrow in SET_CELL and other methods (#930)
* get_cell, set_cell, set_area, set_merge

* Test classes + Fixes

* demo simple set_cell in zdemo_excel1

* rename the "normalize" methods + cleanup

* Demonstration programs and few fixes

* added "raising cx_static_check"

* zdemo_excel40 call methods with only IP_RANGE

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 09:44:09 +01:00
Lars Hvam
87b8291ea2
remove use of DTEL SYLANGU and DTEL GUID_16 (#953)
* remove use of DTEL SYLANGU

* and GUID_16

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-05 21:39:55 +01:00
Lars Hvam
8d63df6ba6
refactor CONVERT_COLUMN2INT (#952)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-05 21:29:37 +01:00
Lars Hvam
38160bc781
move converter classes to not_cloud package (#951)
* move converter classes to not_cloud package

* STRINGVAL to STRING

* fix whitespace

* fix SYBATCH

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-05 21:19:14 +01:00
sandraros
3ef605e74a
Sandraros/check demo regressions 2 (#940)
* remove sy-datum/sy-uzeit from demo programs

* Fixed data for all demo programs

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-05 10:31:48 +01:00
Lars Hvam
9d0c970682
change FLOAT to F (#949)
* change FLOAT to F

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:50:43 +01:00
Lars Hvam
8d072439da
remove TYPE-POOLS statements (#948)
* remove TYPE-POOLS statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:42:10 +01:00
Lars Hvam
496b51e531
change SYTABIX to I (#947)
* change SYTABIX to I

* another
2022-01-03 21:33:18 +01:00
sandraros
3a4270c11e
Delete code instead of commenting it (#946)
* Detect commented code

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* first batch of modifications

* Last batch of modifications

* Last batch of modifications (again)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-03 08:54:52 +01:00
Gregor Wolf
a5e4bb9c77
add column for photographer, improve formatting (#943)
* add column for photographer, improve formatting

* Update src/demos/zdemo_calendar.prog.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/demos/zdemo_calendar.prog.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-02 12:05:16 +01:00
sandraros
9ee01464fc
keyword_case upper (#942)
* keyword to upper case (using class builder)

(methods in zcl_excel_style_changer were automatically reordered)

* keyword upper case of local implementations

* Update src/zcl_excel_style_changer.clas.abap

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-02 08:23:57 +01:00
Lars Hvam
98d67652a9
refactor to use new collection classes (#937)
* refactor to use new collection classes

closes #880

* Update src/zcl_excel.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_comments.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_data_validations.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_drawings.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheets.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_csv.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_huge_file.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_xlsm.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_columns.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_fill_template.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_ranges.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_reader_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_rows.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles_cond.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-01 12:46:10 +01:00
sandraros
f16a3cc9b2
Allow more than 255 sheets per workbook (#934)
Fix #530

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-29 05:42:09 +01:00
Gregor Wolf
2818544c9a
Domain for ZEXCEL_SHEET_TITLE (#936) 2021-12-28 23:35:01 +01:00
sandraros
9e90a307c1
Demo WebDynpro: ICF, button text, MIME type (#928)
* * add ICF Service to demo webdynpro

* WDA MIME application/vnd.openxmlformats-officed...

* * empty button text -> text "download"

* Custom "download" OTR text for Demo WDA

* Demo WDA button text Download dynamically (no OTR)

(to overcome issue https://github.com/abapGit/abapGit/issues/5232)

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-27 21:54:21 +01:00
Lars Hvam
26a42d8bdb
ddic, fix UUID and GUID_16 (#924)
* ddic, fix DOMA UUID

* fix DTEL GUID_16

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-25 21:22:49 +01:00
Abo
c55cf528fd
fix typo: hasehd -> hashed (#927)
* fix typo: hasehd -> hashed

* make "hasehd" types private

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 19:20:40 +01:00
Lars Hvam
dea6cfd9f0
refactor all MOVE statements (#926)
* refactor all MOVE statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 18:11:40 +01:00
Abo
a35c91face
remove DTEL INTTYPE (#898)
* first draft - remove INTTYPE

* rewrite inttype as char

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 17:02:52 +01:00
Pascal Möller
49938b0c60
Fix: after BIND_TABLE no columns in object (#731)
* Fix: after BIND_TABLE no columns in object

* fix 4 methods get_{rows|columns}[_iterator]

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-12-24 16:21:42 +01:00
sandraros
3df52da4c2
+ change_area_style (same as change_cell_style, but for area) (#922)
* + change_area_style

New method change_area_style as combination of change_cell_style and set_area_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-24 12:46:31 +01:00
sandraros
df709ace6a
customizable demo 25 + backend in demo 37 (#909)
and removing demo 25 from zdemo_excel (no interest).

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-21 10:00:09 +01:00
sandraros
6efa4c6904
Reflect new abap2xlsx project URL (#920) 2021-12-18 18:20:04 +01:00
Christian Günter
a479c0b337
Fix enhancement categories of several structures (#918)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-18 12:22:57 +01:00
Abo
74a3559b28
Fix links after org. move (#919)
* change links to new org

* fixed links

* fixed links
2021-12-15 06:54:32 +01:00
sandraros
0f51d6d884
refactor method change_cell_style in zcl_excel_worksheet (#904)
* refactor worksheet change_cell_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-14 22:57:06 +01:00
Christian Aasan
7898a21548
Correcting broken links after moving of repo (#916)
The link to the documentation and abapGit installation instructions are broken after the move.
2021-12-12 15:37:37 +01:00
sandraros
cb315c5572
Reader fails for workbook with chart (#910)
* Reader fails for workbook with chart

fix #790

* pretty printer

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 13:21:01 +01:00
sandraros
6532e0e0b5
+ worksheet columns right-to-left (#911)
fix #890

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 09:14:17 +01:00
Lars Hvam
41196fd58a
README.md, update urls (#914) 2021-12-12 09:13:19 +01:00
sandraros
6ffcba1aa1
# Huge writer error height/hight and fit to page (#912)
Fix #553

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-12-11 11:21:50 +01:00
sandraros
3eaf645fe2
Error on year 2021 -> 2020 (#901) 2021-12-04 12:14:02 +01:00
Lars Hvam
adde441cd2
remove use of DOMA INT2 (#899)
use builtin type instead, ref #692

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-03 15:25:17 +01:00
Lars Hvam
730ab2f174
remove use of DTEL DSTRING (#900)
use builtin type instead, ref #692

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-03 12:21:52 +01:00
sandraros
a5a1d65c3a
changelog (#887)
* zcl_excel_apack version 7.14.0

* Create changelog.txt

* Proposing a bigger changelog FWIW

* zcl_excel=>version = '7.14.0'

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-03 09:58:01 +01:00
sandraros
3167c6a8f2
huge reader reading cells multiple styles (#897)
* huge reader reading cells multiple styles

Fix #614

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-29 14:40:22 +01:00
sandraros
d7011f715c
Fix #893
* first part

* second and last part

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-11-28 20:25:35 +01:00
Mike Pokraka
dbd260da2c
Add exeption handling (#889)
* Add exeption handling

* Lint fixes

* Revert back keywords -> upper case

(test classes of zcl_excel_worksheet)

* revert pretty print->diff shows only excp handl

proposing to create a different pull request with only pretty print

* proposing tiny fixes

1) a few alignment fixes
2) ls_message renamed to lv_message
3) message ... type 'E' -> message ... type 'I' display like 'E' to avoid short dumps

Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-24 19:40:45 +01:00
Abo
68707e1469
split convert_column2alpha (#892) 2021-11-21 16:44:10 +01:00
sandraros
8f65718db4
SET_AREA/SET_AREA_FORMULA: set value or formula for whole area instead top/left only (#869)
* Fix #867

* Behavior to depend on ip_merge / ip_area parameters

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-14 18:36:15 +01:00
Lars Hvam
fd83cbc112
extract font width logic to new class (#882)
* extract font width logic to new class

* rename importing parameters

* fixes

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.testclasses.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* fix syntax

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-11 10:19:41 +01:00
Lars Hvam
ea40b6860e
DDIC reference fixes (#884)
* DATS -> D, and propagate exceptions to caller

* replace sydatum and syuzeit

* ZEXCEL_CONDITIONAL_ABOVE_AVG, change to builtin ty

* fix ZEXCEL_DOCSECURITY

* fix NUMC3

* fix numc3

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-07 20:44:40 +01:00
Lars Hvam
d80521c747
add collection classes (#883)
* add collection classes

first step of #880

* pp
2021-11-07 20:33:46 +01:00
Abo
74345edd32
split tests for shift_formula (#886) 2021-11-07 15:57:54 +01:00
Lars Hvam
d60571434d
worksheet: remove unused header variable (#876)
* workseet: remove unused header variable

* pretty print with SE80

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-06 17:23:36 +01:00
Lars Hvam
a83d322a87
pretty print zcl_excel_worksheet.clas.testclasses (#877)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-06 17:02:42 +01:00
Lars Hvam
a82056b285
change use of DOMA INT1 to builtin (#879) 2021-11-06 12:18:56 +01:00