Commit Graph

766 Commits

Author SHA1 Message Date
Lars Hvam
9cc7da37cb
upadte to latest abapGit format (#808)
https://github.com/abapGit/abapGit/blob/main/changelog.txt

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-09-26 10:03:34 +02:00
Lars Hvam
24ae5ecef2
zcl_excel_common: unit tests cleanup (#806)
* common: unit tests cleanup

* refactor macro to method

* refactor macro to method

* delete old commented lines (method definitions char2hex and number_to_excel_string)

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-09-26 09:57:36 +02:00
Lars Hvam
10b8df9b2f
remove use of aunit class (#809)
* remove use of aunit class

* aunit
2021-09-26 09:40:24 +02:00
sandraros
e72e4ea6a9
Fix issue 704 lint sy fields modified (#802)
* Do not change sy fields anymore (abaplint)

Fix #704

* forgotten case in zcl_excel_writer_2007

#704

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-23 07:19:02 +02:00
sandraros
ae76133265
abapGit diff says source has changed (#804)
In github repository, ZDEMO_CALENDAR_CLASSES seems to not contain a newline character at the end. When pulling it, abapGit creates ABAP source code with newline character at the end -> abapGit indicates a difference. PR to push the newline character at the end.

Co-authored-by: sandra <sandra.rossi@gmail.com>
2021-09-19 13:17:59 +02:00
Lars Hvam
5fa4f838b6
update abaplint configuration to latest (#798) 2021-09-19 11:23:22 +02:00
sandraros
8abf2adf9f
Move non-Cloud code to separate package (#795)
Fix of issue #717

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-19 09:56:37 +02:00
sandraros
41d5553181
Replace useless ZCL_EXCEL_AUNIT (#796)
Fix #715. Replaced with CL_ABAP_UNIT_ASSERT. Class ZCL_EXCEL_AUNIT deleted.

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-19 09:53:58 +02:00
sandraros
69d4883773
Do not change sy fields anymore (abaplint) (#797)
Fix #704

Co-authored-by: sandra <sandra.rossi@gmail.com>
2021-09-19 09:49:46 +02:00
sandraros
3b80566fa8
Fix so that empty Excel date -> ABAP date 00000000 (#792)
issue #703

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-09-14 22:57:45 +02:00
Abo
1cb2e42328
remove remaining usage of XFELD (#775)
followup #714
WIP #692

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:14:05 +02:00
Abo
530d4661f2
first draft of the contributing guidelines ( WIP #768 ) (#769)
* first draft of the contributing guidelines

* added link to coding guidelines

* clarified use of github for bugreports vs SCN for usage questions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-21 11:00:16 +02:00
Abo
0064ae0a40
remove usage of CHAR07 domain (#754)
* remove CHAR07

See #692

* fixed formatting

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-16 08:52:21 +02:00
Mike Pokraka
2710dd9717
Pretty print (#781)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-28 00:33:22 +02:00
sandraros
6edf73b01d
Create coding-guidelines.md (#778)
#773
2021-07-27 12:32:23 +02:00
Abo
e03fd5596d
remove usage of CHAR08 DTEL (#776)
WIP #692

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-10 17:49:40 +02:00
Abo
bd8f75537f
remove usage of CHAR10 domain (#777)
WIP #692
2021-07-10 17:30:23 +02:00
Abo
2120bc00ee
remove usage of OS_BOOLEAN (#774)
I could find only one use of the OS_BOOLEAN DTEL in all of abap2xlsx, precisely in zdemo_excel_outputopt_incl where it is used for the return value of a standard class method, cl_send_request->send.

"send" calls "release" which calls "submit" which finally sets e_sent_to_all to X unless one recipient has issues, in which case it is cleared: for this reason, replacing "IS INITIAL" with "= abap_false" is incorrect and the test should be inverted.
2021-07-10 11:40:59 +02:00
Abo
beaac0a28a
remove unused DOMA (#772)
fix #770
2021-07-09 18:35:40 +02:00
sandraros
e029864bbb
Wrongly changed file size #722 (#741)
* Fix #722 worksheet dimension (last empty rows)

* Fix #722 reduce DIFF quantity (indentations)

Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-07-03 19:07:18 +02:00
Gregor Wolf
0a3beaf7f8
fix #765 and pretty pring (#766) 2021-06-29 15:39:35 +02:00
sandraros
5110f924b4
Fix Vietnamese/Emoji not rendered #756 (#757)
Fix of bug #756
Vietnamese/Emoji should now be rendered in systems before ABAP 7.52

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-26 14:18:40 +02:00
sandraros
8c92b12d6f
Fix 474 newline in table header (#763)
* First solution, but wrong

Excel saves table1.xml with _x000d__x000a_ but abap2xlsx doing the same thing makes Excel say it's wrong!? To be analyzed...

* non-final solution

* Fix newline now accepted in table header

Fix of #474, \r\n can now be used in field catalog of table header in bind_table to display text on several lines. ZDEMO_EXCEL22 demonstrates it in first column "Flight Number" on 2 lines.

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-21 23:24:30 +02:00
sandraros
f4312ebf5d
Fix #761 (#762)
These lines are added to method SET_CELL of ZCL_EXCEL_WORKSHEET:
    IF lv_value CS '_x'.
      " Issue #761 value "_x0041_" rendered as "A".
      " "_x...._", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
      " that Excel uses to store special characters, it's interpreted like Unicode character U+....
      " for instance "_x0041_" is U+0041 which is "A".
      " To not interpret such text, the first underscore is replaced with "_x005f_".
      " The value "_x0041_" is to be stored internally "_x005f_x0041_" so that it's rendered like "_x0041_".
      " Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
      REPLACE ALL OCCURRENCES OF REGEX '_(x[0-9a-fA-F]{4}_)' IN lv_value WITH '_x005f_$1' RESPECTING CASE.
    ENDIF.

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-06-21 23:20:57 +02:00
Lars Hvam
18ff2dfc3c
update linter config to latest (#759) 2021-06-04 15:48:13 +02:00
Jaime Rodriguez Capote
32306262b2
Remove 15 chars. limit at encrypt password (#758) 2021-06-03 17:31:06 +02:00
sandraros
7b48cd0d90
fix #687 for reading range of hyperlinks (#750)
fix-#687-for-reading-range-of-hyperlinks

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-05-21 21:15:49 +02:00
sandraros
6eac42678c
Unicode characters not written to excel (#743)
* Fix output of "non-XML" characters 672 and 688

Fix #672 ("vietnamese") and #688 ("emoji").
It works for a recent system but unfortunately I can't test it on a old system to make sure that the new method `is_support_non_xml_characters` returns false.

* Remove useless code and rename variables

* Demo "Hello World" in 10 major languages + Emoji

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-05-21 20:28:17 +02:00
AlexandreHT
85dd442551
Update of DEMO31 as advised in #558 (#744)
Set_auto_size needs lo_worksheet->calculate_column_widths( ) to work
2021-05-19 22:42:22 +02:00
Abo
7fd9e3cbe0
remove CHAR01 (#753)
see #692
2021-05-17 11:21:17 +02:00
Abo
53b19eda8d
remove "BOOLEAN" domain (#746)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 13:14:42 +02:00
Abo
adf2c63ec8
use ZABAP2XLSX message class (#752)
related to #659
2021-04-19 12:55:00 +02:00
Abo
a9be231d99
remove CHAR_02 domain (#747)
WIP #692

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-20 14:20:06 +01:00
Abo
6b7d38cd8b
abapGit format update (#748) 2021-03-20 14:19:03 +01:00
sandraros
a0e234958b
AUnit warning zcl excel reader huge file "# au > "#au #739 (#742)
* Fix #739 AUnit warning ZCL_EXCEL_READER_HUGE_FILE

Useless warning in ABAP Unit tests of ZCL_EXCEL_READER_HUGE_FILE (reason: extra space "# AU -> "#AU) #739

* remove #AU everywhere in abap2xlsx

Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-02-21 16:12:15 +01:00
Abo
0a907d27de
Remove doma ZEXCEL_BOOLE01 (#738)
* remove ZEXCEL_SHEET_PROTECTION_BOOL

this dtel uses doma ZEXCEL_BOOLE01

* remove ZEXCEL_CONDITIONAL_SHOW_VALUE

this dtel uses doma ZEXCEL_BOOLE01

* ZEXCEL_BOOLE01

it was used by:
dtel ZEXCEL_SHEET_PROTECTION_BOOL
dtel ZEXCEL_CONDITIONAL_SHOW_VALUE

* fixed spurious edit of .abapgit.xml
2021-02-21 11:21:07 +01:00
Pascal Möller
bd8975ec66
Possibility to get the fieldcatalog with mandt (#732)
* Possibility to get the fieldcatalog with mandt

In some cases i need the mandt in the table.
Normally it is hidden but can be displayed if necessary

* adjusted code style
2021-02-10 09:08:57 +01:00
Abo
976c3c1d3c
cleanup types in zif_excel_book_protection (#721)
* cleanup types in zif_excel_book_protection

fixes #720

* cleanup types in zif_excel_book_protection 

fixes #720
2021-02-04 14:12:03 +01:00
Abo
ccd0fb8740
fixes #716 (#719)
* changed demo links

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-09 12:07:10 +01:00
Abo
f11a2762cf
fixes #716 (#718)
* removed broken screenshots on plinky.it (parked domain)
* added disclaimer
2021-01-09 11:48:36 +01:00
Abo
6c92a7f1ee
remove XFELD (#714)
see https://github.com/sapmentors/abap2xlsx/issues/692
2021-01-04 16:59:45 +01:00
Gregor Wolf
41823b64c9
Dynamic prefill of date (#713) 2021-01-02 10:35:42 +01:00
Stefan Rutzmoser
719fe85ef8
Fix in demo 11: Field-symbol usage (#712)
Do not rely on IF ... IS ASSIGNED for a field symbol inside a LOOP
2020-11-19 10:10:48 +01:00
Abo
482d04b1b3
Update abapGit-installation.md (#711) 2020-11-18 05:59:50 +01:00
Gregor Wolf
240f8cc126
Improve Documentaiton (#710)
* Cleanup dead links in Wiki

* Prefil question title with [abap2xlsx]
2020-11-11 10:22:47 +01:00
Gregor Wolf
7dd3e882fd
Improvements to the readme and documentation (#709) 2020-11-10 19:04:54 +01:00
Stefan Rutzmoser
1c276c6027
Fix package errors (#708)
* Fix package check errors

* Bump version number to 7.2.0
2020-11-10 18:21:38 +01:00
Stefan Rutzmoser
74c1a543cd
Feature: Enable custom converters (#707)
* Feature: Enable custom converters

Added method get_supported_class to ZIF_EXCEL_CONVERTER.

Implement your own converter by implementing this interface
and tell via the new interface method which class you support.

All instanceable implementations of the interface will be found
automatically.

* Fix abapLint issues
2020-11-05 13:16:47 +01:00
Lars Hvam
5bc24b234c
update linter config, omit RECEIVING (#705) 2020-10-10 17:37:13 +02:00
Domi Bigl
17461f911b
move some includes and WDA to demo package (#702) 2020-10-07 12:15:17 +02:00