Commit Graph

983 Commits

Author SHA1 Message Date
pksingh78
9fde3924bb
Fix issue 1013 part1 (#1039)
* Replace pass by value with reference

#1013

* Possible sequential read on sorted/hashed table

#1014

* Update src/not_cloud/zcl_excel_converter.clas.locals_def.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* remove comments and old coding

* fix UT errors

* remove more comments and old coding

* Improvements / Fix aesthetic regression on XML

---------

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2025-03-08 19:23:02 +01:00
pksingh78
ca6fda29ed
Replace pass by value with reference (#1037)
* Replace pass by value with reference

#1013

---------

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2025-02-22 16:59:14 +01:00
Lars Hvam
a1af09f064
Create SECURITY.md: Reporting Security Issues (#1289)
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2025-02-09 16:29:59 +01:00
Domi Bigl
8428eb04d2
usea APLHA for cols in reference string (#1279)
fixes #1215
2025-02-08 19:47:27 +01:00
sandraros
13da36b7a2
Dump ITAB_DUPLICATE in reader=>load_shared_strings (#1288)
Fix #1287
2025-02-08 10:02:22 +01:00
Oliver Hütköper
4eb3df1611
Options to skip hidden rows and columns for CSV format (#1268)
* Options to skip hidden rows and columns for CSV format

Add options to skip hidden rows and columns when saving the data in CSV format. This is especially useful, when converting an ALV to an Excel object and saving it as CSV file. ALV layouts often display only selected columns.

* Adding missing data definition

Adding missing data definition for lo_autofilter.

* Fix dates not converterted to external format

Method get_default_excel_date_format of class zcl_excel_worksheet uses language "E" (English) to determine the date format from domain XUDATFM. 
Method create_csv of class zcl_excel_writer_csv has a logic to determine the field type from the number format. For this also the values from domain XUDATFM are used. But here they are read with sy-langu. Due to this, fields are not correctly identified as "date" when the user language is not English.

Solution: Additionally read domain values with language "E".

* Trigger filter area validation

Trigger filter area validation

* Fix date identification logic for newer AS ABAP versions

The texts of domain XUDATFM changed in newer systems:
NW 7.40: DD.MM.YYYY
NW 7.52: DD.MM.YYYY (Gregorian Date)

This breaks the date identification logic.

New logic copied from get_date_format_des of class cl_abap_datfm, which is called in method get_default_excel_date_format of class zcl_excel_worksheet to get the users default date pattern.

* Performance improvement for skip hidden rows

Performance improvement for skip hidden rows

---------

Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2025-01-05 15:16:30 +01:00
Domi Bigl
bae673121b
Fix dump for GUI download (#1276)
* fix gui download dump
* remove detailed exceptions
2024-10-25 20:10:59 +02:00
Lars Hvam
776ff5aa26
normalize_style_parameter: remove check for absolute names (#1167)
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2024-09-13 12:41:08 +02:00
Bernd
f6eeb339e4
Yet another autofilter problem using converter and ALV (#1239)
Fix #1238
---------
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-09-10 13:48:59 +02:00
sandraros
e1cccfabda
Fix code which prevents ABAP Cleaner from running (#1267)
Fix #1266
2024-09-01 13:13:11 +02:00
Bernd
467b96f73b
Fix in line 1174 of zcl_excel_writer_2007.clas.locals_imp.abap (bug in conditional formatting) (#1255)
* Fix in line 1174 of zcl_excel_writer_2007.clas.locals_imp.abap

* Handle c_rule_textfunction in CREATE_XL_STYLES

---------

Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-08-31 08:28:07 +02:00
Bernd
d146e5b893
Update zexcel_s_cstyle_fill.tabl.xml (#1260)
Fix #1259.
Gradtype now is related to the correct structure
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2024-08-24 17:28:10 +02:00
Domi Bigl
b3201166fc
consider time format for cell with calculation (#1263)
fixes #521
2024-08-22 11:46:55 +02:00
sandraros
b5f5d11e1c
Fix default cell format to not use UTCLONG (#1262)
Fix #1261

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-08-18 14:52:53 +02:00
Bernd
3d2926c5a6
Update ZEXCEL_FILL_TYPE 'cornerRB' (#1258)
Fix #1257
2024-08-17 17:07:05 +02:00
Lars Hvam
4e1931af15
font class cleanup (#1125) 2024-08-07 09:05:50 +02:00
sandraros
0f19081a04
Code to handle the UTCLONG type added in ABAP 7.54 (#1253)
Fix #1252
2024-08-06 14:12:23 +02:00
Lars Hvam
5ee365d831
update npm dependencies (#1207) 2024-08-05 19:06:55 +02:00
Bernd
48db7f0b1b
How to get rid of the obscure code in writer's method create_xl_sheet_sheet_data step #1 (#1231)
Fix #440
2024-06-15 12:07:36 +02:00
sandraros
d25eb31d78
Remove no-more-appropriate comments from set_title (#1237)
These comments are old and useless
2024-06-09 20:40:45 +02:00
Bernd
e389d2dff5
Worksheet's method set_title doesn't handle escaped titles and sheetlocal ranges (#1236)
Fix #1235
2024-06-09 20:34:29 +02:00
Bernd
564d60e0f5
Update zcl_excel_reader_2007.clas.abap (#1234) 2024-06-09 10:39:59 +02:00
sandraros
fd2dc14ac2
Support of empty cell address by LOAD (workbook) (#1225)
Fix #1081

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Andrea Borgia <andrea@borgia.bo.it>
2024-05-12 11:57:33 +02:00
RixarSAP
c2096d1f9b
Added field WIDTH in field catalog of method BIND_TABLE (#1224)
Fix #1227
2024-05-11 17:34:06 +02:00
sandraros
aee3b3efa4
More control on comment box position/size (#1226) 2024-05-11 16:56:20 +02:00
RixarSAP
a9e1068e44
Add possibility to change the size of the comments. (#1219)
Fix #1221
2024-05-06 08:42:16 +02:00
Domi Bigl
3cb8f883f1
fix hidden compare values (#1208)
set hidden compare values to constants lc_xml_attr_true and lc_xml_attr_true_int ( 'true' and '1' )
2024-04-27 12:14:29 +02:00
Bernd
5cb47b143c
Header/footer images and comments together create wrong file destinations in sheet#.xml.rels (#1201)
* Update zcl_excel_writer_2007.clas.abap

Fix #1214
2024-04-20 18:32:50 +02:00
Bernd
191bf9cf61
Update zcl_excel_writer_2007.clas.locals_imp.abap (#1200)
solves #1113
2024-04-20 12:26:15 +02:00
Kjetil Kilhavn
f9685c981d
Convert fields with date & time value correctly to just date or just time (#1197)
* Convert fields with date 

Ignore decimals when converting to date and ignore integer when converting to time
Fix #1132

* New ip_exact parameter of excel_string_to_date

- I'm not comfortable about changing the logic in `excel_string_to_date`, in case other people have implemented a "-1 day" fix after the call, so I added a parameter `ip_exact` to keep an ascending compatibility.
- I reused the old structure of unit tests to simplify the diff
- fix #1205 (I added this time issue that you fixed, the original issue mentioned only the date issue)

---------

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-04-20 09:53:31 +02:00
juancarlosrodriguezf
0f473095e1
Format Date (#1050)
* Fix format date for dd/mm/yyyy
* added new date format DD/MM/YY
* New constant for dd/mm/yyyy instead of changing the existing one to keep the ascending compatibility

---------

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-04-14 10:32:55 +02:00
sandraros
a69258e829
set_table to support table components not DDIC (#1204)
Fix #1166
2024-04-13 15:54:22 +02:00
Aditya Waghmare
35425c3220
CSV Initial External Date (#1190)
* CSV Initial External Date

Added code to set an initial external date other than the value returned by function module 'CONVERT_DATE_TO_EXTERNAL'.

* Default value as public constant

---------

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2024-02-15 15:20:09 +01:00
sandraros
39f92725a0
Update LICENSE Copyright (#1191)
Fix #1153
2024-02-15 11:16:49 +01:00
sandraros
242a3d4e43
Ineffective Set_Namespace_Prefix on DOM document (#1186)
It always return an error but isn't handled → line removed
2024-02-06 20:01:26 +01:00
sandraros
e4f0ca2333
Unused calls/variables about cl_xml_document (#1185) 2024-02-06 15:15:51 +01:00
sandraros
b77b48fd15
Cleanup unused variables in zcl_excel_theme (#1183)
Removing the statement ixml_element->get_attribute( 'xmlns:a' ) is anyway a good thing because getting a namespace attribute this way is not supported by IXML and it is always returning an empty string even if this "attribute" exists.
2024-02-01 17:37:36 +01:00
sandraros
cc8fb819ad
Fix freeze and topLeftCell in reader/writer (#1178)
Fix freeze and topLeftCell in reader/writer

Fix #1175
Adds new methods set_pane_top_left_cell and set_sheetview_top_left_cell to zcl_excel_worksheet
2024-01-31 16:23:15 +01:00
Lars Hvam
1148838a0f
add basic unit test for recursive_struct_to_class (#1124)
* add basic unit test for recursive_struct_to_class

* Update zcl_excel_common.clas.testclasses.abap
2024-01-29 07:21:05 +01:00
Lars Hvam
b4a79ebe6c
start unit testing setup (#872) 2024-01-29 07:18:57 +01:00
sandraros
5f784c8ed6
Fix zoom information in reader and writer (#1177)
Fix #1176
2024-01-19 21:37:06 +01:00
Attila Berencsi
6bb02920df
Address DDIC Issues on BTP ABAP Environment: SAP_BASIS 794 (SAPK-79406INSAPBASIS 0006) (#1169)
* Address DDIC Issues on BTP ABAP Environment.
SAP_BASIS 794 (SAPK-79406INSAPBASIS  0006)

* Move DynPro related DDIC to NOT_CLOUD package

* Remove one langu from DTEL, DOMA 2 see git changes

* Remove non-english translations for copied data elements for cloud

* Package assignment and diff cleanup
Moved from package <root>_NOT_CLOUD to <root>
- ZEXCEL_S_FIELDCATALOG
Moved from package <root> to <root>_NOT_CLOUD:
- ZEXCEL_T_CONVERTER_COL
- ZEXCEL_T_CONVERTER_FCAT
- ZIF_EXCEL_CONVERTER
"No change" (latest abapGit version indicates a Diff but details give message "no diff" - abapGit bug?), let's see if it solves:
- /src/not_cloud/zexcel_component_position.dtel.xml
- /src/not_cloud/zexcel_convexit.doma.xml
- /src/not_cloud/zexcel_convexit.dtel.xml
- /src/not_cloud/zexcel_ddic_flag.doma.xml
- /src/not_cloud/zexcel_disp_text_long.doma.xml
- /src/not_cloud/zexcel_disp_text_long.dtel.xml
- /src/not_cloud/zexcel_disp_text_medium.dtel.xml
- /src/not_cloud/zexcel_disp_text_short.doma.xml
- /src/not_cloud/zexcel_disp_text_short.dtel.xml
- /src/not_cloud/zexcel_screen_display.dtel.xml

---------

Co-authored-by: 04c82057-cb12-4722-bad9-5d002feb93ac <attila.berencsi@gmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2024-01-14 14:43:22 +01:00
HuprichTo
92809a41e3
Fix unescape string value when not escpaped (#1160)
* BUGFIX: Skip Input without escaped Character

Some special Values, e.g. "TEST_X" were handled like it was an escaped Character, thats because it was not checked if the second conition, an "_" behind it was there

* Adjust Package Description to its Original

* Remove commented Code

Was there for testing, not needed anymore

* Downport to 7.02

Adjust Method Call to apply 7.02 Syntax

* Fix abaplint Issues

* Fix abaplint Issues (again)

---------

Fix #1122 

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2024-01-11 17:35:46 +01:00
sandraros
76a39a7819
Make the reader get the Tables (#1159)
Fix #1158
Fix #1168
2023-12-25 16:36:58 +01:00
Lars Hvam
1c2607f655
move ZEXCEL_TR_DOCPROPS_CORE to demos (#1165) 2023-12-24 20:28:06 +01:00
Lars Hvam
a6176d7f17
replace use of REFFIELD (#1154) 2023-11-05 11:21:52 +01:00
Lars Hvam
bcec07b41a
fix syntax warning (#1155) 2023-11-05 11:18:36 +01:00
larsip
c1a20e870b
Convert currency amount to external format (#1147)
Fix #1145

* Convert currency amount to external format
Fetching currency reference field from ALV and use the value from this field convert the value to external format

* Missing field catalog update

* Little changes proposed

* Code best positioned, delete unused declaration
Latest changes proposed by darnoc312
2023-11-04 17:09:11 +01:00
Arno
ccda3a0aa8
read all header/footer (odd/even) elements (#1144)
Previously only the "oddFooter" was read and stored. Read the missing elements as well.
2023-10-29 19:09:30 +01:00
Daniel Wegner
cf8bb2c501
add iv_end_row to convert_to_table (#1148)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2023-10-29 18:29:51 +01:00