Method `if_ixml_document->render` has been aliassed to `if_ixml_node->render` in a later SAP_BASIS release
Solution: abandon the render call completely, replace it by `call transformation`
"Exit is only allowed in loops" - it is wrong by any programming standard to prohibit the EXIT statement in WHILE loops (as it is used here)
But I used this commit to change the idiom `WHILE lo_iterator->has_next( )` to `WHILE lo_iterator->has_next( ) EQ abap_true` for backwards compatibility instead
* Replace pass by value with reference
#1013
* Possible sequential read on sorted/hashed table
#1014
* Update src/not_cloud/zcl_excel_converter.clas.locals_def.abap
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
* remove comments and old coding
* fix UT errors
* remove more comments and old coding
* Improvements / Fix aesthetic regression on XML
---------
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
* Replace pass by value with reference
#1013
---------
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
* Options to skip hidden rows and columns for CSV format
Add options to skip hidden rows and columns when saving the data in CSV format. This is especially useful, when converting an ALV to an Excel object and saving it as CSV file. ALV layouts often display only selected columns.
* Adding missing data definition
Adding missing data definition for lo_autofilter.
* Fix dates not converterted to external format
Method get_default_excel_date_format of class zcl_excel_worksheet uses language "E" (English) to determine the date format from domain XUDATFM.
Method create_csv of class zcl_excel_writer_csv has a logic to determine the field type from the number format. For this also the values from domain XUDATFM are used. But here they are read with sy-langu. Due to this, fields are not correctly identified as "date" when the user language is not English.
Solution: Additionally read domain values with language "E".
* Trigger filter area validation
Trigger filter area validation
* Fix date identification logic for newer AS ABAP versions
The texts of domain XUDATFM changed in newer systems:
NW 7.40: DD.MM.YYYY
NW 7.52: DD.MM.YYYY (Gregorian Date)
This breaks the date identification logic.
New logic copied from get_date_format_des of class cl_abap_datfm, which is called in method get_default_excel_date_format of class zcl_excel_worksheet to get the users default date pattern.
* Performance improvement for skip hidden rows
Performance improvement for skip hidden rows
---------
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
* Fix in line 1174 of zcl_excel_writer_2007.clas.locals_imp.abap
* Handle c_rule_textfunction in CREATE_XL_STYLES
---------
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
* Convert fields with date
Ignore decimals when converting to date and ignore integer when converting to time
Fix#1132
* New ip_exact parameter of excel_string_to_date
- I'm not comfortable about changing the logic in `excel_string_to_date`, in case other people have implemented a "-1 day" fix after the call, so I added a parameter `ip_exact` to keep an ascending compatibility.
- I reused the old structure of unit tests to simplify the diff
- fix#1205 (I added this time issue that you fixed, the original issue mentioned only the date issue)
---------
Co-authored-by: sandraros <sandra.rossi@gmail.com>
* Fix format date for dd/mm/yyyy
* added new date format DD/MM/YY
* New constant for dd/mm/yyyy instead of changing the existing one to keep the ascending compatibility
---------
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
* CSV Initial External Date
Added code to set an initial external date other than the value returned by function module 'CONVERT_DATE_TO_EXTERNAL'.
* Default value as public constant
---------
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Removing the statement ixml_element->get_attribute( 'xmlns:a' ) is anyway a good thing because getting a namespace attribute this way is not supported by IXML and it is always returning an empty string even if this "attribute" exists.
