Commit Graph

63 Commits

Author SHA1 Message Date
Rahul Dwivedi
df9db3d55c
zcl_excel_writer- create_xl_sheet Refactor1 (#1069) 2022-10-27 20:10:38 +02:00
Domi Bigl
bca6db91c3
enable 255 cell header with table binding (#1051)
* add column_name to fcat and link cell to table

add column_name char 255 to table fieldcat - this is used as table name and cell value
link cell to table and fieldcat

* update fieldcat by cell value change

* fix linter errors

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix linter errors

* fix linter errors

* undo PP

* undo PP

* undo PP

* fix colname for totals functions

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-08-07 15:56:26 +02:00
Abo
a09229a130
remove CONDENSE from formulas (#968) 2022-01-15 14:56:12 +01:00
sandraros
c5eb18acdc
prevent row height zero (#950)
Fix #944

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 10:32:24 +01:00
Lars Hvam
496b51e531
change SYTABIX to I (#947)
* change SYTABIX to I

* another
2022-01-03 21:33:18 +01:00
sandraros
3a4270c11e
Delete code instead of commenting it (#946)
* Detect commented code

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* first batch of modifications

* Last batch of modifications

* Last batch of modifications (again)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-03 08:54:52 +01:00
Lars Hvam
98d67652a9
refactor to use new collection classes (#937)
* refactor to use new collection classes

closes #880

* Update src/zcl_excel.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_comments.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_data_validations.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_drawings.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheets.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_csv.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_huge_file.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_xlsm.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_columns.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_fill_template.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_ranges.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_reader_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_rows.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles_cond.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-01 12:46:10 +01:00
Lars Hvam
dea6cfd9f0
refactor all MOVE statements (#926)
* refactor all MOVE statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 18:11:40 +01:00
sandraros
6532e0e0b5
+ worksheet columns right-to-left (#911)
fix #890

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 09:14:17 +01:00
sandraros
d7011f715c
Fix #893
* first part

* second and last part

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-11-28 20:25:35 +01:00
Mike Pokraka
dbd260da2c
Add exeption handling (#889)
* Add exeption handling

* Lint fixes

* Revert back keywords -> upper case

(test classes of zcl_excel_worksheet)

* revert pretty print->diff shows only excp handl

proposing to create a different pull request with only pretty print

* proposing tiny fixes

1) a few alignment fixes
2) ls_message renamed to lv_message
3) message ... type 'E' -> message ... type 'I' display like 'E' to avoid short dumps

Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-24 19:40:45 +01:00
Lars Hvam
ea40b6860e
DDIC reference fixes (#884)
* DATS -> D, and propagate exceptions to caller

* replace sydatum and syuzeit

* ZEXCEL_CONDITIONAL_ABOVE_AVG, change to builtin ty

* fix ZEXCEL_DOCSECURITY

* fix NUMC3

* fix numc3

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-07 20:44:40 +01:00
sandraros
3b2423ea29
fix #844 to remove all macros (#860)
* fix #844 to remove all macros 

* abaplint.json avoid_use/define false -> true

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-01 16:57:17 +01:00
sandraros
5da41aaab2
Fix #486 Multiple Styles in One Cell ("rich text format") (#852)
* Final modifications - All good

* Lint 7.02 + reader huge was forgotten

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <sandraros@gmail.com>
2021-10-24 16:07:58 +02:00
Abo
fb4c62d598
remove usage of CHAR5 ( WIP #692 ) (#856)
* remove usage of CHAR5

* remove type from class local types

* move type declaration

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: Domi Bigl <dominik.bigl@cadaxo.com>
2021-10-17 20:08:39 +02:00
sandraros
ec3f73c0e2
Fix #836 new feature "Ignored Errors" (#839)
* Fix SHIFT_FORMULA (issues #727 and #728) (#830) (#838)

Fix SHIFT_FORMULA (issues #727 and #728)

Co-authored-by: Abo <andrea@borgia.bo.it>

Co-authored-by: Abo <andrea@borgia.bo.it>

* Fix #836 new feature "Ignored Errors"

Fix #836

* Lint xsdbool -> boolc
* lint expression as argument -> variable as argumen
* lint remove constructor expression

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix previous merge mistake

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandraros@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-16 13:22:38 +02:00
sandraros
111bb57804
Ignore invalid Excel Table names (#793)
fix bug #733

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-16 11:00:33 +02:00
sandraros
904a014609
Fix #723 Calculated Columns - Replace PR 734 (#843)
* Fix #723 Calculated Columns - Replace PR 734

Co-authored-by: sandraros <sandraros@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 17:22:00 +02:00
sandraros
de39aa842a
Modif done but tests not done (#851)
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 15:42:33 +02:00
Paul Hardy
d19ac690c6
Fix for Issue #783 - Conditional Formatting for Cells that "Begin With" a certain string - Third Attempt (#786)
* Issue 783 - Third Attempt
* Extension to fix all 4 text-specific operators

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-09 09:49:17 +02:00
sandraros
b9a248dcb4
Fix issue #819 read/write autofilter values (#820)
* Fix issue #819 read/write autofilter values

Fix issue #819

* Code cleanup

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-04 16:47:32 +02:00
sandraros
03faa9500f
urgent fix of PR 805 (syntax error in write class) (#812)
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-09-26 12:45:08 +02:00
sandraros
868c90ffdc
Fix issue 673 trailing spaces of cell values lost (#805)
* indicate preserve attribute in Excel writer

fix #673

* Update src/zcl_excel_writer_2007.clas.abap

Not sure to understand why it's needed, but no problem to do that

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-26 10:17:32 +02:00
sandraros
e72e4ea6a9
Fix issue 704 lint sy fields modified (#802)
* Do not change sy fields anymore (abaplint)

Fix #704

* forgotten case in zcl_excel_writer_2007

#704

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-23 07:19:02 +02:00
Mike Pokraka
2710dd9717
Pretty print (#781)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-28 00:33:22 +02:00
sandraros
e029864bbb
Wrongly changed file size #722 (#741)
* Fix #722 worksheet dimension (last empty rows)

* Fix #722 reduce DIFF quantity (indentations)

Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-07-03 19:07:18 +02:00
sandraros
5110f924b4
Fix Vietnamese/Emoji not rendered #756 (#757)
Fix of bug #756
Vietnamese/Emoji should now be rendered in systems before ABAP 7.52

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-26 14:18:40 +02:00
sandraros
8c92b12d6f
Fix 474 newline in table header (#763)
* First solution, but wrong

Excel saves table1.xml with _x000d__x000a_ but abap2xlsx doing the same thing makes Excel say it's wrong!? To be analyzed...

* non-final solution

* Fix newline now accepted in table header

Fix of #474, \r\n can now be used in field catalog of table header in bind_table to display text on several lines. ZDEMO_EXCEL22 demonstrates it in first column "Flight Number" on 2 lines.

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-21 23:24:30 +02:00
sandraros
6eac42678c
Unicode characters not written to excel (#743)
* Fix output of "non-XML" characters 672 and 688

Fix #672 ("vietnamese") and #688 ("emoji").
It works for a recent system but unfortunately I can't test it on a old system to make sure that the new method `is_support_non_xml_characters` returns false.

* Remove useless code and rename variables

* Demo "Hello World" in 10 major languages + Emoji

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-05-21 20:28:17 +02:00
Stefan Rutzmoser
1c276c6027
Fix package errors (#708)
* Fix package check errors

* Bump version number to 7.2.0
2020-11-10 18:21:38 +01:00
Lars Hvam
88ac30f84c
update linter config, remove some unused variables (#685)
* update linter config

* teched9 demo, cleanup unused variables

* 28 and 29, cleanup unused variables

* remove few more
2020-08-12 08:48:15 +02:00
psio3123
3e780bb65e
Fixed ShowDropDown Constant (#670)
Enable display of DropDownList when using inline value list

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 12:19:33 +02:00
psio3123
701e8a197e
Enable ValidationStyle (#671)
Enable Validation Style (Error/Warning/...) for Value Lists

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 12:16:28 +02:00
Domi Bigl
37ad2fd68a
improve handling of multiple CF rules and ranges (#682) 2020-07-21 22:22:20 +02:00
Lars Hvam
49d78bfe35
remove tabs, remove seq empty lines (#660)
LGTM
2020-04-19 16:15:07 +02:00
bhavesh4321
c48484d6dc
Update zcl_excel_writer_2007.clas.abap (#654)
* Update zcl_excel_writer_2007.clas.abap

* dummy change

* revert

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-24 08:20:08 +01:00
Lars Hvam
8ea5ab07ea update abaplint config to latest (#645)
* update abaplint config to latest

* remove whitespace
2020-01-23 09:00:14 +01:00
Manuel Laggner
df80e6fd74 remove illegal files from the XML (#644)
according to the SAP note 1750204 we can use the method IF_IXML_OSTREAM->SKIP_NON_XML_CHARACTERS to strip out illegal characters for XML rendering.
Since this method needs a kernel version with builtin support, I've made the call dynamically in a try/catch block to support systems with a lower kernel too.

This patch fixes the issues from #298 (at least for us)
2020-01-22 14:40:44 +01:00
mfallen
d104e020f3 Error headerfooter (#603)
Error (again?) when using more than 1 sheet
2019-09-29 19:07:29 +02:00
AtomKrieg
8938dba50f remove boilerplate: create/render ixml_document (#605)
also clear "dead code"
2019-09-29 17:40:48 +02:00
mfallen
edb50701b1 Redefinition Header Footer Image
Get errors when using header/footer in more than one sheet
2019-02-21 15:45:27 +01:00
Gregor Wolf
09b6b5f162
Merge pull request #595 from mfallen/headerfooter
Header Footer Image
2019-02-19 10:55:44 +01:00
mfallen
d1c74a18e4 Update XSTRING conversion 2019-02-19 07:47:30 +01:00
mfallen
d907d03e28 Header Footer Image
including a test program
2019-02-18 07:23:15 +01:00
AtomKrieg
a5194c647b fix comments on second sheet
https://github.com/sapmentors/abap2xlsx/issues/587
2019-02-17 11:35:01 +03:00
Gregor Wolf
42a85aaa18 700 support #562 2019-02-11 17:33:24 +00:00
Gregor Wolf
aaad50440d Support for comments (Issue #180) (#583)
* Read UTF-8 input file correctly

* Classes for cell coments

As contributed by guillaumegarcia13

* Support for comments (Issue #180)

As contributed by guillaumegarcia13
2019-01-23 08:23:09 -06:00
Lars Hvam
6b84761443
update to latest abapGit format (#582)
* update to latest abapGit format

* fix syntax error
2019-01-11 09:46:50 +01:00
MCH123
4ca4991167 Issue #572 - Protect sheet with filter caused Excel error (#577)
Issue #572 - Protect sheet with filter caused Excel error 

Autofilter + sheet protection causes excel error.

Sheet protection must be set BEFORE autofilter in XML.
2019-01-09 08:25:50 -06:00
larshp
faa434ec3e add spaces 2018-11-21 17:50:54 +01:00