Domi Bigl
c24196bcd0
add better error message for logical path ( #850 )
2021-10-15 09:19:37 +02:00
Lars Hvam
98a251a859
zcl_excel_common: refactor unit tests ( #833 )
...
* split date_to_excel_string into one test per metho
* split excel_string_to_time
* refactor time_to_excel_string
2021-10-11 20:14:41 +02:00
Abo
66a45b840a
remove CHAR255 ( WIP #692 ) ( #847 )
...
DTEL, "STRU" and CLAS
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-09 20:04:05 +02:00
Abo
a959c0c69a
remove uses of CHAR20 ( WIP #692 ) ( #846 )
...
both DTEL and "STRU"
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-09 19:54:19 +02:00
Abo
b8be9c5de1
remove uses of CHAR2 ( #845 )
...
DTEL and in class
2021-10-09 19:42:53 +02:00
Domi Bigl
372fe61c75
add DECFLOAT16 and DECFLOAT34 ( #834 )
2021-10-09 11:57:38 +02:00
Domi Bigl
2cda265b4c
clear exporting parameter GET_CELL #789 ( #840 )
...
* clear exporting parameter GET_CELL #789
* satisfy linter
* satisfy linter - WHILE
2021-10-09 11:21:07 +02:00
Paul Hardy
d19ac690c6
Fix for Issue #783 - Conditional Formatting for Cells that "Begin With" a certain string - Third Attempt ( #786 )
...
* Issue 783 - Third Attempt
* Extension to fix all 4 text-specific operators
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-09 09:49:17 +02:00
Lars Hvam
679950b498
DDIC: pane state and type change to builtin string ( #835 )
...
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-08 22:58:08 +02:00
Lars Hvam
9bbc35a3ac
delete unused customui objects ( #832 )
...
closes #803
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-08 22:56:13 +02:00
Abo
d722718970
fix #826 ( #841 )
2021-10-08 22:53:30 +02:00
Abo
c4a97b44b9
Remove dtel char1 ( #842 )
...
* removes uses of CHAR1 data el. ( WIP #692 )
2021-10-08 20:01:12 +02:00
sandraros
f7151f3d39
Fix SHIFT_FORMULA (issues #727 and #728 ) ( #830 )
...
Fix SHIFT_FORMULA (issues #727 and #728 )
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-07 19:47:35 +02:00
Lars Hvam
16430d17dd
ZCL_EXCEL_COMMON: less DDIC references ( #828 )
...
* ZCL_EXCEL_COMMON: less DDIC references
* Update zexcel_s_org_rel.tabl.xml
* fix
* remove more DDIC references from testclasses
2021-10-07 06:33:48 +02:00
Lars Hvam
ca69b38a79
Less DDIC references ( #831 )
...
* CHAR3
* fix some DTELs
* fixes
* fix ZEXCEL_ALIGNMENT
* fix ZEXCEL_BORDER
* fix ZEXCEL_STYLE_COLOR_ARGB
* fixes
2021-10-07 06:32:01 +02:00
Lars Hvam
e9386fd022
refactor some ddic uses to builtin ( #824 )
...
reference = #692
2021-10-06 08:08:11 +02:00
Lars Hvam
e0052bbb9e
zcl_excel_style_number_format: refactor macro to method ( #818 )
...
* zcl_excel_style_number_format: refactor macro to method
* fix whitespace
2021-10-06 08:07:29 +02:00
sandraros
1076b86547
Fix #547 autofilter messed up if several sheets ( #821 )
...
Fix #547
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-04 16:50:50 +02:00
sandraros
b9a248dcb4
Fix issue #819 read/write autofilter values ( #820 )
...
* Fix issue #819 read/write autofilter values
Fix issue #819
* Code cleanup
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-04 16:47:32 +02:00
sandraros
90992efb50
Fix #546 autofilter on row>1 and one-row height ( #822 )
...
Fix #546
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-10-04 12:20:18 +02:00
Lars Hvam
e7d34b65c1
delete unused DDIC objects ( #817 )
...
* delete unused DDIC objects
#799
* enable rule unused_ddic
* delete additional objects
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-03 11:32:37 +02:00
Lars Hvam
af1448dbbf
refactor use of INT4 DOMA ( #816 )
...
Instead of referring to DOMA INT4, this changes the DTELs to use the built-in type INT4 instead
2021-10-03 11:11:42 +02:00
Lars Hvam
ac5c95ace7
change EXIT to RETURN, where applicable ( #814 )
2021-09-26 18:43:53 +02:00
Lars Hvam
d66e0d5cc7
zcl_excel_common: refactor STATICS to CLASS-DATA ( #811 )
...
* rename statics
* move to class-data
* move to private
* Update src/zcl_excel_common.clas.abap
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-09-26 13:43:36 +02:00
sandraros
03faa9500f
urgent fix of PR 805 (syntax error in write class) ( #812 )
...
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-09-26 12:45:08 +02:00
sandraros
868c90ffdc
Fix issue 673 trailing spaces of cell values lost ( #805 )
...
* indicate preserve attribute in Excel writer
fix #673
* Update src/zcl_excel_writer_2007.clas.abap
Not sure to understand why it's needed, but no problem to do that
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-26 10:17:32 +02:00
Lars Hvam
88d75bfe8a
move zexcel_s_org_rel to demos ( #810 )
...
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-09-26 10:07:05 +02:00
Lars Hvam
9cc7da37cb
upadte to latest abapGit format ( #808 )
...
https://github.com/abapGit/abapGit/blob/main/changelog.txt
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-09-26 10:03:34 +02:00
Lars Hvam
24ae5ecef2
zcl_excel_common: unit tests cleanup ( #806 )
...
* common: unit tests cleanup
* refactor macro to method
* refactor macro to method
* delete old commented lines (method definitions char2hex and number_to_excel_string)
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-09-26 09:57:36 +02:00
Lars Hvam
10b8df9b2f
remove use of aunit class ( #809 )
...
* remove use of aunit class
* aunit
2021-09-26 09:40:24 +02:00
sandraros
e72e4ea6a9
Fix issue 704 lint sy fields modified ( #802 )
...
* Do not change sy fields anymore (abaplint)
Fix #704
* forgotten case in zcl_excel_writer_2007
#704
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-23 07:19:02 +02:00
sandraros
ae76133265
abapGit diff says source has changed ( #804 )
...
In github repository, ZDEMO_CALENDAR_CLASSES seems to not contain a newline character at the end. When pulling it, abapGit creates ABAP source code with newline character at the end -> abapGit indicates a difference. PR to push the newline character at the end.
Co-authored-by: sandra <sandra.rossi@gmail.com>
2021-09-19 13:17:59 +02:00
Lars Hvam
5fa4f838b6
update abaplint configuration to latest ( #798 )
2021-09-19 11:23:22 +02:00
sandraros
8abf2adf9f
Move non-Cloud code to separate package ( #795 )
...
Fix of issue #717
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-19 09:56:37 +02:00
sandraros
41d5553181
Replace useless ZCL_EXCEL_AUNIT ( #796 )
...
Fix #715 . Replaced with CL_ABAP_UNIT_ASSERT. Class ZCL_EXCEL_AUNIT deleted.
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-19 09:53:58 +02:00
sandraros
69d4883773
Do not change sy fields anymore (abaplint) ( #797 )
...
Fix #704
Co-authored-by: sandra <sandra.rossi@gmail.com>
2021-09-19 09:49:46 +02:00
sandraros
3b80566fa8
Fix so that empty Excel date -> ABAP date 00000000 ( #792 )
...
issue #703
Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-09-14 22:57:45 +02:00
Abo
1cb2e42328
remove remaining usage of XFELD ( #775 )
...
followup #714
WIP #692
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:14:05 +02:00
Abo
530d4661f2
first draft of the contributing guidelines ( WIP #768 ) ( #769 )
...
* first draft of the contributing guidelines
* added link to coding guidelines
* clarified use of github for bugreports vs SCN for usage questions
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-21 11:00:16 +02:00
Abo
0064ae0a40
remove usage of CHAR07 domain ( #754 )
...
* remove CHAR07
See #692
* fixed formatting
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-16 08:52:21 +02:00
Mike Pokraka
2710dd9717
Pretty print ( #781 )
...
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-28 00:33:22 +02:00
sandraros
6edf73b01d
Create coding-guidelines.md ( #778 )
...
#773
2021-07-27 12:32:23 +02:00
Abo
e03fd5596d
remove usage of CHAR08 DTEL ( #776 )
...
WIP #692
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-10 17:49:40 +02:00
Abo
bd8f75537f
remove usage of CHAR10 domain ( #777 )
...
WIP #692
2021-07-10 17:30:23 +02:00
Abo
2120bc00ee
remove usage of OS_BOOLEAN ( #774 )
...
I could find only one use of the OS_BOOLEAN DTEL in all of abap2xlsx, precisely in zdemo_excel_outputopt_incl where it is used for the return value of a standard class method, cl_send_request->send.
"send" calls "release" which calls "submit" which finally sets e_sent_to_all to X unless one recipient has issues, in which case it is cleared: for this reason, replacing "IS INITIAL" with "= abap_false" is incorrect and the test should be inverted.
2021-07-10 11:40:59 +02:00
Abo
beaac0a28a
remove unused DOMA ( #772 )
...
fix #770
2021-07-09 18:35:40 +02:00
sandraros
e029864bbb
Wrongly changed file size #722 ( #741 )
...
* Fix #722 worksheet dimension (last empty rows)
* Fix #722 reduce DIFF quantity (indentations)
Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-07-03 19:07:18 +02:00
Gregor Wolf
0a3beaf7f8
fix #765 and pretty pring ( #766 )
2021-06-29 15:39:35 +02:00
sandraros
5110f924b4
Fix Vietnamese/Emoji not rendered #756 ( #757 )
...
Fix of bug #756
Vietnamese/Emoji should now be rendered in systems before ABAP 7.52
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-26 14:18:40 +02:00
sandraros
8c92b12d6f
Fix 474 newline in table header ( #763 )
...
* First solution, but wrong
Excel saves table1.xml with _x000d__x000a_ but abap2xlsx doing the same thing makes Excel say it's wrong!? To be analyzed...
* non-final solution
* Fix newline now accepted in table header
Fix of #474 , \r\n can now be used in field catalog of table header in bind_table to display text on several lines. ZDEMO_EXCEL22 demonstrates it in first column "Flight Number" on 2 lines.
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-06-21 23:24:30 +02:00