Commit Graph

46 Commits

Author SHA1 Message Date
Ivan
c2419f3896 Code Inspector improvements
Change coding issues raised by code inspector.
Still some remain to fix.
2014-03-18 10:34:13 -05:00
alsp80
4310280806 Add extraction of data validations 2014-03-04 22:26:54 +01:00
alsp80
8811d2c755 Add data import of data validations to reader 2014-03-04 16:34:05 +01:00
Ivan
ad22cf7eaf Improved memory usage and readability
Extract the parts for loading the file from application server /
presentation server into two new private methods.
Not only is the code better readable (currently, the very important LOAD
call at the end of the method almost vanishes after all that file
loading code)  - it also saves memory. Currently, when the LOAD message
is processed, not only the EXCEL_DATA xstring, but also BIN_TAB, the
auxiliary table of bytes which is retrieved from GUI_UPLOAD, is kept in
the memory as a redundant copy of the raw data, although during the
parse process it is not needed any more.
2014-02-24 16:04:18 -06:00
Ivan
822f9f75a3 Load file has new importing parameter for sy-batch
In the interface method ZIF_EXCEL_READER~LOAD_FILE, add an optional
import parameter I_FROM_APPLSERVER of type flag with default SY-BATCH,
and use this parameter, instead of SY-BATCH directly, for the decision
whether to load the file from application or from presentation server.
This will make the method more flexible, decoupling the decision "Where
to read the file from" from the circumstance "Am I in batch mode". By
making the parameter optional and using the default value SY-BATCH, all
existing client code will work as before.
2014-02-24 15:31:25 -06:00
Ivan
449e312c87 Suggestion by Rüdiger Plantiko
In methid ZIF_EXCEL_READER~LOAD_FILE, change the import parameter
I_FILENAME from type STRING to the generic type CSEQUENCE, and move it
to a string internally where needed.
This saves the client from having to move a CHAR field to an auxiliary
STRING field, only for not having a "type conflict" when calling the
method.
2014-02-24 15:24:18 -06:00
Ivan
75d100150f Huge file reader by Rüdiger Plantiko
See more details in this blog
http://scn.sap.com/community/abap/blog/2014/01/27/a-way-of-reading-huge-excel-files
2014-02-24 12:11:39 -06:00
Stefan Schmöcker
efedac0571 #284: Added support of reading XLSX-Files where the formulae are not stated explicitly but by reference to another cell holding a reference formula. Thanks to David for supplying the method to shift a formula to another cell.
Enhanced Demoreport 6 to demonstrate how this new method can be used in other circumstances then reading in an EXCEL-sheet


set to test #268:  Changed unit-test to make use of the extended functionality in ZCX_EXCEL

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@428 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2013-08-11 10:43:02 +00:00
Gregor Wolf
c1f6d37498 Issue #194: Replace REGEX to split Column & Row with method from the common class in LOAD_WORKSHEET Method of ZCL_EXCEL_READER_2007.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@407 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2013-02-25 12:25:39 +00:00
Stefan Schmöcker
9b4aaf829f #235 Extended Readerclass to support templating of repeatable rows/columns, minor fix in zcl_excel_common-method for range-area-breakup
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@400 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-12-09 11:06:01 +00:00
Stefan Schmöcker
8a7d689995 issue #235 - Prepared Reader and Writerclass for handling of repeat rows/columns
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@377 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-12-02 09:46:47 +00:00
Alessandro Iannacci
c9fff4fa44 #236 Chart creation in a worksheet from ABAP - Temporary version (doesn't work)
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@372 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-30 17:54:06 +00:00
Stefan Schmöcker
ebc222caeb #230 . Pimp my code: All style-methods in ZCL_EXCEL_READER_2007.slnk have been normalized
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@366 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-25 22:13:46 +00:00
Stefan Schmöcker
82c6b78f09 issue #234 : We may not ship patched copy of CL_ABAP_ZIP. Removed from trunk and switched coding to dynamic methodcalls.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@365 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-18 19:21:01 +00:00
Stefan Schmöcker
3081783b51 #230 . Pimp my code: Some methods in ZCL_EXCEL_READER_2007 have been normalized
set ready to test #234 : Various problems with files created by LibreOffice
set ready to test #186 : Seems to be integrated for some time already
set ready to test #194 : Reading state Hidden, Outlinelevel, Collapsed of rows and columns

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@364 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-18 14:52:01 +00:00
Stefan Schmöcker
abc25ede86 ready to test #232
issue #230 Pimp my code:  ZCL_EXCEL_READER_2007->LOAD_WORKBOOK

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@363 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-11 09:36:28 +00:00
Stefan Schmöcker
e710844968 #230 Pimp my Code:
ZCL_EXCEL_READER_2007->ZIF_EXCEL_READER~CAN_READ_FILE
ZCL_EXCEL_READER_2007->ZIF_EXCEL_READER~LOAD
ZCL_EXCEL_READER_2007->FILL_STRUCT_FROM_ATTRIBUTES
ZCL_EXCEL_READER_2007->GET_FROM_ZIP_ARCHIVE
ZCL_EXCEL_READER_2007->GET_IXML_FROM_ZIP_ARCHIVE

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@361 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-07 23:24:34 +00:00
Stefan Schmöcker
c21a49617b #230 - Pimp my Code - ZCL_EXCEL_READER_2007->ZIF_EXCEL_READER~LOAD_FILE
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@360 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-05 23:13:19 +00:00
Ivan Femia
fda6f0e3eb Ready to test #163
Added range capability to worksheet

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@358 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-04 22:22:46 +00:00
Stefan Schmöcker
9f65e6f7f8 set ready to test #229: Set active worksheet in readerclass
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@357 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-11-04 20:29:40 +00:00
Stefan Schmöcker
70e0a556db Fix issue #222 - Reader was disfunctional if path .\xl\worksheets\_rels\ isn't existing.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@347 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-28 10:26:17 +00:00
Stefan Schmöcker
6e902d884b #179 - Add coloring of worksheet tabs ready for testing. Reader & Writer updated
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@345 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-23 22:23:45 +00:00
Stefan Schmöcker
596b0cd041 #217 - replacing coding not allowed on 7.00 systems
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@343 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-21 22:20:50 +00:00
Ivan Femia
2d1d7d3bef Ready to test #193 #194 #207
Thanks to Vladimir Scheglov

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@340 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-14 13:57:34 +00:00
Ivan Femia
3cac5e5501 Ready to test #208
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@338 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-14 13:19:57 +00:00
Stefan Schmöcker
57dc5ef6dd Ready to test bugfixes for issues #180 and #212
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@336 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-10-02 23:18:19 +00:00
Rene Turnheim
cd1f087bd8 Fixed #206 issue; Minor issues resolved because of method calls direct on return values. This is not supported in 7.00.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@333 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-08-29 01:09:48 +00:00
Ivan Femia
485a7e8655 Ready to test #204 #187 #188
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@328 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-08-26 16:28:49 +00:00
Ivan Femia
161134a92d Ready to test #195
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@322 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-07-16 20:51:35 +00:00
Ivan Femia
e6bf4339a1 Ready to test #163
Ready to test #164

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@299 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-04-25 10:08:20 +00:00
Ivan Femia
d98d0f79d1 Fixed #122
Move to protected in order to align to WRITER and allows specific readers.

BTW it is not needed a new class in this case because reader 2007 should work either with Excel 2010.
Maybe it is useful an enhancement to current reader.



git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@271 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-03-19 22:10:58 +00:00
Gregor Wolf
42a8c8a5b6 ready to test #127 - enhanced ZDEMO_EXCEL15 to test new functionality, thanks to Shahrin Shahrulzaman for this contribution.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@245 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2012-01-03 17:43:06 +00:00
Ivan Femia
b536dbdfd1 Fix issue #168 by Alexander Budeyev
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@234 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-12-26 11:47:38 +00:00
Gregor Wolf
e239953895 Implemented Fix by Shahrin Shahrulzaman to add support for named rages for the Excel 2007 Reader #126
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@230 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-12-15 21:32:29 +00:00
Ivan Femia
076c556087 fix issue #111
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@211 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-07-27 21:31:32 +00:00
Tomek Mackowski
cdadc45142 fix #108 - set active sheet in reader
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@207 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-07-18 20:55:59 +00:00
Ivan Femia
d3f95ed657 Macro-Enabled workbook issue #89
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@194 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-06-02 09:23:58 +00:00
Tomek Mackowski
3481c02f35 Fix #93 Read PROTECTION style
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@181 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-05-13 21:49:35 +00:00
Tomek Mackowski
0d952ea2ef re #93 - read cell alignment and diagonal borders
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@180 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-05-13 21:29:25 +00:00
Tomek Mackowski
dfe73c22dd Fix #86 - add support for all Excel coloring options - standard color themes, indexed colors and tint
Both writer and reader updated.

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@170 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-05-04 21:52:43 +00:00
Tomek Mackowski
e8aa4ec888 #25 Adding support for reading styles in the READER
Currently following style options are supported:
-fonts
-borders
-fills
-number formats

DEMO1 and DEMO2 updated 

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@164 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-04-25 21:32:43 +00:00
Tomek Mackowski
ff8cd877f9 Fix #82 - data types from source sheets are preserver in the reader
Fix #80 - both value and formula are read by the reader

These 2 fixes allow reading xlsx templates with values of different types and formulas and saving them back

git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@159 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-04-13 22:18:10 +00:00
Gregor Wolf
7f94e7c77a Correct the ZCL_EXCEL_READER_2007 to fix issue #45. The multi table testfile raised another error that was fixed by adjusting the method get_dimension_range in class ZCL_EXCEL_WORKSHEET. Now this method returns A1 when the sheet is empty.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@125 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2011-02-05 17:23:06 +00:00
Ivan Femia
92573fea3c Implementation of worksheet set_title / get_title.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@80 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2010-12-17 21:21:36 +00:00
Gregor Wolf
0e8bce3637 Added CONVERT_COLUMNROW2COLUMN_A_ROW method in the ZCL_EXCEL_COMMON class to fix #45 in the Excel Reader class ZCL_EXCEL_READER_2007.
git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@73 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049
2010-12-10 22:35:10 +00:00
Ivan Femia
2b85b956c9 git-svn-id: https://subversion.assembla.com/svn/abap2xlsx/trunk@3 b7d68dce-7c3c-4a99-8ce0-9ea847f5d049 2010-09-14 08:05:50 +00:00