Commit Graph

82 Commits

Author SHA1 Message Date
sandraros
f2dd72e76e
SET_CELL use output length for conversion exits (#982)
* SET_CELL use output length for conversion exits

* bind_table: field catalog + demo

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-19 15:59:22 +01:00
sandraros
2973d66594
Refactor headings logic in BIND_TABLE (#960)
* Refactor headings logic in BIND_TABLE

to help proposing a change for #764

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-02-07 16:37:06 +01:00
sandraros
5bb343a3e4
Fix set_cell overflow big value type int8 (#979)
Fix #977

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-29 18:08:54 +01:00
sandraros
79d0df4dc3
BIND_TABLE incorrect table overlap check (#964)
* draft, not finished

* Final commit

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 19:19:14 +01:00
sandraros
c3481d5d90
GET_TABLE skip bottom empty rows (#959)
Fix #787

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-15 18:32:56 +01:00
sandraros
7fa137bc94
ip_style TYPE any + add_new_style( io_clone_of = ) (#929)
* ip_style TYPE any + add_new_style( io_clone_of = )

* zdemo_excel2 instead of zdemo_excel1

* Update zcl_excel_worksheet.clas.abap

* Unit tests added + fix demo 2

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-09 13:07:22 +01:00
Lars Hvam
5e1ca6255f
change REFRESH to CLEAR (#954)
* change REFRESH to CLEAR

and remve REFRESH if the variable is always empty

* more refresh

* enable REFRESH obsolete rule

* another

* last two

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-07 09:25:03 +01:00
sandraros
c5eb18acdc
prevent row height zero (#950)
Fix #944

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 10:32:24 +01:00
sandraros
6fcbc5c8a8
ip_columnrow in SET_CELL and other methods (#930)
* get_cell, set_cell, set_area, set_merge

* Test classes + Fixes

* demo simple set_cell in zdemo_excel1

* rename the "normalize" methods + cleanup

* Demonstration programs and few fixes

* added "raising cx_static_check"

* zdemo_excel40 call methods with only IP_RANGE

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2022-01-06 09:44:09 +01:00
Lars Hvam
9d0c970682
change FLOAT to F (#949)
* change FLOAT to F

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:50:43 +01:00
Lars Hvam
8d072439da
remove TYPE-POOLS statements (#948)
* remove TYPE-POOLS statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-03 21:42:10 +01:00
sandraros
3a4270c11e
Delete code instead of commenting it (#946)
* Detect commented code

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* first batch of modifications

* Last batch of modifications

* Last batch of modifications (again)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2022-01-03 08:54:52 +01:00
Lars Hvam
98d67652a9
refactor to use new collection classes (#937)
* refactor to use new collection classes

closes #880

* Update src/zcl_excel.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_comments.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_data_validations.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_drawings.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheets.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_csv.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_huge_file.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_xlsm.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_columns.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_fill_template.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_ranges.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_reader_2007.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_rows.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_styles_cond.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2022-01-01 12:46:10 +01:00
Lars Hvam
dea6cfd9f0
refactor all MOVE statements (#926)
* refactor all MOVE statements

* fix whitespace

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-12-24 18:11:40 +01:00
Pascal Möller
49938b0c60
Fix: after BIND_TABLE no columns in object (#731)
* Fix: after BIND_TABLE no columns in object

* fix 4 methods get_{rows|columns}[_iterator]

Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-12-24 16:21:42 +01:00
sandraros
3df52da4c2
+ change_area_style (same as change_cell_style, but for area) (#922)
* + change_area_style

New method change_area_style as combination of change_cell_style and set_area_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-24 12:46:31 +01:00
sandraros
0f51d6d884
refactor method change_cell_style in zcl_excel_worksheet (#904)
* refactor worksheet change_cell_style

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-12-14 22:57:06 +01:00
sandraros
6532e0e0b5
+ worksheet columns right-to-left (#911)
fix #890

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-12 09:14:17 +01:00
sandraros
d7011f715c
Fix #893
* first part

* second and last part

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-11-28 20:25:35 +01:00
Mike Pokraka
dbd260da2c
Add exeption handling (#889)
* Add exeption handling

* Lint fixes

* Revert back keywords -> upper case

(test classes of zcl_excel_worksheet)

* revert pretty print->diff shows only excp handl

proposing to create a different pull request with only pretty print

* proposing tiny fixes

1) a few alignment fixes
2) ls_message renamed to lv_message
3) message ... type 'E' -> message ... type 'I' display like 'E' to avoid short dumps

Co-authored-by: John Doe <sandra.rossi@accenture.com>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-24 19:40:45 +01:00
sandraros
8f65718db4
SET_AREA/SET_AREA_FORMULA: set value or formula for whole area instead top/left only (#869)
* Fix #867

* Behavior to depend on ip_merge / ip_area parameters

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-14 18:36:15 +01:00
Lars Hvam
fd83cbc112
extract font width logic to new class (#882)
* extract font width logic to new class

* rename importing parameters

* fixes

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_worksheet.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.testclasses.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

* fix syntax

* Update src/zcl_excel_font.clas.abap

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-11 10:19:41 +01:00
Lars Hvam
d60571434d
worksheet: remove unused header variable (#876)
* workseet: remove unused header variable

* pretty print with SE80

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-11-06 17:23:36 +01:00
sandraros
9b6bf15277
SET_CELL_FORMULA: set formula even if cell was uninitialized (#868)
* Fix #866

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-04 19:54:50 +01:00
sandraros
3b2423ea29
fix #844 to remove all macros (#860)
* fix #844 to remove all macros 

* abaplint.json avoid_use/define false -> true

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-11-01 16:57:17 +01:00
AntonSikidin
dc3962a402
Add ability to generate report from template (#669)
write tool to automate abap2xlsx

fix merged cells

code style

Convert keyword to UPPER case

adapt code to 702

New proposal

fix of Lint errors

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-10-30 21:49:50 +02:00
sandraros
5da41aaab2
Fix #486 Multiple Styles in One Cell ("rich text format") (#852)
* Final modifications - All good

* Lint 7.02 + reader huge was forgotten

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: sandraros <sandraros@gmail.com>
2021-10-24 16:07:58 +02:00
Abo
ac0ae6eca0
remove usage of CHAR3 (#855)
Fix #692
2021-10-17 10:42:55 +02:00
sandraros
ec3f73c0e2
Fix #836 new feature "Ignored Errors" (#839)
* Fix SHIFT_FORMULA (issues #727 and #728) (#830) (#838)

Fix SHIFT_FORMULA (issues #727 and #728)

Co-authored-by: Abo <andrea@borgia.bo.it>

Co-authored-by: Abo <andrea@borgia.bo.it>

* Fix #836 new feature "Ignored Errors"

Fix #836

* Lint xsdbool -> boolc
* lint expression as argument -> variable as argumen
* lint remove constructor expression

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/zcl_excel_writer_2007.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix previous merge mistake

Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: sandraros <sandraros@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-16 13:22:38 +02:00
sandraros
904a014609
Fix #723 Calculated Columns - Replace PR 734 (#843)
* Fix #723 Calculated Columns - Replace PR 734

Co-authored-by: sandraros <sandraros@gmail.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 17:22:00 +02:00
Abo
66a45b840a
remove CHAR255 ( WIP #692 ) (#847)
DTEL, "STRU" and CLAS

Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
2021-10-09 20:04:05 +02:00
Domi Bigl
372fe61c75
add DECFLOAT16 and DECFLOAT34 (#834) 2021-10-09 11:57:38 +02:00
Domi Bigl
2cda265b4c
clear exporting parameter GET_CELL #789 (#840)
* clear exporting parameter GET_CELL #789

* satisfy linter

* satisfy linter - WHILE
2021-10-09 11:21:07 +02:00
Lars Hvam
ac5c95ace7
change EXIT to RETURN, where applicable (#814) 2021-09-26 18:43:53 +02:00
sandraros
8abf2adf9f
Move non-Cloud code to separate package (#795)
Fix of issue #717

Co-authored-by: sandra <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-19 09:56:37 +02:00
Mike Pokraka
2710dd9717
Pretty print (#781)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-28 00:33:22 +02:00
sandraros
e029864bbb
Wrongly changed file size #722 (#741)
* Fix #722 worksheet dimension (last empty rows)

* Fix #722 reduce DIFF quantity (indentations)

Co-authored-by: Jane Doe <Jane.Doe@World.com>
Co-authored-by: Abo <andrea@borgia.bo.it>
2021-07-03 19:07:18 +02:00
Gregor Wolf
0a3beaf7f8
fix #765 and pretty pring (#766) 2021-06-29 15:39:35 +02:00
sandraros
f4312ebf5d
Fix #761 (#762)
These lines are added to method SET_CELL of ZCL_EXCEL_WORKSHEET:
    IF lv_value CS '_x'.
      " Issue #761 value "_x0041_" rendered as "A".
      " "_x...._", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
      " that Excel uses to store special characters, it's interpreted like Unicode character U+....
      " for instance "_x0041_" is U+0041 which is "A".
      " To not interpret such text, the first underscore is replaced with "_x005f_".
      " The value "_x0041_" is to be stored internally "_x005f_x0041_" so that it's rendered like "_x0041_".
      " Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
      REPLACE ALL OCCURRENCES OF REGEX '_(x[0-9a-fA-F]{4}_)' IN lv_value WITH '_x005f_$1' RESPECTING CASE.
    ENDIF.

Co-authored-by: sandraros <sandra.rossi@gmail.com>
2021-06-21 23:20:57 +02:00
sandraros
7b48cd0d90
fix #687 for reading range of hyperlinks (#750)
fix-#687-for-reading-range-of-hyperlinks

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Gregor Wolf <gregor.wolf@gmail.com>
2021-05-21 21:15:49 +02:00
Abo
adf2c63ec8
use ZABAP2XLSX message class (#752)
related to #659
2021-04-19 12:55:00 +02:00
Abo
6c92a7f1ee
remove XFELD (#714)
see https://github.com/sapmentors/abap2xlsx/issues/692
2021-01-04 16:59:45 +01:00
Stefan Rutzmoser
1c276c6027
Fix package errors (#708)
* Fix package check errors

* Bump version number to 7.2.0
2020-11-10 18:21:38 +01:00
Lars Hvam
c36800ee49
update linter config, plus remove identical N01 condition (#696)
* update linter config, plus remove identical N01 condition

* add deps
2020-09-19 08:14:14 +02:00
Domi Bigl
37ad2fd68a
improve handling of multiple CF rules and ranges (#682) 2020-07-21 22:22:20 +02:00
srps
5a33253f0e
Bug fix - add INT4 support (#679)
* Bug fix - add INT4 support

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-20 20:58:41 +02:00
Domi Bigl
3b7f7f7b04
get INT8 typekind dynamic (#676) 2020-07-02 06:39:20 +02:00
Lars Hvam
49d78bfe35
remove tabs, remove seq empty lines (#660)
LGTM
2020-04-19 16:15:07 +02:00
Dennis Schaaf
718b15091e
ATC check cleared (#657)
* ATC check cleared

removed SELECT * from USR01
removed empty SELECT...ENDSELECT on URS01

* Removed Inerface method implementation

ZIF_EXCEL_READER~CAN_READ_FILE was implemented but this method is not defined anymore in the Interface.
ATC check failed with incorrect syntax.
Solution: Method implementation deleted.
2020-04-17 11:06:58 +02:00
striezl
36ea883d33 Fix #637 (#638)
LGTM. Thanks.
2019-10-30 07:20:30 +01:00