From 00a378a42b69d8f715fc8a2aa6c091a60580f636 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jakub.filak@sap.com>
Date: Fri, 29 Mar 2019 06:55:55 +0100
Subject: [PATCH] A pair of SFPF and PROG error messages with more details
 (#2588)

* sfpf: make deserialization errors more verbose

Just to make debugging a little be easier.

* prog: make updating errors more verbose

For simpler debugging.
---
 src/objects/zcl_abapgit_object_sfpf.clas.abap     | 7 ++++---
 src/objects/zcl_abapgit_objects_program.clas.abap | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/objects/zcl_abapgit_object_sfpf.clas.abap b/src/objects/zcl_abapgit_object_sfpf.clas.abap
index aca4e6e3c..c43a29486 100644
--- a/src/objects/zcl_abapgit_object_sfpf.clas.abap
+++ b/src/objects/zcl_abapgit_object_sfpf.clas.abap
@@ -215,7 +215,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPF IMPLEMENTATION.
           lv_layout    TYPE xstring,
           lv_name      TYPE fpname,
           li_wb_object TYPE REF TO if_fp_wb_form,
-          li_form      TYPE REF TO if_fp_form.
+          li_form      TYPE REF TO if_fp_form,
+          lx_fp_err    TYPE REF TO cx_fp_api.
 
 
     lv_name = ms_item-obj_name.
@@ -238,8 +239,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPF IMPLEMENTATION.
                                               i_form = li_form ).
         li_wb_object->save( ).
         li_wb_object->free( ).
-      CATCH cx_fp_api.
-        zcx_abapgit_exception=>raise( 'SFPF error, deserialize' ).
+      CATCH cx_fp_api INTO lx_fp_err.
+        zcx_abapgit_exception=>raise( |SFPF deserialization error: { lx_fp_err->get_text( ) }| ).
     ENDTRY.
 
     zcl_abapgit_objects_activation=>add_item( ms_item ).
diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap
index 60a85e2b6..63e9f90c4 100644
--- a/src/objects/zcl_abapgit_objects_program.clas.abap
+++ b/src/objects/zcl_abapgit_objects_program.clas.abap
@@ -459,7 +459,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION.
         IF sy-msgid = 'EU' AND sy-msgno = '510'.
           zcx_abapgit_exception=>raise( 'User is currently editing program' ).
         ELSE.
-          zcx_abapgit_exception=>raise( 'PROG, error updating' ).
+          zcx_abapgit_exception=>raise( |PROG { is_progdir-name }, updating error: { sy-msgid } { sy-msgno }| ).
         ENDIF.
       ENDIF.