From 00c1c36e32292ca61237a4f4f6b68073b47e6279 Mon Sep 17 00:00:00 2001 From: larshp Date: Fri, 8 Jul 2016 10:05:33 +0000 Subject: [PATCH] move more popups, fix lint error --- src/zabapgit_gui.prog.abap | 96 +---------------------------------- src/zabapgit_popups.prog.abap | 91 +++++++++++++++++++++++++++++++++ 2 files changed, 93 insertions(+), 94 deletions(-) diff --git a/src/zabapgit_gui.prog.abap b/src/zabapgit_gui.prog.abap index dac5ef8f4..5573f113f 100644 --- a/src/zabapgit_gui.prog.abap +++ b/src/zabapgit_gui.prog.abap @@ -55,9 +55,6 @@ CLASS lcl_gui_router DEFINITION FINAL. IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key RAISING lcx_exception. - METHODS repo_package_zip - RAISING lcx_exception. - METHODS repo_pull IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key RAISING lcx_exception. @@ -66,11 +63,6 @@ CLASS lcl_gui_router DEFINITION FINAL. IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key RAISING lcx_exception. - METHODS create_branch_popup - EXPORTING ev_name TYPE string - ev_cancel TYPE abap_bool - RAISING lcx_exception. - METHODS create_branch IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key RAISING lcx_exception. @@ -684,7 +676,7 @@ CLASS lcl_gui_router IMPLEMENTATION. iv_zip = abap_false ). ev_state = gc_event_state-no_more_act. WHEN 'packagezip'. - repo_package_zip( ). + lcl_popups=>repo_package_zip( ). ev_state = gc_event_state-no_more_act. WHEN 'transportzip'. lcl_transport=>zip( ). @@ -986,52 +978,6 @@ CLASS lcl_gui_router IMPLEMENTATION. ENDMETHOD. "repo_remove - METHOD repo_package_zip. - - DATA: lo_repo TYPE REF TO lcl_repo_offline, - ls_data TYPE lcl_persistence_repo=>ty_repo, - lv_returncode TYPE c, - lt_fields TYPE TABLE OF sval. - - FIELD-SYMBOLS: LIKE LINE OF lt_fields. - - " TAB FLD LABEL DEF ATTR - _add_dialog_fld 'TDEVC' 'DEVCLASS' 'Package' '' ''. - - CALL FUNCTION 'POPUP_GET_VALUES' - EXPORTING - no_value_check = abap_true - popup_title = 'Export' "#EC NOTEXT - IMPORTING - returncode = lv_returncode - TABLES - fields = lt_fields - EXCEPTIONS - error_in_fields = 1 - OTHERS = 2. - IF sy-subrc <> 0. - _raise 'Error from POPUP_GET_VALUES'. - ENDIF. - IF lv_returncode = 'A'. - RETURN. - ENDIF. - - READ TABLE lt_fields INDEX 1 ASSIGNING . - ASSERT sy-subrc = 0. - TRANSLATE -value TO UPPER CASE. - - ls_data-key = 'DUMMY'. - ls_data-package = -value. - ls_data-master_language = sy-langu. - - CREATE OBJECT lo_repo - EXPORTING - is_data = ls_data. - - lcl_zip=>export( lo_repo ). - - ENDMETHOD. "repo_package_zip - METHOD reset. DATA: lo_repo TYPE REF TO lcl_repo_online, @@ -1067,44 +1013,6 @@ CLASS lcl_gui_router IMPLEMENTATION. ENDMETHOD. - METHOD create_branch_popup. - - DATA: lv_answer TYPE c LENGTH 1, - lt_fields TYPE TABLE OF sval. - - FIELD-SYMBOLS: LIKE LINE OF lt_fields. - - - CLEAR ev_name. - CLEAR ev_cancel. - -* TAB FLD LABEL DEF ATTR - _add_dialog_fld 'TEXTL' 'LINE' 'Name' 'refs/heads/branch_name' ''. - - CALL FUNCTION 'POPUP_GET_VALUES' - EXPORTING - popup_title = 'Create branch' - IMPORTING - returncode = lv_answer - TABLES - fields = lt_fields - EXCEPTIONS - error_in_fields = 1 - OTHERS = 2 ##NO_TEXT. - IF sy-subrc <> 0. - _raise 'error from POPUP_GET_VALUES'. - ENDIF. - - IF lv_answer = 'A'. - ev_cancel = abap_true. - ELSE. - READ TABLE lt_fields INDEX 1 ASSIGNING . - ASSERT sy-subrc = 0. - ev_name = -value. - ENDIF. - - ENDMETHOD. - METHOD create_branch. DATA: lv_name TYPE string, @@ -1114,7 +1022,7 @@ CLASS lcl_gui_router IMPLEMENTATION. lo_repo ?= lcl_app=>repo_srv( )->get( iv_key ). - create_branch_popup( + lcl_popups=>create_branch_popup( IMPORTING ev_name = lv_name ev_cancel = lv_cancel ). diff --git a/src/zabapgit_popups.prog.abap b/src/zabapgit_popups.prog.abap index b9e0d608d..c7b5fff89 100644 --- a/src/zabapgit_popups.prog.abap +++ b/src/zabapgit_popups.prog.abap @@ -14,6 +14,12 @@ CLASS lcl_popups DEFINITION. END OF ty_popup. CLASS-METHODS: + repo_package_zip + RAISING lcx_exception, + create_branch_popup + EXPORTING ev_name TYPE string + ev_cancel TYPE abap_bool + RAISING lcx_exception, repo_new_offline RETURNING VALUE(ro_repo) TYPE REF TO lcl_repo_offline RAISING lcx_exception, @@ -44,6 +50,91 @@ CLASS lcl_popups IMPLEMENTATION. -field_attr = &5. "#EC NOTEXT END-OF-DEFINITION. + + METHOD repo_package_zip. + + DATA: lo_repo TYPE REF TO lcl_repo_offline, + ls_data TYPE lcl_persistence_repo=>ty_repo, + lv_returncode TYPE c, + lt_fields TYPE TABLE OF sval. + + FIELD-SYMBOLS: LIKE LINE OF lt_fields. + + " TAB FLD LABEL DEF ATTR + _add_dialog_fld 'TDEVC' 'DEVCLASS' 'Package' '' ''. + + CALL FUNCTION 'POPUP_GET_VALUES' + EXPORTING + no_value_check = abap_true + popup_title = 'Export' "#EC NOTEXT + IMPORTING + returncode = lv_returncode + TABLES + fields = lt_fields + EXCEPTIONS + error_in_fields = 1 + OTHERS = 2. + IF sy-subrc <> 0. + _raise 'Error from POPUP_GET_VALUES'. + ENDIF. + IF lv_returncode = 'A'. + RETURN. + ENDIF. + + READ TABLE lt_fields INDEX 1 ASSIGNING . + ASSERT sy-subrc = 0. + TRANSLATE -value TO UPPER CASE. + + ls_data-key = 'DUMMY'. + ls_data-package = -value. + ls_data-master_language = sy-langu. + + CREATE OBJECT lo_repo + EXPORTING + is_data = ls_data. + + lcl_zip=>export( lo_repo ). + + ENDMETHOD. "repo_package_zip + + METHOD create_branch_popup. + + DATA: lv_answer TYPE c LENGTH 1, + lt_fields TYPE TABLE OF sval. + + FIELD-SYMBOLS: LIKE LINE OF lt_fields. + + + CLEAR ev_name. + CLEAR ev_cancel. + +* TAB FLD LABEL DEF ATTR + _add_dialog_fld 'TEXTL' 'LINE' 'Name' 'refs/heads/branch_name' ''. + + CALL FUNCTION 'POPUP_GET_VALUES' + EXPORTING + popup_title = 'Create branch' + IMPORTING + returncode = lv_answer + TABLES + fields = lt_fields + EXCEPTIONS + error_in_fields = 1 + OTHERS = 2 ##NO_TEXT. + IF sy-subrc <> 0. + _raise 'error from POPUP_GET_VALUES'. + ENDIF. + + IF lv_answer = 'A'. + ev_cancel = abap_true. + ELSE. + READ TABLE lt_fields INDEX 1 ASSIGNING . + ASSERT sy-subrc = 0. + ev_name = -value. + ENDIF. + + ENDMETHOD. + METHOD repo_new_offline. DATA: lv_returncode TYPE c,