From 01df9ce9484ca261fbbdc83a98b90730d4345264 Mon Sep 17 00:00:00 2001 From: francisco-milan <36721657+francisco-milan@users.noreply.github.com> Date: Mon, 29 Jan 2024 22:36:46 -0700 Subject: [PATCH] Fix typos and adjust comments within the codebase (Cont'd). (#6780) Co-authored-by: Lars Hvam --- src/objects/zcl_abapgit_object_iamu.clas.abap | 2 +- src/objects/zcl_abapgit_object_vcls.clas.abap | 2 +- src/objects/zcl_abapgit_object_w3xx_super.clas.abap | 2 +- src/objects/zcl_abapgit_objects.clas.abap | 2 +- src/objects/zcl_abapgit_objects_bridge.clas.abap | 2 +- src/objects/zcl_abapgit_objects_generic.clas.abap | 2 +- src/objects/zcl_abapgit_objects_program.clas.abap | 2 +- src/repo/zcl_abapgit_repo_checksums.clas.abap | 2 +- src/repo/zcl_abapgit_repo_checksums.clas.locals_imp.abap | 2 +- src/syntax/zcl_abapgit_syntax_factory.clas.abap | 2 +- src/syntax/zcl_abapgit_syntax_highlighter.clas.abap | 4 ++-- src/ui/core/zcl_abapgit_gui_asset_manager.clas.abap | 2 +- src/ui/core/zcl_abapgit_gui_css_processor.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_diff_base.clas.abap | 6 +++--- src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap | 2 +- src/ui/zabapgit_js_common.w3mi.data.js | 4 ++-- src/utils/zcl_abapgit_convert.clas.abap | 2 +- 18 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/objects/zcl_abapgit_object_iamu.clas.abap b/src/objects/zcl_abapgit_object_iamu.clas.abap index e4f4fc656..e86d287ac 100644 --- a/src/objects/zcl_abapgit_object_iamu.clas.abap +++ b/src/objects/zcl_abapgit_object_iamu.clas.abap @@ -418,7 +418,7 @@ CLASS zcl_abapgit_object_iamu IMPLEMENTATION. ls_internet_appl_comp_binary = read( ). - " Seriazation v2, separate data file + " Serialization v2, separate data file LOOP AT ls_internet_appl_comp_binary-source ASSIGNING . lv_xstring = lv_xstring && -line. ENDLOOP. diff --git a/src/objects/zcl_abapgit_object_vcls.clas.abap b/src/objects/zcl_abapgit_object_vcls.clas.abap index 1f6ee91e7..20144196e 100644 --- a/src/objects/zcl_abapgit_object_vcls.clas.abap +++ b/src/objects/zcl_abapgit_object_vcls.clas.abap @@ -180,7 +180,7 @@ CLASS zcl_abapgit_object_vcls IMPLEMENTATION. lv_argument = ms_item-obj_name. lv_argument_langu = |@{ ms_item-obj_name }|. - "Check all relevant maintein tabeles for view clusters + "Check all relevant maintain tables for view clusters IF is_locked( iv_tabname = 'VCLDIR' iv_argument = lv_argument ) = abap_true OR is_locked( iv_tabname = 'VCLDIRT' diff --git a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap index 46f4a25b9..74834effe 100644 --- a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap @@ -498,7 +498,7 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION. io_xml->add( iv_name = 'PARAMS' ig_data = lt_w3params ). - " Seriazation v2, separate data file. 'extra' added to prevent conflict with .xml + " Serialization v2, separate data file. 'extra' added to prevent conflict with .xml mo_files->add_raw( iv_data = lv_xstring iv_extra = 'data' iv_ext = get_ext( lt_w3params ) ). diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index ebaa11b9f..3b55c4638 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -721,7 +721,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. check_objects_locked( lt_items ). - " Check the original system of all objects to prevent overwritting + " Check the original system of all objects to prevent overwriting check_original_system( it_items = lt_items ii_log = ii_log diff --git a/src/objects/zcl_abapgit_objects_bridge.clas.abap b/src/objects/zcl_abapgit_objects_bridge.clas.abap index 8e822e31e..9d8b520b0 100644 --- a/src/objects/zcl_abapgit_objects_bridge.clas.abap +++ b/src/objects/zcl_abapgit_objects_bridge.clas.abap @@ -113,7 +113,7 @@ CLASS zcl_abapgit_objects_bridge IMPLEMENTATION. LOOP AT lt_plugin_obj_type INTO ls_objtype_map-obj_typ. INSERT ls_objtype_map INTO TABLE gt_objtype_map. IF sy-subrc <> 0. -* No exception in class-contructor possible. +* No exception in class-constructor possible. * Anyway, a shortdump is more appropriate in this case ASSERT 'There must not be' = |multiple abapGit-Plugins for the same object type { diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index d8a3eabc3..21f8aadb7 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -362,7 +362,7 @@ CLASS zcl_abapgit_objects_generic IMPLEMENTATION. ls_objkey_sub-num = cs_objkey-num. lv_objkey_sub_pos = 0. -* we want to fill the atribute values which are not covered by explicit key components yet +* we want to fill the attribute values which are not covered by explicit key components yet lv_count_components_covered = ls_objkey_sub-num - 1. DO lv_count_components_covered TIMES. DELETE lt_key_component_uncovered INDEX 1. diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap index 573eed6ea..c2b7352ce 100644 --- a/src/objects/zcl_abapgit_objects_program.clas.abap +++ b/src/objects/zcl_abapgit_objects_program.clas.abap @@ -501,7 +501,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION. ELSE. INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in FROM it_tpool "main language cannot be activated because - LANGUAGE lv_language "this woul activate the deletion of the textpool + LANGUAGE lv_language "this would activate the deletion of the textpool STATE lv_state. "of the mail program -> insert empty textpool ENDIF. ELSE. diff --git a/src/repo/zcl_abapgit_repo_checksums.clas.abap b/src/repo/zcl_abapgit_repo_checksums.clas.abap index f0008c63b..af7ee77e2 100644 --- a/src/repo/zcl_abapgit_repo_checksums.clas.abap +++ b/src/repo/zcl_abapgit_repo_checksums.clas.abap @@ -84,7 +84,7 @@ CLASS ZCL_ABAPGIT_REPO_CHECKSUMS IMPLEMENTATION. " This methods is run at repo creation moment or manually by user " In the first case it assumes that the local state is the CURRENT state " Thus the idea is to copy local state to checksums - " The second case is an exception, when we acknoledge that the state is unknown + " The second case is an exception, when we acknowledge that the state is unknown " Thus copying the local to checksums is the "best guess" LOOP AT it_local ASSIGNING . diff --git a/src/repo/zcl_abapgit_repo_checksums.clas.locals_imp.abap b/src/repo/zcl_abapgit_repo_checksums.clas.locals_imp.abap index a644de22e..d96ec3416 100644 --- a/src/repo/zcl_abapgit_repo_checksums.clas.locals_imp.abap +++ b/src/repo/zcl_abapgit_repo_checksums.clas.locals_imp.abap @@ -52,7 +52,7 @@ CLASS lcl_checksum_serializer IMPLEMENTATION. SPLIT lv_buf AT c_splitter INTO -path -filename -sha1. IF -path IS INITIAL OR -filename IS INITIAL OR -sha1 IS INITIAL. - " Incorrect checksums struture, maybe raise, though it is not critical for execution + " Incorrect checksums structure, maybe raise, though it is not critical for execution RETURN. ENDIF. ELSEIF lv_buf = c_root. " Root diff --git a/src/syntax/zcl_abapgit_syntax_factory.clas.abap b/src/syntax/zcl_abapgit_syntax_factory.clas.abap index 3a36c2d7f..f24868e77 100644 --- a/src/syntax/zcl_abapgit_syntax_factory.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_factory.clas.abap @@ -22,7 +22,7 @@ CLASS zcl_abapgit_syntax_factory IMPLEMENTATION. METHOD create. - " Create instance of highighter dynamically dependent on syntax type + " Create instance of highlighter dynamically dependent on syntax type IF iv_filename CP '*.abap'. CREATE OBJECT ro_instance TYPE zcl_abapgit_syntax_abap. ELSEIF iv_filename CP '*.xml' OR iv_filename CP '*.html'. diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap index f05527e5b..6507128e6 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap @@ -138,7 +138,7 @@ CLASS zcl_abapgit_syntax_highlighter IMPLEMENTATION. SORT ct_matches BY offset. - " Add entries refering to parts of text that should not be formatted + " Add entries referring to parts of text that should not be formatted LOOP AT ct_matches ASSIGNING . IF -offset > lv_last_pos. lv_length = -offset - lv_last_pos. @@ -233,7 +233,7 @@ CLASS zcl_abapgit_syntax_highlighter IMPLEMENTATION. APPEND ls_match TO rt_matches. ELSE. READ TABLE -submatches ASSIGNING INDEX -relevant_submatch. - "submatch might be empty if only discarted parts matched + "submatch might be empty if only discarded parts matched IF sy-subrc = 0 AND -offset >= 0 AND -length > 0. ls_match-token = -token. ls_match-offset = -offset. diff --git a/src/ui/core/zcl_abapgit_gui_asset_manager.clas.abap b/src/ui/core/zcl_abapgit_gui_asset_manager.clas.abap index 1a4993d15..b6fcdbd45 100644 --- a/src/ui/core/zcl_abapgit_gui_asset_manager.clas.abap +++ b/src/ui/core/zcl_abapgit_gui_asset_manager.clas.abap @@ -170,7 +170,7 @@ CLASS zcl_abapgit_gui_asset_manager IMPLEMENTATION. ENDIF. DELETE mt_asset_register WHERE url = iv_url. - " TODO: Maybe forbid averwriting cachable assets as they were probably already cached ... agrueable + " TODO: Maybe forbid overwriting cachable assets as they were probably already cached ... agrueable APPEND ls_asset TO mt_asset_register. ENDMETHOD. diff --git a/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap b/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap index 05b4aca52..f1e2dcdee 100644 --- a/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap +++ b/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap @@ -158,7 +158,7 @@ CLASS ZCL_ABAPGIT_GUI_CSS_PROCESSOR IMPLEMENTATION. ENDIF. ENDDO. ELSE. - zcx_abapgit_exception=>raise( |CSS variable { iv_variable_name } not resolveable| ). + zcx_abapgit_exception=>raise( |CSS variable { iv_variable_name } not resolvable| ). ENDIF. ENDMETHOD. ENDCLASS. diff --git a/src/ui/pages/zcl_abapgit_gui_page_diff_base.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_diff_base.clas.abap index e78c01a36..2c62686c3 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_diff_base.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_diff_base.clas.abap @@ -1289,7 +1289,7 @@ CLASS zcl_abapgit_gui_page_diff_base IMPLEMENTATION. ls_view = ms_view. CASE ii_event->mv_action. - WHEN c_actions-toggle_unified. " Toggle file diplay + WHEN c_actions-toggle_unified. " Toggle file display mv_unified = zcl_abapgit_persistence_user=>get_instance( )->toggle_diff_unified( ). @@ -1359,12 +1359,12 @@ CLASS zcl_abapgit_gui_page_diff_base IMPLEMENTATION. ls_hotkey_action-hotkey = |a|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. - ls_hotkey_action-description = |Toogle Split/Unified|. + ls_hotkey_action-description = |Toggle Split/Unified|. ls_hotkey_action-action = c_actions-toggle_unified. ls_hotkey_action-hotkey = |u|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. - ls_hotkey_action-description = |Toogle Hidden Characters|. + ls_hotkey_action-description = |Toggle Hidden Characters|. ls_hotkey_action-action = c_actions-toggle_hidden_chars. ls_hotkey_action-hotkey = |h|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. diff --git a/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap index 6cd0c22b0..a8d172f22 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap @@ -1072,7 +1072,7 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION. rs_handled-page = zcl_abapgit_gui_page_runit=>create( mo_repo ). rs_handled-state = zcl_abapgit_gui=>c_event_state-new_page. - WHEN c_actions-toggle_hide_files. " Toggle file diplay + WHEN c_actions-toggle_hide_files. " Toggle file display mv_hide_files = zcl_abapgit_persistence_user=>get_instance( )->toggle_hide_files( ). rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render. diff --git a/src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap index 1bb8b127c..419c56d85 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap @@ -264,7 +264,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION. )->checkbox( iv_name = c_id-ignore_subpackages iv_label = 'Ignore Subpackages' - iv_hint = 'Syncronize root package only' + iv_hint = 'Synchronize root package only' )->checkbox( iv_name = c_id-only_local_objects iv_label = 'Only Local Objects' diff --git a/src/ui/zabapgit_js_common.w3mi.data.js b/src/ui/zabapgit_js_common.w3mi.data.js index 34c104104..009101ff8 100644 --- a/src/ui/zabapgit_js_common.w3mi.data.js +++ b/src/ui/zabapgit_js_common.w3mi.data.js @@ -184,7 +184,7 @@ function errorStub(event) { alert("JS Error, please log an issue (@" + targetName + ")"); } -// Confirm JS initilization +// Confirm JS initialization function confirmInitialized() { var errorBanner = document.getElementById("js-error-banner"); if (errorBanner) { @@ -2519,4 +2519,4 @@ function toggleBrowserControlWarning(){ function displayBrowserControlFooter() { var out = document.getElementById("browser-control-footer"); out.innerHTML = " - " + ( navigator.userAgent.includes("Edg") ? "Edge" : "IE" ); -} \ No newline at end of file +} diff --git a/src/utils/zcl_abapgit_convert.clas.abap b/src/utils/zcl_abapgit_convert.clas.abap index 903b863cd..1e91965ce 100644 --- a/src/utils/zcl_abapgit_convert.clas.abap +++ b/src/utils/zcl_abapgit_convert.clas.abap @@ -142,7 +142,7 @@ CLASS zcl_abapgit_convert IMPLEMENTATION. DO lv_len TIMES. IF sy-index = 1. - "Intialize + "Initialize IF lv_bitbyte+lv_offset(1) = '1'. rv_int = 1. ENDIF.