mirror of
https://github.com/abapGit/abapGit.git
synced 2025-04-30 20:03:20 +08:00
Fix typos and adjust comments within the codebase (Cont'd). (#6780)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
parent
4a36f0bb34
commit
01df9ce948
|
@ -418,7 +418,7 @@ CLASS zcl_abapgit_object_iamu IMPLEMENTATION.
|
||||||
|
|
||||||
ls_internet_appl_comp_binary = read( ).
|
ls_internet_appl_comp_binary = read( ).
|
||||||
|
|
||||||
" Seriazation v2, separate data file
|
" Serialization v2, separate data file
|
||||||
LOOP AT ls_internet_appl_comp_binary-source ASSIGNING <lv_data>.
|
LOOP AT ls_internet_appl_comp_binary-source ASSIGNING <lv_data>.
|
||||||
lv_xstring = lv_xstring && <lv_data>-line.
|
lv_xstring = lv_xstring && <lv_data>-line.
|
||||||
ENDLOOP.
|
ENDLOOP.
|
||||||
|
|
|
@ -180,7 +180,7 @@ CLASS zcl_abapgit_object_vcls IMPLEMENTATION.
|
||||||
lv_argument = ms_item-obj_name.
|
lv_argument = ms_item-obj_name.
|
||||||
lv_argument_langu = |@{ ms_item-obj_name }|.
|
lv_argument_langu = |@{ ms_item-obj_name }|.
|
||||||
|
|
||||||
"Check all relevant maintein tabeles for view clusters
|
"Check all relevant maintain tables for view clusters
|
||||||
IF is_locked( iv_tabname = 'VCLDIR'
|
IF is_locked( iv_tabname = 'VCLDIR'
|
||||||
iv_argument = lv_argument ) = abap_true
|
iv_argument = lv_argument ) = abap_true
|
||||||
OR is_locked( iv_tabname = 'VCLDIRT'
|
OR is_locked( iv_tabname = 'VCLDIRT'
|
||||||
|
|
|
@ -498,7 +498,7 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION.
|
||||||
io_xml->add( iv_name = 'PARAMS'
|
io_xml->add( iv_name = 'PARAMS'
|
||||||
ig_data = lt_w3params ).
|
ig_data = lt_w3params ).
|
||||||
|
|
||||||
" Seriazation v2, separate data file. 'extra' added to prevent conflict with .xml
|
" Serialization v2, separate data file. 'extra' added to prevent conflict with .xml
|
||||||
mo_files->add_raw( iv_data = lv_xstring
|
mo_files->add_raw( iv_data = lv_xstring
|
||||||
iv_extra = 'data'
|
iv_extra = 'data'
|
||||||
iv_ext = get_ext( lt_w3params ) ).
|
iv_ext = get_ext( lt_w3params ) ).
|
||||||
|
|
|
@ -721,7 +721,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
|
||||||
|
|
||||||
check_objects_locked( lt_items ).
|
check_objects_locked( lt_items ).
|
||||||
|
|
||||||
" Check the original system of all objects to prevent overwritting
|
" Check the original system of all objects to prevent overwriting
|
||||||
check_original_system(
|
check_original_system(
|
||||||
it_items = lt_items
|
it_items = lt_items
|
||||||
ii_log = ii_log
|
ii_log = ii_log
|
||||||
|
|
|
@ -113,7 +113,7 @@ CLASS zcl_abapgit_objects_bridge IMPLEMENTATION.
|
||||||
LOOP AT lt_plugin_obj_type INTO ls_objtype_map-obj_typ.
|
LOOP AT lt_plugin_obj_type INTO ls_objtype_map-obj_typ.
|
||||||
INSERT ls_objtype_map INTO TABLE gt_objtype_map.
|
INSERT ls_objtype_map INTO TABLE gt_objtype_map.
|
||||||
IF sy-subrc <> 0.
|
IF sy-subrc <> 0.
|
||||||
* No exception in class-contructor possible.
|
* No exception in class-constructor possible.
|
||||||
* Anyway, a shortdump is more appropriate in this case
|
* Anyway, a shortdump is more appropriate in this case
|
||||||
ASSERT 'There must not be' =
|
ASSERT 'There must not be' =
|
||||||
|multiple abapGit-Plugins for the same object type {
|
|multiple abapGit-Plugins for the same object type {
|
||||||
|
|
|
@ -362,7 +362,7 @@ CLASS zcl_abapgit_objects_generic IMPLEMENTATION.
|
||||||
ls_objkey_sub-num = cs_objkey-num.
|
ls_objkey_sub-num = cs_objkey-num.
|
||||||
lv_objkey_sub_pos = 0.
|
lv_objkey_sub_pos = 0.
|
||||||
|
|
||||||
* we want to fill the atribute values which are not covered by explicit key components yet
|
* we want to fill the attribute values which are not covered by explicit key components yet
|
||||||
lv_count_components_covered = ls_objkey_sub-num - 1.
|
lv_count_components_covered = ls_objkey_sub-num - 1.
|
||||||
DO lv_count_components_covered TIMES.
|
DO lv_count_components_covered TIMES.
|
||||||
DELETE lt_key_component_uncovered INDEX 1.
|
DELETE lt_key_component_uncovered INDEX 1.
|
||||||
|
|
|
@ -501,7 +501,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION.
|
||||||
ELSE.
|
ELSE.
|
||||||
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
|
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
|
||||||
FROM it_tpool "main language cannot be activated because
|
FROM it_tpool "main language cannot be activated because
|
||||||
LANGUAGE lv_language "this woul activate the deletion of the textpool
|
LANGUAGE lv_language "this would activate the deletion of the textpool
|
||||||
STATE lv_state. "of the mail program -> insert empty textpool
|
STATE lv_state. "of the mail program -> insert empty textpool
|
||||||
ENDIF.
|
ENDIF.
|
||||||
ELSE.
|
ELSE.
|
||||||
|
|
|
@ -84,7 +84,7 @@ CLASS ZCL_ABAPGIT_REPO_CHECKSUMS IMPLEMENTATION.
|
||||||
" This methods is run at repo creation moment or manually by user
|
" This methods is run at repo creation moment or manually by user
|
||||||
" In the first case it assumes that the local state is the CURRENT state
|
" In the first case it assumes that the local state is the CURRENT state
|
||||||
" Thus the idea is to copy local state to checksums
|
" Thus the idea is to copy local state to checksums
|
||||||
" The second case is an exception, when we acknoledge that the state is unknown
|
" The second case is an exception, when we acknowledge that the state is unknown
|
||||||
" Thus copying the local to checksums is the "best guess"
|
" Thus copying the local to checksums is the "best guess"
|
||||||
|
|
||||||
LOOP AT it_local ASSIGNING <ls_local>.
|
LOOP AT it_local ASSIGNING <ls_local>.
|
||||||
|
|
|
@ -52,7 +52,7 @@ CLASS lcl_checksum_serializer IMPLEMENTATION.
|
||||||
SPLIT lv_buf AT c_splitter INTO <ls_file>-path <ls_file>-filename <ls_file>-sha1.
|
SPLIT lv_buf AT c_splitter INTO <ls_file>-path <ls_file>-filename <ls_file>-sha1.
|
||||||
|
|
||||||
IF <ls_file>-path IS INITIAL OR <ls_file>-filename IS INITIAL OR <ls_file>-sha1 IS INITIAL.
|
IF <ls_file>-path IS INITIAL OR <ls_file>-filename IS INITIAL OR <ls_file>-sha1 IS INITIAL.
|
||||||
" Incorrect checksums struture, maybe raise, though it is not critical for execution
|
" Incorrect checksums structure, maybe raise, though it is not critical for execution
|
||||||
RETURN.
|
RETURN.
|
||||||
ENDIF.
|
ENDIF.
|
||||||
ELSEIF lv_buf = c_root. " Root
|
ELSEIF lv_buf = c_root. " Root
|
||||||
|
|
|
@ -22,7 +22,7 @@ CLASS zcl_abapgit_syntax_factory IMPLEMENTATION.
|
||||||
|
|
||||||
METHOD create.
|
METHOD create.
|
||||||
|
|
||||||
" Create instance of highighter dynamically dependent on syntax type
|
" Create instance of highlighter dynamically dependent on syntax type
|
||||||
IF iv_filename CP '*.abap'.
|
IF iv_filename CP '*.abap'.
|
||||||
CREATE OBJECT ro_instance TYPE zcl_abapgit_syntax_abap.
|
CREATE OBJECT ro_instance TYPE zcl_abapgit_syntax_abap.
|
||||||
ELSEIF iv_filename CP '*.xml' OR iv_filename CP '*.html'.
|
ELSEIF iv_filename CP '*.xml' OR iv_filename CP '*.html'.
|
||||||
|
|
|
@ -138,7 +138,7 @@ CLASS zcl_abapgit_syntax_highlighter IMPLEMENTATION.
|
||||||
|
|
||||||
SORT ct_matches BY offset.
|
SORT ct_matches BY offset.
|
||||||
|
|
||||||
" Add entries refering to parts of text that should not be formatted
|
" Add entries referring to parts of text that should not be formatted
|
||||||
LOOP AT ct_matches ASSIGNING <ls_match>.
|
LOOP AT ct_matches ASSIGNING <ls_match>.
|
||||||
IF <ls_match>-offset > lv_last_pos.
|
IF <ls_match>-offset > lv_last_pos.
|
||||||
lv_length = <ls_match>-offset - lv_last_pos.
|
lv_length = <ls_match>-offset - lv_last_pos.
|
||||||
|
@ -233,7 +233,7 @@ CLASS zcl_abapgit_syntax_highlighter IMPLEMENTATION.
|
||||||
APPEND ls_match TO rt_matches.
|
APPEND ls_match TO rt_matches.
|
||||||
ELSE.
|
ELSE.
|
||||||
READ TABLE <ls_result>-submatches ASSIGNING <ls_submatch> INDEX <ls_regex>-relevant_submatch.
|
READ TABLE <ls_result>-submatches ASSIGNING <ls_submatch> INDEX <ls_regex>-relevant_submatch.
|
||||||
"submatch might be empty if only discarted parts matched
|
"submatch might be empty if only discarded parts matched
|
||||||
IF sy-subrc = 0 AND <ls_submatch>-offset >= 0 AND <ls_submatch>-length > 0.
|
IF sy-subrc = 0 AND <ls_submatch>-offset >= 0 AND <ls_submatch>-length > 0.
|
||||||
ls_match-token = <ls_regex>-token.
|
ls_match-token = <ls_regex>-token.
|
||||||
ls_match-offset = <ls_submatch>-offset.
|
ls_match-offset = <ls_submatch>-offset.
|
||||||
|
|
|
@ -170,7 +170,7 @@ CLASS zcl_abapgit_gui_asset_manager IMPLEMENTATION.
|
||||||
ENDIF.
|
ENDIF.
|
||||||
|
|
||||||
DELETE mt_asset_register WHERE url = iv_url.
|
DELETE mt_asset_register WHERE url = iv_url.
|
||||||
" TODO: Maybe forbid averwriting cachable assets as they were probably already cached ... agrueable
|
" TODO: Maybe forbid overwriting cachable assets as they were probably already cached ... agrueable
|
||||||
APPEND ls_asset TO mt_asset_register.
|
APPEND ls_asset TO mt_asset_register.
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
|
@ -158,7 +158,7 @@ CLASS ZCL_ABAPGIT_GUI_CSS_PROCESSOR IMPLEMENTATION.
|
||||||
ENDIF.
|
ENDIF.
|
||||||
ENDDO.
|
ENDDO.
|
||||||
ELSE.
|
ELSE.
|
||||||
zcx_abapgit_exception=>raise( |CSS variable { iv_variable_name } not resolveable| ).
|
zcx_abapgit_exception=>raise( |CSS variable { iv_variable_name } not resolvable| ).
|
||||||
ENDIF.
|
ENDIF.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
|
@ -1289,7 +1289,7 @@ CLASS zcl_abapgit_gui_page_diff_base IMPLEMENTATION.
|
||||||
ls_view = ms_view.
|
ls_view = ms_view.
|
||||||
|
|
||||||
CASE ii_event->mv_action.
|
CASE ii_event->mv_action.
|
||||||
WHEN c_actions-toggle_unified. " Toggle file diplay
|
WHEN c_actions-toggle_unified. " Toggle file display
|
||||||
|
|
||||||
mv_unified = zcl_abapgit_persistence_user=>get_instance( )->toggle_diff_unified( ).
|
mv_unified = zcl_abapgit_persistence_user=>get_instance( )->toggle_diff_unified( ).
|
||||||
|
|
||||||
|
@ -1359,12 +1359,12 @@ CLASS zcl_abapgit_gui_page_diff_base IMPLEMENTATION.
|
||||||
ls_hotkey_action-hotkey = |a|.
|
ls_hotkey_action-hotkey = |a|.
|
||||||
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
||||||
|
|
||||||
ls_hotkey_action-description = |Toogle Split/Unified|.
|
ls_hotkey_action-description = |Toggle Split/Unified|.
|
||||||
ls_hotkey_action-action = c_actions-toggle_unified.
|
ls_hotkey_action-action = c_actions-toggle_unified.
|
||||||
ls_hotkey_action-hotkey = |u|.
|
ls_hotkey_action-hotkey = |u|.
|
||||||
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
||||||
|
|
||||||
ls_hotkey_action-description = |Toogle Hidden Characters|.
|
ls_hotkey_action-description = |Toggle Hidden Characters|.
|
||||||
ls_hotkey_action-action = c_actions-toggle_hidden_chars.
|
ls_hotkey_action-action = c_actions-toggle_hidden_chars.
|
||||||
ls_hotkey_action-hotkey = |h|.
|
ls_hotkey_action-hotkey = |h|.
|
||||||
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
|
||||||
|
|
|
@ -1072,7 +1072,7 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
|
||||||
rs_handled-page = zcl_abapgit_gui_page_runit=>create( mo_repo ).
|
rs_handled-page = zcl_abapgit_gui_page_runit=>create( mo_repo ).
|
||||||
rs_handled-state = zcl_abapgit_gui=>c_event_state-new_page.
|
rs_handled-state = zcl_abapgit_gui=>c_event_state-new_page.
|
||||||
|
|
||||||
WHEN c_actions-toggle_hide_files. " Toggle file diplay
|
WHEN c_actions-toggle_hide_files. " Toggle file display
|
||||||
mv_hide_files = zcl_abapgit_persistence_user=>get_instance( )->toggle_hide_files( ).
|
mv_hide_files = zcl_abapgit_persistence_user=>get_instance( )->toggle_hide_files( ).
|
||||||
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
|
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
|
||||||
|
|
||||||
|
|
|
@ -264,7 +264,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
|
||||||
)->checkbox(
|
)->checkbox(
|
||||||
iv_name = c_id-ignore_subpackages
|
iv_name = c_id-ignore_subpackages
|
||||||
iv_label = 'Ignore Subpackages'
|
iv_label = 'Ignore Subpackages'
|
||||||
iv_hint = 'Syncronize root package only'
|
iv_hint = 'Synchronize root package only'
|
||||||
)->checkbox(
|
)->checkbox(
|
||||||
iv_name = c_id-only_local_objects
|
iv_name = c_id-only_local_objects
|
||||||
iv_label = 'Only Local Objects'
|
iv_label = 'Only Local Objects'
|
||||||
|
|
|
@ -184,7 +184,7 @@ function errorStub(event) {
|
||||||
alert("JS Error, please log an issue (@" + targetName + ")");
|
alert("JS Error, please log an issue (@" + targetName + ")");
|
||||||
}
|
}
|
||||||
|
|
||||||
// Confirm JS initilization
|
// Confirm JS initialization
|
||||||
function confirmInitialized() {
|
function confirmInitialized() {
|
||||||
var errorBanner = document.getElementById("js-error-banner");
|
var errorBanner = document.getElementById("js-error-banner");
|
||||||
if (errorBanner) {
|
if (errorBanner) {
|
||||||
|
@ -2519,4 +2519,4 @@ function toggleBrowserControlWarning(){
|
||||||
function displayBrowserControlFooter() {
|
function displayBrowserControlFooter() {
|
||||||
var out = document.getElementById("browser-control-footer");
|
var out = document.getElementById("browser-control-footer");
|
||||||
out.innerHTML = " - " + ( navigator.userAgent.includes("Edg") ? "Edge" : "IE" );
|
out.innerHTML = " - " + ( navigator.userAgent.includes("Edg") ? "Edge" : "IE" );
|
||||||
}
|
}
|
||||||
|
|
|
@ -142,7 +142,7 @@ CLASS zcl_abapgit_convert IMPLEMENTATION.
|
||||||
DO lv_len TIMES.
|
DO lv_len TIMES.
|
||||||
|
|
||||||
IF sy-index = 1.
|
IF sy-index = 1.
|
||||||
"Intialize
|
"Initialize
|
||||||
IF lv_bitbyte+lv_offset(1) = '1'.
|
IF lv_bitbyte+lv_offset(1) = '1'.
|
||||||
rv_int = 1.
|
rv_int = 1.
|
||||||
ENDIF.
|
ENDIF.
|
||||||
|
|
Loading…
Reference in New Issue
Block a user