SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

LinkHints/Hotkey: Unify activation (#5108)

Browse Source 
Use hotkey activation logic also for link hints. Previously it was possble to activate link hints on some input fields (e.g. search on stage page). This is now fixed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Christian Günter 2021-11-09 05:45:57 +01:00 committed by GitHub
parent 285fbb21ff
commit 02a06cae8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/zabapgit_js_common.w3mi.data.js
View File

@ -1393,11 +1393,7 @@ LinkHints.prototype.handleKey = function(event){
return; return;
} }
var activeElement = (document.activeElement && document.activeElement) || {}; if (event.key === this.linkHintHotKey && Hotkeys.isHotkeyCallPossible()) {
// link hints are disabled for input and textareas for obvious reasons.
// Maybe we must add other types here in the future
if (event.key === this.linkHintHotKey && activeElement.type !== "text" && activeElement.type !== "number" && activeElement.nodeName !== "TEXTAREA") {
// on user hide hints, close an opened dropdown too // on user hide hints, close an opened dropdown too
if (this.areHintsDisplayed && this.activatedDropdown) this.closeActivatedDropdown(); if (this.areHintsDisplayed && this.activatedDropdown) this.closeActivatedDropdown();
@ -1626,7 +1622,7 @@ Hotkeys.prototype.onkeydown = function(oEvent){
return; return;
} }
if (!this.isHotkeyCallPossible()){ if (!Hotkeys.isHotkeyCallPossible()){
return; return;
} }
@ -1639,7 +1635,7 @@ Hotkeys.prototype.onkeydown = function(oEvent){
} }
}; };
Hotkeys.prototype.isHotkeyCallPossible = function(){ Hotkeys.isHotkeyCallPossible = function(){
var activeElementType = ((document.activeElement && document.activeElement.nodeName) || ""); var activeElementType = ((document.activeElement && document.activeElement.nodeName) || "");
var activeElementReadOnly = ((document.activeElement && document.activeElement.readOnly) || false); var activeElementReadOnly = ((document.activeElement && document.activeElement.readOnly) || false);