use boolc (#3920)

abaplint.json

@@ -72,6 +72,8 @@
     "globalMacros": []
   },
   "rules": {
+    "prefer_is_not": false,
+    "use_bool_expression": true,
     "check_subrc": false,
     "cyclomatic_complexity": {
       "max": 25

src/apack/zcl_abapgit_apack_migration.clas.abap

@@ -206,11 +206,8 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION.
     FIELD-SYMBOLS: <lv_interface_version> TYPE i.
 
     ASSIGN ('ZIF_APACK_MANIFEST')=>('CO_INTERFACE_VERSION') TO <lv_interface_version>.
-    IF <lv_interface_version> IS ASSIGNED AND <lv_interface_version> >= c_apack_interface_version.
+    rv_interface_valid = boolc( <lv_interface_version> IS ASSIGNED
-      rv_interface_valid = abap_true.
+      AND <lv_interface_version> >= c_apack_interface_version ).
-    ELSE.
-      rv_interface_valid = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_ddls.clas.abap

@@ -260,11 +260,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION.
             get_state = 'A'
           IMPORTING
             got_state = lv_state.
-        IF lv_state IS INITIAL.
+        rv_bool = boolc( NOT ( lv_state IS INITIAL ) ).
-          rv_bool = abap_false.
-        ELSE.
-          rv_bool = abap_true.
-        ENDIF.
       CATCH cx_root.
         rv_bool = abap_false.
     ENDTRY.

src/objects/zcl_abapgit_object_oa2p.clas.abap

@@ -236,11 +236,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION.
         enq     = lt_locks.    " Number of chosen lock entries
 
 
-    IF lv_lock_number > 0.
+    rv_is_locked = boolc( lv_lock_number > 0 ).
-      rv_is_locked = abap_true.
-    ELSE.
-      rv_is_locked = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_sprx.clas.abap

@@ -296,11 +296,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SPRX IMPLEMENTATION.
         status      = lv_status
         status_text = lv_status_text ).
 
-    IF lv_status = if_proxy=>c_state_active.
+    rv_bool = boolc( lv_status = if_proxy=>c_state_active ).
-      rv_bool = abap_true.
-    ELSE.
-      rv_bool = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_vcls.clas.abap

@@ -172,12 +172,8 @@ CLASS ZCL_ABAPGIT_OBJECT_VCLS IMPLEMENTATION.
     SELECT SINGLE changedate INTO lv_changedate FROM vcldir
       WHERE vclname = ms_item-obj_name.
 
-    IF lv_changedate IS NOT INITIAL.
 * see logic in function module VIEWCLUSTER_GET_DEFINITION
-      rv_active = abap_true.
+    rv_active = boolc( lv_changedate IS NOT INITIAL ).
-    ELSE.
-      rv_active = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_wdcc.clas.abap

@@ -301,11 +301,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDCC IMPLEMENTATION.
     ENDIF.
 
     DESCRIBE TABLE lt_enq LINES lv_lines.
-    IF lv_lines > 0.
+    rv_is_locked = boolc( lv_lines > 0 ).
-      rv_is_locked = abap_true.
-    ELSE.
-      rv_is_locked = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_xslt.clas.abap

@@ -155,11 +155,7 @@ CLASS ZCL_ABAPGIT_OBJECT_XSLT IMPLEMENTATION.
     lv_name = ms_item-obj_name.
 
     rv_bool = cl_o2_api_xsltdesc=>exists( lv_name ).
-    IF rv_bool = '1'.
+    rv_bool = boolc( rv_bool = '1' ).
-      rv_bool = abap_true.
-    ELSE.
-      rv_bool = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_objects_program.clas.abap

@@ -430,11 +430,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION.
     SELECT SINGLE progname FROM reposrc INTO lv_progname
       WHERE progname = is_progdir-name
       AND r3state = 'A'.
-    IF sy-subrc = 0.
+    lv_exists = boolc( sy-subrc = 0 ).
-      lv_exists = abap_true.
-    ELSE.
-      lv_exists = abap_false.
-    ENDIF.
 
     IF lv_exists = abap_true.
       zcl_abapgit_language=>set_current_language( mv_language ).

src/syntax/zcl_abapgit_syntax_highlighter.clas.abap

@@ -208,11 +208,7 @@ CLASS ZCL_ABAPGIT_SYNTAX_HIGHLIGHTER IMPLEMENTATION.
     "/^\s+$/
     lv_whitespace = ` ` && cl_abap_char_utilities=>horizontal_tab && cl_abap_char_utilities=>cr_lf.
 
-    IF iv_string CO lv_whitespace.
+    rv_result = boolc( iv_string CO lv_whitespace ).
-      rv_result = abap_true.
-    ELSE.
-      rv_result = abap_false.
-    ENDIF.
 
   ENDMETHOD.
 

src/ui/zcl_abapgit_popups.clas.abap

@@ -1018,11 +1018,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
         p_object_data    = es_package_data
       EXCEPTIONS
         action_cancelled = 1.
-    IF sy-subrc = 0.
+    ev_create = boolc( sy-subrc = 0 ).
-      ev_create = abap_true.
-    ELSE.
-      ev_create = abap_false.
-    ENDIF.
   ENDMETHOD.
 
 

src/utils/zcl_abapgit_adt_link.clas.abap

@@ -190,11 +190,7 @@ CLASS ZCL_ABAPGIT_ADT_LINK IMPLEMENTATION.
           RECEIVING
             result     = lv_vit_wb_request.
 
-        IF lv_vit_wb_request = abap_true.
+        rv_is_adt_jump_possible = boolc( NOT ( lv_vit_wb_request = abap_true ) ).
-          rv_is_adt_jump_possible = abap_false.
-        ELSE.
-          rv_is_adt_jump_possible = abap_true.
-        ENDIF.
 
       CATCH cx_root.
         zcx_abapgit_exception=>raise( 'ADT Jump Error' ).

src/zcl_abapgit_merge.clas.abap

@@ -375,11 +375,7 @@ CLASS ZCL_ABAPGIT_MERGE IMPLEMENTATION.
 
   METHOD has_conflicts.
 
-    IF lines( mt_conflicts ) > 0.
+    rv_conflicts_exists = boolc( lines( mt_conflicts ) > 0 ).
-      rv_conflicts_exists = abap_true.
-    ELSE.
-      rv_conflicts_exists = abap_false.
-    ENDIF.
 
   ENDMETHOD.